Re: Add trim_trailing_whitespace to editorconfig file

2024-04-09 Thread Jelte Fennema-Nio
On Thu, 4 Apr 2024 at 16:58, Jelte Fennema-Nio wrote: > > ISTM that with a small shell script, .editorconfig could be generated > > from .gitattributes? > > Honestly, I don't think building such automation is worth the effort. Okay, I spent the time to add a script to generate the editorconfig

Re: Add trim_trailing_whitespace to editorconfig file

2024-04-04 Thread Jelte Fennema-Nio
On Thu, 4 Apr 2024 at 17:23, Peter Eisentraut wrote: > git diff-tree --check $(git hash-object -t tree /dev/null) HEAD > > That's what I was hoping for for editorconfig-check, but as I said, the > experience wasn't good. Ah, I wasn't able to find that git incantation. I definitely think it

Re: Add trim_trailing_whitespace to editorconfig file

2024-04-04 Thread Peter Eisentraut
On 04.04.24 16:58, Jelte Fennema-Nio wrote: On Thu, 4 Apr 2024 at 15:25, Peter Eisentraut wrote: Everybody has git. Everybody who edits .gitattributes can use git to check what they did. What CLI command do you use to fix/ gitattributes on all existing files? Afaict there's no command to

Re: Add trim_trailing_whitespace to editorconfig file

2024-04-04 Thread Jelte Fennema-Nio
On Thu, 4 Apr 2024 at 15:25, Peter Eisentraut wrote: > Everybody has git. Everybody who edits .gitattributes can use git to > check what they did. What CLI command do you use to fix/ gitattributes on all existing files? Afaict there's no command to actually remove the trailing whitespace that

Re: Add trim_trailing_whitespace to editorconfig file

2024-04-04 Thread Peter Eisentraut
On 19.02.24 16:21, Jelte Fennema-Nio wrote: v3-0003-Bring-editorconfig-in-line-with-gitattributes.patch I question whether we need to add rules to .editorconfig about files that are generated or imported from elsewhere, since those are not meant to be edited. I agree that it's not strictly

Re: Add trim_trailing_whitespace to editorconfig file

2024-02-19 Thread Jelte Fennema-Nio
On Fri, 16 Feb 2024 at 11:45, Peter Eisentraut wrote: > I have committed that one. Thanks :) > v3-0002-Require-final-newline-in-.po-files.patch > > The .po files are imported from elsewhere, so I'm not sure this is going > to have the desired effect. Perhaps it's worth cleaning up, but it >

Re: Add trim_trailing_whitespace to editorconfig file

2024-02-16 Thread Peter Eisentraut
v3-0001-Remove-non-existing-file-from-.gitattributes.patch I have committed that one. v3-0002-Require-final-newline-in-.po-files.patch The .po files are imported from elsewhere, so I'm not sure this is going to have the desired effect. Perhaps it's worth cleaning up, but it would require

Re: Add trim_trailing_whitespace to editorconfig file

2024-02-15 Thread Jelte Fennema-Nio
On Thu, 15 Feb 2024 at 16:57, Peter Eisentraut wrote: > Is there a command-line tool to verify the syntax of .editorconfig and > check compliance of existing files? > > I'm worried that expanding .editorconfig with detailed per-file rules > will lead to a lot of mistakes and blind editing, if we

Re: Add trim_trailing_whitespace to editorconfig file

2024-02-15 Thread Peter Eisentraut
On 15.02.24 10:26, Jelte Fennema-Nio wrote: On Wed, 14 Feb 2024 at 23:19, Daniel Gustafsson wrote: +1 from me. But when do we want it to be false? That is, why not declare it true for all file types? Regression test .out files commonly have spaces at the end of the line. (Not to mention the

Re: Add trim_trailing_whitespace to editorconfig file

2024-02-15 Thread Jelte Fennema-Nio
On Wed, 14 Feb 2024 at 23:19, Daniel Gustafsson wrote: > > +1 from me. But when do we want it to be false? That is, why not > > declare it true for all file types? > > Regression test .out files commonly have spaces at the end of the line. (Not > to mention the ECPG .c files but they probably

Re: Add trim_trailing_whitespace to editorconfig file

2024-02-14 Thread Daniel Gustafsson
> On 14 Feb 2024, at 23:06, Melanie Plageman wrote: > > On Wed, Feb 14, 2024 at 11:35 AM Jelte Fennema-Nio wrote: >> >> This brings our .gitattributes and .editorconfig files more in line. I >> had the problem that "git add" would complain often about trailing >> whitespaces when I was

Re: Add trim_trailing_whitespace to editorconfig file

2024-02-14 Thread Melanie Plageman
On Wed, Feb 14, 2024 at 11:35 AM Jelte Fennema-Nio wrote: > > This brings our .gitattributes and .editorconfig files more in line. I > had the problem that "git add" would complain often about trailing > whitespaces when I was changing sgml files specifically. +1 from me. But when do we want it

Add trim_trailing_whitespace to editorconfig file

2024-02-14 Thread Jelte Fennema-Nio
This brings our .gitattributes and .editorconfig files more in line. I had the problem that "git add" would complain often about trailing whitespaces when I was changing sgml files specifically. v1-0001-Configure-trailing-whitespace-trimming-in-editorc.patch Description: Binary data