RE: ECPG: proposal for new DECLARE STATEMENT

2021-01-27 Thread kuroda.hay...@fujitsu.com
Dear Hackers, I know I'm asking a big favor, but could you review(and commit) the patch? The status has become RFC last Nov., but no one checked this after that. Maybe Meskes is quite busy and have no time to review it. The main part of the patch is about 200 lines(It means not so long), and

Re: ECPG: proposal for new DECLARE STATEMENT

2020-11-16 Thread Shawn Wang
The following review has been posted through the commitfest application: make installcheck-world: tested, passed Implements feature: tested, passed Spec compliant: tested, passed Documentation:tested, passed Recently I have been doing some work on ecpg. So I review

RE: ECPG: proposal for new DECLARE STATEMENT

2020-10-23 Thread kuroda.hay...@fujitsu.com
Commitfest. Best regards, Hayato Kuroda FUJITSU LIMITED -Original Message- From: Michael Meskes Sent: Tuesday, September 15, 2020 7:32 PM To: pgsql-hackers@lists.postgresql.org Subject: Re: ECPG: proposal for new DECLARE STATEMENT > This patch has now been silent for quite a

Re: ECPG: proposal for new DECLARE STATEMENT

2020-09-15 Thread Michael Meskes
> This patch has now been silent for quite a while, unless someone is > interested > enough to bring it forward it seems about time to close it. I am interested but still short on time. I will definitely look into it as soon as I find some spare minutes. Michael -- Michael Meskes Michael at

Re: ECPG: proposal for new DECLARE STATEMENT

2020-09-15 Thread Daniel Gustafsson
> On 30 Mar 2020, at 18:53, David Steele wrote: > > On 1/11/20 10:41 PM, Tomas Vondra wrote: >> On Sun, Jan 12, 2020 at 03:52:48AM +0100, Tomas Vondra wrote: >>> ... >>> >>> I'm not an ecpg expert (in fact I've never even used it), so my review >>> is pretty superficial, but I only found a

Re: ECPG: proposal for new DECLARE STATEMENT

2020-03-30 Thread David Steele
On 1/11/20 10:41 PM, Tomas Vondra wrote: On Sun, Jan 12, 2020 at 03:52:48AM +0100, Tomas Vondra wrote: ... I'm not an ecpg expert (in fact I've never even used it), so my review is pretty superficial, but I only found a couple of minor whitespace issues (adding/removing a line/tab) - see the

Re: ECPG: proposal for new DECLARE STATEMENT

2020-01-11 Thread Tomas Vondra
On Sun, Jan 12, 2020 at 03:52:48AM +0100, Tomas Vondra wrote: ... I'm not an ecpg expert (in fact I've never even used it), so my review is pretty superficial, but I only found a couple of minor whitespace issues (adding/removing a line/tab) - see the attached file. Meh, forgot to attach the

Re: ECPG: proposal for new DECLARE STATEMENT

2020-01-11 Thread Tomas Vondra
Hi, On Thu, Oct 31, 2019 at 12:29:30PM +, kuroda.hay...@fujitsu.com wrote: Dear hackers, As declared last month, I propose again the new ECPG grammar, DECLARE STATEMENT. This had been committed once, but it removed from PG12 because of some problems. In this mail, I want to report some

ECPG: proposal for new DECLARE STATEMENT

2019-10-31 Thread kuroda.hay...@fujitsu.com
Dear hackers, As declared last month, I propose again the new ECPG grammar, DECLARE STATEMENT. This had been committed once, but it removed from PG12 because of some problems. In this mail, I want to report some problems that previous implementation has, produce a new solution, and attach a WIP