.
--
Regards,
Alena Rybakina
Postgres Professional: http://www.postgrespro.com
The Russian Postgres Company
From bf40b14c0cb63f47280299fd3f76a1711db6aada Mon Sep 17 00:00:00 2001
From: Alena Rybakina
Date: Sun, 28 Jan 2024 11:58:44 +0300
Subject: [PATCH] WIP: Evaluate arguments of correlated SubPlans
On Tue, 24 Oct 2023 at 01:47, Alena Rybakina wrote:
>
> Hi!
>
> I looked through your patch and noticed that it was not applied to the
> current version of the master. I rebased it and attached a version. I didn't
> see any problems and, honestly, no big changes were needed, all regression
>
Hi,
On 2024-01-22 10:30:22 +1100, Peter Smith wrote:
> 2024-01 Commitfest.
>
> Hi, This patch has a CF status of "Ready for Committer", but it is
> currently failing some CFbot tests [1]. Please have a look and post an
> updated version..
I think this failure is independent of this patch - by
2024-01 Commitfest.
Hi, This patch has a CF status of "Ready for Committer", but it is
currently failing some CFbot tests [1]. Please have a look and post an
updated version..
==
[1] https://cirrus-ci.com/github/postgresql-cfbot/postgresql/commitfest/46/4209
Kind Regards,
Peter Smith.
On Tue, Oct 10, 2023 at 10:00 AM Andres Freund wrote:
>
> Hi,
>
> On 2023-10-01 14:53:23 -0400, Tom Lane wrote:
> > Peter Eisentraut writes:
> > > Is this patch still being worked on?
> >
> > I thought Andres simply hadn't gotten back to it yet.
> > It still seems like a worthwhile improvement.
, but to be honest, I haven't been able
to come up with something yet.
--
Regards,
Alena Rybakina
From f7a8ca7f3263fa5f82056f90231cf937133622c9 Mon Sep 17 00:00:00 2001
From: Andres Freund
Date: Mon, 23 Oct 2023 22:54:04 +0300
Subject: [PATCH] WIP: Evaluate arguments of correlated SubPlans
Hi,
On 2023-10-01 14:53:23 -0400, Tom Lane wrote:
> Peter Eisentraut writes:
> > Is this patch still being worked on?
>
> I thought Andres simply hadn't gotten back to it yet.
> It still seems like a worthwhile improvement.
Indeed - I do plan to commit it. I haven't quite shifted into v17 mode
Peter Eisentraut writes:
> Is this patch still being worked on?
I thought Andres simply hadn't gotten back to it yet.
It still seems like a worthwhile improvement.
regards, tom lane
Is this patch still being worked on?
On 07.03.23 01:51, Tom Lane wrote:
Andres Freund writes:
On 2023-03-03 15:09:18 -0500, Tom Lane wrote:
It'd be good to have a header comment for ExecInitExprRec documenting
the arguments, particularly that resv/resnull are where to put the
subplan's
Andres Freund writes:
> On 2023-03-03 15:09:18 -0500, Tom Lane wrote:
>> It'd be good to have a header comment for ExecInitExprRec documenting
>> the arguments, particularly that resv/resnull are where to put the
>> subplan's eventual result.
> Did you mean ExecInitSubPlanExpr()?
Right,
Hi,
On 2023-03-03 15:09:18 -0500, Tom Lane wrote:
> Andres Freund writes:
> > On 2023-03-02 13:00:31 -0800, Andres Freund wrote:
> >> I'm not opposed to EXPR_PARAM_SET, to be clear. I'll send an updated
> >> version later. I was just thinking about the correctness in the current
> >> world.
>
>
Andres Freund writes:
> On 2023-03-02 13:00:31 -0800, Andres Freund wrote:
>> I'm not opposed to EXPR_PARAM_SET, to be clear. I'll send an updated
>> version later. I was just thinking about the correctness in the current
>> world.
> Attached.
I've looked through this, and it looks basically OK
0800
Subject: [PATCH v2] WIP: Evaluate arguments of correlated SubPlans in the
referencing ExprState
---
src/include/executor/execExpr.h | 6 +-
src/include/nodes/execnodes.h | 1 -
src/backend/executor/execExpr.c | 93 +--
src/backend/executor/execExprI
Hi,
On 2023-03-02 15:10:31 -0500, Tom Lane wrote:
> Andres Freund writes:
> > On 2023-03-02 14:33:35 -0500, Tom Lane wrote:
> >> I looked through this, and there is one point that is making me really
> >> uncomfortable. This bit is assuming that we can bind the address of
> >> the
Andres Freund writes:
> On 2023-03-02 14:33:35 -0500, Tom Lane wrote:
>> I looked through this, and there is one point that is making me really
>> uncomfortable. This bit is assuming that we can bind the address of
>> the es_param_exec_vals array right into the compiled expression:
> Yea, I
Hi,
On 2023-03-02 14:33:35 -0500, Tom Lane wrote:
> Andres Freund writes:
> > Around
> > https://www.postgresql.org/message-id/20230224015417.75yimxbksejpffh3%40awork3.anarazel.de
> > I suggested that we should evaluate the arguments of correlated SubPlans as
> > part of the expression
Andres Freund writes:
> Around
> https://www.postgresql.org/message-id/20230224015417.75yimxbksejpffh3%40awork3.anarazel.de
> I suggested that we should evaluate the arguments of correlated SubPlans as
> part of the expression referencing the subplan.
> Here's a patch for that.
I looked through
rom 3b68577bbcd0f78b80abe1ac07eedd6998254951 Mon Sep 17 00:00:00 2001
From: Andres Freund
Date: Sat, 25 Feb 2023 13:39:19 -0800
Subject: [PATCH v1] WIP: Evaluate arguments of correlated SubPlans in the
referencing ExprState
---
src/include/nodes/execnodes.h | 1 -
src/backend/executor/execExpr.c |
18 matches
Mail list logo
