Re: Fix comment in btree_gist--1.8--1.9.sql

2025-07-09 Thread Michael Paquier
On Wed, Jul 09, 2025 at 06:21:05PM -0700, Paul Jungwirth wrote: > Here is a patch with the new order. Thanks, done. -- Michael signature.asc Description: PGP signature

Re: Fix comment in btree_gist--1.8--1.9.sql

2025-07-09 Thread Paul Jungwirth
On 7/9/25 16:16, Michael Paquier wrote: On Wed, Jul 09, 2025 at 01:52:08PM -0400, Tom Lane wrote: I considered putting the sortsupport functions first, since they have a lower support function number, but I thought defining them in the same order as we've been doing was a tiny bit safer. Maybe

Re: Fix comment in btree_gist--1.8--1.9.sql

2025-07-09 Thread Michael Paquier
On Wed, Jul 09, 2025 at 01:52:08PM -0400, Tom Lane wrote: >> I considered putting the sortsupport functions first, since they have a >> lower support function >> number, but I thought defining them in the same order as we've been doing >> was a tiny bit safer. >> Maybe that is superstitious. >

Re: Fix comment in btree_gist--1.8--1.9.sql

2025-07-09 Thread Tom Lane
Paul Jungwirth writes: > On 7/9/25 08:51, Tom Lane wrote: >> +1 for merging those two while we still can. > Patch attached, based on REL_18_STABLE. > I considered putting the sortsupport functions first, since they have a lower > support function > number, but I thought defining them in the sa

Re: Fix comment in btree_gist--1.8--1.9.sql

2025-07-09 Thread Paul Jungwirth
On 7/9/25 08:51, Tom Lane wrote: Michael Paquier writes: On Tue, Jul 08, 2025 at 04:49:30PM -0700, Paul Jungwirth wrote: A related question: In the v18 release we are adding two upgrade files: btree_gist--1.7--1.8.sql and btree_gist--1.8-1.9.sql. Why not collapse them into one? Technically we

Re: Fix comment in btree_gist--1.8--1.9.sql

2025-07-09 Thread Tom Lane
Michael Paquier writes: > On Tue, Jul 08, 2025 at 04:49:30PM -0700, Paul Jungwirth wrote: >> A related question: In the v18 release we are adding two upgrade files: >> btree_gist--1.7--1.8.sql and btree_gist--1.8-1.9.sql. Why not collapse them >> into one? Technically we briefly had btree_gist--1.

Re: Fix comment in btree_gist--1.8--1.9.sql

2025-07-08 Thread Michael Paquier
On Tue, Jul 08, 2025 at 04:49:30PM -0700, Paul Jungwirth wrote: > I noticed that the comment at the top of btree_gist--1.8--1.9.sql says it is > the 1.7--1.8 file. Here is a one-line patch to fix that. > > A related question: In the v18 release we are adding two upgrade files: > btree_gist--1.7--1

Fix comment in btree_gist--1.8--1.9.sql

2025-07-08 Thread Paul Jungwirth
Mon Sep 17 00:00:00 2001 From: "Paul A. Jungwirth" Date: Tue, 8 Jul 2025 16:42:54 -0700 Subject: [PATCH v1] Fix comment in btree_gist--1.8--1.9.sql The comment said this was the 1.7--1.8 file, but actually it's the file for 1.8--1.9. --- contrib/btree_gist/btree_gist--1.8--1.9.sql