Re: Incorrect file reference in comment in procarray.c

2023-11-13 Thread Etsuro Fujita
On Fri, Nov 3, 2023 at 6:53 PM Etsuro Fujita wrote: > On Thu, Nov 2, 2023 at 10:20 PM Daniel Gustafsson wrote: > > > On 2 Nov 2023, at 13:40, Etsuro Fujita wrote: > > > Attached is a small patch for that: s/heapam_visibility.c/snapmgr.c/. > > > > No objections to the patch, the change is correct

Re: Incorrect file reference in comment in procarray.c

2023-11-03 Thread Etsuro Fujita
On Thu, Nov 2, 2023 at 10:20 PM Daniel Gustafsson wrote: > > On 2 Nov 2023, at 13:40, Etsuro Fujita wrote: > > Attached is a small patch for that: s/heapam_visibility.c/snapmgr.c/. > > No objections to the patch, the change is correct. However, with git grep and > ctags and other ways of discove

Re: Incorrect file reference in comment in procarray.c

2023-11-02 Thread Daniel Gustafsson
> On 2 Nov 2023, at 13:40, Etsuro Fujita wrote: > Attached is a small patch for that: s/heapam_visibility.c/snapmgr.c/. No objections to the patch, the change is correct. However, with git grep and ctags and other ways of discovery I wonder if we're not better off avoiding such references to fi

Incorrect file reference in comment in procarray.c

2023-11-02 Thread Etsuro Fujita
Hi, While working on something else, I noticed $SUBJECT: commit b7eda3e0e moved XidInMVCCSnapshot() from tqual.c into snapmgr.c, but follow-up commit c91560def updated this reference incorrectly: @@ -1498,7 +1498,7 @@ GetMaxSnapshotSubxidCount(void) * information may not be available. If we fi