Re: Minor issues in .pgpass

On 2020/03/04 23:01, Hamid Akhtar wrote: The following review has been posted through the commitfest application: make installcheck-world: tested, passed Implements feature: tested, passed Spec compliant: tested, passed Documentation:tested, passed Tested and look

Re: Minor issues in .pgpass

The following review has been posted through the commitfest application: make installcheck-world: tested, passed Implements feature: tested, passed Spec compliant: tested, passed Documentation:tested, passed Tested and looks fine to me. The new status of this patch is

Re: Minor issues in .pgpass

On Wed, Mar 4, 2020 at 4:54 PM Fujii Masao wrote: > > > On 2020/03/04 20:39, Hamid Akhtar wrote: > > > > > > On Tue, Mar 3, 2020 at 8:57 PM Fujii Masao > wrote: > > > > > > > > On 2020/03/03 21:38, Hamid Akhtar wrote: > > > > > > > > > On Mo

Re: Minor issues in .pgpass

On 2020/03/04 20:39, Hamid Akhtar wrote: On Tue, Mar 3, 2020 at 8:57 PM Fujii Masao mailto:masao.fu...@oss.nttdata.com>> wrote: On 2020/03/03 21:38, Hamid Akhtar wrote: > > > On Mon, Mar 2, 2020 at 6:07 PM Fujii Masao mailto:masao.fu...@oss.nttdata.com>

Re: Minor issues in .pgpass

On Tue, Mar 3, 2020 at 8:57 PM Fujii Masao wrote: > > > On 2020/03/03 21:38, Hamid Akhtar wrote: > > > > > > On Mon, Mar 2, 2020 at 6:07 PM Fujii Masao > wrote: > > > > > > > > On 2020/02/29 0:46, Hamid Akhtar wrote: > > > The following review has bee

Re: Minor issues in .pgpass

On 2020/03/03 22:07, Hamid Akhtar wrote: On Tue, Mar 3, 2020 at 5:38 PM Hamid Akhtar mailto:hamid.akh...@gmail.com>> wrote: On Mon, Mar 2, 2020 at 6:07 PM Fujii Masao mailto:masao.fu...@oss.nttdata.com>> wrote: On 2020/02/29 0:46, Hamid Akhtar wrote: > The following r

Re: Minor issues in .pgpass

On 2020/03/03 21:38, Hamid Akhtar wrote: On Mon, Mar 2, 2020 at 6:07 PM Fujii Masao mailto:masao.fu...@oss.nttdata.com>> wrote: On 2020/02/29 0:46, Hamid Akhtar wrote: > The following review has been posted through the commitfest application: > make installcheck-world:  not

Re: Minor issues in .pgpass

On Tue, Mar 3, 2020 at 5:38 PM Hamid Akhtar wrote: > > > On Mon, Mar 2, 2020 at 6:07 PM Fujii Masao > wrote: > >> >> >> On 2020/02/29 0:46, Hamid Akhtar wrote: >> > The following review has been posted through the commitfest application: >> > make installcheck-world: not tested >> > Implements

Re: Minor issues in .pgpass

On Mon, Mar 2, 2020 at 6:07 PM Fujii Masao wrote: > > > On 2020/02/29 0:46, Hamid Akhtar wrote: > > The following review has been posted through the commitfest application: > > make installcheck-world: not tested > > Implements feature: not tested > > Spec compliant: not tested >

Re: Minor issues in .pgpass

On 2020/02/29 0:46, Hamid Akhtar wrote: The following review has been posted through the commitfest application: make installcheck-world: not tested Implements feature: not tested Spec compliant: not tested Documentation:not tested First of all, this seems like fi

Re: Minor issues in .pgpass

The following review has been posted through the commitfest application: make installcheck-world: not tested Implements feature: not tested Spec compliant: not tested Documentation:not tested First of all, this seems like fixing a valid issue, albeit, the probability o

Re: Minor issues in .pgpass

On 2020/01/22 9:06, David Fetter wrote: On Tue, Jan 21, 2020 at 03:27:50PM +0900, Fujii Masao wrote: Hi, When I was researching the maximum length of password in PostgreSQL to answer the question from my customer, I found that there are two minor issues in .pgpass file. (1) If the length of

Re: Minor issues in .pgpass

On Tue, Jan 21, 2020 at 03:27:50PM +0900, Fujii Masao wrote: > Hi, > > When I was researching the maximum length of password in PostgreSQL > to answer the question from my customer, I found that there are two > minor issues in .pgpass file. > > (1) If the length of a li

Re: Minor issues in .pgpass

> On 21 Jan 2020, at 07:27, Fujii Masao wrote: > For (2), libpq should treat any lines beginning with # as comments. I haven't read the code to confirm that it really isn't, but +1 on making it so. I can't see a reason for allowing a hostname to start with #, but allowing comments does seem use

Minor issues in .pgpass

Hi, When I was researching the maximum length of password in PostgreSQL to answer the question from my customer, I found that there are two minor issues in .pgpass file. (1) If the length of a line in .pgpass file is larger than 319B, libpq silently treats each 319B in the line as a