Re: Possible typo in nodeAgg.c

2023-11-02 Thread David Rowley
On Fri, 3 Nov 2023 at 13:49, Bruce Momjian wrote: > > On Fri, Oct 16, 2020 at 09:03:52AM +, Hou, Zhijie wrote: > > /* > >* Don't set the limit below 3/4 of hash_mem. In that case, we are at > > the > >* minimum number of partitions, so we aren't going to dramatically >

Re: Possible typo in nodeAgg.c

2023-11-02 Thread Bruce Momjian
On Fri, Oct 16, 2020 at 09:03:52AM +, Hou, Zhijie wrote: > Hi > > In /src/backend/executor/nodeAgg.c > > I found the following comment still use work mem, > Since hash_mem has been introduced, Is it more accurate to use hash_mem here ? > > @@ -1827,7 +1827,7 @@ hash_agg_set_limits(double has

Possible typo in nodeAgg.c

2020-10-16 Thread Hou, Zhijie
Hi In /src/backend/executor/nodeAgg.c I found the following comment still use work mem, Since hash_mem has been introduced, Is it more accurate to use hash_mem here ? @@ -1827,7 +1827,7 @@ hash_agg_set_limits(double hashentrysize, double input_groups, int used_bits, /* * Don't