Re: Proposal: roll pg_stat_statements into core

2019-09-05 Thread Alvaro Herrera from 2ndQuadrant
On 2019-Sep-02, Euler Taveira wrote: > At least if pg_stat_statements > was in core you could load it by default and have a GUC to turn it > on/off without restarting the server (that was Magnus proposal and > Andres agreed). I support this idea. Actually this is possible without moving to part

Re: Proposal: roll pg_stat_statements into core

2019-09-04 Thread Andres Freund
Hi, On 2019-09-02 12:07:17 -0400, Tom Lane wrote: > Euler Taveira writes: > > At least if pg_stat_statements > > was in core you could load it by default and have a GUC to turn it > > on/off without restarting the server (that was Magnus proposal and > > Andres agreed). > > That assertion is

Re: Proposal: roll pg_stat_statements into core

2019-09-04 Thread David Fetter
On Wed, Sep 04, 2019 at 12:14:50AM -0400, Tom Lane wrote: > Stephen Frost writes: > > * Alvaro Herrera (alvhe...@2ndquadrant.com) wrote: > >> I think there is a false dichotomy here. Migrating an extension out of > >> contrib doesn't have to equate making it no longer an extension. We > >>

Re: Proposal: roll pg_stat_statements into core

2019-09-03 Thread Stephen Frost
Greetings, * Tom Lane (t...@sss.pgh.pa.us) wrote: > Stephen Frost writes: > > * Alvaro Herrera (alvhe...@2ndquadrant.com) wrote: > >> I think there is a false dichotomy here. Migrating an extension out of > >> contrib doesn't have to equate making it no longer an extension. We > >> could,

Re: Proposal: roll pg_stat_statements into core

2019-09-03 Thread Tom Lane
Stephen Frost writes: > * Alvaro Herrera (alvhe...@2ndquadrant.com) wrote: >> I think there is a false dichotomy here. Migrating an extension out of >> contrib doesn't have to equate making it no longer an extension. We >> could, instead, keep it being an extension, but move it out of contrib

Re: Proposal: roll pg_stat_statements into core

2019-09-03 Thread Stephen Frost
Greetings, * Alvaro Herrera (alvhe...@2ndquadrant.com) wrote: > On 2019-Sep-03, Stephen Frost wrote: > > * David Fetter (da...@fetter.org) wrote: > > > I'd like to $Subject, on by default, with a switch to turn it off for > > > those really at the outer edges of performance. Some reasons include:

Re: Proposal: roll pg_stat_statements into core

2019-09-03 Thread Alvaro Herrera
On 2019-Sep-03, Stephen Frost wrote: > Greetings, > > * David Fetter (da...@fetter.org) wrote: > > I'd like to $Subject, on by default, with a switch to turn it off for > > those really at the outer edges of performance. Some reasons include: > > Sure, half of contrib should really be in core

Re: Proposal: roll pg_stat_statements into core

2019-09-03 Thread Stephen Frost
Greetings, On Tue, Sep 3, 2019 at 19:38 David Fetter wrote: > On Tue, Sep 03, 2019 at 03:56:28PM -0400, Stephen Frost wrote: > > Greetings, > > > > * David Fetter (da...@fetter.org) wrote: > > > I'd like to $Subject, on by default, with a switch to turn it off for > > > those really at the

Re: Proposal: roll pg_stat_statements into core

2019-09-03 Thread David Fetter
On Tue, Sep 03, 2019 at 07:41:00PM -0400, Stephen Frost wrote: > Greetings, > > On Tue, Sep 3, 2019 at 19:38 David Fetter wrote: > > > On Tue, Sep 03, 2019 at 03:56:28PM -0400, Stephen Frost wrote: > > > Greetings, > > > > > > * David Fetter (da...@fetter.org) wrote: > > > > I'd like to

Re: Proposal: roll pg_stat_statements into core

2019-09-03 Thread David Fetter
On Tue, Sep 03, 2019 at 03:56:28PM -0400, Stephen Frost wrote: > Greetings, > > * David Fetter (da...@fetter.org) wrote: > > I'd like to $Subject, on by default, with a switch to turn it off for > > those really at the outer edges of performance. Some reasons include: > > Sure, half of contrib

Re: Proposal: roll pg_stat_statements into core

2019-09-03 Thread Stephen Frost
Greetings, * David Fetter (da...@fetter.org) wrote: > I'd like to $Subject, on by default, with a switch to turn it off for > those really at the outer edges of performance. Some reasons include: Sure, half of contrib should really be in core (amcheck, file_fdw, postgres_fdw, maybe dblink,

Re: Proposal: roll pg_stat_statements into core

2019-09-03 Thread Ibrar Ahmed
On Tue, Sep 3, 2019 at 11:37 AM Michael Paquier wrote: > grOn Mon, Sep 02, 2019 at 12:07:17PM -0400, Tom Lane wrote: > > Euler Taveira writes: > >> At least if pg_stat_statements > >> was in core you could load it by default and have a GUC to turn it > >> on/off without restarting the server

Re: Proposal: roll pg_stat_statements into core

2019-09-03 Thread Michael Paquier
grOn Mon, Sep 02, 2019 at 12:07:17PM -0400, Tom Lane wrote: > Euler Taveira writes: >> At least if pg_stat_statements >> was in core you could load it by default and have a GUC to turn it >> on/off without restarting the server (that was Magnus proposal and >> Andres agreed). > > That assertion

Re: Proposal: roll pg_stat_statements into core

2019-09-02 Thread Tom Lane
Euler Taveira writes: > At least if pg_stat_statements > was in core you could load it by default and have a GUC to turn it > on/off without restarting the server (that was Magnus proposal and > Andres agreed). That assertion is 100% bogus. To turn it on or off on-the-fly, you'd need some way

Re: Proposal: roll pg_stat_statements into core

2019-09-02 Thread Euler Taveira
Em seg, 2 de set de 2019 às 05:11, Adrien Nayrat escreveu: > > On 9/1/19 8:54 PM, Tom Lane wrote: > >> - The overhead for most use cases is low compared to the benefit. > > Please do not expect that we're going to accept such assertions > > unsupported by evidence. (As a very quick-n-dirty test,

Re: Proposal: roll pg_stat_statements into core

2019-09-02 Thread Adrien Nayrat
On 9/1/19 8:54 PM, Tom Lane wrote: >> - The overhead for most use cases is low compared to the benefit. > Please do not expect that we're going to accept such assertions > unsupported by evidence. (As a very quick-n-dirty test, I tried > "pgbench -S" and got somewhere around 4% TPS degradation

Re: Proposal: roll pg_stat_statements into core

2019-09-01 Thread Pavel Stehule
ne 1. 9. 2019 v 20:48 odesílatel David Fetter napsal: > On Sun, Sep 01, 2019 at 08:12:15PM +0200, Pavel Stehule wrote: > > Hi > > > > ne 1. 9. 2019 v 20:00 odesílatel David Fetter napsal: > > > > > Folks, > > > > > > I'd like to $Subject, on by default, with a switch to turn it off for > > >

Re: Proposal: roll pg_stat_statements into core

2019-09-01 Thread Tom Lane
David Fetter writes: > - It's broadly useful. Maybe. Whether it can be argued that it's so broadly useful as to justify being on-by-default is not clear. > - Right now, the barrier for turning it on is quite high. In addition > to being non-core, which is already a pretty high barrier at a

Re: Proposal: roll pg_stat_statements into core

2019-09-01 Thread David Fetter
On Sun, Sep 01, 2019 at 08:12:15PM +0200, Pavel Stehule wrote: > Hi > > ne 1. 9. 2019 v 20:00 odesílatel David Fetter napsal: > > > Folks, > > > > I'd like to $Subject, on by default, with a switch to turn it off for > > those really at the outer edges of performance. Some reasons include: > >

Re: Proposal: roll pg_stat_statements into core

2019-09-01 Thread Pavel Stehule
Hi ne 1. 9. 2019 v 20:00 odesílatel David Fetter napsal: > Folks, > > I'd like to $Subject, on by default, with a switch to turn it off for > those really at the outer edges of performance. Some reasons include: > > - It's broadly useful. > - Right now, the barrier for turning it on is quite

Proposal: roll pg_stat_statements into core

2019-09-01 Thread David Fetter
Folks, I'd like to $Subject, on by default, with a switch to turn it off for those really at the outer edges of performance. Some reasons include: - It's broadly useful. - Right now, the barrier for turning it on is quite high. In addition to being non-core, which is already a pretty high