> This patch is still in the current CommitFest, so I decided to review
> it. I see that DCH_keywords[] includes upper and lower-case entries
> for everything except the three cases corrected by this patch, where
> it includes upper-case entries but not the corresponding lower-case
> entries. It se
On Fri, Jul 9, 2021 at 10:44 AM Tomas Vondra
wrote:
> Yeah, does not seem to be worth it, as there seem to be no actual
> reports of issues in the field.
>
> FWIW there seem to be quite a bit of other to_char differences compared
> to Oracle (judging by docs and playing with sqlfiddle). But the pa
The following review has been posted through the commitfest application:
make installcheck-world: not tested
Implements feature: tested, passed
Spec compliant: not tested
Documentation:not tested
Applied the patch `v2_support_of_tzh_tzm_patterns.patch` to `REL_14_STABL
On 5/20/21 8:25 PM, Bruce Momjian wrote:
> On Thu, May 20, 2021 at 12:21:12PM +0530, Nitin Jadhav wrote:
>> Thanks Suraj for reviewing the patch.
>>
>>> 1:
>>> +RESET timezone;
>>> +
>>> +
>>> CREATE TABLE TIMESTAMPTZ_TST (a int , b timestamptz);
>>>
>>> Extra line.
>>>
>>> 2:
>>> +SET timezone
On Thu, May 20, 2021 at 12:21:12PM +0530, Nitin Jadhav wrote:
> Thanks Suraj for reviewing the patch.
>
> > 1:
> > +RESET timezone;
> > +
> > +
> > CREATE TABLE TIMESTAMPTZ_TST (a int , b timestamptz);
> >
> > Extra line.
> >
> > 2:
> > +SET timezone = '00:00';
> > +SELECT to_char(now(), 'of') as
Thanks Suraj for reviewing the patch.
> 1:
> +RESET timezone;
> +
> +
> CREATE TABLE TIMESTAMPTZ_TST (a int , b timestamptz);
>
> Extra line.
>
> 2:
> +SET timezone = '00:00';
> +SELECT to_char(now(), 'of') as "Of", to_char(now(), 'tzh:tzm') as
"tzh:tzm";
I have fixed these comments.
> I am not
+1 for the change.
I quickly reviewed the patch and overall it looks good to me.
Few cosmetic suggestions:
1:
+RESET timezone;
+
+
CREATE TABLE TIMESTAMPTZ_TST (a int , b timestamptz);
Extra line.
2:
+SET timezone = '00:00';
+SELECT to_char(now(), 'of') as "Of", to_char(now(), 'tzh:tzm') as
"t
> Please add it to the July commitfest: https://commitfest.postgresql.org/33/
Added a commitfest entry https://commitfest.postgresql.org/33/3121/
Thanks & Regards,
Nitin Jadhav
On Mon, May 17, 2021 at 7:05 AM David Rowley wrote:
>
> On Mon, 17 May 2021 at 06:23, Nitin Jadhav
> wrote:
> >
> > >
On Mon, 17 May 2021 at 06:23, Nitin Jadhav
wrote:
>
> > Hm. If Oracle does that, then there's an argument for us doing it
> > too. I can't get hugely excited about it, but maybe someone else
> > cares enough to prepare a patch.
>
> Thanks for the confirmation. Attached patch supports these forma
> Hm. If Oracle does that, then there's an argument for us doing it
> too. I can't get hugely excited about it, but maybe someone else
> cares enough to prepare a patch.
Thanks for the confirmation. Attached patch supports these format
patterns. Kindly review and let me know if any changes are r
Nitin Jadhav writes:
> Thanks for the explanation. I also feel that we may not support every
> case-variant. But the other reason which triggered me to think in the
> other way is, as mentioned in commit [1] where this feature was added,
> says that these format patterns are compatible with Oracle
> AFAICS, table 9.26 specifically shows which case-variants are supported.
> If there are some others that happen to work, we probably shouldn't
> remove them for fear of breaking poorly-written apps ... but that does
> not imply that we need to support every case-variant.
Thanks for the explanati
Nitin Jadhav writes:
> While understanding the behaviour of the to_char() function as
> explained in [1], I observed that some patterns related to time zones
> do not display values if we mention in lower case. As shown in the
> sample output [2], time zone related patterns TZH, TZM and OF outputs
Hi Hackers,
While understanding the behaviour of the to_char() function as
explained in [1], I observed that some patterns related to time zones
do not display values if we mention in lower case. As shown in the
sample output [2], time zone related patterns TZH, TZM and OF outputs
proper values wh
14 matches
Mail list logo
