Re: Question on error code selection in conflict detection

2025-06-12 Thread Robert Haas
On Thu, Jun 12, 2025 at 3:09 AM Amit Kapila wrote: > cases like UPDATE_MISSING, DELETE_MISSING, the existing code > ERRCODE_NO_DATA_FOUND seems to be an exact match. The LOG message > appears when we don't find the row to be updated or deleted while > applying changes. This can happen if someone d

Re: Question on error code selection in conflict detection

2025-06-12 Thread shveta malik
On Thu, Jun 12, 2025 at 12:39 PM Amit Kapila wrote: > > On Wed, Jun 11, 2025 at 7:33 PM Robert Haas wrote: > > > > On Tue, Jun 10, 2025 at 2:09 AM Amit Kapila wrote: > > > Can we instead try to use other suitable existing error codes? > > > > Why? > > > > I mean, I'm not 100% against using exist

Re: Question on error code selection in conflict detection

2025-06-12 Thread Amit Kapila
On Wed, Jun 11, 2025 at 7:33 PM Robert Haas wrote: > > On Tue, Jun 10, 2025 at 2:09 AM Amit Kapila wrote: > > Can we instead try to use other suitable existing error codes? > > Why? > > I mean, I'm not 100% against using existing error codes, but I feel > like we might be distorting the meanings

Re: Question on error code selection in conflict detection

2025-06-11 Thread Dilip Kumar
On Wed, Jun 11, 2025 at 7:33 PM Robert Haas wrote: > > On Tue, Jun 10, 2025 at 2:09 AM Amit Kapila wrote: > > Can we instead try to use other suitable existing error codes? > > Why? > > I mean, I'm not 100% against using existing error codes, but I feel > like we might be distorting the meanings

Re: Question on error code selection in conflict detection

2025-06-11 Thread Robert Haas
On Tue, Jun 10, 2025 at 2:09 AM Amit Kapila wrote: > Can we instead try to use other suitable existing error codes? Why? I mean, I'm not 100% against using existing error codes, but I feel like we might be distorting the meanings of the existing error codes. If we used new error codes, then peop

Re: Question on error code selection in conflict detection

2025-06-11 Thread shveta malik
On Wed, Jun 11, 2025 at 11:05 AM Dilip Kumar wrote: > > On Tue, Jun 10, 2025 at 12:14 PM Dilip Kumar wrote: > > > > On Tue, Jun 10, 2025 at 11:39 AM Amit Kapila > > wrote: > > > > > > On Mon, Jun 9, 2025 at 7:14 PM Dilip Kumar wrote: > > > > > > > > I was reviewing the code for conflict report

Re: Question on error code selection in conflict detection

2025-06-10 Thread Dilip Kumar
On Tue, Jun 10, 2025 at 12:14 PM Dilip Kumar wrote: > > On Tue, Jun 10, 2025 at 11:39 AM Amit Kapila wrote: > > > > On Mon, Jun 9, 2025 at 7:14 PM Dilip Kumar wrote: > > > > > > I was reviewing the code for conflict reporting and became curious > > > about the choice of ERRCODE_T_R_SERIALIZATION

Re: Question on error code selection in conflict detection

2025-06-10 Thread Dilip Kumar
On Tue, Jun 10, 2025 at 1:25 AM Robert Haas wrote: > > On Mon, Jun 9, 2025 at 9:45 AM Dilip Kumar wrote: > > I was reviewing the code for conflict reporting and became curious > > about the choice of ERRCODE_T_R_SERIALIZATION_FAILURE. This error code > > typically signifies a serialization failur

Re: Question on error code selection in conflict detection

2025-06-10 Thread Amit Kapila
On Mon, Jun 9, 2025 at 7:14 PM Dilip Kumar wrote: > > I was reviewing the code for conflict reporting and became curious > about the choice of ERRCODE_T_R_SERIALIZATION_FAILURE. This error code > typically signifies a serialization failure within a transaction under > serializable isolation, so it

Re: Question on error code selection in conflict detection

2025-06-09 Thread Dilip Kumar
On Tue, Jun 10, 2025 at 11:39 AM Amit Kapila wrote: > > On Mon, Jun 9, 2025 at 7:14 PM Dilip Kumar wrote: > > > > I was reviewing the code for conflict reporting and became curious > > about the choice of ERRCODE_T_R_SERIALIZATION_FAILURE. This error code > > typically signifies a serialization f

Re: Question on error code selection in conflict detection

2025-06-09 Thread Robert Haas
On Mon, Jun 9, 2025 at 9:45 AM Dilip Kumar wrote: > I was reviewing the code for conflict reporting and became curious > about the choice of ERRCODE_T_R_SERIALIZATION_FAILURE. This error code > typically signifies a serialization failure within a transaction under > serializable isolation, so its

Question on error code selection in conflict detection

2025-06-09 Thread Dilip Kumar
Hi, I was reviewing the code for conflict reporting and became curious about the choice of ERRCODE_T_R_SERIALIZATION_FAILURE. This error code typically signifies a serialization failure within a transaction under serializable isolation, so its use here for a different type of conflict seems somewh