Re: tablesync copy ignores publication actions

2022-06-24 Thread Amit Kapila
On Fri, Jun 24, 2022 at 2:09 AM Robert Haas wrote: > > On Thu, Jun 23, 2022 at 2:13 AM Amit Kapila wrote: > > The patch looks good to me as well. I will push this patch in HEAD (as > > per option (a)) tomorrow unless I see any more suggestions/comments. > > The example seems to demonstrate the

Re: tablesync copy ignores publication actions

2022-06-23 Thread Robert Haas
On Thu, Jun 23, 2022 at 2:13 AM Amit Kapila wrote: > The patch looks good to me as well. I will push this patch in HEAD (as > per option (a)) tomorrow unless I see any more suggestions/comments. The example seems to demonstrate the point quite well but one thing that I notice is that it is quite

Re: tablesync copy ignores publication actions

2022-06-23 Thread Amit Kapila
On Thu, Jun 23, 2022 at 8:43 AM shiy.f...@fujitsu.com wrote: > > On Wed, Jun 22, 2022 4:49 PM Peter Smith wrote: > > > > > > > > This patch looks mostly good to me except for a few minor comments > > > which are mentioned below. It is not very clear in which branch(es) we > > > should commit

RE: tablesync copy ignores publication actions

2022-06-22 Thread shiy.f...@fujitsu.com
On Wed, Jun 22, 2022 4:49 PM Peter Smith wrote: > > On Wed, Jun 22, 2022 at 2:18 PM Amit Kapila > wrote: > > > > On Thu, Jun 16, 2022 at 6:07 AM Peter Smith > wrote: > > > > > > > > Thank you for your review comments. Those reported mistakes are fixed > > > in the attached patch v3. > > > > >

Re: tablesync copy ignores publication actions

2022-06-22 Thread Peter Smith
On Wed, Jun 22, 2022 at 2:18 PM Amit Kapila wrote: > > On Thu, Jun 16, 2022 at 6:07 AM Peter Smith wrote: > > > > > Thank you for your review comments. Those reported mistakes are fixed > > in the attached patch v3. > > > > This patch looks mostly good to me except for a few minor comments >

Re: tablesync copy ignores publication actions

2022-06-21 Thread Amit Kapila
On Thu, Jun 16, 2022 at 6:07 AM Peter Smith wrote: > > Thank you for your review comments. Those reported mistakes are fixed > in the attached patch v3. > This patch looks mostly good to me except for a few minor comments which are mentioned below. It is not very clear in which branch(es) we

Re: tablesync copy ignores publication actions

2022-06-15 Thread Peter Smith
On Wed, Jun 15, 2022 at 5:05 PM shiy.f...@fujitsu.com wrote: > ... > Thanks for updating the patch. Two comments: > > 1. > + it means the copied table t3 contains all rows even > when > + they do not patch the row filter of publication > pub3b. > > Typo. I think "they do not patch the

RE: tablesync copy ignores publication actions

2022-06-15 Thread shiy.f...@fujitsu.com
On Tue, Jun 14, 2022 3:36 PM Peter Smith wrote: > > PSA v2 of the patch, based on all feedback received. > > ~~~ > > Main differences from v1: > > * Rewording and more explanatory text. > > * The examples were moved to the "Subscription" [1] page and also > extended to show some normal

Re: tablesync copy ignores publication actions

2022-06-14 Thread Peter Smith
PSA v2 of the patch, based on all feedback received. ~~~ Main differences from v1: * Rewording and more explanatory text. * The examples were moved to the "Subscription" [1] page and also extended to show some normal replication and row filter examples, from [Amit]. * Added some text to

RE: tablesync copy ignores publication actions

2022-06-13 Thread shiy.f...@fujitsu.com
On Wed, Jun 8, 2022 12:10 PM Amit Kapila wrote: > > On Tue, Jun 7, 2022 at 7:08 PM Euler Taveira wrote: > > > > On Tue, Jun 7, 2022, at 1:10 AM, Peter Smith wrote: > > > > The logical replication tablesync ignores the publication 'publish' > > operations during the initial data copy. > > > >

Re: tablesync copy ignores publication actions

2022-06-07 Thread Amit Kapila
On Tue, Jun 7, 2022 at 7:08 PM Euler Taveira wrote: > > On Tue, Jun 7, 2022, at 1:10 AM, Peter Smith wrote: > > The logical replication tablesync ignores the publication 'publish' > operations during the initial data copy. > > This is current/known PG behaviour (e.g. as recently mentioned [1]) >

Re: tablesync copy ignores publication actions

2022-06-07 Thread Euler Taveira
On Tue, Jun 7, 2022, at 1:10 AM, Peter Smith wrote: > The logical replication tablesync ignores the publication 'publish' > operations during the initial data copy. > > This is current/known PG behaviour (e.g. as recently mentioned [1]) > but it was not documented anywhere. initial data