On Mon, Jul 16, 2018 at 03:35:57PM +0800, Haozhou Wang wrote:
> +1, I also think that we may not change the previous behavior of plpython.
> @Nikita Glukhov maybe we just check the
> whether pyobject is int or long only in related conversion functions, and
> fallback otherwise?
This patch was
+1, I also think that we may not change the previous behavior of plpython.
@Nikita Glukhov maybe we just check the
whether pyobject is int or long only in related conversion functions, and
fallback otherwise?
On Fri, Jul 13, 2018 at 12:09 AM Heikki Linnakangas wrote:
> On 12/07/18 18:06,
On 12/07/18 18:06, Nikita Glukhov wrote:
I have added some cross-type test cases and now almost all new code is covered
(excluding several error cases which can be triggered only by custom numeric
type implementations).
Thanks! Some of those new tests actually fail, if you run them against
On 11.07.2018 21:03, Heikki Linnakangas wrote:
On 26/03/18 19:07, Nikita Glukhov wrote:
Attached fixed 3th version of the patch:
Thanks, I'm reviewing this now. Nice speedup!
Thank you for your review.
There is no test coverage for some of the added code. You can get a
code coverage
On 26/03/18 19:07, Nikita Glukhov wrote:
Attached fixed 3th version of the patch:
Thanks, I'm reviewing this now. Nice speedup!
There is no test coverage for some of the added code. You can get a code
coverage report with:
./configure --enable-coverage ...
make
make -C src/pl/plpython
On 4/11/18 2:36 AM, Haozhou Wang wrote:
>
> Thanks for your email.
> Just wondering will I need to re-submit this patch?
No need to resubmit, the CF entry has been moved here:
https://commitfest.postgresql.org/18/1499/
You should have a look at Nikita's patch, though.
Regards,
--
-David
On 3/26/18 12:07 PM, Nikita Glukhov wrote:
> On 26.03.2018 17:19, David Steele wrote:
>
>> On 2/20/18 10:14 AM, Haozhou Wang wrote:
>>> Thank you very much for your review!
>>>
>>> I attached a new patch with typo fixed.
>> I think it's a bit premature to mark this Ready for Committer after a
>>
Thanks Nikita!
On Tue, Mar 27, 2018 at 12:07 AM, Nikita Glukhov
wrote:
> On 26.03.2018 17:19, David Steele wrote:
>
> On 2/20/18 10:14 AM, Haozhou Wang wrote:
>>
>>> Thank you very much for your review!
>>>
>>> I attached a new patch with typo fixed.
>>>
>> I think it's
On 26.03.2018 17:19, David Steele wrote:
On 2/20/18 10:14 AM, Haozhou Wang wrote:
Thank you very much for your review!
I attached a new patch with typo fixed.
I think it's a bit premature to mark this Ready for Committer after a
review consisting of a few typos. Anthony only said that he
On 2/20/18 10:14 AM, Haozhou Wang wrote:
> Thank you very much for your review!
>
> I attached a new patch with typo fixed.
I think it's a bit premature to mark this Ready for Committer after a
review consisting of a few typos. Anthony only said that he started
looking at it so I've marked it
Thank you very much for your review!
I attached a new patch with typo fixed.
Regards,
Haozhou
On Mon, Feb 19, 2018 at 2:37 PM, Anthony Bykov
wrote:
> On Wed, 31 Jan 2018 11:57:12 +0800
> Haozhou Wang wrote:
>
> > Hi All,
> >
> > PL/Python already
On Wed, 31 Jan 2018 11:57:12 +0800
Haozhou Wang wrote:
> Hi All,
>
> PL/Python already has different type conversion functions to
> convert PostgreSQL datum to Python object. However, the conversion
> functions from Python object to PostgreSQL datum only has Boolean,
> Bytea
12 matches
Mail list logo