Re: BUG #15572: Misleading message reported by "Drop function operation" on DB with functions having same name

2019-03-21 Thread David Rowley
On Fri, 22 Mar 2019 at 05:04, Tom Lane wrote: > Pushed with mostly-cosmetic adjustments. Thanks for pushing this. > I noticed a couple of loose ends that are somewhat outside the scope > of the bug report, but maybe are worth considering now: > > 1. There's some inconsistency in the wording of

Re: BUG #15572: Misleading message reported by "Drop function operation" on DB with functions having same name

2019-03-21 Thread Tom Lane
David Rowley writes: > [ drop_func_if_not_exists_fix_v9.patch ] Pushed with mostly-cosmetic adjustments. I noticed a couple of loose ends that are somewhat outside the scope of the bug report, but maybe are worth considering now: 1. There's some inconsistency in the wording of the error

Re: BUG #15572: Misleading message reported by "Drop function operation" on DB with functions having same name

2019-03-20 Thread David Rowley
Thanks for reviewing this. On Wed, 20 Mar 2019 at 04:31, Pavel Stehule wrote: > I propose maybe more strongly comment fact so noError is applied only on "not > found" event. In other cases, this flag is ignored and error is raised > immediately there. I think so it is not good enough commented

Re: BUG #15572: Misleading message reported by "Drop function operation" on DB with functions having same name

2019-03-19 Thread Pavel Stehule
The following review has been posted through the commitfest application: make installcheck-world: tested, passed Implements feature: tested, passed Spec compliant: not tested Documentation:not tested I read a discussion and I think so currently implemented behave (by