Re: Few untranslated error messages in OAuth

2025-11-13 Thread Jacob Champion
On Thu, Nov 13, 2025 at 3:08 PM Jacob Champion wrote: > I'm writing up a patch that combines all of that. And here's what I have so far. I could use help double-checking the .po result; I'm not entirely sure my usage of update-po is correct. I took this opportunity to address a complaint from Al

Re: Few untranslated error messages in OAuth

2025-11-13 Thread Jacob Champion
On Thu, Nov 13, 2025 at 8:23 AM Jacob Champion wrote: > On Thu, Nov 13, 2025 at 4:49 AM Daniel Gustafsson wrote: > > If so, should that be extended to oauth_json_set_error as well? (and > > possibly others?) > > That should be covered already by nls.mk, unless I messed that up > too... I'll do a

Re: Few untranslated error messages in OAuth

2025-11-13 Thread Jacob Champion
On Thu, Nov 13, 2025 at 4:49 AM Daniel Gustafsson wrote: > If so, should that be extended to oauth_json_set_error as well? (and possibly > others?) That should be covered already by nls.mk, unless I messed that up too... I'll do a deeper dive. Another way to fix this would be to wrap the assign

Re: Few untranslated error messages in OAuth

2025-11-13 Thread Daniel Gustafsson
> On 13 Nov 2025, at 13:32, Álvaro Herrera wrote: > > On 2025-Nov-13, Daniel Gustafsson wrote: > >> I was pondering that since auth error messages in backend libpq does this, >> but >> since we don't use gettext_noop anywhere else in frontend libpq today it >> makes >> sense to go with libpq_g

Re: Few untranslated error messages in OAuth

2025-11-13 Thread Álvaro Herrera
On 2025-Nov-13, Daniel Gustafsson wrote: > I was pondering that since auth error messages in backend libpq does this, but > since we don't use gettext_noop anywhere else in frontend libpq today it makes > sense to go with libpq_gettext and update the docs instead. > > Unless you, who has more tran

Re: Few untranslated error messages in OAuth

2025-11-13 Thread Daniel Gustafsson
> On 13 Nov 2025, at 09:13, Álvaro Herrera wrote: > On 2025-Nov-13, Zhijie Hou (Fujitsu) wrote: >> During testing of libpq, I noticed several error messages not processed by >> libpq_gettext, resulting in their exclusion from *.pot files. The attached >> patch >> wraps these messages. Thanks fo

Re: Few untranslated error messages in OAuth

2025-11-13 Thread Álvaro Herrera
On 2025-Nov-13, Zhijie Hou (Fujitsu) wrote: > Hi, > > During testing of libpq, I noticed several error messages not processed by > libpq_gettext, resulting in their exclusion from *.pot files. The attached > patch > wraps these messages. Yeah, this roughly makes sense. I think the documentatio

Re: Few untranslated error messages in OAuth

2025-11-12 Thread Michael Paquier
On Thu, Nov 13, 2025 at 06:01:29AM +, Zhijie Hou (Fujitsu) wrote: > During testing of libpq, I noticed several error messages not processed by > libpq_gettext, resulting in their exclusion from *.pot files. The attached > patch > wraps these messages. (Added Jacob and Daniel in CC.) async_ct