On Wed, Jul 11, 2018 at 11:04 PM, Tom Lane wrote:
> Andres Freund writes:
>> On 2018-07-11 12:56:49 +0530, Amit Kapila wrote:
>>> Yeah, it is good practice to drop the objects at the end. It is
>>> strange that original commit adfb81d9e1 has this at the end of the
>>> test, but a later commit 36
Andres Freund writes:
> On 2018-07-11 12:56:49 +0530, Amit Kapila wrote:
>> Yeah, it is good practice to drop the objects at the end. It is
>> strange that original commit adfb81d9e1 has this at the end of the
>> test, but a later commit 367b99bbb1 by Tom has removed the Drop
>> statement. AFAIC
On 2018-07-11 12:56:49 +0530, Amit Kapila wrote:
> On Wed, Jul 11, 2018 at 12:37 PM, Kuntal Ghosh
> wrote:
> > Hello all,
> >
> > In pageinspect/sql/gin.sql, we don't drop the table test1 at the end
> > of the test. IMHO, we should clean-up at the end of a test.
> >
>
> Yeah, it is good practice
On Wed, Jul 11, 2018 at 12:37 PM, Kuntal Ghosh
wrote:
> Hello all,
>
> In pageinspect/sql/gin.sql, we don't drop the table test1 at the end
> of the test. IMHO, we should clean-up at the end of a test.
>
Yeah, it is good practice to drop the objects at the end. It is
strange that original commit
