On Thu Nov 13, 2025 at 6:11 AM -03, Chao Li wrote:
>>
>
> 1 - commit comment
> ```
> User-defined locations are only visible for users that has the
> pg_read_extension_paths role, otherwise is
> returned as a column value, the same behaviour that we already have on
> pg_stat_activity.
> ```
>
> F
Hi Matheus,
I just reviewed and tested the patch again, got a few more comments:
> On Nov 11, 2025, at 20:47, Matheus Alcantara wrote:
>
>
> On this new v5 version I also swap the order of "comment" and "location"
> columns as it was suggested by Michael.
>
> --
> Matheus Alcantara
> EDB: htt
On Tue Nov 11, 2025 at 8:17 PM -03, Rohit Prasad wrote:
> Hi Matheus,
>
> Apologies for the mix up on the names :-)
>
> I agree with your responses (please ignore my prior comment about
> test_extension code; I had missed some of your changes there).
>
> I also reviewed v5 of your patch and the c
Hi Matheus,
Apologies for the mix up on the names :-)
I agree with your responses (please ignore my prior comment about
test_extension code; I had missed some of your changes there).
I also reviewed v5 of your patch and the changes look good to me.
Thanks,
-Rohit
On Mon Nov 10, 2025 at 11:06 PM -03, Rohit Prasad wrote:
> Hi Michael,
>
I think you wanted to say Matheus :)
> I am just getting started in the Postgres community (this is my first
> code review). So please excuse me if I have missed something (in terms
> of process etc).
>
Thank you for reviewin
On Mon Nov 10, 2025 at 8:10 PM -03, Michael Banck wrote:
>> > I have a small bikeshedding comment around making "location" the 4th column
>> > returned for "select * from pg_available_extensions", as opposed to leaving
>> > "comment" the 4th column returned for "select * from
>> > pg_available_exte
Hi Michael,
I am just getting started in the Postgres community (this is my first code
review). So please excuse me if I have missed something (in terms of process
etc).
I reviewed your proposed code changes in the attached patch file and they look
good to me. I have some minor comments:
1. In
Hi,
On Mon, Nov 10, 2025 at 07:48:03PM -0300, Matheus Alcantara wrote:
> On Mon Nov 10, 2025 at 3:25 PM -03, Manni Wood wrote:
> > I have a small bikeshedding comment around making "location" the 4th column
> > returned for "select * from pg_available_extensions", as opposed to leaving
> > "commen
Thank you for reviewing this!
On Mon Nov 10, 2025 at 3:25 PM -03, Manni Wood wrote:
> Hello!
>
> I have a small bikeshedding comment around making "location" the 4th column
> returned for "select * from pg_available_extensions", as opposed to leaving
> "comment" the 4th column returned for "select
On Thu, Nov 6, 2025 at 9:29 AM Matheus Alcantara
wrote:
> Thanks for reviewing this!
>
> On Sun Nov 2, 2025 at 12:11 PM -03, Michael Banck wrote:
> > On Mon, Sep 15, 2025 at 09:18:25PM -0300, Matheus Alcantara wrote:
> >> postgres=# select * from pg_available_extensions;
> >> name | default_v
Thanks for reviewing this!
On Sun Nov 2, 2025 at 12:11 PM -03, Michael Banck wrote:
> On Mon, Sep 15, 2025 at 09:18:25PM -0300, Matheus Alcantara wrote:
>> postgres=# select * from pg_available_extensions;
>> name | default_version | installed_version | comment
>>
Hi,
On Mon, Sep 15, 2025 at 09:18:25PM -0300, Matheus Alcantara wrote:
> postgres=# select * from pg_available_extensions;
> name | default_version | installed_version | comment
> | location
> -+-+--
On Tue Oct 28, 2025 at 5:56 PM -03, Euler Taveira wrote:
> On Tue, Oct 28, 2025, at 9:29 AM, Matheus Alcantara wrote:
>> So here it is, see attached.
>>
>
> I took another look at this patch.
>
Thanks for reviewing!
> ! This adds a new "location" column on pg_available_extensions and
> ! pg_availa
On Tue, Oct 28, 2025, at 9:29 AM, Matheus Alcantara wrote:
> So here it is, see attached.
>
I took another look at this patch.
! This adds a new "location" column on pg_available_extensions and
! pg_available_extension_versions views to show the path of locations that
! Postgres is seeing based o
On Thu Oct 23, 2025 at 10:57 PM -03, Quan Zongliang wrote:
> On 10/23/25 9:56 PM, Euler Taveira wrote:
>
>>
>> * insufficient privilege: if the role doesn't have the sufficient privileges,
>>return NULL or '' (similar to pg_stat_activity). I
>>don't have a strong preference but the latter
On 10/23/25 9:56 PM, Euler Taveira wrote:
* insufficient privilege: if the role doesn't have the sufficient privileges,
return NULL or '' (similar to pg_stat_activity). I
don't have a strong preference but the latter can impose more effort to use
if you don't know the role has suffi
On Thu Oct 23, 2025 at 10:56 AM -03, Euler Taveira wrote:
> On Wed, Oct 22, 2025, at 10:28 PM, Chao Li wrote:
>>> On 9/16/25 8:18 AM, Matheus Alcantara wrote:
>>>
Any opinions on this?
[1]
https://www.postgresql.org/message-id/CAKFQuwbR1Fzr8yRuMW%3DN1UMA1cTpFcqZe9bW_-ZF8%3DBa2Ud2%3
Thanks for reviewing this!
On Wed Oct 22, 2025 at 10:28 PM -03, Chao Li wrote:
>>
>
> Got a few comments:
>
> 1 - extension.c
> ```
> +/*
> + * A location configured on extension_control_path GUC.
> + *
> + * The macro is the macro plaeholder that the extension_control_path support
> + * and whic
Thanks for testing this!
On Wed Oct 22, 2025 at 9:19 PM -03, Quan Zongliang wrote:
> On 9/16/25 8:18 AM, Matheus Alcantara wrote:
>
>> Any opinions on this?
>>
>> [1]
>> https://www.postgresql.org/message-id/CAKFQuwbR1Fzr8yRuMW%3DN1UMA1cTpFcqZe9bW_-ZF8%3DBa2Ud2%3Dw%40mail.gmail.com
>>
> Just as
On Wed, Oct 22, 2025, at 10:28 PM, Chao Li wrote:
>> On 9/16/25 8:18 AM, Matheus Alcantara wrote:
>>
>>> Any opinions on this?
>>> [1]
>>> https://www.postgresql.org/message-id/CAKFQuwbR1Fzr8yRuMW%3DN1UMA1cTpFcqZe9bW_-ZF8%3DBa2Ud2%3Dw%40mail.gmail.com
>> Just as the discussion here. Adding extens
> On 9/16/25 8:18 AM, Matheus Alcantara wrote:
>
>> Any opinions on this?
>> [1]
>> https://www.postgresql.org/message-id/CAKFQuwbR1Fzr8yRuMW%3DN1UMA1cTpFcqZe9bW_-ZF8%3DBa2Ud2%3Dw%40mail.gmail.com
> Just as the discussion here. Adding extension location is a good idea.
+1. I like the ideal.
On 9/16/25 8:18 AM, Matheus Alcantara wrote:
Any opinions on this?
[1]
https://www.postgresql.org/message-id/CAKFQuwbR1Fzr8yRuMW%3DN1UMA1cTpFcqZe9bW_-ZF8%3DBa2Ud2%3Dw%40mail.gmail.com
Just as the discussion here. Adding extension location is a good idea.
Suppose there is an amcheck 1.5 lo
22 matches
Mail list logo
