Re: Possible inaccurate description of wal_compression in docs

2025-08-13 Thread Jingtang Zhang
> Do any of you have a specific wording in mind? 'Like when FPW is on …' would be okay, or '(e.g., when FPW is on …)' would be formal? -- Regards, Jingtang

Re: Possible inaccurate description of wal_compression in docs

2025-08-12 Thread Xuneng Zhou
Hi, On Tue, Aug 12, 2025 at 12:41 PM Michael Paquier wrote: > On Mon, Aug 11, 2025 at 06:59:55PM +0300, Andrey Borodin wrote: > > FPWs are used here and there in a lot of places, like "FPI for > > hint". And indexes are build using FPI for many years, it did not > > start with 17... > > This lis

Re: Possible inaccurate description of wal_compression in docs

2025-08-11 Thread Michael Paquier
On Mon, Aug 11, 2025 at 06:59:55PM +0300, Andrey Borodin wrote: > FPWs are used here and there in a lot of places, like "FPI for > hint". And indexes are build using FPI for many years, it did not > start with 17... > This list is not exhaustive in any case, so I agree that formulation > should no

Re: Possible inaccurate description of wal_compression in docs

2025-08-11 Thread Jingtang Zhang
Hi~ > FPWs are used here and there in a lot of places, like "FPI for hint". And > indexes are build using FPI for many years, it did not start with 17... Yeah, my fault. Creating index prior to v17 was also using log_newpages. — Regards, Jingtang

Re: Possible inaccurate description of wal_compression in docs

2025-08-11 Thread Andrey Borodin
> On 10 Aug 2025, at 13:53, Jingtang Zhang wrote: > > Hi hackers~ > > I find the specification of wal_compression in our docs a little bit confusing > for it 'compress full page images when FPW is on or during a base backup', > which was true before v17. Since v17, we will also use full page

Re: Possible inaccurate description of wal_compression in docs

2025-08-11 Thread Xuneng Zhou
Hi, On Sun, Aug 10, 2025 at 6:53 PM Jingtang Zhang wrote: > > Hi hackers~ > > I find the specification of wal_compression in our docs a little bit confusing > for it 'compress full page images when FPW is on or during a base backup', > which was true before v17. Since v17, we will also use full p