On Tue, Apr 20, 2021 at 9:08 AM Masahiko Sawada wrote:
>
> On Mon, Apr 19, 2021 at 4:48 PM Masahiko Sawada wrote:
> >
> > On Mon, Apr 19, 2021 at 2:14 PM Amit Kapila wrote:
> > >
> > > On Mon, Apr 19, 2021 at 9:00 AM Masahiko Sawada
> > > wrote:
> > > >
> > > > On Fri, Apr 16, 2021 at 2:58 PM
On Tue, Apr 20, 2021 at 9:08 AM Masahiko Sawada wrote:
>
> I've attached the new version patch that fixed the compilation error
> reported off-line by Amit.
>
I was thinking about whether we can someway avoid the below risk:
In case where the
+ * message for dropping the old slot gets lost and a
On Mon, Apr 19, 2021 at 4:48 PM Masahiko Sawada wrote:
>
> On Mon, Apr 19, 2021 at 2:14 PM Amit Kapila wrote:
> >
> > On Mon, Apr 19, 2021 at 9:00 AM Masahiko Sawada
> > wrote:
> > >
> > > On Fri, Apr 16, 2021 at 2:58 PM Amit Kapila
> > > wrote:
> > > >
> > > >
> > > > 4.
> > > > +CREATE VIEW
On Fri, Apr 16, 2021 at 3:16 PM Amit Kapila wrote:
>
> On Mon, Apr 12, 2021 at 2:57 PM vignesh C wrote:
> >
> > On Sat, Mar 20, 2021 at 9:26 AM Amit Kapila wrote:
> > >
> > > On Sat, Mar 20, 2021 at 12:22 AM Andres Freund wrote:
> > > >
> > > > And then more generally about the feature:
> > > >
On Mon, Apr 19, 2021 at 2:14 PM Amit Kapila wrote:
>
> On Mon, Apr 19, 2021 at 9:00 AM Masahiko Sawada wrote:
> >
> > On Fri, Apr 16, 2021 at 2:58 PM Amit Kapila wrote:
> > >
> > >
> > > 4.
> > > +CREATE VIEW pg_stat_replication_slots AS
> > > +SELECT
> > > +s.slot_name,
> > > +
On Mon, Apr 19, 2021 at 9:00 AM Masahiko Sawada wrote:
>
> On Fri, Apr 16, 2021 at 2:58 PM Amit Kapila wrote:
> >
> >
> > 4.
> > +CREATE VIEW pg_stat_replication_slots AS
> > +SELECT
> > +s.slot_name,
> > +s.spill_txns,
> > +s.spill_count,
> > +
On Fri, Apr 16, 2021 at 8:50 AM Justin Pryzby wrote:
>
> On Fri, Apr 16, 2021 at 08:48:29AM +0530, Amit Kapila wrote:
> > I am fine with your proposed changes. There are one or two more
> > patches in this area. I can include your suggestions along with those
> > if you don't mind?
>
> However's c
On Sun, Apr 18, 2021 at 6:51 PM Masahiko Sawada wrote:
>
> Yes, also the following expectation in expected/stats.out is wrong:
>
> SELECT slot_name, spill_txns = 0 AS spill_txns, spill_count = 0 AS
> spill_count, total_txns > 0 AS total_txns, total_bytes > 0 AS
> total_bytes FROM pg_stat_replicati
On Fri, Apr 16, 2021 at 2:58 PM Amit Kapila wrote:
>
> On Thu, Apr 15, 2021 at 4:35 PM Masahiko Sawada wrote:
> >
> > Thank you for the update! The patch looks good to me.
> >
>
> I have pushed the first patch. Comments on the next patch
> v13-0001-Use-HTAB-for-replication-slot-statistics:
> 1.
>
On Sun, Apr 18, 2021 at 9:02 AM vignesh C wrote:
>
> On Sun, Apr 18, 2021 at 8:43 AM Amit Kapila wrote:
> >
> > On Sun, Apr 18, 2021 at 7:36 AM vignesh C wrote:
> > >
> > > On Sun, Apr 18, 2021 at 3:51 AM Tom Lane wrote:
> > > >
> > > > I wrote:
> > > > > The buildfarm suggests that this isn't
On Sun, Apr 18, 2021 at 12:13 PM Amit Kapila wrote:
>
> On Sun, Apr 18, 2021 at 7:36 AM vignesh C wrote:
> >
> > On Sun, Apr 18, 2021 at 3:51 AM Tom Lane wrote:
> > >
> > > I wrote:
> > > > The buildfarm suggests that this isn't entirely stable:
> > > > https://buildfarm.postgresql.org/cgi-bin/s
On Sun, Apr 18, 2021 at 8:43 AM Amit Kapila wrote:
>
> On Sun, Apr 18, 2021 at 7:36 AM vignesh C wrote:
> >
> > On Sun, Apr 18, 2021 at 3:51 AM Tom Lane wrote:
> > >
> > > I wrote:
> > > > The buildfarm suggests that this isn't entirely stable:
> > > > https://buildfarm.postgresql.org/cgi-bin/sh
On Sun, Apr 18, 2021 at 7:36 AM vignesh C wrote:
>
> On Sun, Apr 18, 2021 at 3:51 AM Tom Lane wrote:
> >
> > I wrote:
> > > The buildfarm suggests that this isn't entirely stable:
> > > https://buildfarm.postgresql.org/cgi-bin/show_log.pl?nm=anole&dt=2021-04-17%2011%3A14%3A49
> > > https://buildf
On Sun, Apr 18, 2021 at 3:51 AM Tom Lane wrote:
>
> I wrote:
> > The buildfarm suggests that this isn't entirely stable:
> > https://buildfarm.postgresql.org/cgi-bin/show_log.pl?nm=anole&dt=2021-04-17%2011%3A14%3A49
> > https://buildfarm.postgresql.org/cgi-bin/show_log.pl?nm=bichir&dt=2021-04-17%2
I wrote:
> The buildfarm suggests that this isn't entirely stable:
> https://buildfarm.postgresql.org/cgi-bin/show_log.pl?nm=anole&dt=2021-04-17%2011%3A14%3A49
> https://buildfarm.postgresql.org/cgi-bin/show_log.pl?nm=bichir&dt=2021-04-17%2016%3A30%3A15
Oh, I missed that hyrax is showing the ident
Amit Kapila writes:
> I have pushed the first patch.
The buildfarm suggests that this isn't entirely stable:
https://buildfarm.postgresql.org/cgi-bin/show_log.pl?nm=anole&dt=2021-04-17%2011%3A14%3A49
https://buildfarm.postgresql.org/cgi-bin/show_log.pl?nm=bichir&dt=2021-04-17%2016%3A30%3A15
Eac
On Fri, Apr 16, 2021 at 11:28 AM Amit Kapila wrote:
>
> On Thu, Apr 15, 2021 at 4:35 PM Masahiko Sawada wrote:
> >
> > Thank you for the update! The patch looks good to me.
> >
>
> I have pushed the first patch. Comments on the next patch
> v13-0001-Use-HTAB-for-replication-slot-statistics:
Also
On Fri, Apr 16, 2021 at 3:16 PM Amit Kapila wrote:
>
> On Mon, Apr 12, 2021 at 2:57 PM vignesh C wrote:
> >
> > On Sat, Mar 20, 2021 at 9:26 AM Amit Kapila wrote:
> > >
> > > On Sat, Mar 20, 2021 at 12:22 AM Andres Freund wrote:
> > > >
> > > > And then more generally about the feature:
> > > >
On Mon, Apr 12, 2021 at 2:57 PM vignesh C wrote:
>
> On Sat, Mar 20, 2021 at 9:26 AM Amit Kapila wrote:
> >
> > On Sat, Mar 20, 2021 at 12:22 AM Andres Freund wrote:
> > >
> > > And then more generally about the feature:
> > > - If a slot was used to stream out a large amount of changes (say an
On Thu, Apr 15, 2021 at 4:35 PM Masahiko Sawada wrote:
>
> Thank you for the update! The patch looks good to me.
>
I have pushed the first patch. Comments on the next patch
v13-0001-Use-HTAB-for-replication-slot-statistics:
1.
+ /*
+ * Check for all replication slots in stats hash table. We do th
On Thu, Apr 15, 2021 at 2:46 PM Amit Kapila wrote:
>
> On Thu, Apr 15, 2021 at 1:13 PM Masahiko Sawada wrote:
> >
> > On Thu, Apr 15, 2021 at 3:22 PM Amit Kapila wrote:
> > >
> > Thank you for updating the patch.
> >
> > I have one question on the doc change:
> >
> > +so the counter is n
On Fri, Apr 16, 2021 at 08:48:29AM +0530, Amit Kapila wrote:
> I am fine with your proposed changes. There are one or two more
> patches in this area. I can include your suggestions along with those
> if you don't mind?
However's convenient is fine
--
Justin
On Fri, Apr 16, 2021 at 8:22 AM Justin Pryzby wrote:
>
> On Thu, Apr 15, 2021 at 02:46:35PM +0530, Amit Kapila wrote:
> > On Thu, Apr 15, 2021 at 1:13 PM Masahiko Sawada
> > wrote:
> > >
> > > On Thu, Apr 15, 2021 at 3:22 PM Amit Kapila
> > > wrote:
> > > >
> > > Thank you for updating the pat
On Thu, Apr 15, 2021 at 02:46:35PM +0530, Amit Kapila wrote:
> On Thu, Apr 15, 2021 at 1:13 PM Masahiko Sawada wrote:
> >
> > On Thu, Apr 15, 2021 at 3:22 PM Amit Kapila wrote:
> > >
> > Thank you for updating the patch.
> >
> > I have one question on the doc change:
> >
> > +so the count
On Thu, Apr 15, 2021 at 6:16 PM Amit Kapila wrote:
>
> On Thu, Apr 15, 2021 at 1:13 PM Masahiko Sawada wrote:
> >
> > On Thu, Apr 15, 2021 at 3:22 PM Amit Kapila wrote:
> > >
> > Thank you for updating the patch.
> >
> > I have one question on the doc change:
> >
> > +so the counter is n
On Thu, Apr 15, 2021 at 1:13 PM Masahiko Sawada wrote:
>
> On Thu, Apr 15, 2021 at 3:22 PM Amit Kapila wrote:
> >
> Thank you for updating the patch.
>
> I have one question on the doc change:
>
> +so the counter is not incremented for subtransactions. Note that this
> +includes t
On Thu, Apr 15, 2021 at 3:22 PM Amit Kapila wrote:
>
> On Wed, Apr 14, 2021 at 5:52 PM vignesh C wrote:
> >
>
> I have made minor changes to the 0001 and 0002 patches. Attached is
> the combined patch for them, I think we can push them as one patch.
> Changes made are (a) minor editing in comment
On Thu, Apr 15, 2021 at 12:45 PM vignesh C wrote:
>
> On Thu, Apr 15, 2021 at 11:52 AM Amit Kapila wrote:
> >
> > On Wed, Apr 14, 2021 at 5:52 PM vignesh C wrote:
> > >
> >
> > I have made minor changes to the 0001 and 0002 patches. Attached is
> > the combined patch for them, I think we can pus
On Thu, Apr 15, 2021 at 11:52 AM Amit Kapila wrote:
>
> On Wed, Apr 14, 2021 at 5:52 PM vignesh C wrote:
> >
>
> I have made minor changes to the 0001 and 0002 patches. Attached is
> the combined patch for them, I think we can push them as one patch.
> Changes made are (a) minor editing in commen
On Wed, Apr 14, 2021 at 5:52 PM vignesh C wrote:
>
I have made minor changes to the 0001 and 0002 patches. Attached is
the combined patch for them, I think we can push them as one patch.
Changes made are (a) minor editing in comments, (b) changed the
condition when to report stats such that unles
On Wed, Apr 14, 2021 at 12:09 PM Amit Kapila wrote:
>
> On Tue, Apr 13, 2021 at 1:37 PM vignesh C wrote:
> >
> > On Mon, Apr 12, 2021 at 7:03 PM Masahiko Sawada
> > wrote:
> > >
> > >
> > > The following test for the latest v8 patch seems to show different.
> > > total_bytes is 1808 whereas spi
On Tue, Apr 13, 2021 at 1:37 PM vignesh C wrote:
>
> On Mon, Apr 12, 2021 at 7:03 PM Masahiko Sawada wrote:
> >
> >
> > The following test for the latest v8 patch seems to show different.
> > total_bytes is 1808 whereas spill_bytes is 1320. Am I missing
> > something?
> >
> > postgres(1:85969
On Wed, Apr 14, 2021 at 8:04 AM vignesh C wrote:
>
> On Wed, Apr 14, 2021 at 7:52 AM Masahiko Sawada wrote:
> >
> > I've not looked at the patches yet but as Amit mentioned before[1],
> > it's better to move 0002 patch to after 0004. That is, 0001 patch
> > changes data type to NameData, 0002 pat
On Wed, Apr 14, 2021 at 7:52 AM Masahiko Sawada wrote:
>
> On Tue, Apr 13, 2021 at 5:07 PM vignesh C wrote:
> >
> > On Mon, Apr 12, 2021 at 7:03 PM Masahiko Sawada
> > wrote:
> > >
> > > On Mon, Apr 12, 2021 at 9:36 PM Amit Kapila
> > > wrote:
> > > >
> > > > On Mon, Apr 12, 2021 at 5:29 PM M
On Tue, Apr 13, 2021 at 5:07 PM vignesh C wrote:
>
> On Mon, Apr 12, 2021 at 7:03 PM Masahiko Sawada wrote:
> >
> > On Mon, Apr 12, 2021 at 9:36 PM Amit Kapila wrote:
> > >
> > > On Mon, Apr 12, 2021 at 5:29 PM Masahiko Sawada
> > > wrote:
> > > >
> > > > On Mon, Apr 12, 2021 at 8:08 PM Amit K
On Tue, Apr 13, 2021 at 10:46 AM Masahiko Sawada
wrote:
>
> On Mon, Apr 12, 2021 at 9:16 PM vignesh C wrote:
> >
> > On Mon, Apr 12, 2021 at 4:46 PM Amit Kapila
wrote:
> > >
> > > On Sat, Apr 10, 2021 at 6:51 PM vignesh C wrote:
> > > >
> > >
> > > Thanks, 0001 and 0002 look good to me. I have
On Mon, Apr 12, 2021 at 7:03 PM Masahiko Sawada wrote:
>
> On Mon, Apr 12, 2021 at 9:36 PM Amit Kapila wrote:
> >
> > On Mon, Apr 12, 2021 at 5:29 PM Masahiko Sawada
> > wrote:
> > >
> > > On Mon, Apr 12, 2021 at 8:08 PM Amit Kapila
> > > wrote:
> > > >
> > > > On Mon, Apr 12, 2021 at 4:34 PM
On Mon, Apr 12, 2021 at 9:16 PM vignesh C wrote:
>
> On Mon, Apr 12, 2021 at 4:46 PM Amit Kapila wrote:
> >
> > On Sat, Apr 10, 2021 at 6:51 PM vignesh C wrote:
> > >
> >
> > Thanks, 0001 and 0002 look good to me. I have a minor comment for 0002.
> >
> >
> > +total_bytesbigint
> > +
On Mon, Apr 12, 2021 at 7:03 PM Masahiko Sawada wrote:
>
> On Mon, Apr 12, 2021 at 9:36 PM Amit Kapila wrote:
> >
> > On Mon, Apr 12, 2021 at 5:29 PM Masahiko Sawada
> > wrote:
> > >
> > > On Mon, Apr 12, 2021 at 8:08 PM Amit Kapila
> > > wrote:
> > > >
> > > > On Mon, Apr 12, 2021 at 4:34 PM
On Mon, Apr 12, 2021 at 9:36 PM Amit Kapila wrote:
>
> On Mon, Apr 12, 2021 at 5:29 PM Masahiko Sawada wrote:
> >
> > On Mon, Apr 12, 2021 at 8:08 PM Amit Kapila wrote:
> > >
> > > On Mon, Apr 12, 2021 at 4:34 PM Masahiko Sawada
> > > wrote:
> > > >
> > > > On Mon, Apr 12, 2021 at 6:19 PM Amit
On Mon, Apr 12, 2021 at 5:29 PM Masahiko Sawada wrote:
>
> On Mon, Apr 12, 2021 at 8:08 PM Amit Kapila wrote:
> >
> > On Mon, Apr 12, 2021 at 4:34 PM Masahiko Sawada
> > wrote:
> > >
> > > On Mon, Apr 12, 2021 at 6:19 PM Amit Kapila
> > > wrote:
> > > >
> > > > On Mon, Apr 12, 2021 at 10:27 A
On Mon, Apr 12, 2021 at 4:46 PM Amit Kapila wrote:
>
> On Sat, Apr 10, 2021 at 6:51 PM vignesh C wrote:
> >
>
> Thanks, 0001 and 0002 look good to me. I have a minor comment for 0002.
>
>
> +total_bytesbigint
> +
> +
> +Amount of decoded transactions data sent to th
On Mon, Apr 12, 2021 at 8:08 PM Amit Kapila wrote:
>
> On Mon, Apr 12, 2021 at 4:34 PM Masahiko Sawada wrote:
> >
> > On Mon, Apr 12, 2021 at 6:19 PM Amit Kapila wrote:
> > >
> > > On Mon, Apr 12, 2021 at 10:27 AM Masahiko Sawada
> > > wrote:
> > > >
> > > > On Sat, Apr 10, 2021 at 9:53 PM Ami
On Sat, Apr 10, 2021 at 6:51 PM vignesh C wrote:
>
Thanks, 0001 and 0002 look good to me. I have a minor comment for 0002.
+total_bytesbigint
+
+
+Amount of decoded transactions data sent to the decoding output plugin
+while decoding the changes from WAL fo
On Mon, Apr 12, 2021 at 4:34 PM Masahiko Sawada wrote:
>
> On Mon, Apr 12, 2021 at 6:19 PM Amit Kapila wrote:
> >
> > On Mon, Apr 12, 2021 at 10:27 AM Masahiko Sawada
> > wrote:
> > >
> > > On Sat, Apr 10, 2021 at 9:53 PM Amit Kapila
> > > wrote:
> > > >
> > > >
> > > > It seems Vignesh has c
On Mon, Apr 12, 2021 at 4:34 PM Masahiko Sawada wrote:
>
> On Mon, Apr 12, 2021 at 6:19 PM Amit Kapila wrote:
> >
> > On Mon, Apr 12, 2021 at 10:27 AM Masahiko Sawada
> > wrote:
> > >
> > > On Sat, Apr 10, 2021 at 9:53 PM Amit Kapila
> > > wrote:
> > > >
> > > >
> > > > It seems Vignesh has c
On Mon, Apr 12, 2021 at 6:19 PM Amit Kapila wrote:
>
> On Mon, Apr 12, 2021 at 10:27 AM Masahiko Sawada
> wrote:
> >
> > On Sat, Apr 10, 2021 at 9:53 PM Amit Kapila wrote:
> > >
> > >
> > > It seems Vignesh has changed patches based on the latest set of
> > > comments so you might want to rebas
On Sat, Mar 20, 2021 at 9:26 AM Amit Kapila wrote:
>
> On Sat, Mar 20, 2021 at 12:22 AM Andres Freund wrote:
> >
> > And then more generally about the feature:
> > - If a slot was used to stream out a large amount of changes (say an
> > initial data load), but then replication is interrupted be
On Mon, Apr 12, 2021 at 10:27 AM Masahiko Sawada wrote:
>
> On Sat, Apr 10, 2021 at 9:53 PM Amit Kapila wrote:
> >
> >
> > It seems Vignesh has changed patches based on the latest set of
> > comments so you might want to rebase.
>
> I've merged my patch into the v6 patch set Vignesh submitted.
>
On Sat, Apr 10, 2021 at 9:53 PM Amit Kapila wrote:
>
> On Sat, Apr 10, 2021 at 7:24 AM Masahiko Sawada wrote:
> >
> > IIUC there are two problems in the case where the drop message is lost:
> >
> > 1. Writing beyond the end of replSlotStats.
> > This can happen if after restarting the number of s
Thanks for the comments.
On Fri, Apr 9, 2021 at 4:13 PM Amit Kapila wrote:
>
> On Wed, Apr 7, 2021 at 2:51 PM vignesh C wrote:
> >
> > That is not required, I have modified it.
> > Attached v4 patch has the fixes for the same.
> >
>
> Few comments:
>
> 0001
> --
> 1. The first patch includes
On Sat, Apr 10, 2021 at 6:24 PM Amit Kapila wrote:
>
> On Sat, Apr 10, 2021 at 1:06 PM vignesh C wrote:
> >
> > Thanks Amit for your Patch. I have merged your changes into my
> > patchset. I did not find any issues in my testing.
> > Thoughts?
> >
>
> 0001
> --
> PgStat_Counter m_stream_byt
On Sat, Apr 10, 2021 at 1:06 PM vignesh C wrote:
>
> Thanks Amit for your Patch. I have merged your changes into my
> patchset. I did not find any issues in my testing.
> Thoughts?
>
0001
--
PgStat_Counter m_stream_bytes;
+ PgStat_Counter m_total_txns;
+ PgStat_Counter m_total_bytes;
} PgS
On Sat, Apr 10, 2021 at 7:24 AM Masahiko Sawada wrote:
>
> IIUC there are two problems in the case where the drop message is lost:
>
> 1. Writing beyond the end of replSlotStats.
> This can happen if after restarting the number of slots whose stats
> are stored in the stats file exceeds max_replic
On Sat, Apr 10, 2021 at 9:50 AM Amit Kapila wrote:
>
> On Fri, Apr 9, 2021 at 4:13 PM Amit Kapila wrote:
> >
> > 2.
> > @@ -2051,6 +2054,17 @@ ReorderBufferProcessTXN(ReorderBuffer *rb,
> > ReorderBufferTXN *txn,
> > rb->begin(rb, txn);
> > }
> >
> > + /*
> > + * Update total transaction coun
On Sat, Apr 10, 2021 at 9:50 AM Amit Kapila wrote:
>
> On Fri, Apr 9, 2021 at 4:13 PM Amit Kapila wrote:
> >
> > 2.
> > @@ -2051,6 +2054,17 @@ ReorderBufferProcessTXN(ReorderBuffer *rb,
> > ReorderBufferTXN *txn,
> > rb->begin(rb, txn);
> > }
> >
> > + /*
> > + * Update total transaction coun
On Fri, Apr 9, 2021 at 4:13 PM Amit Kapila wrote:
>
> 2.
> @@ -2051,6 +2054,17 @@ ReorderBufferProcessTXN(ReorderBuffer *rb,
> ReorderBufferTXN *txn,
> rb->begin(rb, txn);
> }
>
> + /*
> + * Update total transaction count and total transaction bytes, if
> + * transaction is streamed or spilled
On Thu, Apr 8, 2021 at 7:30 PM Amit Kapila wrote:
>
> On Wed, Apr 7, 2021 at 2:51 PM vignesh C wrote:
> >
>
> @@ -4069,6 +4069,24 @@ pgstat_read_statsfiles(Oid onlydb, bool
> permanent, bool deep)
> * slot follows.
> */
> case 'R':
> + /*
> + * There is a remote scenario where one of the re
On Wed, Apr 7, 2021 at 2:51 PM vignesh C wrote:
>
> That is not required, I have modified it.
> Attached v4 patch has the fixes for the same.
>
Few comments:
0001
--
1. The first patch includes changing char datatype to NameData
datatype for slotname. I feel this can be a separate patch from
On Thu, Apr 8, 2021 at 4:00 PM Amit Kapila wrote:
>
> On Wed, Apr 7, 2021 at 2:51 PM vignesh C wrote:
> >
>
> @@ -4069,6 +4069,24 @@ pgstat_read_statsfiles(Oid onlydb, bool
> permanent, bool deep)
> * slot follows.
> */
> case 'R':
> + /*
> + * There is a remote scenario where one of the re
On Wed, Apr 7, 2021 at 2:51 PM vignesh C wrote:
>
@@ -4069,6 +4069,24 @@ pgstat_read_statsfiles(Oid onlydb, bool
permanent, bool deep)
* slot follows.
*/
case 'R':
+ /*
+ * There is a remote scenario where one of the replication slots
+ * is dropped and the drop slot statistics message is n
On Tue, Apr 6, 2021 at 12:19 PM Amit Kapila wrote:
>
> On Mon, Apr 5, 2021 at 8:51 PM vignesh C wrote:
> >
>
> Few comments on the latest patches:
> Comments on 0001
>
> 1.
> @@ -659,6 +661,8 @@ ReorderBufferTXNByXid(ReorderBuffer *rb,
> TransactionId xid, bool cr
On Tue, Apr 6, 2021 at 12:19 PM Amit Kapila wrote:
>
> On Mon, Apr 5, 2021 at 8:51 PM vignesh C wrote:
> >
>
> Few comments on the latest patches:
> Comments on 0001
>
> 1.
> @@ -659,6 +661,8 @@ ReorderBufferTXNByXid(ReorderBuffer *rb,
> TransactionId xid, bool cr
On Mon, Apr 5, 2021 at 8:51 PM vignesh C wrote:
>
Few comments on the latest patches:
Comments on 0001
1.
@@ -659,6 +661,8 @@ ReorderBufferTXNByXid(ReorderBuffer *rb,
TransactionId xid, bool create,
dlist_push_tail(&rb->toplevel_by_lsn, &txn->node);
AssertTXNL
On Mon, Mar 22, 2021 at 9:55 AM Masahiko Sawada wrote:
>
> On Sat, Mar 20, 2021 at 3:52 AM Andres Freund wrote:
> >
> >
> > - PgStat_ReplSlotStats etc use slotname[NAMEDATALEN]. Why not just NameData?
>
> That's because we followed other definitions in pgstat.h that use
> char[NAMEDATALEN]. I'm o
On Sat, Apr 3, 2021 at 11:07 PM vignesh C wrote:
>
> On Fri, Apr 2, 2021 at 9:29 AM Masahiko Sawada wrote:
> >
> > On Fri, Apr 2, 2021 at 1:55 AM vignesh C wrote:
> > >
> > > On Thu, Apr 1, 2021 at 5:58 PM Amit Kapila
> > > wrote:
> > > >
> > > > On Thu, Apr 1, 2021 at 3:43 PM vignesh C wrote
On Mon, Apr 5, 2021 at 12:44 PM Bharath Rupireddy
wrote:
>
> On Sat, Apr 3, 2021 at 11:12 PM vignesh C wrote:
> > Here pg_stat_replication_slots will not have enought slots. I changed
> > it to below:
> > errmsg("skipping \"%s\" replication slot statistics as
> > pg_stat_replication_slots does no
On Sat, Apr 3, 2021 at 11:12 PM vignesh C wrote:
> Here pg_stat_replication_slots will not have enought slots. I changed
> it to below:
> errmsg("skipping \"%s\" replication slot statistics as
> pg_stat_replication_slots does not have enough slots"
> Thoughts?
WFM.
> > 3) Should we change the if
On Fri, Apr 2, 2021 at 11:28 AM Bharath Rupireddy
wrote:
>
> On Fri, Apr 2, 2021 at 9:57 AM vignesh C wrote:
> > Thanks for the comments, I will fix the comments and provide a patch
> > for this soon.
>
Thanks for the comments.
> Here are some comments:
> 1) How about something like below
> +
On Fri, Apr 2, 2021 at 9:29 AM Masahiko Sawada wrote:
>
> On Fri, Apr 2, 2021 at 1:55 AM vignesh C wrote:
> >
> > On Thu, Apr 1, 2021 at 5:58 PM Amit Kapila wrote:
> > >
> > > On Thu, Apr 1, 2021 at 3:43 PM vignesh C wrote:
> > > >
> > > > On Wed, Mar 31, 2021 at 11:32 AM vignesh C wrote:
> >
On Fri, Apr 2, 2021 at 9:57 AM vignesh C wrote:
> Thanks for the comments, I will fix the comments and provide a patch
> for this soon.
Here are some comments:
1) How about something like below
+(errmsg("skipping \"%s\" replication slot
statistics as the statistic coll
On Thu, Apr 1, 2021 at 6:19 PM Masahiko Sawada wrote:
>
> On Tue, Mar 30, 2021 at 9:58 AM Andres Freund wrote:
> >
> > IMO, independent of the shutdown / startup issue, it'd be worth writing
> > a patch tracking the bytes sent independently of the slot stats storage
> > issues. That would also ma
On Fri, Apr 2, 2021 at 9:29 AM Masahiko Sawada wrote:
>
> On Fri, Apr 2, 2021 at 1:55 AM vignesh C wrote:
> >
> > On Thu, Apr 1, 2021 at 5:58 PM Amit Kapila wrote:
> > >
> > > On Thu, Apr 1, 2021 at 3:43 PM vignesh C wrote:
> > > >
> > > > On Wed, Mar 31, 2021 at 11:32 AM vignesh C wrote:
> >
On Fri, Apr 2, 2021 at 1:55 AM vignesh C wrote:
>
> On Thu, Apr 1, 2021 at 5:58 PM Amit Kapila wrote:
> >
> > On Thu, Apr 1, 2021 at 3:43 PM vignesh C wrote:
> > >
> > > On Wed, Mar 31, 2021 at 11:32 AM vignesh C wrote:
> > > >
> > > > On Tue, Mar 30, 2021 at 11:00 AM Andres Freund
> > > > wr
On Thu, Apr 1, 2021 at 5:58 PM Amit Kapila wrote:
>
> On Thu, Apr 1, 2021 at 3:43 PM vignesh C wrote:
> >
> > On Wed, Mar 31, 2021 at 11:32 AM vignesh C wrote:
> > >
> > > On Tue, Mar 30, 2021 at 11:00 AM Andres Freund wrote:
> > > >
> > > > Hi,
> > > >
> > > > On 2021-03-30 10:13:29 +0530, vig
On Tue, Mar 30, 2021 at 9:58 AM Andres Freund wrote:
>
> IMO, independent of the shutdown / startup issue, it'd be worth writing
> a patch tracking the bytes sent independently of the slot stats storage
> issues. That would also make the testing for the above cheaper...
Agreed.
I think the bytes
On Thu, Apr 1, 2021 at 3:43 PM vignesh C wrote:
>
> On Wed, Mar 31, 2021 at 11:32 AM vignesh C wrote:
> >
> > On Tue, Mar 30, 2021 at 11:00 AM Andres Freund wrote:
> > >
> > > Hi,
> > >
> > > On 2021-03-30 10:13:29 +0530, vignesh C wrote:
> > > > On Tue, Mar 30, 2021 at 6:28 AM Andres Freund
>
On Wed, Mar 31, 2021 at 11:32 AM vignesh C wrote:
>
> On Tue, Mar 30, 2021 at 11:00 AM Andres Freund wrote:
> >
> > Hi,
> >
> > On 2021-03-30 10:13:29 +0530, vignesh C wrote:
> > > On Tue, Mar 30, 2021 at 6:28 AM Andres Freund wrote:
> > > > Any chance you could write a tap test exercising a few
On Tue, Mar 30, 2021 at 11:00 AM Andres Freund wrote:
>
> Hi,
>
> On 2021-03-30 10:13:29 +0530, vignesh C wrote:
> > On Tue, Mar 30, 2021 at 6:28 AM Andres Freund wrote:
> > > Any chance you could write a tap test exercising a few of these cases?
> >
> > I can try to write a patch for this if nob
Hi,
On 2021-03-30 10:13:29 +0530, vignesh C wrote:
> On Tue, Mar 30, 2021 at 6:28 AM Andres Freund wrote:
> > Any chance you could write a tap test exercising a few of these cases?
>
> I can try to write a patch for this if nobody objects.
Cool!
> > E.g. things like:
> >
> > - create a few slo
On Tue, Mar 30, 2021 at 6:28 AM Andres Freund wrote:
>
> Hi,
>
> On 2021-03-26 07:58:58 +0530, Amit Kapila wrote:
> > On Fri, Mar 26, 2021 at 1:17 AM Andres Freund wrote:
> > > I suggest we wait doing anything about this until we know if the shared
> > > stats patch gets in or not (I'd give it 50
Hi,
On 2021-03-26 07:58:58 +0530, Amit Kapila wrote:
> On Fri, Mar 26, 2021 at 1:17 AM Andres Freund wrote:
> > I suggest we wait doing anything about this until we know if the shared
> > stats patch gets in or not (I'd give it 50% maybe). If it does get in
> > things get a good bit easier, becau
On Fri, Mar 26, 2021 at 1:17 AM Andres Freund wrote:
>
> Hi,
>
> On 2021-03-25 17:12:31 +0530, Amit Kapila wrote:
> > On Thu, Mar 25, 2021 at 11:36 AM Masahiko Sawada
> > wrote:
> > >
> > > On Wed, Mar 24, 2021 at 7:06 PM Amit Kapila
> > > wrote:
> > > >
> > > >
> > > > Leaving aside restart c
Hi,
On 2021-03-25 17:12:31 +0530, Amit Kapila wrote:
> On Thu, Mar 25, 2021 at 11:36 AM Masahiko Sawada
> wrote:
> >
> > On Wed, Mar 24, 2021 at 7:06 PM Amit Kapila wrote:
> > >
> > >
> > > Leaving aside restart case, without some sort of such sanity checking,
> > > if both drop (of old slot) a
On Thu, Mar 25, 2021 at 11:36 AM Masahiko Sawada wrote:
>
> On Wed, Mar 24, 2021 at 7:06 PM Amit Kapila wrote:
> >
> >
> > Leaving aside restart case, without some sort of such sanity checking,
> > if both drop (of old slot) and create (of new slot) messages are lost
> > then we will start accumu
On Wed, Mar 24, 2021 at 7:06 PM Amit Kapila wrote:
>
> On Tue, Mar 23, 2021 at 10:54 PM Andres Freund wrote:
> >
> > On 2021-03-23 23:37:14 +0900, Masahiko Sawada wrote:
> >
> > > > > Maybe we can compare the slot name in the
> > > > > received message to the name in the element of replSlotStats.
On Tue, Mar 23, 2021 at 10:54 PM Andres Freund wrote:
>
> On 2021-03-23 23:37:14 +0900, Masahiko Sawada wrote:
>
> > > > Maybe we can compare the slot name in the
> > > > received message to the name in the element of replSlotStats. If they
> > > > don’t match, we swap entries in replSlotStats to
Hi,
On 2021-03-23 23:37:14 +0900, Masahiko Sawada wrote:
> On Tue, Mar 23, 2021 at 3:09 PM Amit Kapila wrote:
> >
> > On Mon, Mar 22, 2021 at 12:20 PM Masahiko Sawada
> > wrote:
> > >
> > > On Mon, Mar 22, 2021 at 1:25 PM Masahiko Sawada
> > > wrote:
> > > >
> > > > On Sat, Mar 20, 2021 at 3:
On Tue, Mar 23, 2021 at 3:09 PM Amit Kapila wrote:
>
> On Mon, Mar 22, 2021 at 12:20 PM Masahiko Sawada
> wrote:
> >
> > On Mon, Mar 22, 2021 at 1:25 PM Masahiko Sawada
> > wrote:
> > >
> > > On Sat, Mar 20, 2021 at 3:52 AM Andres Freund wrote:
> > > >
> > > > - If max_replication_slots was l
On Mon, Mar 22, 2021 at 12:20 PM Masahiko Sawada wrote:
>
> On Mon, Mar 22, 2021 at 1:25 PM Masahiko Sawada wrote:
> >
> > On Sat, Mar 20, 2021 at 3:52 AM Andres Freund wrote:
> > >
> > > - If max_replication_slots was lowered between a restart,
> > > pgstat_read_statfile() will happily write
On Mon, Mar 22, 2021 at 1:25 PM Masahiko Sawada wrote:
>
> On Sat, Mar 20, 2021 at 3:52 AM Andres Freund wrote:
> >
> > - If max_replication_slots was lowered between a restart,
> > pgstat_read_statfile() will happily write beyond the end of
> > replSlotStats.
>
> I think we cannot restart th
On Sat, Mar 20, 2021 at 3:52 AM Andres Freund wrote:
>
> - If max_replication_slots was lowered between a restart,
> pgstat_read_statfile() will happily write beyond the end of
> replSlotStats.
I think we cannot restart the server after lowering
max_replication_slots to a value less than the
On Mon, Mar 22, 2021 at 3:10 AM Andres Freund wrote:
>
> On 2021-03-21 16:08:00 +0530, Amit Kapila wrote:
> > On Sun, Mar 21, 2021 at 2:57 AM Andres Freund wrote:
> > > On 2021-03-20 10:28:06 +0530, Amit Kapila wrote:
> > > > On Sat, Mar 20, 2021 at 9:25 AM Amit Kapila
> > > > wrote:
> > > > >
Hi,
On 2021-03-21 16:08:00 +0530, Amit Kapila wrote:
> On Sun, Mar 21, 2021 at 2:57 AM Andres Freund wrote:
> > On 2021-03-20 10:28:06 +0530, Amit Kapila wrote:
> > > On Sat, Mar 20, 2021 at 9:25 AM Amit Kapila
> > > wrote:
> > > > This idea is worth exploring to address the complaints but what
On Sun, Mar 21, 2021 at 2:56 AM Andres Freund wrote:
>
> On 2021-03-20 09:25:40 +0530, Amit Kapila wrote:
> > On Sat, Mar 20, 2021 at 12:22 AM Andres Freund wrote:
> > >
> > > And then more generally about the feature:
> > > - If a slot was used to stream out a large amount of changes (say an
> >
On Sun, Mar 21, 2021 at 2:57 AM Andres Freund wrote:
>
> Hi,
>
> On 2021-03-20 10:28:06 +0530, Amit Kapila wrote:
> > On Sat, Mar 20, 2021 at 9:25 AM Amit Kapila wrote:
> > > This idea is worth exploring to address the complaints but what do we
> > > do when we detect that the stats are from the
Hi,
On 2021-03-20 10:28:06 +0530, Amit Kapila wrote:
> On Sat, Mar 20, 2021 at 9:25 AM Amit Kapila wrote:
> > This idea is worth exploring to address the complaints but what do we
> > do when we detect that the stats are from the different slot? It has
> > mixed of stats from the old and new slot
Hi,
On 2021-03-20 09:25:40 +0530, Amit Kapila wrote:
> On Sat, Mar 20, 2021 at 12:22 AM Andres Freund wrote:
> >
> > And then more generally about the feature:
> > - If a slot was used to stream out a large amount of changes (say an
> > initial data load), but then replication is interrupted be
On Sat, Mar 20, 2021 at 9:25 AM Amit Kapila wrote:
>
> On Sat, Mar 20, 2021 at 12:22 AM Andres Freund wrote:
> >
> > And then more generally about the feature:
> > - If a slot was used to stream out a large amount of changes (say an
> > initial data load), but then replication is interrupted be
On Sat, Mar 20, 2021 at 12:22 AM Andres Freund wrote:
>
> And then more generally about the feature:
> - If a slot was used to stream out a large amount of changes (say an
> initial data load), but then replication is interrupted before the
> transaction is committed/aborted, stream_bytes will
101 - 200 of 200 matches
Mail list logo
