On Tue, 02 Aug 2022 at 15:45, Daniel Gustafsson wrote:
>> On 2 Aug 2022, at 09:37, Richard Guo wrote:
>
>> The examples listed upthread all contain such comment in foo.h saying
>> 'prototypes for functions in foo.c'. For instance, in buffile.h, there is
>> comment saying
>
>> /*
>> *
> On 2 Aug 2022, at 09:37, Richard Guo wrote:
> The examples listed upthread all contain such comment in foo.h saying
> 'prototypes for functions in foo.c'. For instance, in buffile.h, there is
> comment saying
> /*
> * prototypes for functions in buffile.c
> */
>
> So if we remove such
On Tue, Aug 2, 2022 at 12:13 PM John Naylor
wrote:
>
> On Tue, Aug 2, 2022 at 10:06 AM Richard Guo
> wrote:
> >
> > I'm not sure that we should remove such comments. And a rough search
> > shows that there are much more places with this kind of comments, such
> > as below:
> >
> > nbtxlog
On Mon, Aug 1, 2022 at 9:16 PM Tom Lane wrote:
>
> John Naylor writes:
> > You are correct, but I wonder if it'd be better to just drop the comment
> > entirely. I checked a couple other random headers with function
> > declarations and they didn't have such a comment, and it's kind of
obvious
>
On Tue, 02 Aug 2022 at 11:06, Richard Guo wrote:
> On Mon, Aug 1, 2022 at 10:42 PM Japin Li wrote:
>
>>
>> On Mon, 01 Aug 2022 at 22:16, Tom Lane wrote:
>> > John Naylor writes:
>> >> You are correct, but I wonder if it'd be better to just drop the comment
>> >> entirely. I checked a couple
On Tue, Aug 2, 2022 at 10:06 AM Richard Guo wrote:
>
> I'm not sure that we should remove such comments. And a rough search
> shows that there are much more places with this kind of comments, such
> as below:
>
> nbtxlog transam readfuncs walreceiver buffile bufmgr fd latch pmsignal
> procsignal
On Mon, Aug 1, 2022 at 10:42 PM Japin Li wrote:
>
> On Mon, 01 Aug 2022 at 22:16, Tom Lane wrote:
> > John Naylor writes:
> >> You are correct, but I wonder if it'd be better to just drop the comment
> >> entirely. I checked a couple other random headers with function
> >> declarations and
On Mon, 01 Aug 2022 at 22:16, Tom Lane wrote:
> John Naylor writes:
>> You are correct, but I wonder if it'd be better to just drop the comment
>> entirely. I checked a couple other random headers with function
>> declarations and they didn't have such a comment, and it's kind of obvious
>>
On Mon, 01 Aug 2022 at 20:46, John Naylor wrote:
> On Mon, Aug 1, 2022 at 4:18 PM Japin Li wrote:
>>
>>
>> Hi, hackers
>>
>> I think there is a typo in pg_db_role_setting.h, should we fix it?
>>
>> diff --git a/src/include/catalog/pg_db_role_setting.h
>
John Naylor writes:
> You are correct, but I wonder if it'd be better to just drop the comment
> entirely. I checked a couple other random headers with function
> declarations and they didn't have such a comment, and it's kind of obvious
> what they're for.
Some places have these, some don't.
On Mon, Aug 1, 2022 at 4:18 PM Japin Li wrote:
>
>
> Hi, hackers
>
> I think there is a typo in pg_db_role_setting.h, should we fix it?
>
> diff --git a/src/include/catalog/pg_db_role_setting.h
b/src/include/catalog/pg_db_role_setting.h
> index 45d478e9e7..f92e867df4 100644
> /*
> - * prototypes
On Mon, Aug 1, 2022 at 5:18 PM Japin Li wrote:
> I think there is a typo in pg_db_role_setting.h, should we fix it?
Definitely this is wrong. +1 for the fix.
Thanks
Richard
12 matches
Mail list logo
