Amit Kapila writes:
> It seems you would also like to see this back-patched. I am not sure
> if that is a good idea as there is some risk of breaking existing
> usage. Tom, do you have any opinion on this patch? It seems to me
> you were thinking to have a separate hook for partial paths, but
On Wed, Feb 6, 2019 at 10:35 AM Kohei KaiGai wrote:
>
> Hello,
> Let me remind the thread again.
> I'm waiting for the fix getting committed for a month...
>
It seems you would also like to see this back-patched. I am not sure
if that is a good idea as there is some risk of breaking existing
Hello,
Let me remind the thread again.
I'm waiting for the fix getting committed for a month...
2019年1月22日(火) 20:50 Kohei KaiGai :
>
> Let me remind the thread.
> If no more comments, objections, or better ideas, please commit this fix.
>
> Thanks,
>
> 2019年1月17日(木) 18:29 Kyotaro HORIGUCHI :
> >
Let me remind the thread.
If no more comments, objections, or better ideas, please commit this fix.
Thanks,
2019年1月17日(木) 18:29 Kyotaro HORIGUCHI :
>
> Hello, sorry for the absence.
>
> At Fri, 11 Jan 2019 11:36:43 -0500, Robert Haas wrote
> in
> > On Thu, Jan 10, 2019 at 9:10 PM Kohei KaiGai
Hello, sorry for the absence.
At Fri, 11 Jan 2019 11:36:43 -0500, Robert Haas wrote
in
> On Thu, Jan 10, 2019 at 9:10 PM Kohei KaiGai wrote:
> > 2019年1月11日(金) 5:52 Robert Haas :
> > > On Wed, Jan 9, 2019 at 12:44 AM Kohei KaiGai wrote:
> > > > So, is it sufficient if set_rel_pathlist_hook is
On Thu, Jan 10, 2019 at 9:10 PM Kohei KaiGai wrote:
> 2019年1月11日(金) 5:52 Robert Haas :
> > On Wed, Jan 9, 2019 at 12:44 AM Kohei KaiGai wrote:
> > > So, is it sufficient if set_rel_pathlist_hook is just relocated in
> > > front of the generate_gather_paths?
> > > If we have no use case for the
2019年1月11日(金) 5:52 Robert Haas :
>
> On Wed, Jan 9, 2019 at 12:44 AM Kohei KaiGai wrote:
> > So, is it sufficient if set_rel_pathlist_hook is just relocated in
> > front of the generate_gather_paths?
> > If we have no use case for the second hook, here is little necessity
> > to have the
On Wed, Jan 9, 2019 at 12:44 AM Kohei KaiGai wrote:
> So, is it sufficient if set_rel_pathlist_hook is just relocated in
> front of the generate_gather_paths?
> If we have no use case for the second hook, here is little necessity
> to have the post_rel_pathlist_hook() here.
> (At least, PG-Strom
2019年1月9日(水) 13:18 Kyotaro HORIGUCHI :
>
> At Sun, 30 Dec 2018 12:31:22 +0900, Kohei KaiGai wrote
> in
> > 2018年12月30日(日) 4:12 Tom Lane :
> > On the other hands, the later hook must be dedicated to add regular paths,
> > and also provides a chance for extensions to manipulate pre-built
At Sun, 30 Dec 2018 12:31:22 +0900, Kohei KaiGai wrote in
> 2018年12月30日(日) 4:12 Tom Lane :
> On the other hands, the later hook must be dedicated to add regular paths,
> and also provides a chance for extensions to manipulate pre-built path-list
> including Gather-path.
> As long as I know,
I tried to make a patch to have dual hooks at set_rel_pathlist(), and
adjusted PG-Strom for the new design. It stopped to create GatherPath
by itself, just added a partial path for the base relation.
It successfully made a plan using parallel custom-scan node, without
system crash.
As I mentioned
2018年12月31日(月) 22:25 Amit Kapila :
>
> On Mon, Dec 31, 2018 at 5:48 PM Kohei KaiGai wrote:
> >
> > 2018年12月31日(月) 13:10 Amit Kapila :
> > >
> > > On Sun, Dec 30, 2018 at 9:01 AM Kohei KaiGai wrote:
> > > > 2018年12月30日(日) 4:12 Tom Lane :
> > > > >
> > > > > Kohei KaiGai writes:
> > > > > >
On Mon, Dec 31, 2018 at 5:48 PM Kohei KaiGai wrote:
>
> 2018年12月31日(月) 13:10 Amit Kapila :
> >
> > On Sun, Dec 30, 2018 at 9:01 AM Kohei KaiGai wrote:
> > > 2018年12月30日(日) 4:12 Tom Lane :
> > > >
> > > > Kohei KaiGai writes:
> > > > > 2018年12月29日(土) 1:44 Tom Lane :
> > > > >> However, first I'd
On Sun, Dec 30, 2018 at 9:01 AM Kohei KaiGai wrote:
> 2018年12月30日(日) 4:12 Tom Lane :
> >
> > Kohei KaiGai writes:
> > > 2018年12月29日(土) 1:44 Tom Lane :
> > >> However, first I'd like to know why this situation is arising in the
> > >> first
> > >> place. To have the situation you're describing,
2018年12月30日(日) 4:12 Tom Lane :
>
> Kohei KaiGai writes:
> > 2018年12月29日(土) 1:44 Tom Lane :
> >> However, first I'd like to know why this situation is arising in the first
> >> place. To have the situation you're describing, we'd have to have
> >> attempted to make some Gather paths before we
2018年12月29日(土) 1:44 Tom Lane :
>
> Kohei KaiGai writes:
> > I've investigated a crash report of PG-Strom for a few days, then I doubt
> > add_partial_path() can unexpectedly release dominated old partial path
> > but still referenced by other Gather node, and it leads unexpected system
> > crash.
Kohei KaiGai writes:
> I've investigated a crash report of PG-Strom for a few days, then I doubt
> add_partial_path() can unexpectedly release dominated old partial path
> but still referenced by other Gather node, and it leads unexpected system
> crash.
Hm. This seems comparable to the special
17 matches
Mail list logo
