On Tue, Apr 14, 2020 at 2:54 AM Justin Pryzby wrote:
>
> Looks good. One more change:
>
> [-Even if-]{+If+} this option is specified with the ANALYZE
> [-option-]{+option,+}
>
> Remove "even" and add comma.
>
Pushed after making this change.
--
With Regards,
Amit Kapila.
EnterpriseDB:
On Mon, Apr 13, 2020 at 03:22:06PM +0530, Amit Kapila wrote:
> On Mon, Apr 13, 2020 at 2:00 PM Justin Pryzby wrote:
> >
> > |Copy the index
> > |bulk-deletion result returned from ambulkdelete and amvacuumcleanup to
> > |the DSM segment if it's the first time [???] because they allocate locally
>
On Mon, Apr 13, 2020 at 2:00 PM Justin Pryzby wrote:
>
> |Copy the index
> |bulk-deletion result returned from ambulkdelete and amvacuumcleanup to
> |the DSM segment if it's the first time [???] because they allocate locally
> |and it's possible that an index will be vacuumed by a different
>
On Mon, Apr 13, 2020 at 10:44:42AM +0530, Amit Kapila wrote:
> On Fri, Apr 10, 2020 at 7:16 PM Justin Pryzby wrote:
> >
> > Also, this part still doesn't read well:
> >
> > -* amvacuumcleanup to the DSM segment if it's the first time to get
> > it?
> > -* from them? because they?
On Fri, Apr 10, 2020 at 7:16 PM Justin Pryzby wrote:
>
> Also, this part still doesn't read well:
>
> -* amvacuumcleanup to the DSM segment if it's the first time to get
> it?
> -* from them? because they? allocate it locally and it's possible
> that an
> -* index will
On Fri, Apr 10, 2020 at 12:56:08PM +0530, Amit Kapila wrote:
> On Wed, Apr 8, 2020 at 12:49 PM Masahiko Sawada
> wrote:
> >
> > On Tue, 7 Apr 2020 at 13:55, Justin Pryzby wrote:
> > >
> >
> > I don't have comments on your change other than the comments Amit
> > already sent. Thank you for
On Fri, 10 Apr 2020 at 16:26, Amit Kapila wrote:
>
> On Wed, Apr 8, 2020 at 12:49 PM Masahiko Sawada
> wrote:
> >
> > On Tue, 7 Apr 2020 at 13:55, Justin Pryzby wrote:
> > >
> >
> > I don't have comments on your change other than the comments Amit
> > already sent. Thank you for reviewing this
On Wed, Apr 8, 2020 at 12:49 PM Masahiko Sawada
wrote:
>
> On Tue, 7 Apr 2020 at 13:55, Justin Pryzby wrote:
> >
>
> I don't have comments on your change other than the comments Amit
> already sent. Thank you for reviewing this part!
>
I have made the modifications as per my comments. What do
On Tue, 7 Apr 2020 at 13:55, Justin Pryzby wrote:
>
> On Tue, Apr 07, 2020 at 09:57:46AM +0530, Amit Kapila wrote:
> > On Mon, Mar 23, 2020 at 10:34 AM Amit Kapila
> > wrote:
> > > On Sun, Mar 22, 2020 at 7:48 AM Justin Pryzby
> > > wrote:
> > > >
> > > > Original, long thread
> > > >
On Tue, Apr 7, 2020 at 10:25 AM Justin Pryzby wrote:
>
> On Tue, Apr 07, 2020 at 09:57:46AM +0530, Amit Kapila wrote:
> > On Mon, Mar 23, 2020 at 10:34 AM Amit Kapila
> > wrote:
> > > On Sun, Mar 22, 2020 at 7:48 AM Justin Pryzby
> > > wrote:
> > > >
> > > > Original, long thread
> > > >
On Tue, Apr 07, 2020 at 09:57:46AM +0530, Amit Kapila wrote:
> On Mon, Mar 23, 2020 at 10:34 AM Amit Kapila wrote:
> > On Sun, Mar 22, 2020 at 7:48 AM Justin Pryzby wrote:
> > >
> > > Original, long thread
> > >
On Mon, Mar 23, 2020 at 10:34 AM Amit Kapila wrote:
>
> On Sun, Mar 22, 2020 at 7:48 AM Justin Pryzby wrote:
> >
> > Original, long thread
> > https://www.postgresql.org/message-id/flat/CAA4eK1%2Bnw1FBK3_sDnW%2B7kB%2Bx4qbDJqetgqwYW8k2xv82RZ%2BKw%40mail.gmail.com#b1745ee853b137043e584b500b41300f
On Sun, Mar 22, 2020 at 7:48 AM Justin Pryzby wrote:
>
> Original, long thread
> https://www.postgresql.org/message-id/flat/CAA4eK1%2Bnw1FBK3_sDnW%2B7kB%2Bx4qbDJqetgqwYW8k2xv82RZ%2BKw%40mail.gmail.com#b1745ee853b137043e584b500b41300f
>
I have comments/questions on the patches:
doc changes
13 matches
Mail list logo
