Daniel Gustafsson writes:
> On 28 Apr 2021, at 22:47, Tom Lane wrote:
>> This wording is copied-and-pasted from the other similar tests. I agree
>> that it's advocating a solution that might be overkill, but if we change
>> it we should also change the existing messages.
> Good point.
>> I d
> On 28 Apr 2021, at 22:47, Tom Lane wrote:
>
> Daniel Gustafsson writes:
>>> On 28 Apr 2021, at 17:09, Tom Lane wrote:
>>> + pg_fatal("Your installation contains system-defined composite
>>> type(s) in user tables.\n"
>>> +"These type OIDs are not stable
Daniel Gustafsson writes:
>> On 28 Apr 2021, at 17:09, Tom Lane wrote:
>> +pg_fatal("Your installation contains system-defined composite
>> type(s) in user tables.\n"
>> + "These type OIDs are not stable across
>> PostgreSQL versions,\n"
>> +
> On 28 Apr 2021, at 17:09, Tom Lane wrote:
>
> [ blast-from-the-past department ]
>
> I wrote:
>> Daniel Gustafsson writes:
>>> I can see the appeal of
>>> including it before the wrap, even though I personally would've held off.
>
>> Nah, I'm not gonna risk it at this stage. I concur with y
[ blast-from-the-past department ]
I wrote:
> Daniel Gustafsson writes:
>> I can see the appeal of
>> including it before the wrap, even though I personally would've held off.
> Nah, I'm not gonna risk it at this stage. I concur with your point
> that this is an ancient bug, and one that is unl
Daniel Gustafsson writes:
> Applies, builds clean and passes light testing.
Thanks for checking!
> I can see the appeal of
> including it before the wrap, even though I personally would've held off.
Nah, I'm not gonna risk it at this stage. I concur with your point
that this is an ancient bug,
> On 10 Nov 2019, at 22:12, Tom Lane wrote:
>
> Daniel Gustafsson writes:
>> On 10 Nov 2019, at 20:07, Tom Lane wrote:
>>> (Note: this patch is shown with --ignore-space-change
>>> to make it more reviewable, but I did re-pgindent the code.) Then
>>> 0002 actually adds the array and range case
> On 10 Nov 2019, at 22:05, Tom Lane wrote:
> Daniel Gustafsson writes:
>>> + /* arrays over any type selected so far */
>>> + " SELECT
>>> t.oid FROM pg_catalog.pg_type t, x WHERE typelem = x.oid AND typtype = 'b' "
>
>
Daniel Gustafsson writes:
> On 10 Nov 2019, at 20:07, Tom Lane wrote:
>> (Note: this patch is shown with --ignore-space-change
>> to make it more reviewable, but I did re-pgindent the code.) Then
>> 0002 actually adds the array and range cases.
> Was the source pgindented, but not committed, be
Daniel Gustafsson writes:
> On 10 Nov 2019, at 20:07, Tom Lane wrote:
>> Although this is a really straightforward patch and I've tested it
>> against appropriate old versions (9.1 and 9.2), I'm very hesitant
>> to shove it in so soon before a release wrap. Should I do that, or
>> let it wait ti
> On 10 Nov 2019, at 20:07, Tom Lane wrote:
> 0001 refactors the code in question
> so that we have only one copy not three-and-growing. The only
> difference between the three copies was that one case didn't bother
> to search indexes, but I judged that that wasn't an optimization we
> need to
11 matches
Mail list logo
