Re: remove unnecessary include in src/backend/commands/policy.c

2025-10-21 Thread Shinya Kato
On Tue, Oct 21, 2025 at 1:01 PM jian he wrote: > > Thank you, I agree with Álvaro. So, I think it is better to leave them > > as they are, except for access/relation.h. And, replacing > > relation_open to table_open looks good to me. > > > > ok. > > The attached patch only replaces relation_open t

Re: remove unnecessary include in src/backend/commands/policy.c

2025-10-20 Thread jian he
On Wed, Oct 15, 2025 at 1:44 PM Shinya Kato wrote: > > On Sun, Oct 12, 2025 at 5:31 PM Álvaro Herrera wrote: > > > > On 2025-Sep-30, Shinya Kato wrote: > > > > > However, the changes make policy.c rely on transitive includes. For > > > example, policy.c uses GETSTRUCT(), which is defined in > > >

Re: remove unnecessary include in src/backend/commands/policy.c

2025-10-18 Thread Shinya Kato
Hi, On Sun, Sep 14, 2025 at 3:38 PM jian he wrote: > > hi. > > in src/backend/commands/policy.c, i found that > #include "access/htup.h" > #include "access/htup_details.h" > #include "catalog/catalog.h" > #include "nodes/pg_list.h" > #include "parser/parse_node.h" > #include "utils/array.h" > > i

Re: remove unnecessary include in src/backend/commands/policy.c

2025-10-18 Thread Shinya Kato
On Sun, Oct 12, 2025 at 5:31 PM Álvaro Herrera wrote: > > On 2025-Sep-30, Shinya Kato wrote: > > > However, the changes make policy.c rely on transitive includes. For > > example, policy.c uses GETSTRUCT(), which is defined in > > access/htup_details.h. Instead of being included directly, that hea

Re: remove unnecessary include in src/backend/commands/policy.c

2025-10-18 Thread Álvaro Herrera
On 2025-Sep-30, Shinya Kato wrote: > However, the changes make policy.c rely on transitive includes. For > example, policy.c uses GETSTRUCT(), which is defined in > access/htup_details.h. Instead of being included directly, that header > is currently pulled in via a fairly long chain: > catalog/in

Re: remove unnecessary include in src/backend/commands/policy.c

2025-09-14 Thread Chao Li
> On Sep 14, 2025, at 14:37, jian he wrote: > > hi. > > in src/backend/commands/policy.c, i found that > #include "access/htup.h" > #include "access/htup_details.h" > #include "catalog/catalog.h" > #include "nodes/pg_list.h" > #include "parser/parse_node.h" > #include "utils/array.h" > > is n