On Thu, Apr 07, 2022 at 06:29:53PM -0400, Tom Lane wrote:
> Chapman Flack writes:
> > v4 looks good to me.
>
> Pushed with very minor editorialization. Mainly, I undid the
> decision to stop printing the function source text, on the
> grounds that (1) it falsified the comment immediately above,
Chapman Flack writes:
> v4 looks good to me.
Pushed with very minor editorialization. Mainly, I undid the
decision to stop printing the function source text, on the
grounds that (1) it falsified the comment immediately above,
and (2) if you have to print it anyway to avoid compiler warnings,
you
The following review has been posted through the commitfest application:
make installcheck-world: tested, passed
Implements feature: tested, passed
Spec compliant: not tested
Documentation:not tested
v4 looks good to me.
I don't think this requires any documentation c
On Thu, Apr 07, 2022 at 10:30:13AM -0400, c...@anastigmatix.net wrote:
> On 2022-04-06 16:44, Mark Wong wrote:
> > I think I've applied all of these suggestions and attached a new patch.
>
> That looks good to me, though I wonder about the pfree(source).
> In the simplest case of a PL that uses no
On 2022-04-06 16:44, Mark Wong wrote:
I think I've applied all of these suggestions and attached a new patch.
That looks good to me, though I wonder about the pfree(source).
In the simplest case of a PL that uses no advance compilation or
augmentation step, the Code Execution block might natura
On Wed, Apr 6, 2022 at 5:44 PM Mark Wong wrote:
>
> On Thu, Mar 10, 2022 at 06:36:44PM -0500, Chapman Flack wrote:
> > On 03/02/22 15:12, Mark Wong wrote:
> >
> > > I've attached v2, which reduces the output:
> > >
> > > * Removing the notices for the text body, and the "compile" message.
> > > *
On Thu, Mar 10, 2022 at 06:36:44PM -0500, Chapman Flack wrote:
> On 03/02/22 15:12, Mark Wong wrote:
>
> > I've attached v2, which reduces the output:
> >
> > * Removing the notices for the text body, and the "compile" message.
> > * Replaced the notice for "compile" message with a comment as a
>
On 03/02/22 15:12, Mark Wong wrote:
> I've attached v2, which reduces the output:
>
> * Removing the notices for the text body, and the "compile" message.
> * Replaced the notice for "compile" message with a comment as a
> placeholder for where a compiling code or checking a cache may go.
> * R
On Fri, Feb 25, 2022 at 06:39:39PM +, Chapman Flack wrote:
> This patch is straightforward, does what it says, and passes the tests.
>
> Regarding the duplication of code between plsample_func_handler and
> plsample_trigger_handler, perhaps that's for the best for now, as 3554 in
> the same co
The following review has been posted through the commitfest application:
make installcheck-world: tested, passed
Implements feature: tested, passed
Spec compliant: not tested
Documentation:not tested
This patch is straightforward, does what it says, and passes the test
10 matches
Mail list logo
