Re: Replace (stat())[7] in TAP tests with -s

2023-10-02 Thread Michael Paquier
On Mon, Oct 02, 2023 at 12:44:59PM +0100, Dagfinn Ilmari Mannsåker wrote: > I approve of removing use of the list form of stat, it's a horrible API. Agreed, I've appied the suggestion to use -s, like we do anywhere else. > If we weren't already using -s everywhere else, I would prefer >

Re: Replace (stat())[7] in TAP tests with -s

2023-10-02 Thread Dagfinn Ilmari Mannsåker
"Drouvot, Bertrand" writes: > Hi hackers, > > Please find attached a tiny patch to $SUBJECT. > > It: > > - provides more consistency to the way we get files size in TAP tests > - seems more elegant that relying on a hardcoded result position I approve of removing use of the list form of stat,

Replace (stat())[7] in TAP tests with -s

2023-10-02 Thread Drouvot, Bertrand
Hi hackers, Please find attached a tiny patch to $SUBJECT. It: - provides more consistency to the way we get files size in TAP tests - seems more elegant that relying on a hardcoded result position Regards, -- Bertrand Drouvot PostgreSQL Contributors Team RDS Open Source Databases Amazon