Re: SI-read predicate locks on materialized views

2022-11-30 Thread Yugo NAGATA
On Thu, 1 Dec 2022 15:48:21 +0900 Michael Paquier wrote: > On Tue, Oct 18, 2022 at 05:29:58PM +0900, Yugo NAGATA wrote: > > Thank you for your review. I agree that an isolation test is required. > > The attached patch contains the test using the scenario as explained in > > the previous post. >

Re: SI-read predicate locks on materialized views

2022-11-30 Thread Michael Paquier
On Tue, Oct 18, 2022 at 05:29:58PM +0900, Yugo NAGATA wrote: > Thank you for your review. I agree that an isolation test is required. > The attached patch contains the test using the scenario as explained in > the previous post. Cool, thanks. Sorry for my late reply here. I have put my head on t

Re: SI-read predicate locks on materialized views

2022-10-18 Thread Yugo NAGATA
Hello Micheal-san, On Thu, 13 Oct 2022 17:02:06 +0900 Michael Paquier wrote: > On Fri, Sep 30, 2022 at 10:12:13AM +0900, Yugo NAGATA wrote: > > Thank you for comment. Do you think it can be marked as Ready for Commiter? > > Matviews have been discarded from needing predicate locks since > 3bf3a

Re: SI-read predicate locks on materialized views

2022-10-13 Thread Michael Paquier
On Fri, Sep 30, 2022 at 10:12:13AM +0900, Yugo NAGATA wrote: > Thank you for comment. Do you think it can be marked as Ready for Commiter? Matviews have been discarded from needing predicate locks since 3bf3ab8 and their introduction, where there was no concurrent flavor of refresh yet. Shouldn't

Re: SI-read predicate locks on materialized views

2022-09-29 Thread Yugo NAGATA
On Fri, 9 Sep 2022 16:27:45 +0530 Dilip Kumar wrote: > On Tue, Jul 26, 2022 at 3:31 PM Richard Guo wrote: > > > > > > On Tue, Jul 26, 2022 at 3:44 PM Yugo NAGATA wrote: > >> > >> If such two transactions run concurrently, a write skew anomaly occurs, > >> and the result of order_summary refresh

Re: SI-read predicate locks on materialized views

2022-09-09 Thread Dilip Kumar
On Tue, Jul 26, 2022 at 3:31 PM Richard Guo wrote: > > > On Tue, Jul 26, 2022 at 3:44 PM Yugo NAGATA wrote: >> >> If such two transactions run concurrently, a write skew anomaly occurs, >> and the result of order_summary refreshed in T1 will not contain the >> record inserted in T2. Yes we do ha

Re: SI-read predicate locks on materialized views

2022-07-26 Thread Richard Guo
On Tue, Jul 26, 2022 at 3:44 PM Yugo NAGATA wrote: > If such two transactions run concurrently, a write skew anomaly occurs, > and the result of order_summary refreshed in T1 will not contain the > record inserted in T2. Indeed we have write skew anomaly here between the two transactions. > O

SI-read predicate locks on materialized views

2022-07-26 Thread Yugo NAGATA
Hi, I propose to acquire SI-read predicate locks on materialized views as the attached patch. Currently, materialized views do not participate in predicate locking, but I think this causes a serialization anomaly when `REFRESH MATERIALIZED VIEW CONCURRENTLY` is used. For example, supporse that