Hello Tom,
On 2020-11-18 16:49, Tom Lane wrote:
Tels writes:
On 2020-11-18 06:06, Michael Paquier wrote:
On Mon, Nov 16, 2020 at 10:14:10PM -0500, Tom Lane wrote:
Agreed, I'm not trying to block this patch. Just wishing
there were a better way.
To me the code looks like a prime
Tels writes:
> On 2020-11-18 06:06, Michael Paquier wrote:
>> On Mon, Nov 16, 2020 at 10:14:10PM -0500, Tom Lane wrote:
>>> Agreed, I'm not trying to block this patch. Just wishing
>>> there were a better way.
> To me the code looks like a prime candidate for "data-driven"
> refactoring.
> It
On 2020-11-18 06:06, Michael Paquier wrote:
On Mon, Nov 16, 2020 at 10:14:10PM -0500, Tom Lane wrote:
Michael Paquier writes:
I don't think that this is a requirement for this thread, though.
Agreed, I'm not trying to block this patch. Just wishing
there were a better way.
Okay. I have
day, November 18, 2020 2:07 PM
To: Tom Lane
Cc: Shinoda, Noriyoshi (PN Japan FSI) ;
pgsql-hackers@lists.postgresql.org
Subject: Re: Tab complete for CREATE OR REPLACE TRIGGER statement
On Mon, Nov 16, 2020 at 10:14:10PM -0500, Tom Lane wrote:
> Michael Paquier writes:
>> I
On Mon, Nov 16, 2020 at 10:14:10PM -0500, Tom Lane wrote:
> Michael Paquier writes:
>> I don't think that this is a requirement for this thread, though.
>
> Agreed, I'm not trying to block this patch. Just wishing
> there were a better way.
Okay. I have tweaked a couple of things in the patch
Michael Paquier writes:
> I don't think that this is a requirement for this thread, though.
Agreed, I'm not trying to block this patch. Just wishing
there were a better way.
regards, tom lane
On Mon, Nov 16, 2020 at 09:14:51PM -0500, Tom Lane wrote:
> It's kind of depressing how repetitive the patch is. There's
> probably not much to be done about that in the short run, but
> it seems to point up the need to start thinking about how to
> refactor tab-complete.c more thoroughly.
Michael Paquier writes:
> On Mon, Nov 16, 2020 at 08:12:05AM +, Shinoda, Noriyoshi (PN Japan FSI)
> wrote:
>> Yesterday, OR REPLACE clause was provided to the CREATE TRIGGER
>> statement, so I wrote a patch for tab completion for the psql
>> command.
> Thanks, the logic looks fine. I'll
On Mon, Nov 16, 2020 at 08:12:05AM +, Shinoda, Noriyoshi (PN Japan FSI)
wrote:
> Yesterday, OR REPLACE clause was provided to the CREATE TRIGGER
> statement, so I wrote a patch for tab completion for the psql
> command.
Thanks, the logic looks fine. I'll apply if there are no objections.
Hi, Hackers.
Yesterday, OR REPLACE clause was provided to the CREATE TRIGGER statement, so
I wrote a patch for tab completion for the psql command.
TRIGGER adds tab completion to the CREATE OR REPLACE statement, and the CREATE
TRIGGER and CREATE OR REPLACE TRIGGER statements are completed in
10 matches
Mail list logo
