Re: Typo in comment for pgstat_database_flush_cb()

On Mon, Apr 7, 2025 at 6:50 PM Etsuro Fujita wrote: > On Sun, Apr 6, 2025 at 11:44 PM Michael Paquier wrote: > > Could you also backpatch that down to v15? It > > would be good to keep this level of comment documentation consistent > > across all branches. > > Sure, I will do that as well. Push

Re: Typo in comment for pgstat_database_flush_cb()

On Sun, Apr 6, 2025 at 11:44 PM Michael Paquier wrote: > On Sun, Apr 06, 2025 at 01:31:50PM +0200, Etsuro Fujita wrote: > > +1 for both suggestions. So I modified the comment as such in each > > file with such a flush_cb function. I will push the patch. > > Thanks for the fix. Could you also ba

Re: Typo in comment for pgstat_database_flush_cb()

On Sun, Apr 06, 2025 at 01:31:50PM +0200, Etsuro Fujita wrote: > +1 for both suggestions. So I modified the comment as such in each > file with such a flush_cb function. I will push the patch. Thanks for the fix. Could you also backpatch that down to v15? It would be good to keep this level of

Re: Typo in comment for pgstat_database_flush_cb()

On Sun, Mar 30, 2025 at 7:54 PM Gurjeet Singh wrote: > On Sun Mar 30, 2025 at 4:39 AM PDT, Heikki Linnakangas wrote: > > On 30/03/2025 14:32, Heikki Linnakangas wrote: > >> On 30/03/2025 13:28, Etsuro Fujita wrote: > >>> Another thing I noticed is $SUBJECT: I think “if lock could not > >>> immedia

Re: Typo in comment for pgstat_database_flush_cb()

On Sun Mar 30, 2025 at 4:39 AM PDT, Heikki Linnakangas wrote: > On 30/03/2025 14:32, Heikki Linnakangas wrote: >> On 30/03/2025 13:28, Etsuro Fujita wrote: >>> Another thing I noticed is $SUBJECT: I think “if lock could not >>> immediately acquired” should be “if lock could not be immediately >>> a

Re: Typo in comment for pgstat_database_flush_cb()

On 30/03/2025 13:28, Etsuro Fujita wrote: Another thing I noticed is $SUBJECT: I think “if lock could not immediately acquired” should be “if lock could not be immediately acquired”. Attached is a patch for that. Yep. And there are more instances of the same typo in other such flush_cb functi

Re: Typo in comment for pgstat_database_flush_cb()

On 30/03/2025 14:32, Heikki Linnakangas wrote: On 30/03/2025 13:28, Etsuro Fujita wrote: Another thing I noticed is $SUBJECT: I think “if lock could not immediately acquired” should be “if lock could not be immediately acquired”.  Attached is a patch for that. Yep. And there are more instances

Re: Typo in comment for pgstat_database_flush_cb()

Etsuro Fujita 于2025年3月30日周日 18:28写道： > Another thing I noticed is $SUBJECT: I think “if lock could not > immediately acquired” should be “if lock could not be immediately > acquired”. Attached is a patch for that. > Agree. The patch looks good to me. -- Thanks, Tender Wang

Typo in comment for pgstat_database_flush_cb()

Another thing I noticed is $SUBJECT: I think “if lock could not immediately acquired” should be “if lock could not be immediately acquired”. Attached is a patch for that. Best regards, Etsuro Fujita fix-typo-in-comment.patch Description: Binary data

Re: Fix typo in comment of compute_return_type()

On Wed, Dec 25, 2024 at 05:44:17PM +0800, Japin Li wrote: > When I reading the implementation of CreateFunction(), I found there is a typo > in comment of compute_return_type(). Good catch. Will fix! -- Michael signature.asc Description: PGP signature

Fix typo in comment of compute_return_type()

Hi, hackers When I reading the implementation of CreateFunction(), I found there is a typo in comment of compute_return_type(). -- Regrads, Japin Li >From 3a1008c692a919d55a456a7fa34e07d9c93879dd Mon Sep 17 00:00:00 2001 From: Li Jianping Date: Wed, 25 Dec 2024 14:39:15 +0800 Subject: [PA

Re: Typo in comment of auto_explain.c

On 27.11.2024 15:54, Heikki Linnakangas wrote: On 27/11/2024 14:46, Ilia Evdokimov wrote: Hi everyone, I found typo in comment auto_explain.c line 282 (/* Enable per-node instrumentation iff log_analyze is required. */). Not 'iff' but 'if'. It's short for &qu

Re: Typo in comment of auto_explain.c

On 27/11/2024 14:46, Ilia Evdokimov wrote: Hi everyone, I found typo in comment auto_explain.c line 282 (/* Enable per-node instrumentation iff log_analyze is required. */). Not 'iff' but 'if'. It's short for "if and only if". See https://en.wikipedia.o

Re: Typo in comment of auto_explain.c

> On 27 Nov 2024, at 13:46, Ilia Evdokimov > wrote: > I found typo in comment auto_explain.c line 282 (/* Enable per-node > instrumentation iff log_analyze is required. */). > > Not 'iff' but 'if'. iff is a shorthand for "if and only if", whi

Typo in comment of auto_explain.c

Hi everyone, I found typo in comment auto_explain.c line 282 (/* Enable per-node instrumentation iff log_analyze is required. */). Not 'iff' but 'if'. -- Best regards, Ilia Evdokimov, Tantor Labs LLC.

Re: fixing typo in comment for restriction_is_or_clause

On Tue, Oct 25, 2022 at 3:37 PM Alvaro Herrera wrote: > On 2022-Oct-25, Richard Guo wrote: > > > Agree with your point. Do you think we can further make the one-line > > function a macro or an inline function in the .h file? > > We can, but should we? > > > I think this function is called quite

Re: fixing typo in comment for restriction_is_or_clause

On Tue, Oct 25, 2022 at 2:25 PM John Naylor wrote: > > On Tue, Oct 25, 2022 at 9:48 AM Richard Guo > wrote: > > > > > > On Tue, Oct 25, 2022 at 10:05 AM John Naylor < > john.nay...@enterprisedb.com> wrote: > >> > >> It's perfectly clear and simple now, even if it doesn't win at "code > golf". >

Re: fixing typo in comment for restriction_is_or_clause

On 2022-Oct-25, Richard Guo wrote: > Agree with your point. Do you think we can further make the one-line > function a macro or an inline function in the .h file? We can, but should we? > I think this function is called quite frequently during planning, so > maybe doing that would bring a littl

Re: fixing typo in comment for restriction_is_or_clause

On Tue, Oct 25, 2022 at 9:48 AM Richard Guo wrote: > > > On Tue, Oct 25, 2022 at 10:05 AM John Naylor wrote: >> >> It's perfectly clear and simple now, even if it doesn't win at "code golf". > > > Agree with your point. Do you think we can further make the one-line > function a macro or an inlin

Re: fixing typo in comment for restriction_is_or_clause

On Tue, 25 Oct 2022 at 12:01, Richard Guo wrote: > On Tue, Oct 25, 2022 at 11:46 AM Japin Li wrote: > >> >> On Tue, 25 Oct 2022 at 11:07, Zhihong Yu wrote: >> > Please take a look at patch v2. >> >> Maybe we should define those functions in headers. See patch v3. > > > Yes, putting them in .h

Re: fixing typo in comment for restriction_is_or_clause

On Tue, Oct 25, 2022 at 11:46 AM Japin Li wrote: > > On Tue, 25 Oct 2022 at 11:07, Zhihong Yu wrote: > > Please take a look at patch v2. > > Maybe we should define those functions in headers. See patch v3. Yes, putting them in .h file is better to me. For the v3 patch, we can do the same one-

Re: fixing typo in comment for restriction_is_or_clause

On Tue, 25 Oct 2022 at 11:07, Zhihong Yu wrote: > Please take a look at patch v2. Maybe we should define those functions in headers. See patch v3. -- Regrads, Japin Li. ChengDu WenWu Information Technology Co.,Ltd. diff --git a/src/backend/optimizer/util/restrictinfo.c b/src/backend/optimize

Re: fixing typo in comment for restriction_is_or_clause

On Mon, Oct 24, 2022 at 7:58 PM Japin Li wrote: > > On Tue, 25 Oct 2022 at 10:48, Richard Guo wrote: > > On Tue, Oct 25, 2022 at 10:05 AM John Naylor < > john.nay...@enterprisedb.com> > > wrote: > > > >> > >> On Tue, Oct 25, 2022 at 12:19 AM Zhihong Yu wrote: > >> > > >> > Hi, > >> > When I was

Re: fixing typo in comment for restriction_is_or_clause

On Tue, 25 Oct 2022 at 10:48, Richard Guo wrote: > On Tue, Oct 25, 2022 at 10:05 AM John Naylor > wrote: > >> >> On Tue, Oct 25, 2022 at 12:19 AM Zhihong Yu wrote: >> > >> > Hi, >> > When I was looking at src/backend/optimizer/util/restrictinfo.c, I found >> a typo in one of the comments. >> >

Re: fixing typo in comment for restriction_is_or_clause

On Tue, Oct 25, 2022 at 10:05 AM John Naylor wrote: > > On Tue, Oct 25, 2022 at 12:19 AM Zhihong Yu wrote: > > > > Hi, > > When I was looking at src/backend/optimizer/util/restrictinfo.c, I found > a typo in one of the comments. > > Using "t" as an abbreviation for "true" was probably intentiona

Re: fixing typo in comment for restriction_is_or_clause

On Tue, Oct 25, 2022 at 12:19 AM Zhihong Yu wrote: > > Hi, > When I was looking at src/backend/optimizer/util/restrictinfo.c, I found a typo in one of the comments. Using "t" as an abbreviation for "true" was probably intentional, so not a typo. There is no doubt what the behavior is. > I also t

fixing typo in comment for restriction_is_or_clause

Hi, When I was looking at src/backend/optimizer/util/restrictinfo.c, I found a typo in one of the comments. I also took the chance to simplify the code a little bit. Please take a look at the patch. Thanks is-or.patch Description: Binary data

Re: Fix typo in comment

Alvaro Herrera writes: > On 2022-May-06, Zaorang Yang wrote: >> Maybe, the first letter of comments in postinit.c should be capitalized. > Hmm, typically these one-line comments are not "full sentences", so they > don't have capitals and no ending periods either. I wouldn't like the > endless st

Re: Fix typo in comment

> On 6 May 2022, at 14:50, Alvaro Herrera wrote: > > On 2022-May-06, Zaorang Yang wrote: > >> Maybe, the first letter of comments in postinit.c should be capitalized. > > Hmm, typically these one-line comments are not "full sentences", so they > don't have capitals and no ending periods either.

Re: Fix typo in comment

On 2022-May-06, Zaorang Yang wrote: > Maybe, the first letter of comments in postinit.c should be capitalized. Hmm, typically these one-line comments are not "full sentences", so they don't have capitals and no ending periods either. I wouldn't like the endless stream of patches that would resul

Fix typo in comment

Maybe, the first letter of comments in postinit.c should be capitalized. Attaching a tiny patch to fix it. 0001-Fix-typo-in-comment.patch Description: Binary data

Re: Fix typo in comment

On Tue, Jan 5, 2021 at 5:36 AM Peter Smith wrote: > > PSA a trivial patch to correct a comment typo. > LGTM. Pushed! -- With Regards, Amit Kapila.

Fix typo in comment

PSA a trivial patch to correct a comment typo. Kind Regards, Peter Smith Fujitsu Australia. fix_typo.patch Description: Binary data

Re: Fixing a trivial typo in comment in rewriteManip.c

At Mon, 9 Apr 2018 14:22:33 +0300, Heikki Linnakangas wrote in <4ee784f4-a7c6-dced-0d4c-0a2ac5b87...@iki.fi> > On 09/04/18 13:26, Kyotaro HORIGUCHI wrote: > > While I was looking on some patch, I happened to notice that > > there's a trivial typo in rewriteManip.c > > > >> a ConvertRowTypeExpr t

Re: Fixing a trivial typo in comment in rewriteManip.c

On 09/04/18 13:26, Kyotaro HORIGUCHI wrote: While I was looking on some patch, I happened to notice that there's a trivial typo in rewriteManip.c a ConvertRowTypeExpr to map back to the rowtype expected by the expression. The correct name for "ConvertRowTypeExpr" is "ConvertRowtypeExpr" Fix

Fixing a trivial typo in comment in rewriteManip.c

While I was looking on some patch, I happened to notice that there's a trivial typo in rewriteManip.c > a ConvertRowTypeExpr to map back to the rowtype expected by the expression. The correct name for "ConvertRowTypeExpr" is "ConvertRowtypeExpr" regards, -- Kyotaro Horiguchi NTT Open Source So

Re: Small typo in comment in json_agg_transfn

On Sun, Dec 17, 2017 at 2:43 PM, David Rowley wrote: > The attached fixed a small typo in json_agg_transfn. > Applied, thanks. -- Magnus Hagander Me: https://www.hagander.net/ Work: https://www.redpill-linpro.com/

Small typo in comment in json_agg_transfn

The attached fixed a small typo in json_agg_transfn. -- David Rowley http://www.2ndQuadrant.com/ PostgreSQL Development, 24x7 Support, Training & Services json_agg_transfn_comment_fix.patch Description: Binary data

Re: Typo in comment

(2017/11/17 4:18), Robert Haas wrote: On Thu, Nov 16, 2017 at 6:53 AM, Etsuro Fujita wrote: Here is a patch for fixing a comment typo: s/datum1/datums1/. Thanks, committed. Thank you. Best regards, Etsuro Fujita

Re: Typo in comment

On Thu, Nov 16, 2017 at 6:53 AM, Etsuro Fujita wrote: > Here is a patch for fixing a comment typo: s/datum1/datums1/. Thanks, committed. -- Robert Haas EnterpriseDB: http://www.enterprisedb.com The Enterprise PostgreSQL Company

Typo in comment

Hi, Here is a patch for fixing a comment typo: s/datum1/datums1/. Best regards, Etsuro Fujita diff --git a/src/backend/catalog/partition.c b/src/backend/catalog/partition.c index 07fdf66..fa69995 100644 --- a/src/backend/catalog/partition.c +++ b/src/backend/catalog/partition.c @@ -2601,7 +2601,7