Re: obsolete reference to a SubPlan field

2022-03-14 Thread Robert Haas
On Mon, Mar 14, 2022 at 1:45 PM Tom Lane wrote: > Robert Haas writes: > > On Wed, Feb 2, 2022 at 3:08 AM Amit Langote wrote: > >> Attached patch removes those. > > > Looks right to me. Tom, any comments? > > I'm pretty sure I left those comments alone on purpose back in 2007, > and I don't find

Re: obsolete reference to a SubPlan field

2022-03-14 Thread Tom Lane
Robert Haas writes: > On Wed, Feb 2, 2022 at 3:08 AM Amit Langote wrote: >> Attached patch removes those. > Looks right to me. Tom, any comments? I'm pretty sure I left those comments alone on purpose back in 2007, and I don't find simply removing them to be an improvement. In principle, reade

Re: obsolete reference to a SubPlan field

2022-03-14 Thread Robert Haas
On Wed, Feb 2, 2022 at 3:08 AM Amit Langote wrote: > I noticed $subject while looking at something involving SubLinks and > SubPlans. It seems eab6b8b27eb removed the "plan" field from the > SubPlan node struct definition, but the following line from > expression_tree_mutator(): > >

obsolete reference to a SubPlan field

2022-02-02 Thread Amit Langote
I noticed $subject while looking at something involving SubLinks and SubPlans. It seems eab6b8b27eb removed the "plan" field from the SubPlan node struct definition, but the following line from expression_tree_mutator(): /* but not the sub-Plan itself, which is referenced as-is */