Hi,
On 2022-07-12 12:19:06 -0400, Melanie Plageman wrote:
> > > I also realized that I am not differentiating between IOPATH_SHARED and
> > > IOPATH_STRATEGY for IOOP_FSYNC. But, given that we don't know what type
> > > of buffer we are fsync'ing by the time we call register_dirty_segment(),
> >
Thanks for the review!
On Tue, Jul 12, 2022 at 4:06 AM Kyotaro Horiguchi
wrote:
> At Mon, 11 Jul 2022 22:22:28 -0400, Melanie Plageman <
> melanieplage...@gmail.com> wrote in
> > Hi,
> >
> > In the attached patch set, I've added in missing IO operations for
> > certain IO Paths as well as
At Mon, 11 Jul 2022 22:22:28 -0400, Melanie Plageman
wrote in
> Hi,
>
> In the attached patch set, I've added in missing IO operations for
> certain IO Paths as well as enumerating in the commit message which IO
> Paths and IO Operations are not currently counted and or not possible.
>
>
Hi,
In the attached patch set, I've added in missing IO operations for
certain IO Paths as well as enumerating in the commit message which IO
Paths and IO Operations are not currently counted and or not possible.
There is a TODO in HandleWalWriterInterrupts() about removing
pgstat_report_wal()
Hi,
On 2022-07-05 13:24:55 -0400, Melanie Plageman wrote:
> From 2d089e26236c55d1be5b93833baa0cf7667ba38d Mon Sep 17 00:00:00 2001
> From: Melanie Plageman
> Date: Tue, 28 Jun 2022 11:33:04 -0400
> Subject: [PATCH v22 1/3] Add BackendType for standalone backends
>
> All backends should have a
On Mon, Mar 21, 2022 at 8:15 PM Andres Freund wrote:
> Hi,
>
> On 2022-02-19 11:06:18 -0500, Melanie Plageman wrote:
> > v21 rebased with compile errors fixed is attached.
>
> This currently doesn't apply (mea culpa likely):
> http://cfbot.cputube.org/patch_37_3272.log
>
> Could you rebase?
I already rebased this in a local branch, so here it's.
I don't expect it to survive the day.
This should be updated to use the tuplestore helper.
>From bc4afef0bf0cb34d90fb6c029ab4c5ff1a6d033d Mon Sep 17 00:00:00 2001
From: Melanie Plageman
Date: Mon, 11 Oct 2021 16:15:06 -0400
Subject: [PATCH
Hi,
On 2022-02-19 11:06:18 -0500, Melanie Plageman wrote:
> v21 rebased with compile errors fixed is attached.
This currently doesn't apply (mea culpa likely):
http://cfbot.cputube.org/patch_37_3272.log
Could you rebase? Marked as waiting-on-author for now.
- Andres
v21 rebased with compile errors fixed is attached.
v21-0008-small-comment-correction.patch
Description: Binary data
v21-0007-Remove-superfluous-bgwriter-stats-code.patch
Description: Binary data
v21-0004-Send-IO-operations-to-stats-collector.patch
Description: Binary data
On Thu, Dec 30, 2021 at 3:30 PM Melanie Plageman
wrote:
>
> On Tue, Dec 21, 2021 at 8:32 PM Melanie Plageman
> wrote:
> > On Thu, Dec 16, 2021 at 3:18 PM Andres Freund wrote:
> > > > > > From 9f22da9041e1e1fbc0ef003f5f78f4e72274d438 Mon Sep 17 00:00:00
> > > > > > 2001
> > > > > > From:
On Tue, Dec 21, 2021 at 8:32 PM Melanie Plageman
wrote:
> On Thu, Dec 16, 2021 at 3:18 PM Andres Freund wrote:
> > > > > From 9f22da9041e1e1fbc0ef003f5f78f4e72274d438 Mon Sep 17 00:00:00 2001
> > > > > From: Melanie Plageman
> > > > > Date: Wed, 24 Nov 2021 12:20:10 -0500
> > > > > Subject:
On 2021-Dec-15, Melanie Plageman wrote:
> I noticed after changing the docs on the "bgwriter" target for
> pg_stat_reset_shared to say "checkpointer", that it still said "bgwriter" in
> src/backend/po/ko.po
> src/backend/po/it.po
> ...
> I presume these are automatically updated with some
Hi,
On 2021-12-15 16:40:27 -0500, Melanie Plageman wrote:
> > > +/*
> > > + * Before exiting, a backend sends its IO op statistics to the collector
> > > so
> > > + * that they may be persisted.
> > > + */
> > > +void
> > > +pgstat_send_buffers(void)
> > > +{
> > > + PgStat_MsgIOPathOps msg;
On Fri, Dec 03, 2021 at 03:02:24PM -0500, Melanie Plageman wrote:
> Thanks again! I really appreciate the thorough review.
>
> I have combined responses to all three of your emails below.
> Let me know if it is more confusing to do it this way.
One email is better than three - I'm just not a
v18 attached.
On Thu, Dec 9, 2021 at 2:17 PM Andres Freund wrote:
>
> Hi,
>
> On 2021-12-03 15:02:24 -0500, Melanie Plageman wrote:
> > From e0f7f3dfd60a68fa01f3c023bcdb69305ade3738 Mon Sep 17 00:00:00 2001
> > From: Melanie Plageman
> > Date: Mon, 11 Oct 2021 16:15:06 -0400
> > Subject: [PATCH
Hi,
On 2021-12-03 15:02:24 -0500, Melanie Plageman wrote:
> From e0f7f3dfd60a68fa01f3c023bcdb69305ade3738 Mon Sep 17 00:00:00 2001
> From: Melanie Plageman
> Date: Mon, 11 Oct 2021 16:15:06 -0400
> Subject: [PATCH v17 1/7] Read-only atomic backend write function
>
> For counters in shared
Thanks again! I really appreciate the thorough review.
I have combined responses to all three of your emails below.
Let me know if it is more confusing to do it this way.
On Wed, Dec 1, 2021 at 6:59 PM Justin Pryzby wrote:
>
> On Wed, Dec 01, 2021 at 05:00:14PM -0500, Melanie Plageman wrote:
>
On Wed, Dec 01, 2021 at 04:59:44PM -0500, Melanie Plageman wrote:
> Thanks for the review!
>
> On Wed, Nov 24, 2021 at 8:16 PM Justin Pryzby wrote:
> > You wrote beentry++ at the start of two loops, but I think that's wrong; it
> > should be at the end, as in the rest of the file (or as a loop
On Wed, Dec 01, 2021 at 04:59:44PM -0500, Melanie Plageman wrote:
> Thanks for the review!
>
> On Wed, Nov 24, 2021 at 8:16 PM Justin Pryzby wrote:
> > You wrote beentry++ at the start of two loops, but I think that's wrong; it
> > should be at the end, as in the rest of the file (or as a loop
On Wed, Dec 01, 2021 at 05:00:14PM -0500, Melanie Plageman wrote:
> > Also:
> > src/include/miscadmin.h:#define BACKEND_NUM_TYPES (B_LOGGER + 1)
> >
> > I think it's wrong to say NUM_TYPES = B_LOGGER + 1 (which would suggest
> > using
> > lessthan-or-equal instead of lessthan as you are).
> >
> >
v16 (also rebased) attached
On Fri, Nov 26, 2021 at 4:16 PM Justin Pryzby wrote:
>
> On Wed, Nov 24, 2021 at 07:15:59PM -0600, Justin Pryzby wrote:
> > There's extraneous blank lines in these functions:
> >
> > +pgstat_sum_io_path_ops
> > +pgstat_report_live_backend_io_path_ops
> >
Thanks for the review!
On Wed, Nov 24, 2021 at 8:16 PM Justin Pryzby wrote:
> You wrote beentry++ at the start of two loops, but I think that's wrong; it
> should be at the end, as in the rest of the file (or as a loop increment).
> BackendStatusArray[0] is actually used (even though its backend
On Wed, Nov 24, 2021 at 07:15:59PM -0600, Justin Pryzby wrote:
> There's extraneous blank lines in these functions:
>
> +pgstat_sum_io_path_ops
> +pgstat_report_live_backend_io_path_ops
> +pgstat_recv_resetsharedcounter
> +GetIOPathDesc
> +StrategyRejectBuffer
+ an extra blank line
Thanks for working on this. I was just trying to find something like
"pg_stat_checkpointer".
You wrote beentry++ at the start of two loops, but I think that's wrong; it
should be at the end, as in the rest of the file (or as a loop increment).
BackendStatusArray[0] is actually used (even though
On Fri, Nov 19, 2021 at 11:49 AM Andres Freund wrote:
> > +/*
> > + * On modern systems this is really just *counter++. On some older systems
> > + * there might be more to it, due to inability to read and write 64 bit
> > values
> > + * atomically.
> > + */
> > +static inline void
Hi,
On 2021-11-02 15:26:52 -0400, Melanie Plageman wrote:
> Subject: [PATCH v14 1/4] Allow bootstrap process to beinit
Pushed.
> +/*
> + * On modern systems this is really just *counter++. On some older systems
> + * there might be more to it, due to inability to read and write 64 bit
>
v14 attached.
On Tue, Oct 19, 2021 at 3:29 PM Andres Freund wrote:
>
>
> > > Is pgstattuple the best place for this helper? It's not really pgstatfuncs
> > > specific...
> > >
> > > It also looks vaguely familiar - I wonder if we have a helper roughly like
> > > this somewhere else already...
>
Hi,
On 2021-10-11 16:48:01 -0400, Melanie Plageman wrote:
> On Fri, Oct 8, 2021 at 1:56 PM Andres Freund wrote:
> > On 2021-10-01 16:05:31 -0400, Melanie Plageman wrote:
> > > diff --git a/src/backend/utils/init/postinit.c
> > > b/src/backend/utils/init/postinit.c
> > > index
On Fri, Oct 8, 2021 at 1:56 PM Andres Freund wrote:
>
> Hi,
>
> On 2021-10-01 16:05:31 -0400, Melanie Plageman wrote:
> > From 40c809ad1127322f3462e85be080c10534485f0d Mon Sep 17 00:00:00 2001
> > From: Melanie Plageman
> > Date: Fri, 24 Sep 2021 17:39:12 -0400
> > Subject: [PATCH v13 1/4] Allow
Hi,
On 2021-10-01 16:05:31 -0400, Melanie Plageman wrote:
> From 40c809ad1127322f3462e85be080c10534485f0d Mon Sep 17 00:00:00 2001
> From: Melanie Plageman
> Date: Fri, 24 Sep 2021 17:39:12 -0400
> Subject: [PATCH v13 1/4] Allow bootstrap process to beinit
>
> ---
>
v13 (attached) contains several cosmetic updates and the full rename
(comments included) of BufferAccessType and BufferType.
On Thu, Sep 30, 2021 at 7:15 PM Alvaro Herrera wrote:
>
> Can you say more about 0001?
>
The rationale for this patch was that it doesn't save much to avoid
initializing
Can you say more about 0001?
--
Álvaro Herrera PostgreSQL Developer — https://www.EnterpriseDB.com/
"Use it up, wear it out, make it do, or do without"
On Wed, Sep 29, 2021 at 4:46 PM Melanie Plageman
wrote:
>
> On Mon, Sep 27, 2021 at 2:58 PM Melanie Plageman
> wrote:
> >
> > On Fri, Sep 24, 2021 at 5:58 PM Melanie Plageman
> > wrote:
> > >
> > > On Thu, Sep 23, 2021 at 5:05 PM Melanie Plageman
> > > wrote:
> > > The only remaining TODOs are
On Mon, Sep 27, 2021 at 2:58 PM Melanie Plageman
wrote:
>
> On Fri, Sep 24, 2021 at 5:58 PM Melanie Plageman
> wrote:
> >
> > On Thu, Sep 23, 2021 at 5:05 PM Melanie Plageman
> > wrote:
> > The only remaining TODOs are described in the commit message.
> > most critical one is that the reset
On Fri, Sep 24, 2021 at 5:58 PM Melanie Plageman
wrote:
>
> On Thu, Sep 23, 2021 at 5:05 PM Melanie Plageman
> wrote:
> The only remaining TODOs are described in the commit message.
> most critical one is that the reset message doesn't work.
v10 is attached with updated comments and some
On Thu, Sep 23, 2021 at 5:05 PM Melanie Plageman
wrote:
>
> The attached v8 patchset is rewritten to add in an additional dimension
> -- buffer type. Now, a backend keeps track of how many buffers of a
> particular type (e.g. shared, local) it has accessed in a particular way
> (e.g. alloc,
On Tue, Sep 14, 2021 at 9:30 PM Alvaro Herrera wrote:
>
> On 2021-Sep-13, Melanie Plageman wrote:
>
> > I also think it makes sense to rename the pg_stat_buffer_actions view to
> > pg_stat_buffers and to name the columns using both the buffer action
> > type and buffer type -- e.g. shared,
Hello Melanie
On 2021-Sep-13, Melanie Plageman wrote:
> I also think it makes sense to rename the pg_stat_buffer_actions view to
> pg_stat_buffers and to name the columns using both the buffer action
> type and buffer type -- e.g. shared, strategy, local. This leaves open
> the possibility of
Hi,
I've attached the v7 patch set.
Changes from v6:
- removed unnecessary global variable BufferActionsStats
- fixed the loop condition in pg_stat_get_buffer_actions()
- updated some comments
- removed buffers_checkpoint and buffers_clean from pg_stat_bgwriter
view (now pg_stat_bgwriter view
On Wed, Sep 8, 2021 at 9:28 PM Melanie Plageman
wrote:
>
> On Fri, Aug 13, 2021 at 3:08 AM Andres Freund wrote:
> >
> > Hi,
> >
> > On 2021-08-11 16:11:34 -0400, Melanie Plageman wrote:
> > > On Tue, Aug 3, 2021 at 2:13 PM Andres Freund wrote:
> > > > > Also, I'm unsure how writing the buffer
On Fri, Aug 13, 2021 at 3:08 AM Andres Freund wrote:
>
> Hi,
>
> On 2021-08-11 16:11:34 -0400, Melanie Plageman wrote:
> > On Tue, Aug 3, 2021 at 2:13 PM Andres Freund wrote:
> > > > Also, I'm unsure how writing the buffer action stats out in
> > > > pgstat_write_statsfiles() will work, since I
On Fri, Aug 13, 2021 at 3:08 AM Andres Freund wrote:
>
> Hi,
>
> On 2021-08-11 16:11:34 -0400, Melanie Plageman wrote:
> > On Tue, Aug 3, 2021 at 2:13 PM Andres Freund wrote:
> > > > diff --git a/src/backend/catalog/system_views.sql
> > > > b/src/backend/catalog/system_views.sql
> > > > index
Hi,
On 2021-08-11 16:11:34 -0400, Melanie Plageman wrote:
> On Tue, Aug 3, 2021 at 2:13 PM Andres Freund wrote:
> > > Also, I'm unsure how writing the buffer action stats out in
> > > pgstat_write_statsfiles() will work, since I think that backends can
> > > update their buffer action stats
On Wed, Aug 11, 2021 at 4:11 PM Melanie Plageman
wrote:
>
> On Tue, Aug 3, 2021 at 2:13 PM Andres Freund wrote:
> >
> > > @@ -2895,6 +2948,20 @@ FlushBuffer(BufferDesc *buf, SMgrRelation reln)
> > > /*
> > >* bufToWrite is either the shared buffer or a copy, as appropriate.
> > >
On Tue, Aug 3, 2021 at 2:13 PM Andres Freund wrote:
>
> Hi,
>
> On 2021-08-02 18:25:56 -0400, Melanie Plageman wrote:
> > Thanks for the feedback!
> >
> > I agree it makes sense to count strategy writes separately.
> >
> > I thought about this some more, and I don't know if it makes sense to
> >
Hi,
On 2021-08-02 18:25:56 -0400, Melanie Plageman wrote:
> Thanks for the feedback!
>
> I agree it makes sense to count strategy writes separately.
>
> I thought about this some more, and I don't know if it makes sense to
> only count "avoidable" strategy writes.
>
> This would mean that a
On Fri, Jun 4, 2021 at 5:52 PM Alvaro Herrera wrote:
>
> On 2021-Apr-12, Melanie Plageman wrote:
>
> > As for the way I have recorded strategy writes -- it is quite inelegant,
> > but, I wanted to make sure that I only counted a strategy write as one
> > in which the backend wrote out the dirty
On 2021-Apr-12, Melanie Plageman wrote:
> As for the way I have recorded strategy writes -- it is quite inelegant,
> but, I wanted to make sure that I only counted a strategy write as one
> in which the backend wrote out the dirty buffer from its strategy ring
> but did not check if there was any
On Thu, Apr 15, 2021 at 7:59 PM Andres Freund wrote:
> Hi,
>
> On 2021-04-12 19:49:36 -0700, Melanie Plageman wrote:
> > So, I took a stab at implementing this in PgBackendStatus.
>
> Cool!
>
Just a note on v2 of the patch -- the diff for the changes I made to
pgstatfuncs.c is pretty atrocious
Hi,
On 2021-04-12 19:49:36 -0700, Melanie Plageman wrote:
> So, I took a stab at implementing this in PgBackendStatus.
Cool!
> The attached patch is not quite on top of current master, so, alas,
> don't try and apply it. I went to rebase today and realized I needed
> to make some changes in
On Sun, Jan 26, 2020 at 11:21 PM Kyotaro Horiguchi
wrote:
> At Sun, 26 Jan 2020 12:22:03 -0800, Andres Freund wrote
> in
> > On 2020-01-26 16:20:03 +0100, Magnus Hagander wrote:
> > > On Sun, Jan 26, 2020 at 1:44 AM Andres Freund wrote:
> > > > On 2020-01-25 15:43:41 +0100, Magnus Hagander
Hello.
At Sun, 26 Jan 2020 12:22:03 -0800, Andres Freund wrote in
> Hi,
I feel the same on the specific issues brought in upthread.
> On 2020-01-26 16:20:03 +0100, Magnus Hagander wrote:
> > On Sun, Jan 26, 2020 at 1:44 AM Andres Freund wrote:
> > > On 2020-01-25 15:43:41 +0100, Magnus
Hi,
On 2020-01-26 16:20:03 +0100, Magnus Hagander wrote:
> On Sun, Jan 26, 2020 at 1:44 AM Andres Freund wrote:
> > On 2020-01-25 15:43:41 +0100, Magnus Hagander wrote:
> > > On Fri, Jan 24, 2020 at 8:52 PM Andres Freund wrote:
> > > > Lastly, I don't understand what the point of sending fixed
On Sun, Jan 26, 2020 at 1:44 AM Andres Freund wrote:
>
> Hi,
>
> On 2020-01-25 15:43:41 +0100, Magnus Hagander wrote:
> > On Fri, Jan 24, 2020 at 8:52 PM Andres Freund wrote:
> > > Additionally pg_stat_bgwriter.buffers_backend also counts writes done by
> > > autovacuum et al.
>
> > > I think
Hi,
On 2020-01-25 15:43:41 +0100, Magnus Hagander wrote:
> On Fri, Jan 24, 2020 at 8:52 PM Andres Freund wrote:
> > Additionally pg_stat_bgwriter.buffers_backend also counts writes done by
> > autovacuum et al.
> > I think it'd make sense to at least split buffers_backend into
> >
On Fri, Jan 24, 2020 at 8:52 PM Andres Freund wrote:
>
> Hi,
>
> Currently pg_stat_bgwriter.buffers_backend is pretty useless to gauge
> whether backends are doing writes they shouldn't do. That's because it
> counts things that are either unavoidably or unlikely doable by other
> parts of the
Hi,
Currently pg_stat_bgwriter.buffers_backend is pretty useless to gauge
whether backends are doing writes they shouldn't do. That's because it
counts things that are either unavoidably or unlikely doable by other
parts of the system (checkpointer, bgwriter).
In particular extending the file
101 - 157 of 157 matches
Mail list logo
