Re: pg_ugprade test failure on data set with column with default value with type bit/varbit

Paul Guo writes: > [ 0001-Fix-pg_upgrade-test-failure-caused-by-the-DDL-below.v2.patch ] Actually, there's an even easier way to fix this, which is to discard the special case for BITOID/VARBITOID altogether, and let the "default" case handle it. Fixing things by removing code is always great

Re: pg_ugprade test failure on data set with column with default value with type bit/varbit

On 8/1/18, Paul Guo wrote: > Thanks. I updated the patch as attached. > > Double-checked those tests passed. I've verified make check-world passes. I've marked it Ready for Committer. -John Naylor

Re: pg_ugprade test failure on data set with column with default value with type bit/varbit

Thanks. I updated the patch as attached. Double-checked those tests passed. 2018-07-30 9:38 GMT+08:00 Thomas Munro : > On Thu, May 17, 2018 at 8:20 PM, Paul Guo wrote: > > Thanks. I tentatively submitted a patch (See the attachment). > > Hi Paul, > > It looks like you missed a couple of

Re: pg_ugprade test failure on data set with column with default value with type bit/varbit

On Thu, May 17, 2018 at 8:20 PM, Paul Guo wrote: > Thanks. I tentatively submitted a patch (See the attachment). Hi Paul, It looks like you missed a couple of changes in the contrib/btree_gist bit and varbit tests, so make check-world fails: - Index Cond: ((a >= B'100'::"bit") AND (a <=

Re: pg_ugprade test failure on data set with column with default value with type bit/varbit

The following review has been posted through the commitfest application: make installcheck-world: tested, passed Implements feature: tested, passed Spec compliant: tested, passed Documentation:not tested Hi Paul, this is a review of the patch:

Re: pg_ugprade test failure on data set with column with default value with type bit/varbit

On Thu, May 17, 2018 at 4:20 AM, Paul Guo wrote: > Thanks. I tentatively submitted a patch (See the attachment). You probably want to add this to the next Commitfest. > By the way, current pg_upgrade test script depends on the left data on test > database, but it seems that >

Re: pg_ugprade test failure on data set with column with default value with type bit/varbit

Thanks. I tentatively submitted a patch (See the attachment). By the way, current pg_upgrade test script depends on the left data on test database, but it seems that a lot of tables are dropped in those test SQL files so this affects the pg_upgrade test coverage much. Maybe this needs to be

Re: pg_ugprade test failure on data set with column with default value with type bit/varbit

On Fri, Mar 30, 2018 at 5:36 AM, Paul Guo wrote: > There is no diff in functionality of the dump SQLs, but it is annoying. The > simple patch below could fix this. Thanks. > > --- a/src/backend/utils/adt/ruleutils.c > +++ b/src/backend/utils/adt/ruleutils.c > @@ -9389,7 +9389,7

pg_ugprade test failure on data set with column with default value with type bit/varbit

Hello, While testing pg_upgrade we seemed to find an issue related to default value of a column with type bit/varbit. Below are the steps to reproduce. In this case we added two 'create table' DDLs in the regression database. Obviously we saw diff after pg_upgrade testing. The pg binaries are