Re: postgres_fdw "parallel_commit" docs

2022-05-13 Thread Etsuro Fujita
Hi Jonathan, On Thu, May 12, 2022 at 10:32 PM Jonathan S. Katz wrote: > On 5/12/22 7:26 AM, Etsuro Fujita wrote: > > Attached is an updated patch. I'll commit the patch if no objections. > > I think this is much easier to read. Cool! > I made a few minor copy edits. Please see attached. LGTM,

Re: postgres_fdw "parallel_commit" docs

2022-05-12 Thread Jonathan S. Katz
Hi Etsuro, On 5/12/22 7:26 AM, Etsuro Fujita wrote: I modified the patch to use the old language. Also, I fixed a typo reported by Justin. Attached is an updated patch. I'll commit the patch if no objections. Thanks for reviewing and revising! I think this is much easier to read. I made a

Re: postgres_fdw "parallel_commit" docs

2022-05-12 Thread Etsuro Fujita
On Wed, May 11, 2022 at 7:25 PM Etsuro Fujita wrote: > One thing I noticed is this bit: > > -When multiple remote (sub)transactions are involved in a local > -(sub)transaction, by default postgres_fdw commits > -those remote (sub)transactions one by one when the local (sub)transaction

Re: postgres_fdw "parallel_commit" docs

2022-05-11 Thread Etsuro Fujita
Hi Justin, On Tue, May 10, 2022 at 12:58 AM Justin Pryzby wrote: > On Mon, May 09, 2022 at 11:37:35AM -0400, Jonathan S. Katz wrote: > > - If multiple foreign servers with this option enabled are involved in > > - a local (sub)transaction, multiple remote (sub)transactions opened > >

Re: postgres_fdw "parallel_commit" docs

2022-05-11 Thread Etsuro Fujita
Hi Jonathan, On Tue, May 10, 2022 at 12:37 AM Jonathan S. Katz wrote: > While researching PG15 features, I was trying to read through the > docs[1] for the "parallel_commit" (04e706d4) feature in postgres_fdw to > better understand what it does. I found myself becoming lost with the > references

Re: postgres_fdw "parallel_commit" docs

2022-05-09 Thread Justin Pryzby
On Mon, May 09, 2022 at 11:37:35AM -0400, Jonathan S. Katz wrote: > @@ -473,27 +473,25 @@ OPTIONS (ADD password_required 'false'); > parallel_commit (boolean) > > > - This option controls whether postgres_fdw commits > - remote (sub)transactions opened on a foreign

postgres_fdw "parallel_commit" docs

2022-05-09 Thread Jonathan S. Katz
Hi, While researching PG15 features, I was trying to read through the docs[1] for the "parallel_commit" (04e706d4) feature in postgres_fdw to better understand what it does. I found myself becoming lost with the references to (sub)transaction and a few other items that, while accurate, may be