Re: Flexible permissions for REFRESH MATERIALIZED VIEW

2018-05-21 Thread Robert Haas
On Sat, May 19, 2018 at 12:59 PM, Greg Stark wrote: > On 19 May 2018 at 01:13, Stephen Frost wrote: >> I'm not entirely sure about the varlena suggestion, seems like that >> would change a great deal more code and be slower, though perhaps not >> enough to

Re: pg_basebackup -k option

2018-05-21 Thread Peter Eisentraut
On 5/18/18 11:26, Michael Banck wrote: >>> How about using capital -K in pg_basebackup? Or maybe it doesn't need a >>> short option at all. >> >> +1 for no short option. > > Makes sense to me, I wasn't happy about the -k back then (and I think I > solicited feedback on that). > > PFA a patch

Re: Postgres 11 release notes

2018-05-21 Thread Amit Langote
On Mon, May 21, 2018 at 4:34 PM, David Rowley wrote: > On 19 May 2018 at 03:58, Amit Langote wrote: >> I wonder what you think about including this little performance item: >> >>

Re: Postgres 11 release notes

2018-05-21 Thread Tom Lane
"Jonathan S. Katz" writes: > Per feedback from many asynchronous threads, attached is the proposed > patch for the list of major features. I also expect a torrent of feedback. I > will have a corresponding press release for Beta 1 in the very near future. > This being my

Re: Postgres 11 release notes

2018-05-21 Thread Jonathan S. Katz
> On May 21, 2018, at 12:38 PM, Tom Lane wrote: > > "Jonathan S. Katz" writes: >> Per feedback from many asynchronous threads, attached is the proposed >> patch for the list of major features. I also expect a torrent of feedback. I >> will have a

RE: [HACKERS] Moving relation extension locks out of heavyweight lock manager

2018-05-21 Thread Alex Ignatov
-Original Message- From: Robert Haas Sent: Thursday, April 26, 2018 10:25 PM To: Andres Freund Cc: Masahiko Sawada ; Michael Paquier ; Mithun Cy ; Tom Lane

Re: Allowing printf("%m") only where it actually works

2018-05-21 Thread Tom Lane
Thomas Munro writes: > On Mon, May 21, 2018 at 4:36 PM, Tom Lane wrote: >> I am wondering whether the elog/ereport macros can locally define some >> version of "errno" that would cause a compile failure if it's referenced >> within the macro

RE: [HACKERS] Moving relation extension locks out of heavyweight lock manager

2018-05-21 Thread Alex Ignatov
-- Alex Ignatov Postgres Professional: http://www.postgrespro.com The Russian Postgres Company -Original Message- From: Alex Ignatov Sent: Monday, May 21, 2018 6:00 PM To: 'Robert Haas' ; 'Andres Freund' Cc:

PostgreSQL Buildfarm Client Release 8

2018-05-21 Thread Andrew Dunstan
I have just release version 8 of the PostgreSQL Buildfarm client It can be downloaded from or This release contains a number of small changes to make using

Re: [HACKERS] Aggregate transition state merging vs. hypothetical set functions

2018-05-21 Thread Peter Eisentraut
On 10/13/17 19:01, Tom Lane wrote: >> Moving on to the exact color of the bikeshed: it seems like the right >> way to present this to users of CREATE AGGREGATE is in terms of "does >> the final function modify the transition state?". So maybe the values >> could be spelled >> SMODIFY = READ_ONLY

Re: PostgreSQL: PY3 files in PY2 installation

2018-05-21 Thread Tom Lane
Devrim =?ISO-8859-1?Q?G=FCnd=FCz?= writes: > On Mon, 2018-05-21 at 12:42 +0100, Devrim Gündüz wrote: >> The following files are installed even when I build PostgreSQL 9.5+ on RHEL 7 >> Python 2.7: >> >> hstore_plpython3u--1.0.sql >> hstore_plpython3u.control >>

Re: Add --include-table-data-where option to pg_dump, to export only a subset of table data

2018-05-21 Thread Stephen Frost
Greetings, * Carter Thaxton (carter.thax...@gmail.com) wrote: > Many times I've wanted to export a subset of a database, using some sort of > row filter condition on some of the large tables. E.g. copying a > production database to a staging environment, but with some time series > data only

Re: PostgreSQL: PY3 files in PY2 installation

2018-05-21 Thread Devrim Gündüz
Hi, On Mon, 2018-05-21 at 12:42 +0100, Devrim Gündüz wrote: > The following files are installed even when I build PostgreSQL 9.5+ on RHEL 7 > - > Python 2.7: > > hstore_plpython3u--1.0.sql > hstore_plpython3u.control > jsonb_plpython3u--1.0.sql > jsonb_plpython3u.control >

PostgreSQL: PY3 files in PY2 installation

2018-05-21 Thread Devrim Gündüz
Hi, The following files are installed even when I build PostgreSQL 9.5+ on RHEL 7 - Python 2.7: hstore_plpython3u--1.0.sql hstore_plpython3u.control jsonb_plpython3u--1.0.sql jsonb_plpython3u.control ltree_plpython3u--1.0.sql ltree_plpython3u.control Is this expected? Regards, -- Devrim

Add --include-table-data-where option to pg_dump, to export only a subset of table data

2018-05-21 Thread Carter Thaxton
Many times I've wanted to export a subset of a database, using some sort of row filter condition on some of the large tables. E.g. copying a production database to a staging environment, but with some time series data only from the past month. We have the existing options:

Re: Postgres, fsync, and OSs (specifically linux)

2018-05-21 Thread Andres Freund
On 2018-05-19 18:12:52 +1200, Thomas Munro wrote: > On Sat, May 19, 2018 at 4:51 PM, Thomas Munro > wrote: > > Next, make check hangs in initdb on both of my pet OSes when md.c > > raises an error (fseek fails) and we raise and error while raising and > > error and

Re: Add --include-table-data-where option to pg_dump, to export only a subset of table data

2018-05-21 Thread Euler Taveira
2018-05-20 20:48 GMT-03:00 Carter Thaxton : > Many times I've wanted to export a subset of a database, using some sort of > row filter condition on some of the large tables. E.g. copying a production > database to a staging environment, but with some time series data

Re: Problem while updating a foreign table pointing to a partitioned table on foreign server

2018-05-21 Thread Kyotaro HORIGUCHI
At Fri, 18 May 2018 15:31:07 -0400, Robert Haas wrote in > On Fri, May 18, 2018 at 4:29 AM, Kyotaro HORIGUCHI > wrote: > > I have reached to the same thought. > > > > The

Re: [HACKERS] Moving relation extension locks out of heavyweight lock manager

2018-05-21 Thread Masahiko Sawada
On Tue, May 22, 2018 at 12:05 AM, Alex Ignatov wrote: > > > -- > Alex Ignatov > Postgres Professional: http://www.postgrespro.com > The Russian Postgres Company > > -Original Message- > From: Alex Ignatov > Sent: Monday, May 21, 2018

Time to put context diffs in the grave

2018-05-21 Thread Andrew Dunstan
We haven't insisted on context diffs in years now, and one of my interlocutors has just turned handsprings trying to follow the advice at to produce his first patch. Unless someone objects really violently I'm going to rip all that stuff

Re: [doc fix] Add operation of freeing output SQLDA

2018-05-21 Thread Kyotaro HORIGUCHI
Hello. At Fri, 18 May 2018 06:03:59 +, "Kato, Sho" wrote in <25C1C6B2E7BE044889E4FE8643A58BA963A42097@G01JPEXMBKW03> > Hello > > I think it is better to add freeing operation of output SQLDA to the current > PostgreSQL documentation. > As far as I can see

[GSoC] github repo and initial work

2018-05-21 Thread Charles Cui
Hi mentors and hackers, I have set up a github repo for the pg thrift plugin work, and here is the address (https://github.com/charles-cui/pg_thrift). And I have first version of binary protocol implemented, although it is still a very early stage. The current interface is to return value for

[PATCH] (Windows) psql echoes password when reading from pipe

2018-05-21 Thread Matthew Stickney
This is my first time submitting a patch here; apologies in advance if I flub the process. On windows, if you pipe data to psql, the password prompt correctly reads from and writes to the console, but the password text is echoed to the console. This is because echoing is disabled on the

RE: Postgres 11 release notes

2018-05-21 Thread Ideriha, Takeshi
>-Original Message- >From: Bruce Momjian [mailto:br...@momjian.us] >I have committed the first draft of the Postgres 11 release notes. I will add >more >markup soon. You can view the most current version here: Hi, there is a small typo. I think "These function" should be "These

Re: Time to put context diffs in the grave

2018-05-21 Thread Andres Freund
Hi, On 2018-05-21 21:51:11 -0400, Andrew Dunstan wrote: > We haven't insisted on context diffs in years now, and one of my > interlocutors has just turned handsprings trying to follow the advice at > to produce his first > patch. > > > Unless

Re: Time to put context diffs in the grave

2018-05-21 Thread David Fetter
On Mon, May 21, 2018 at 09:51:11PM -0400, Andrew Dunstan wrote: > > We haven't insisted on context diffs in years now, and one of my > interlocutors has just turned handsprings trying to follow the advice at > to produce his first > patch. > >

Re: [HACKERS] kqueue

2018-05-21 Thread Mateusz Guzik
On Mon, May 21, 2018 at 9:03 AM, Thomas Munro wrote: > On Wed, Apr 11, 2018 at 1:05 PM, Thomas Munro > wrote: > > I heard through the grapevine of some people currently investigating > > performance problems on busy FreeBSD systems,

Message on end of cascading physical replica timeline is unhelpful

2018-05-21 Thread Craig Ringer
Hi all By default, cascading replicas don't follow an upstream's timeline change. I'm not arguing that decision, but as I think it violates POLA somewhat it'd be nice to have an informative message. Currently the user gets repeating messages like LOG: restarted WAL streaming at 25/CA00 on

Re: Postgres 11 release notes

2018-05-21 Thread David Rowley
On 19 May 2018 at 03:58, Amit Langote wrote: > I wonder what you think about including this little performance item: > > https://www.postgresql.org/message-id/e1eotsq-0005v0...@gemulon.postgresql.org > > especially considering the part of the commit message which states >

Re: Postgres, fsync, and OSs (specifically linux)

2018-05-21 Thread Craig Ringer
On 21 May 2018 at 12:57, Craig Ringer wrote: > On 18 May 2018 at 00:44, Andres Freund wrote: > >> Hi, >> >> On 2018-05-10 09:50:03 +0800, Craig Ringer wrote: >> > while ((src = (RewriteMappingFile *) >> hash_seq_search(_status)) != NULL) >> >

Re: Postgres 11 release notes

2018-05-21 Thread Haribabu Kommi
On Sat, May 12, 2018 at 1:08 AM, Bruce Momjian wrote: > I have committed the first draft of the Postgres 11 release notes. I > will add more markup soon. You can view the most current version here: > > http://momjian.us/pgsql_docs/release-11.html > Thanks for

Re: Add --include-table-data-where option to pg_dump, to export only a subset of table data

2018-05-21 Thread Carter Thaxton
Hello, I've only taken a quick look but I don't see any regression tests, for > starters, and it's not clear if this can be passed multiple times for > one pg_dump run (I'd certainly hope that it could be...). > Yes, this will absolutely accept multiple options for one run, which is how I'd

[PATCH] Clear up perlcritic 'missing return' warning

2018-05-21 Thread Mike Blackwell
This is the first in a series of patches to reduce the number of warnings from perlcritic. The current plan is to submit a separate patch for each warning or small set of related warnings, to make reviewing more straightforward. This particular patch addresses the warning caused by falling off

Re: [HACKERS] Transactions involving multiple postgres foreign servers

2018-05-21 Thread Ashutosh Bapat
On Fri, May 11, 2018 at 12:27 AM, Robert Haas wrote: > On Tue, Feb 27, 2018 at 2:21 AM, Masahiko Sawada > wrote: >> I might be missing your point. As for API breaking, this patch doesn't >> break any existing FDWs. All new APIs I proposed are

Re: Allowing printf("%m") only where it actually works

2018-05-21 Thread Thomas Munro
On Mon, May 21, 2018 at 4:36 PM, Tom Lane wrote: > ... and, while we're thinking about this, how can we prevent the reverse > problem of using strerror(errno) where you should have used %m? That > is evidently not academic either, cf 81256cd. > > I am wondering whether the

Re: [HACKERS] kqueue

2018-05-21 Thread Thomas Munro
On Wed, Apr 11, 2018 at 1:05 PM, Thomas Munro wrote: > I heard through the grapevine of some people currently investigating > performance problems on busy FreeBSD systems, possibly related to the > postmaster pipe. I suspect this patch might be a part of the

Re: Add --include-table-data-where option to pg_dump, to export only a subset of table data

2018-05-21 Thread Thomas Munro
On Tue, May 22, 2018 at 4:05 AM, Stephen Frost wrote: > * Carter Thaxton (carter.thax...@gmail.com) wrote: >> pg_dump --include-table-data-where=largetable:"created_at >= >> '2018-05-01'" database_name > > I've wanted something similar to this in the past as well, and, as >

Re: [HACKERS] kqueue

2018-05-21 Thread Thomas Munro
On Mon, May 21, 2018 at 7:27 PM, Mateusz Guzik wrote: > I have benchmarked the change on a FreeBSD box and found an big > performance win once the number of clients goes beyond the number of > hardware threads on the target machine. For smaller number of clients > the win was