Re: Proposal: CREATE/ALTER DOMAIN ... STORAGE/COMPRESSION = ...

2022-08-20 Thread Peter Eisentraut
On 17.08.22 11:43, Aleksander Alekseev wrote: Do you think it will be useful to specify STORAGE and/or COMPRESSION for domains? Domains are supposed to a logical construct that restricts the accepted values for a data type (it's in the name "domain"). Expanding that into a general "column

Re: Fix typo with logical connector (src/backend/commands/vacuumparallel.c)

2022-08-20 Thread Ranier Vilela
Em sáb., 20 de ago. de 2022 às 01:03, Amit Kapila escreveu: > On Fri, Aug 19, 2022 at 7:45 PM Ranier Vilela wrote: > > > > Em sex., 19 de ago. de 2022 às 10:28, Tom Lane > escreveu: > >> > >> Ranier Vilela writes: > >> > At function parallel_vacuum_process_all_indexes there is > >> > a typo

Re: Avoid unecessary MemSet call (src/backend/utils/cache/relcache.c)

2022-08-20 Thread Ranier Vilela
Em sex., 19 de ago. de 2022 às 19:27, David Zhang escreveu: > Hi Ranier, > Hi David, > > Following the comment in commit 9fd45870c1436b477264c0c82eb195df52bc0919, > > (The same could be done with appropriate memset() calls, but this > patch is part of an effort to phase out MemSet(), so

Re: ICU for global collation

2022-08-20 Thread Marina Polyakova
On 2022-08-17 19:53, Julien Rouhaud wrote: Good catch. There's unfortunately not a lot of regression tests for ICU-initialized clusters. I'm wondering if the build-farm client could be taught about the locale provider rather than assuming libc. Clearly that wouldn't have caught this issue,

Re: Issue in postgresql installation - Target version Postgresql 14.

2022-08-20 Thread kavya chandren
Dear Bruce Momjian, Thanks for clarifying, got the issue resolved with installation of lz4 independently. On Fri, Aug 19, 2022 at 9:16 PM Bruce Momjian wrote: > > First, this is not an appropriate question for hackers. Second, this is > a question for the package manager where you got the

Re: Schema variables - new implementation for Postgres 15

2022-08-20 Thread Erik Rijkers
Op 19-08-2022 om 17:29 schreef Pavel Stehule: pá 19. 8. 2022 v 15:57 odesílatel Pavel Stehule napsal: Hi I am sending fresh update - enhanced work with composite types - now the used composite type can be enhanced, reduced and stored value is converted to expected format - enhancing

Re: Schema variables - new implementation for Postgres 15

2022-08-20 Thread Pavel Stehule
so 20. 8. 2022 v 15:36 odesílatel Erik Rijkers napsal: > Op 20-08-2022 om 15:32 schreef Erik Rijkers: > > Op 19-08-2022 om 17:29 schreef Pavel Stehule: > > > > make check fails as a result of the errors in the attached > > session_variables.out. > > > > > Sorry, that should have been this diffs

Re: [RFC] building postgres with meson - v11

2022-08-20 Thread Peter Eisentraut
On 17.08.22 23:53, Andres Freund wrote: Any comment on the pg_regress_ecpg commit? I'd like to get that out of the way, and it seems considerably cleaner than the hackery we do right now to make VPATH builds work. That one looks like a very good improvement.

Re: static libpq (and other libraries) overwritten on aix

2022-08-20 Thread Andres Freund
Hi, On 2022-08-18 22:56:43 -0700, Noah Misch wrote: > > On 2022-08-17 21:59:29 -0700, Noah Misch wrote: > > > Along the lines of Robert's comment, it could be a nice code > > > beautification to > > > use a different suffix for the short-lived .a file. Perhaps _so_inputs.a. > > > > Agreed, it'd

Re: including pid's for `There are XX other sessions using the database`

2022-08-20 Thread Zhihong Yu
On Fri, Aug 19, 2022 at 9:31 PM Euler Taveira wrote: > On Fri, Aug 19, 2022, at 2:10 PM, Zhihong Yu wrote: > > I want to poll the community on whether including proc->pid's in the error > message would be useful for troubleshooting. > > Such message is only useful for a parameter into a

Re: [PATCH] Use indexes on the subscriber when REPLICA IDENTITY is full on the publisher

2022-08-20 Thread Önder Kalacı
Hi, I'm a little late to catch up with your comments, but here are my replies: > My answer for the above assumes that your question is regarding what > happens if you ANALYZE on a partitioned table. If your question is > something different, please let me know. > > > > I was talking about

Re: sslinfo extension - add notbefore and notafter timestamps

2022-08-20 Thread Daniel Gustafsson
> On 20 Aug 2022, at 01:00, Cary Huang wrote: > I noticed that sslinfo extension does not have functions to return current > client certificate's notbefore and notafter timestamps which are also quite > important attributes in a X509 certificate. The attached patch adds 2 > functions to get

Re: Schema variables - new implementation for Postgres 15

2022-08-20 Thread Erik Rijkers
Op 20-08-2022 om 15:41 schreef Pavel Stehule: so 20. 8. 2022 v 15:36 odesílatel Erik Rijkers napsal: Op 20-08-2022 om 15:32 schreef Erik Rijkers: Op 19-08-2022 om 17:29 schreef Pavel Stehule: make check fails as a result of the errors in the attached session_variables.out. Sorry,

Re: Schema variables - new implementation for Postgres 15

2022-08-20 Thread Julien Rouhaud
On Sat, Aug 20, 2022 at 03:55:07PM +0200, Erik Rijkers wrote: > > Op 20-08-2022 om 15:41 schreef Pavel Stehule: > > so 20. 8. 2022 v 15:36 odesílatel Erik Rijkers napsal: > > > > > Op 20-08-2022 om 15:32 schreef Erik Rijkers: > > > > Op 19-08-2022 om 17:29 schreef Pavel Stehule: > > > > > > > >

Re: shadow variables - pg15 edition

2022-08-20 Thread David Rowley
On Fri, 19 Aug 2022 at 16:28, Justin Pryzby wrote: > Let me know what I can do when it's time for round two. I pushed the modified 0001-0008 patches earlier today and also the one I wrote to fixup the 36 warnings about "expected" being shadowed. I looked through a bunch of your remaining

Re: Schema variables - new implementation for Postgres 15

2022-08-20 Thread Erik Rijkers
Op 20-08-2022 om 15:32 schreef Erik Rijkers: Op 19-08-2022 om 17:29 schreef Pavel Stehule: make check  fails as a result of the errors in the attached session_variables.out. Sorry, that should have been this diffs file, of course (attached). Erikdiff -U3

Inconsistencies around defining FRONTEND

2022-08-20 Thread Andres Freund
Hi, This started at https://postgr.es/m/20220817215317.poeofidf7o7dy6hy%40awork3.anarazel.de Peter made a good point about -DFRONTED not being defined symmetrically between meson and autoconf builds, which made me look at where we define it. And I think we ought to clean this up independ of the

Re: Strip -mmacosx-version-min options from plperl build

2022-08-20 Thread Tom Lane
Andres Freund writes: > Maybe a daft question: Why do want any of the -l flags other than -lperl? With > the patch configure spits out the following on my debian system: > checking for CFLAGS to compile embedded Perl... -DDEBIAN > checking for flags to link embedded Perl... >

Re: Strip -mmacosx-version-min options from plperl build

2022-08-20 Thread Andres Freund
Hi, FWIW, looks like Peter's patch unbreaks building plperl on AIX using gcc and system perl. Before we picked up a bunch of xlc specific flags that prevented that. before: checking for flags to link embedded Perl... -brtl -bdynamic -b64

Re: Schema variables - new implementation for Postgres 15

2022-08-20 Thread Erik Rijkers
Op 20-08-2022 om 20:09 schreef Pavel Stehule: Hi LET public.svar2 = (10, 20, 30); ALTER TYPE public.svar_test_type DROP ATTRIBUTE b; SELECT public.svar; - svar - (10,) + svar +- + (10,16) (1 row) SELECT public.svar2; svar2 - (10,30) (1 row) I

Re: static libpq (and other libraries) overwritten on aix

2022-08-20 Thread Noah Misch
On Sat, Aug 20, 2022 at 01:35:22AM -0700, Andres Freund wrote: > Afaict there's no reason to generate lib.a for extension .so's, right? Right. We install cube.so, not any *cube.a file.

Re: Schema variables - new implementation for Postgres 15

2022-08-20 Thread Pavel Stehule
pá 19. 8. 2022 v 22:54 odesílatel Alvaro Herrera napsal: > > diff --git a/src/backend/parser/parse_relation.c > b/src/backend/parser/parse_relation.c > > index f6b740df0a..b3bee39457 100644 > > --- a/src/backend/parser/parse_relation.c > > +++ b/src/backend/parser/parse_relation.c > > @@ -3667,8

Re: Goodbye Windows XP

2022-08-20 Thread Andrew Dunstan
On 2022-08-13 Sa 16:49, Andrew Dunstan wrote: > For some time I have been nursing along my old Windows XP instance, > which nowadays only builds release 10, which is due to go to EOL in a > few months. The machine has suddenly started having issues with git, and > I'm not really inclined to

Re: static libpq (and other libraries) overwritten on aix

2022-08-20 Thread Andres Freund
Hi, On 2022-08-20 01:35:22 -0700, Andres Freund wrote: > I'll send in a patch series tomorrow, too tired for today. Here it goes. 0001 aix: Fix SHLIB_EXPORTS reference in VPATH builds That's mostly so I could even build. It's not quite right in the sense that we don't depend on the file,

Re: [RFC] building postgres with meson - v11

2022-08-20 Thread Andres Freund
Hi, On 2022-08-20 09:38:48 +0200, Peter Eisentraut wrote: > On 17.08.22 23:53, Andres Freund wrote: > > Any comment on the pg_regress_ecpg commit? I'd like to get that out of the > > way, and it seems considerably cleaner than the hackery we do right now to > > make VPATH builds work. > > That

Re: Strip -mmacosx-version-min options from plperl build

2022-08-20 Thread Andres Freund
Hi, On 2022-08-19 10:00:35 -0400, Tom Lane wrote: > Peter Eisentraut writes: > > After analyzing the source code of ExtUtils::Embed's ldopts, I think we > > can also do this by subtracting $Config{ldflags}, since > > my $linkage = "$ccdlflags $ldflags @archives $ld_or_bs"; > > and we really just

configure --with-uuid=bsd fails on NetBSD

2022-08-20 Thread Tom Lane
Our documentation claims that --with-uuid=bsd works on both FreeBSD and NetBSD: installation.sgml says bsd to use the UUID functions found in FreeBSD, NetBSD, and some other BSD-derived systems and there is comparable wording in uuid-ossp.sgml. In the course of setting up

Re: [RFC] building postgres with meson

2022-08-20 Thread Andres Freund
Hi, On 2022-08-09 08:37:16 -0400, Andrew Dunstan wrote: > On 2022-08-09 Tu 03:10, Andres Freund wrote: > > Hi, > > > > I was looking at re-unifying gendef2.pl that the meson patchset had > > introduced > > for temporary ease during hacking with gendef.pl. Testing that I noticed > > that > >

Re: configure --with-uuid=bsd fails on NetBSD

2022-08-20 Thread Tom Lane
Andres Freund writes: > On 2022-08-20 19:39:32 -0400, Tom Lane wrote: >> In the course of setting up a NetBSD buildfarm animal, I discovered >> that this is a lie. > Also recently reported as a bug: > https://postgr.es/m/17358-89806e7420797025%40postgresql.org > with a bunch of discussion. Ah,

Instrumented pages/tuples frozen in autovacuum's server log out (and VACUUM VERBOSE)

2022-08-20 Thread Peter Geoghegan
Attached is another autovacuum (and VACUUM VERBOSE) instrumentation patch. This one adds instrumentation about freezing to the report autovacuum makes to the server log. Specifically, it makes the output look like this: regression=# vacuum (freeze,verbose) foo; INFO: aggressively vacuuming

Re: [PATCH] Optimize json_lex_string by batching character copying

2022-08-20 Thread Nathan Bossart
On Fri, Aug 19, 2022 at 01:42:15PM -0700, Nathan Bossart wrote: > On Fri, Aug 19, 2022 at 03:11:36PM +0700, John Naylor wrote: >> This is done. Also: >> - a complete overhaul of the pg_lfind8* tests >> - using a typedef for the vector type >> - some refactoring, name changes and other cleanups (a

Re: Making Vars outer-join aware

2022-08-20 Thread Tom Lane
Progress report on this ... I've been trying to remove some of the cruftier aspects of EquivalenceClasses (which really is the main point of this whole effort), and gotten repeatedly blocked by the fact that the semantics are still a bit crufty thanks to the hacking associated with outer join

Re: configure --with-uuid=bsd fails on NetBSD

2022-08-20 Thread Andres Freund
Hi, On 2022-08-20 19:39:32 -0400, Tom Lane wrote: > Our documentation claims that --with-uuid=bsd works on both > FreeBSD and NetBSD: installation.sgml says > >bsd to use the UUID functions found in FreeBSD, > NetBSD, >and some other BSD-derived systems > > and there is

Re: Schema variables - new implementation for Postgres 15

2022-08-20 Thread Julien Rouhaud
On Sat, Aug 20, 2022 at 08:44:49PM +0200, Erik Rijkers wrote: > Op 20-08-2022 om 20:09 schreef Pavel Stehule: > > Hi > > > > > LET public.svar2 = (10, 20, 30); > > > ALTER TYPE public.svar_test_type DROP ATTRIBUTE b; > > > SELECT public.svar; > > > - svar > > > > > > - (10,) > > >

Re: Schema variables - new implementation for Postgres 15

2022-08-20 Thread Pavel Stehule
ne 21. 8. 2022 v 6:36 odesílatel Julien Rouhaud napsal: > On Sat, Aug 20, 2022 at 08:44:49PM +0200, Erik Rijkers wrote: > > Op 20-08-2022 om 20:09 schreef Pavel Stehule: > > > Hi > > > > > > > LET public.svar2 = (10, 20, 30); > > > > ALTER TYPE public.svar_test_type DROP ATTRIBUTE b; > > > >