On Fri, Aug 26, 2022 at 6:55 AM Thomas Munro wrote:
>
> Hi,
>
> We allow $SUBJECT on Windows. I'm not sure exactly how we finished up
> with that, maybe a historical mistake, but I find it misleading today.
> Modern Windows flushes drive write caches for fsync (= _commit()) and
> fdatasync (=
Hi,
On 2022-08-26 10:04:35 -0400, Andrew Dunstan wrote:
> On 2022-08-25 Th 18:13, Andres Freund wrote:
> >>> Could you show objdump -t of the library? Perhaps once with the flags as
> >>> now,
> >>> and once relinking with the "old" flags that we're now omitting?
> >>
> >> current:
> >>
> >>
>
>I agree. Testing StandbyMode here seems bogus. I thought initially
>that the test should perhaps be for InArchiveRecovery rather than
>ArchiveRecoveryRequested, but I see that the code which switches to a
>new timeline cares about ArchiveRecoveryRequested, so I think that is
>
Nazir Bilal Yavuz writes:
> Based on these discussions, I attached a patch.
This is the wrong way to go about it:
+#if defined(__NetBSD__)
+ ereport(ERROR, errmsg("NetBSD's uuid_create function generates "
+ "version-4 UUIDs
instead
On 2022-08-26 Fr 12:36, Jonathan S. Katz wrote:
> On 8/24/22 8:16 PM, Andrew Dunstan wrote:
>>
>> On 2022-08-24 We 20:05, Nikita Glukhov wrote:
>>>
>>>
>>> v8 - is a highly WIP patch, which I failed to finish today.
>>> Even some test cases fail now, and they simply show unfinished
>>> things
On 8/24/22 8:16 PM, Andrew Dunstan wrote:
On 2022-08-24 We 20:05, Nikita Glukhov wrote:
v8 - is a highly WIP patch, which I failed to finish today.
Even some test cases fail now, and they simply show unfinished
things like casts to bytea (they can be simply removed) and missing
safe input
Andres Freund writes:
> On 2022-08-26 10:04:35 -0400, Andrew Dunstan wrote:
>> On 2022-08-25 Th 18:13, Andres Freund wrote:
>>> Can you try adding just that to the flags for building and whether that then
>>> allows a LOAD 'plperl' to succeed?
>> Adding what?
> -Wl,--enable-auto-image-base
And
On Fri, Aug 26, 2022 at 11:55 AM Robert Haas wrote:
> According to pg_has_role, it's possible to have USAGE WITH ADMIN
> OPTION on a role without having USAGE:
One more thing about this. The documentation about how this function
actually works seems never to have been very good, and I think it's
>I think, however, that your fix is wrong and this one is right.
>Fundamentally, the server is either in normal running, or crash
>recovery, or archive recovery. Standby mode is just an optional
>behavior of archive recovery
Good point. Thanks for clearing my understanding.
Hi,
On 8/21/22 04:37, Tom Lane wrote:
Andres Freund writes:
Perhaps we should make them error out instead? It doesn't seem helpful to
just return something wrong...
Yeah, might be appropriate.
Based on these discussions, I attached a patch.
Thanks,
Nazir Bilal Yavuzdiff --git
According to pg_has_role, it's possible to have USAGE WITH ADMIN
OPTION on a role without having USAGE:
template1=# create role foo;
CREATE ROLE
template1=# create role admin;
CREATE ROLE
template1=# grant foo to admin with inherit false, admin true;
GRANT ROLE
template1=# select p.priv,
Here's a patch changing all occurrences of "admin option" in error
messages to "ADMIN OPTION".
Two of these five messages also exist in previous releases; the other
three are new.
I'm not sure if this is our final conclusion on what we want to do
here, so please speak up if you don't agree.
On 2022-08-26 Fr 12:11, Tom Lane wrote:
> Andres Freund writes:
>> On 2022-08-26 10:04:35 -0400, Andrew Dunstan wrote:
>>> On 2022-08-25 Th 18:13, Andres Freund wrote:
Can you try adding just that to the flags for building and whether that
then
allows a LOAD 'plperl' to succeed?
On Fri, Aug 26, 2022 at 11:59 AM Imseih (AWS), Sami wrote:
> >I agree. Testing StandbyMode here seems bogus. I thought initially
> >that the test should perhaps be for InArchiveRecovery rather than
> >ArchiveRecoveryRequested, but I see that the code which switches to a
> >new
On Thu, Aug 25, 2022 at 9:42 AM Peter Eisentraut
wrote:
> The postgres_fdw tests contain this (as amended by patch 0001):
>
> ALTER SERVER loopback_nopw OPTIONS (ADD password 'dummypw');
> ERROR: invalid option "password"
> HINT: Valid options in this context are: service, passfile,
>
Robert Haas writes:
> On Thu, Aug 25, 2022 at 9:42 AM Peter Eisentraut
> wrote:
>> HINT: Valid options in this context are: service, passfile,
>> channel_binding, connect_timeout, dbname, host, hostaddr, port, options,
>> application_name, keepalives, keepalives_idle, keepalives_interval,
>>
Em dom., 21 de ago. de 2022 às 21:15, Michael Paquier
escreveu:
> On Fri, Aug 19, 2022 at 02:22:32PM -0500, Justin Pryzby wrote:
> > If you trace the history back to a17923204, you'll see a comment about
> the
> > "zeroth slot", which makes it clear that the first slot it what's
> intended.
> >
On Thu, Aug 25, 2022 at 11:13:47PM -0700, Nathan Bossart wrote:
> Here is a new patch set that applies on top of v9-0001 in the
> json_lex_string patch set [0] and v3 of the is_valid_ascii patch [1].
Here is a rebased patch set that applies to HEAD.
--
Nathan Bossart
Amazon Web Services:
On Fri, Aug 26, 2022 at 7:01 AM Dilip Kumar wrote:
> While working on this solution I noticed one issue. Basically, the
> problem is that during binary upgrade when we try to rewrite a heap we
> would expect that “binary_upgrade_next_heap_pg_class_oid” and
>
On Thu, Aug 25, 2022 at 10:19 AM Robert Haas wrote:
> On Wed, Aug 24, 2022 at 10:23 AM tushar wrote:
> > On 8/24/22 12:28 AM, Robert Haas wrote:
> > > This patch needed to be rebased pretty extensively after commit
> > > ce6b672e4455820a0348214be0da1a024c3f619f. Here is a new version.
> >
On Fri, Aug 26, 2022 at 8:44 AM Dilip Kumar wrote:
> ArchiveRecoveryRequested is true. So in the below check[1] instead of
> (!StandbyMode), we can just put (! ArchiveRecoveryRequested), and then
> we don't need any other fix. Am I missing anything?
>
> [1]
> ReadRecord{
> ..record =
On 2022-08-25 Th 18:13, Andres Freund wrote:
> Hi,
>
> On 2022-08-25 18:04:34 -0400, Andrew Dunstan wrote:
>> On 2022-08-25 Th 17:47, Andres Freund wrote:
$ egrep '_PG_init|Pg_magic_func' plperl.i
extern __attribute__((visibility("default"))) void _PG_init(void);
extern
On Thu, Aug 25, 2022 at 4:41 PM Tom Lane wrote:
> Yeah, I'd lean against back-patching. This is the sort of behavioral
> change that users tend not to like finding in minor releases.
Here's a small patch. Despite the small size of the patch, there are a
couple of debatable points here:
1.
Hi,
On 2022-08-26 21:39:05 +0700, John Naylor wrote:
> On Fri, Aug 26, 2022 at 9:27 PM Andres Freund wrote:
> >
> > Because perl, extremely unhelpfully, #defines free. Which, not surprisingly,
> > causes issues when including system headers referencing free as well.
> >
> > I don't really see a
On Thu, Aug 25, 2022 at 5:26 PM Dilip Kumar wrote:
> I agree on this that this system is easy to explain that we just
> rewrite anything that conflicts so looks more future-proof. Okay, I
> will try this solution and post the patch.
While working on this solution I noticed one issue.
The last 20 some consecutive builds failed:
https://cirrus-ci.com/github/postgresql-cfbot/postgresql
like this:
[09:29:27.711] C:\Program Files (x86)\Windows
Kits\10\Include\10.0.20348.0\ucrt\malloc.h(159,17): error C2065: 'my_perl':
undeclared identifier (compiling source file
On Fri, Aug 26, 2022 at 9:27 PM Andres Freund wrote:
>
> Because perl, extremely unhelpfully, #defines free. Which, not surprisingly,
> causes issues when including system headers referencing free as well.
>
> I don't really see a good solution to this other than hoisting the
> mb/pg_wchar.h
On Tue, Aug 23, 2022 at 12:06 AM Robert Haas wrote:
>
However, if anything
> did try to look at file #4 it would get confused. Maybe that can
> happen if this is a streaming standby, where we only write an
> end-of-recovery record upon promotion, rather than a checkpoint, or
> maybe if there are
On Fri, Aug 26, 2022 at 10:06 AM Alvaro Herrera wrote:
> There's a small typo in the comment: "When find that". I suppose that
> was meant to be "When we find that". You end that para with "and thus
> we should not do this", but that sounds like it wouldn't matter if we
> did. Maybe "and thus
On Thu, Aug 25, 2022 at 5:55 PM Benjamin Coutu wrote:
>
> Hello,
>
> Inspired by the recent discussions[1][2] around sort improvements, I took a
> look around the code and noticed the use of a somewhat naive version of
> insertion sort within the broader quicksort code.
>
> The current
On Thu, Jul 07, 2022 at 01:56:39PM +0900, Michael Paquier wrote:
> On Thu, Jul 07, 2022 at 09:11:57AM +0900, Michael Paquier wrote:
> > Okay, thanks for confirming. I think that I'll give it a try today
> > then, my schedule would fit nicely with the buildfarm monitoring.
>
> And I have applied
Hi,
On 2022-08-26 06:40:47 -0700, Andres Freund wrote:
> On 2022-08-26 06:21:51 -0700, Andres Freund wrote:
> > On 2022-08-26 06:55:46 -0500, Justin Pryzby wrote:
> > > The last 20 some consecutive builds failed:
> > > https://cirrus-ci.com/github/postgresql-cfbot/postgresql
> > >
> > > like
Hi,
On 2022-08-26 06:21:51 -0700, Andres Freund wrote:
> On 2022-08-26 06:55:46 -0500, Justin Pryzby wrote:
> > The last 20 some consecutive builds failed:
> > https://cirrus-ci.com/github/postgresql-cfbot/postgresql
> >
> > like this:
> > [09:29:27.711] C:\Program Files (x86)\Windows
> >
On 30/6/2022 17:11, Andrey Lepikhov wrote:
On 19/5/2022 16:47, Ronan Dunklau wrote:
I'll take a look at that one.
New version of the patch, rebased on current master:
1. pgindent over the patch have passed.
2. number of changed files is reduced.
3. Some documentation and comments is added.
Hi
On Thu, 25 Aug 2022 at 01:44, David Rowley wrote:
> On Thu, 25 Aug 2022 at 03:03, Bruce Momjian wrote:
> >
> > On Wed, Aug 24, 2022 at 04:01:21PM +0100, Dave Page wrote:
> > > On Wed, 24 Aug 2022 at 15:18, Bruce Momjian wrote:
> > > Would it be simpler to allow the sequential and index
Hi,
At function has_matching_range, if variable ranges->nranges == 0,
we exit quickly with a result equal to false.
This means that nranges can be zero.
It occurs then that it is possible then to occur an array out of bonds, in
the initialization of the variable maxvalue.
So if nranges is equal
Hi,
On 2022-08-26 06:55:46 -0500, Justin Pryzby wrote:
> The last 20 some consecutive builds failed:
> https://cirrus-ci.com/github/postgresql-cfbot/postgresql
>
> like this:
> [09:29:27.711] C:\Program Files (x86)\Windows
> Kits\10\Include\10.0.20348.0\ucrt\malloc.h(159,17): error C2065:
On 2022-Aug-26, Robert Haas wrote:
> I agree. Testing StandbyMode here seems bogus. I thought initially
> that the test should perhaps be for InArchiveRecovery rather than
> ArchiveRecoveryRequested, but I see that the code which switches to a
> new timeline cares about ArchiveRecoveryRequested,
> convenient if you know the type at compile time. See the attached,
> which I had laying around when I was looking at PDQuicksort. I believe
> it's similar to what you have in mind.
That looks very promising.
I also love your recent proposal of partitioning into null and non-null. I
suspect
Andres Freund writes:
> Tom, Ilmari, you seem to have hacked on this stuff most (not so) recently. Do
> you have a better suggestion than moving the mb/pg_wchar.h include out of
> plperl_helpers.h as I suggest below?
I agree with the conclusion that we'd better #include all our own
headers
On Sat, Aug 27, 2022 at 12:17 AM Magnus Hagander wrote:
> So, I don't know how it works now, but the history at least was this:
> it was not about the disk caches, it was about raid controller caches.
> Basically, we determined that windows didn't fsync it all the way. But
> it would with But if
On Fri, Aug 26, 2022 at 06:26:37AM -0500, Justin Pryzby wrote:
> If I'm not wrong, there's some lingering comments which could be removed since
> 495ed0ef2.
It seems to me that you are right. I have not thought about looking
at references to NT. Good catches!
> src/bin/pg_ctl/pg_ctl.c: * on
Andrew Dunstan writes:
> On 2022-08-26 Fr 12:11, Tom Lane wrote:
>> And if that doesn't help, try -Wl,--export-all-symbols
> worked
Hmph. Hard to see how that isn't a linker bug. As a stopgap
to get the farm green again, I propose adding something like
ifeq ($(PORTNAME), cygwin)
SHLIB_LINK
On Thu, Aug 25, 2022 at 08:29:43PM -0700, Andres Freund wrote:
> It's really not great that 7f3e17b4827 disabled randomization without even a
> comment as to why...
This story is on this thread, with some processes not able to start:
Hi,
Tom, Ilmari, you seem to have hacked on this stuff most (not so) recently. Do
you have a better suggestion than moving the mb/pg_wchar.h include out of
plperl_helpers.h as I suggest below?
On 2022-08-26 07:47:40 -0700, Andres Freund wrote:
> On 2022-08-26 21:39:05 +0700, John Naylor wrote:
>
On 2022-08-26 Fr 16:00, Tom Lane wrote:
> Andrew Dunstan writes:
>> On 2022-08-26 Fr 12:11, Tom Lane wrote:
>>> And if that doesn't help, try -Wl,--export-all-symbols
>> worked
> Hmph. Hard to see how that isn't a linker bug. As a stopgap
> to get the farm green again, I propose adding
On 2022-08-26 Fr 10:47, Andres Freund wrote:
> Hi,
>
> On 2022-08-26 21:39:05 +0700, John Naylor wrote:
>> On Fri, Aug 26, 2022 at 9:27 PM Andres Freund wrote:
>>> Because perl, extremely unhelpfully, #defines free. Which, not surprisingly,
>>> causes issues when including system headers
On Sat, Aug 27, 2022 at 4:15 AM Andres Freund wrote:
>
> Hi,
>
> On 2022-08-26 17:05:52 -0400, Andrew Dunstan wrote:
> > On 2022-08-26 Fr 10:47, Andres Freund wrote:
> > > Given the crazy defines of stuff like free, it seems like a good idea to
> > > have
> > > a rule that no headers should be
On Wed, Jan 05, 2022 at 06:12:26PM -0600, Justin Pryzby wrote:
> On Wed, Jan 05, 2022 at 06:51:37PM -0500, Bruce Momjian wrote:
> > On Tue, Jan 4, 2022 at 10:22:50PM +, Finnerty, Jim wrote:
> > > I'm concerned about the maintainability impact of having 2 new
> > > on-disk page formats. It's
Michael Paquier writes:
> Indeed. 45e004f looks like the most interesting bit here. FWIW, I
> would not mind re-enabling that on HEAD, as of something like the
> attached. I have done a dozen of runs without seeing a test failure,
> and knowing that we don't support anything older than Win10
On Sat, Aug 27, 2022 at 10:02 AM Tom Lane wrote:
>
> John Naylor writes:
> > On Sat, Aug 27, 2022 at 4:15 AM Andres Freund wrote:
> >> I think it'd also be needed in hstore_plperl.c, jsonb_plperl.c. Putting the
> >> include in plperl.h would keep that aspect transparent, because
> >>
Hi,
Thanks for working on this.
+htup = (HeapTupleHeader) PageGetItem(ctx.page, rditem);
+if (!(HeapTupleHeaderIsHeapOnly(htup) &&
htup->t_infomask & HEAP_UPDATED))
+report_corruption(,
+
Hi,
On 2022-08-26 17:05:52 -0400, Andrew Dunstan wrote:
> On 2022-08-26 Fr 10:47, Andres Freund wrote:
> > Given the crazy defines of stuff like free, it seems like a good idea to
> > have
> > a rule that no headers should be included after plperl.h with
> > PG_NEED_PERL_XSUB_H defined. It's
John Naylor writes:
> On Sat, Aug 27, 2022 at 4:15 AM Andres Freund wrote:
>> I think it'd also be needed in hstore_plperl.c, jsonb_plperl.c. Putting the
>> include in plperl.h would keep that aspect transparent, because
>> plperl_utils.h
>> includes plperl.h.
> Since plperl_helpers.h already
On Fri, Aug 26, 2022 at 01:54:26PM -0300, Ranier Vilela wrote:
> Is it worth creating a commiffest?
Don't think so, but feel free to create one and mark me as committer
if you think that's appropriate. I have marked this thread as
something to do soon-ishly, but I am being distracted by life
On Sat, Aug 27, 2022 at 11:20 AM John Naylor
wrote:
>
> Here's a patch with that idea, not tested on Windows yet.
Update: I tried taking the CI for a spin, but ran into IT issues with
Github when I tried to push my branch to remote.
--
John Naylor
EDB: http://www.enterprisedb.com
Hi,
On 2022-08-26 16:00:31 -0400, Tom Lane wrote:
> Andrew Dunstan writes:
> > On 2022-08-26 Fr 12:11, Tom Lane wrote:
> >> And if that doesn't help, try -Wl,--export-all-symbols
>
> > worked
Except that it's only happening for plperl, I'd wonder if it's possibly
related to our magic symbols
On 2022-08-26 Fr 16:11, Nikita Glukhov wrote:
>
> Hi,
>
> On 26.08.2022 22:25, Andrew Dunstan wrote:
>> On 2022-08-24 We 20:05, Nikita Glukhov wrote:
>>> v8 - is a highly WIP patch, which I failed to finish today.
>>> Even some test cases fail now, and they simply show unfinished
>>> things like
Hi,
For v36-0001-Remove-self-joins.patch :
bq removes inner join of plane table to itself
plane table -> plain table
For relation_has_unique_index_ext(), it seems when extra_clauses is NULL,
there is no need to compute `exprs`.
Cheers
>
At Fri, 26 Aug 2022 10:25:17 +0200, Alvaro Herrera
wrote in
> Typically the translations are updated from the pgtranslation repository
> on Monday of the release week, at around noon European time. You can
> keep translating till the previous Sunday if you feel like it :-)
Yeah... . .
So..
Re: Daniel Gustafsson
> The attached adds the Exit Status section to pg_recvlogical docs which is
> present in pg_receivewal to make them more aligned, and tweaks comments to
> pgindent standards. This is the version I think is ready to commit.
Looks good to me.
Thanks,
Christoph
Dear David,
On Fri, Aug 26, 2022 at 12:18 PM David Rowley wrote:
> How about instead of doing this caching like this, why don't we code
> up some iterators that we can loop over to fetch the required EMs.
Thank you very much for your quick reply and for sharing your idea
with code. I also think
Hello Kyotaro,
On Fri, 26 Aug 2022 at 10:04, Kyotaro Horiguchi
wrote:
> > With archive_mode = always you can't reproduce it.
> > It is very rarely people set it to always in production due to the
> overhead.
> ...
> > The archive_mode has to be set to on and the archive_command should be
> >
On Fri, Aug 26, 2022 at 10:26 AM Nathan Bossart
wrote:
>
> On Thu, Aug 25, 2022 at 04:41:53PM +0700, John Naylor wrote:
> > v3 applies on top of the v9 json_lex_string patch in [1] and adds a
> > bit more to that, resulting in a simpler patch that is more amenable
> > to additional SIMD-capable
On 2022-Aug-26, Kyotaro Horiguchi wrote:
> At Fri, 26 Aug 2022 10:25:17 +0200, Alvaro Herrera
> wrote in
> > Typically the translations are updated from the pgtranslation repository
> > on Monday of the release week, at around noon European time. You can
> > keep translating till the previous
On Thu, Aug 25, 2022 at 1:35 PM John Naylor
wrote:
>
> I think I'll go ahead and commit 0001 in a couple days pending further
> comments.
Pushed with Nathan's correction and some cosmetic rearrangements.
--
John Naylor
EDB: http://www.enterprisedb.com
(Moved to -hackers)
At Thu, 25 Aug 2022 10:34:40 +0200, Alexander Kukushkin
wrote in
> > # killall -9 postgres
> > # rm -r oldprim newprim oldarch newarch oldprim.log newprim.log
> > mkdir newarch oldarch
> > initdb -k -D oldprim
> > echo "archive_mode = 'always'">> oldprim/postgresql.conf
> >
> Won't the same thing can happen for similar publication commands? Why
> is this unique to the subscription and not other Alter/Drop commands?
I indeed don't think this problem is unique to subscriptions, but it seems
better to at least have this problem in a few places less (not making perfect
Hi KaiGai-san,
On Tue, Aug 23, 2022 at 6:26 PM Kohei KaiGai wrote:
> I internally suggested him to expand the ctidscan module for the PoC purpose.
> https://github.com/kaigai/ctidscan
>
> Even though it does not have asynchronous capability actually, but
> suitable to ensure
> API works and
On 2022-Aug-26, Kyotaro Horiguchi wrote:
> It's a mistake of "には". I'll load it into the next ship. The next
> release is 9/8 and I'm not sure the limit of translation commits for
> the release, though..
Typically the translations are updated from the pgtranslation repository
on Monday of the
Hi hackers,
During the work in [1] we created a new TAP test to test the SYSTEM_USER
behavior with peer authentication.
It turns out that there is currently no TAP test for the peer
authentication, so we think (thanks Michael for the suggestion [2]) that
it's better to split the work in [1]
Here is a new patch set that applies on top of v9-0001 in the
json_lex_string patch set [0] and v3 of the is_valid_ascii patch [1].
[0]
https://postgr.es/m/CAFBsxsFV4v802idV0-Bo%3DV7wLMHRbOZ4er0hgposhyGCikmVGA%40mail.gmail.com
[1]
Hi,
On Mon, Apr 4, 2022 at 11:46 PM Andres Freund wrote:
>
> I think there's a few more things that'd be good to check. For example
> amcheck
> doesn't verify that HOT chains are reasonable, which can often be spotted
> looking at an individual page. Which is a bit unfortunate, given how many
>
At Fri, 26 Aug 2022 14:28:26 +0900, torikoshia
wrote in
> "
> > #: gram.y:1588 gram.y:1604
> > #, c-format
> > msgid "CREATE SCHEMA IF NOT EXISTS cannot include schema elements"
> > -msgstr "CREATE SCHEMA IF NOT EXISTSんはスキーマ要素を含めることはでき
> > -ません"
> > +msgstr "CREATE SCHEMA IF NOT
On 2022-08-26 14:07, Kyotaro Horiguchi wrote:
At Fri, 26 Aug 2022 10:23:01 +0900, Shinya Kato
wrote in
I've found typos in ja.po, and fixed them.
The patch is attached.
(This is not for -hackers but I'm fine with it being posted here;p)
Sorry, I didn't know there was an pgsql-translators.
On 2022-08-26 15:20, Kyotaro Horiguchi wrote:
At Fri, 26 Aug 2022 14:28:26 +0900, torikoshia
wrote in
> #: gram.y:1588 gram.y:1604
> #, c-format
> msgid "CREATE SCHEMA IF NOT EXISTS cannot include schema elements"
> -msgstr "CREATE SCHEMA IF NOT EXISTSんはスキーマ要素を含めることはでき
> -ません"
> +msgstr
76 matches
Mail list logo
