Re: How can end users know the cause of LR slot sync delays?

2025-09-18 Thread Ashutosh Sharma
Hi Amit, On Thu, Sep 18, 2025 at 11:31 AM Amit Kapila wrote: > > On Wed, Sep 17, 2025 at 8:19 PM Ashutosh Sharma wrote: > > > > On Wed, Sep 17, 2025 at 5:14 PM Amit Kapila wrote: > > > > > > On Wed, Sep 17, 2025 at 4:24 PM Hayato Kuroda (Fujitsu) > > > wrote: > > > > > > > > Dear Shlok, > > >

Re: Incorrect logic in XLogNeedsFlush()

2025-09-18 Thread Michael Paquier
On Wed, Sep 17, 2025 at 09:23:05PM -0400, Melanie Plageman wrote: > In terms of comments, I think it is best to update the comment above > XLogNeedsFlush(). Something like : > > /* > - * Test whether XLOG data has been flushed up to (at least) the given > position. > + * Test whether XLOG data h

Re: [BUG] temporary file usage report with extended protocol and unnamed portals

2025-09-18 Thread Michael Paquier
On Tue, Sep 16, 2025 at 02:13:39PM -0500, Sami Imseih wrote: > Also, the tests should be checking that we are logging "temporary file: " > before the next statement is logged. > > I split up the actual fix and the corrected tests into separate patches. > They can be committed together if there is

Re: Should io_method=worker remain the default?

2025-09-18 Thread Jeff Davis
On Mon, 2025-09-08 at 14:39 +1200, Thomas Munro wrote: > Some raw thoughts on this topic, and how we got here:  This type of > extreme workload, namely not doing any physical I/O, just copying the > same data from the kernel page cache to the buffer pool over and over > again, Isn't that one of th

Re: [WIP]Vertical Clustered Index (columnar store extension) - take2

2025-09-18 Thread Japin Li
On Thu, 18 Sep 2025 at 15:07, Peter Smith wrote: > Hi Timur, > > Thanks for your ongoing work for this patch. > > On Thu, Sep 18, 2025 at 1:15 AM Timur Magomedov > wrote: > ... >> I've found (using valgrind) some cases of reading random garbage after >> allocated memory. Investigation showed this

RE: [Patch] add new parameter to pg_replication_origin_session_setup

2025-09-18 Thread Hayato Kuroda (Fujitsu)
Dear hackers, > I considered a test, please see attached files. 0001 was not changed from v6 > and > 0002 contained tests. Here, two sessions were opened and confirmed that they > can > set the same origin. After considering and verifying more, it is more efficient to test via isolation tester.

Re: [PATCH] jit: fix build with LLVM-21

2025-09-18 Thread Anthonin Bonnefoy
Hi, I've tested the patch: it fixes the compilation on arm and I'm correctly linked to llvm21: ldd /var/lib/postgresql/.local/lib/llvmjit.so | grep libLLVM libLLVM.so.21.1 => /lib/aarch64-linux-gnu/libLLVM.so.21.1 (0xec34112d) Testing the query that used to trigger the jit segfau

Re: Clear logical slot's 'synced' flag on promotion of standby

2025-09-18 Thread Ashutosh Sharma
Hi Ajin, On Thu, Sep 18, 2025 at 4:16 PM Ajin Cherian wrote: > > On Fri, Sep 12, 2025 at 1:56 PM shveta malik wrote: > > > > The approach seems valid and should work, but introducing a new file > > like promote.inprogress for this purpose might be excessive. We can > > first try analyzing existi

Re: someone else to do the list of acknowledgments

2025-09-18 Thread Peter Eisentraut
On 18.09.25 10:14, Daniel Gustafsson wrote: On 18 Sep 2025, at 07:02, Corey Huinker wrote: These have been updated. I'm holding off on releasing the update files pending Daniel sending me a list of known preferred names. I'll release another file after I've integrated that list into my proc

Re: Update Windows CI Task Names: Server 2022 + VS 2022 Upgrade

2025-09-18 Thread Andres Freund
Hi, On 2025-09-15 11:50:07 +0300, Nazir Bilal Yavuz wrote: > On Thu, 11 Sept 2025 at 17:55, Jacob Champion > wrote: > > > > On Thu, Sep 11, 2025 at 7:18 AM Peter Eisentraut > > wrote: > > > I don't think we need this level of complication. We already have the > > > situation that for example "

Re: [PATCH] Check that index can return in get_actual_variable_range()

2025-09-18 Thread Aleksander Alekseev
Hi Maxime, > Some recent changes were made to remove the explicit dependency on btree > indexes in some parts of the code. One of these changes was made in commit > 9ef1851685b, which allows non-btree indexes to be used in > get_actual_variable_range(). A follow-up commit ee1ae8b99f9 fixes the

Re: someone else to do the list of acknowledgments

2025-09-18 Thread Daniel Gustafsson
> On 18 Sep 2025, at 14:25, Peter Eisentraut wrote: > > On 18.09.25 10:14, Daniel Gustafsson wrote: >>> On 18 Sep 2025, at 07:02, Corey Huinker wrote: >>> These have been updated. I'm holding off on releasing the update files >>> pending Daniel sending me a list of known preferred names. I'll r

Re: Query Performance Degradation Due to Partition Scan Order – PostgreSQL v17.6

2025-09-18 Thread Ashutosh Bapat
On Mon, Sep 8, 2025 at 5:09 PM Vivek Gadge wrote: > > > For example, when a query runs on a partitioned table, PostgreSQL scans > partitions in the order they were created or attached to the parent table. In > our case (monthly partitions from January through September), this means that > queri

Re: [BUG] temporary file usage report with extended protocol and unnamed portals

2025-09-18 Thread Frédéric Yhuel
Sorry for the late reply. On 8/29/25 20:27, Sami Imseih wrote: This version needs another rebase, but I don't think this is a proper solution yet. It's dropping the portal in an area I don't think we should be concerned with, You might be right, I don't know... my understanding of the code isn

Re: OAuth client code doesn't work with Google OAuth

2025-09-18 Thread Zsolt Parragi
> My overall position is this, let me know what you think about it: I'm > fine with supporting the Google-flavor handshake. That's life, and we > already have some code that deals with variant spellings. But if the > end result is a system that still can't safely authorize clients, I'm > much less

Re: someone else to do the list of acknowledgments

2025-09-18 Thread Corey Huinker
> > > all looks good, except that I can can not found these 3 names: > Emanuel Ionescu (do you mean commit > 4200fea80e79851994b8eb5a64a3d4420456c977) > Jorge Solórzano > Gunnar Wagner > I think those all came from Daniel's list of corrections, which didn't have commit granularity.

Re: [PATCH] Check that index can return in get_actual_variable_range()

2025-09-18 Thread Maxime Schoemans
On 18 Sep 2025, at 15:36, Mark Dilger wrote: > > Testing with the src/test/modules/treeb work in the patch series at [1], > modifying treebcanreturn() to always return false and modifying > _treeb_first(), _treeb_next(), and _treeb_endpoint() to set scan->xs_itup to > NULL rather than to a t

Re: PG 18 relnotes and RC1

2025-09-18 Thread Jonathan S. Katz
On 9/17/25 2:51 PM, Jonathan S. Katz wrote: On Sep 17, 2025, at 2:47 PM, Peter Eisentraut wrote: On 31.08.25 05:02, Nathan Bossart wrote: On Sat, Aug 30, 2025 at 05:56:12PM -0400, Bruce Momjian wrote: On Sat, Aug 30, 2025 at 03:02:10PM -0500, Nathan Bossart wrote: The 18beta1 announcement

Re: Make COPY format extendable: Extract COPY TO format implementations

2025-09-18 Thread Masahiko Sawada
On Tue, Sep 9, 2025 at 7:41 PM Sutou Kouhei wrote: > > Hi, > > In > "Re: Make COPY format extendable: Extract COPY TO format implementations" > on Tue, 9 Sep 2025 13:15:43 -0700, > Masahiko Sawada wrote: > > >> I don't object your approach but we need a good way to > >> measure performance.

Re: someone else to do the list of acknowledgments

2025-09-18 Thread jian he
On Thu, Sep 18, 2025 at 1:02 PM Corey Huinker wrote: >> > So here's the updated. > > This was done against the git log REL_17_STABLE..REL_18_STABLE, > as of 2d756ebbe857e3d395d18350bf232300ebd23981 on master and > a7024398b80a836a83c00af42c6ab7cc25c12087 on REL_18_STABLE. > Hacking Discord shou

Re: someone else to do the list of acknowledgments

2025-09-18 Thread Corey Huinker
On Thu, Sep 18, 2025 at 9:33 AM jian he wrote: > On Thu, Sep 18, 2025 at 1:02 PM Corey Huinker > wrote: > >> > > So here's the updated. > > > > This was done against the git log REL_17_STABLE..REL_18_STABLE, > > as of 2d756ebbe857e3d395d18350bf232300ebd23981 on master and > a7024398b80a836a83c0

Re: PG 18 relnotes and RC1

2025-09-18 Thread Robert Haas
On Thu, Sep 18, 2025 at 12:09 PM Jonathan S. Katz wrote: > Please see attached draft for the major features of PostgreSQL 18. I like Nathan's version better. I suggest we go with that one. -- Robert Haas EDB: http://www.enterprisedb.com

Re: PG 18 relnotes and RC1

2025-09-18 Thread Jonathan S. Katz
> On Sep 18, 2025, at 12:20 PM, Robert Haas wrote: > > On Thu, Sep 18, 2025 at 12:09 PM Jonathan S. Katz > wrote: >> Please see attached draft for the major features of PostgreSQL 18. > > I like Nathan's version better. I suggest we go with that one. Why? This seems arbitrary without mor

Re: PgStat_HashKey padding issue when passed by reference

2025-09-18 Thread Sami Imseih
> I still want to add it, but it also seemed like you were not much a > fan of it, so I did not really want to push forward with something > that was not loved. :D > > Addressing your points, attached is an updated patch labelled v2. I was not a fan of it, when my idea was to allow flexibility in

Re: POC: make mxidoff 64 bits

2025-09-18 Thread Maxim Orlov
On Tue, 16 Sept 2025 at 15:12, wenhui qiu wrote: > > Agree +1 , but I have a question: I remember the XID64 patch got split > into a few threads. How are these threads related? The original one was > seen as too big a change, so it was broken up after people raised > concerns. > Yeah, you're abso

Re: someone else to do the list of acknowledgments

2025-09-18 Thread jian he
On Thu, Sep 18, 2025 at 1:02 PM Corey Huinker wrote: >> > > So here's the updated. > > This was done against the git log REL_17_STABLE..REL_18_STABLE, > as of 2d756ebbe857e3d395d18350bf232300ebd23981 on master and > a7024398b80a836a83c00af42c6ab7cc25c12087 on REL_18_STABLE. > hi. I double check

Re: PG 18 release notes draft committed

2025-09-18 Thread Bruce Momjian
On Wed, Sep 17, 2025 at 04:45:14PM -0400, Bruce Momjian wrote: > On Wed, Sep 17, 2025 at 11:46:58AM -0400, Peter Geoghegan wrote: > > I suggest the following alternative, which has the merit of being a > > bit less verbose: > > > > "Skip scan allows B-Tree index scans to find the most efficient wa

Re: PG 18 relnotes and RC1 - (typo)

2025-09-18 Thread Erik Rijkers
Op 9/18/25 om 18:08 schreef Jonathan S. Katz: Please see attached draft for the major features of PostgreSQL 18. [...] > [v2-0001-add-major-features-to-v18-release-notes.patch] One typo: that can improves throughput should be that can improve throughput Erik

Re: RFC: adding pytest as a supported test framework

2025-09-18 Thread Jacob Champion
On Tue, Sep 9, 2025 at 2:50 PM Jacob Champion wrote: > When enabling the feature, the check_pytest.py script checks that the > configured `PYTHON` executable has all of pytest-requirements.txt > installed. Peter pointed out that this is incorrect: what we actually > want to check is that the inter

Re: PG 18 relnotes and RC1

2025-09-18 Thread Jonathan S. Katz
On 9/18/25 2:19 PM, Nathan Bossart wrote: On Thu, Sep 18, 2025 at 01:38:44PM -0400, Robert Haas wrote: That seems completely backwards to me. We should go with the version that was submitted weeks ago and upon which people have had the opportunity to comment unless you can justify each change th

Re: Mark ItemPointer arguments as const thoughoutly

2025-09-18 Thread Nazir Bilal Yavuz
Hi, On Wed, 10 Sept 2025 at 05:27, Chao Li wrote: > > Hi Hacker, > > This is a follow up 991295f. I searched over the src/ and make all > ItemPointer arguments as const as much as possible. > > I made clean build and no waring found. And "make check" also passes. I will > create a patch on CF t

Re: Fix missing EvalPlanQual recheck for TID scans

2025-09-18 Thread David Rowley
On Tue, 9 Sept 2025 at 04:36, Sophie Alpert wrote: > I've added a new trss_boundsInitialized flag such that we calculate the range > once per EPQ rescan. In order to preserve the semantics when the min or max > is NULL, I'm setting trss_mintid/trss_maxtid to have invalid ItemPointers as > a sen

Re: race condition in pg_class

2025-09-18 Thread Tom Lane
[ blast-from-the-past department ] Noah Misch writes: > I'm attaching patches implementing the LockTuple() design. inplace010-tests-v1.patch from this message, committed as 0844b3968, contains this bit: new file mode 100644 index 000..0367c0e37ab --- /dev/null +++ b/src/test/regress/sql

Re: PG 18 relnotes and RC1

2025-09-18 Thread Robert Haas
On Thu, Sep 18, 2025 at 12:59 PM Jonathan S. Katz wrote: > > I like Nathan's version better. I suggest we go with that one. > > Why? This seems arbitrary without more details. > > I’ve spent the past several weeks staring at the release notes, talking to > users, and putting together a presentati

Re: pg_restore --no-policies should not restore policies' comment

2025-09-18 Thread jian he
On Tue, Sep 9, 2025 at 12:00 PM Fujii Masao wrote: > > On Thu, Sep 4, 2025 at 6:00 PM jian he wrote: > > in _tocEntryRestorePass > > if we do > > > > if ((strcmp(te->desc, "COMMENT") == 0 || > > strcmp(te->desc, "SECURITY LABEL") == 0) && > > strncmp(te->tag, "EVENT TRIGGER "

CopyMultiInsertInfo.bufferedBytes is not increased in binary format cases

2025-09-18 Thread Masahiko Sawada
Hi, When using the multi insertion method during COPY FROM, we buffer input tuples until the number of tuples exceeds MAX_BUFFERED_TUPLES (=1000) or the total buffered tuple size exceeds MAX_BUFFERED_BYTES (=64kB). We use line_buf.len as input tuple size as follows and add it to bufferedBytes:

[PATCH] Accept connections post recovery without waiting for RemoveOldXlogFiles

2025-09-18 Thread Nitin Motiani
Hi Hackers, I'd like to propose a patch to allow accepting connections post recovery without waiting for the removal of old xlog files. *Why* : We have seen instances where the *crash recovery takes very long (tens of minutes to hours) *if a large number of accumulated WAL files need to be cleane

Re: [PATCH] Add tests for Bitmapset

2025-09-18 Thread Greg Burd
I've re-written the set of tests as suggested (I hope!). I've not re-run the coverage report (yet) to ensure we're at least as well covered as v3, but attached is v4 for your inspection (amusement?). I've tried to author the SQL tests such that failures clearly indicate what's at gone wrong. Thi

Re: Invalid primary_slot_name triggers warnings in all processes on reload

2025-09-18 Thread Fujii Masao
On Thu, Sep 18, 2025 at 10:54 PM Fujii Masao wrote: > > On Fri, Sep 12, 2025 at 9:12 PM Fujii Masao wrote: > > > > Hi, > > > > While reviewing the patch at [1], I noticed that if primary_slot_name is > > set to an invalid slot name in postgresql.conf and the configuration file > > is reloaded, al

Re: eliminate xl_heap_visible to reduce WAL (and eventually set VM on-access)

2025-09-18 Thread Andres Freund
Hi, On 2025-09-17 20:10:07 -0400, Melanie Plageman wrote: > 0001 is RFC but waiting on one other reviewer > From cacff6c95e38d370b87148bc48cf6ac5f086ed07 Mon Sep 17 00:00:00 2001 > From: Melanie Plageman > Date: Tue, 17 Jun 2025 17:22:10 -0400 > Subject: [PATCH v14 01/24] Eliminate COPY FREEZE u

Updating IPC::Run in CI?

2025-09-18 Thread Jacob Champion
Hi all, Andres pointed out that one of my new OAuth tests has flaked on NetBSD [1]. The final line of debugging output is missing from the stderr coming from psql. I haven't ruled out a bug in my implementation, but I also remembered that there was some discussion on the list about stderr being l

Re: GB18030-2022 Support in PostgreSQL

2025-09-18 Thread John Naylor
On Thu, Sep 18, 2025 at 3:16 PM Chao Li wrote: > > When you say “communicate how to detect incompatibility for existing > systems”, what would be the communication channel? I am actually very new to > the PG development community, your guidance will be greatly appreciated. My first thought was

Re: ReadRecentBuffer() doesn't scale well

2025-09-18 Thread Andres Freund
Hi, On 2023-06-30 14:13:11 +1200, Thomas Munro wrote: > > I do wonder if we should have an unlocked pre-check for a) the buffer being > > valid and b) BufferTagsEqual() matching. With such a pre-check the race for > > increasing the usage count of the wrong buffer is quite small, without the > >

Re: Parallel heap vacuum

2025-09-18 Thread Masahiko Sawada
On Wed, Sep 17, 2025 at 5:24 PM Tomas Vondra wrote: > > > > On 9/18/25 01:18, Masahiko Sawada wrote: > > For your information, while the implementation itself is relatively > > straightforward, we're still facing one unresolved issue; the system > > doesn't support reloading the configuration file

Re: Eager aggregation, take 3

2025-09-18 Thread Richard Guo
On Fri, Sep 5, 2025 at 10:12 PM Robert Haas wrote: > On Wed, Aug 6, 2025 at 3:52 AM Richard Guo wrote: > > What we really want to exclude are aggregate functions that can > > produce large transition values by accumulating or concatenating input > > rows. So I'm wondering if we could instead che

Re: [PATCH] Add tests for Bitmapset

2025-09-18 Thread Greg Burd
Hello hackers, :) Thanks for all the feedback and time spent reviewing this patch. I switched out the encode/decode functions to use the nodeToString() and stringToNode() functions and change all the SQL testing function signatures to TEXT from BYTEA. This exercises more code and that's good for

Check for availability of docbookx.dtd

2025-09-18 Thread Andrey Teplitskiy
Hi! This patch adds a pre-check to meson for the ability to use docbookx.dtd to avoid obscure errors when the docbook-xsl package is missing from the OS. -- Andrey Teplitskiy Postgres Professional diff --git a/doc/build/check-dtd.xml b/doc/build/check-dtd.xml new file mode 100644 index 000

Re: [Patch] add new parameter to pg_replication_origin_session_setup

2025-09-18 Thread Amit Kapila
On Thu, Sep 18, 2025 at 1:07 PM Hayato Kuroda (Fujitsu) wrote: > > Dear hackers, > > > I considered a test, please see attached files. > Few comments: 1. +step "s0_compare" { +SELECT s0.lsn < s1.lsn +FROM local_lsn_store as s0, local_lsn_store as s1 +WHERE s0.session = 0 AND s1.sessio

Re: Updating IPC::Run in CI?

2025-09-18 Thread Nazir Bilal Yavuz
Hi, On Thu, 18 Sept 2025 at 21:18, Andres Freund wrote: > > Hi, > > On 2025-09-18 10:08:49 -0700, Jacob Champion wrote: > > Andres pointed out that one of my new OAuth tests has flaked on NetBSD > > [1]. The final line of debugging output is missing from the stderr > > coming from psql. > > > > I

Re: Fixing MSVC's inability to detect elog(ERROR) does not return

2025-09-18 Thread David Rowley
On Wed, 17 Sept 2025 at 16:03, Tom Lane wrote: > > David Rowley writes: > > On Wed, 3 Sept 2025 at 23:32, Peter Eisentraut wrote: > >> Btw., I think we should stick to the *_p() naming (for "predicate", I > >> think) for compiler-intrinsic-affiliated functions/macros that report > >> boolean res

Re: someone else to do the list of acknowledgments

2025-09-18 Thread Álvaro Herrera
On 2025-Sep-18, Corey Huinker wrote: > Álvaro Mongil Hmm, where does this name come from? I can't find it anywhere. [... trolls logs ...] ah, did you get it on private email from alv...@datadoghq.com ? -- Álvaro HerreraBreisgau, Deutschland — https://www.EnterpriseDB.com/ Si no sab

Re: Reword messages using "as" instead of "because"

2025-09-18 Thread Tom Lane
Amit Kapila writes: > Yeah, this sounds clear but shall we consider using > max_retention_duration like: "Retention is re-enabled because the > apply process has caught up with the publisher within the configured > max_retention_duration.". We can have a single message if we don't > want to specif

Re: Invalid primary_slot_name triggers warnings in all processes on reload

2025-09-18 Thread Fujii Masao
On Fri, Sep 12, 2025 at 9:12 PM Fujii Masao wrote: > > Hi, > > While reviewing the patch at [1], I noticed that if primary_slot_name is > set to an invalid slot name in postgresql.conf and the configuration file > is reloaded, all running postgres processes emit the WARNING message > as follows. I

Re: Changing shared_buffers without restart

2025-09-18 Thread Andres Freund
Hi, On 2025-09-18 09:52:03 -0400, Andres Freund wrote: > On 2025-09-18 10:25:29 +0530, Ashutosh Bapat wrote: > > From 0a55bc15dc3a724f03e674048109dac1f248c406 Mon Sep 17 00:00:00 2001 > > From: Dmitrii Dolgov <9erthali...@gmail.com> > > Date: Fri, 4 Apr 2025 21:46:14 +0200 > > Subject: [PATCH 04/1

Re: GB18030-2022 Support in PostgreSQL

2025-09-18 Thread Chao Li
> On Sep 18, 2025, at 16:53, John Naylor wrote: > > On Thu, Sep 18, 2025 at 3:16 PM Chao Li wrote: >> >> When you say “communicate how to detect incompatibility for existing >> systems”, what would be the communication channel? I am actually very new to >> the PG development community, your

_CRT_glob stuff

2025-09-18 Thread Peter Eisentraut
When you compile on Windows with a sufficiently new gcc or clang you'll get errors or warnings like this: ../src/common/exec.c:49:17: error: '_CRT_glob' initialized and declared 'extern' [-Werror] 49 | extern int _CRT_glob = 0; /* 0 turns off globbing; 1 turns it on */ or .

Re: someone else to do the list of acknowledgments

2025-09-18 Thread Bruce Momjian
On Thu, Sep 18, 2025 at 11:18:04AM -0400, Robert Haas wrote: > On Thu, Sep 18, 2025 at 11:13 AM Bruce Momjian wrote: > > I can't think of any good reason we are having to rush to complete this > > when we knew and were warned months ago it was needed. Yes, it is > > _slightly_ easier to do it onl

Re: someone else to do the list of acknowledgments

2025-09-18 Thread Daniel Gustafsson
> On 18 Sep 2025, at 11:23, Álvaro Herrera wrote: > > On 2025-Sep-18, Corey Huinker wrote: > >> Álvaro Mongil > > Hmm, where does this name come from? I can't find it anywhere. > > [... trolls logs ...] ah, did you get it on private email from > alv...@datadoghq.com ? Thats correct (this nam

RE: [Patch] add new parameter to pg_replication_origin_session_setup

2025-09-18 Thread Hayato Kuroda (Fujitsu)
Dear Amit, > > Few comments: > 1. +step "s0_compare" { > +SELECT s0.lsn < s1.lsn > +FROM local_lsn_store as s0, local_lsn_store as s1 > +WHERE s0.session = 0 AND s1.session = 1; > +} > > This appears to be a bit tricky to compare the values. Doing a > sequential scan won't guarantee

Re: pg_stat_statements: faster search by queryid

2025-09-18 Thread Karina Litskevich
Thank you for your feedback. > My initial thought is that this patch does not remove the issue of > loading the entire query text (just to return one or a few entries). This patch is not intended to address the issue of loading the file with query texts. We only try to avoid forming and handling

Re: Make TID Scans recalculate the TIDs less often

2025-09-18 Thread Chao Li
On Sep 17, 2025, at 18:31, David Rowley wrote: On Wed, 17 Sept 2025 at 22:13, Andrey Borodin wrote: Occasionally (when dealing with corruption) I do stuff like begin; update public.tablename set description = description where ctid in (select ('('||b.blkno::text||','||(x::text)||')')::tid from

Re: Marking shared buffer lookup table as HASH_FIXED_SIZE

2025-09-18 Thread Ashutosh Bapat
On Thu, Sep 18, 2025 at 6:14 AM Andres Freund wrote: > > Hi, > > On 2025-08-26 19:55:21 +0530, Ashutosh Bapat wrote: > > StrategyInitialize() calls InitBufTable() passing the maximum number > > of possible entries in the shared buffer lookup table. The table can > > not have more entries than the

Re: [BUG] Query with postgres fwd deletes more tuples than it should

2025-09-18 Thread Etsuro Fujita
On Wed, Sep 17, 2025 at 10:11 PM Daniil Davydov <3daniss...@gmail.com> wrote: > On Wed, Sep 17, 2025 at 6:46 PM Etsuro Fujita wrote: > > On Wed, Sep 17, 2025 at 2:46 PM wrote: > > > I think a good way to fix would be to use `(tableoid, ctid)` together as > > > the row > > > identifier in row-by-

Re: Incorrect logic in XLogNeedsFlush()

2025-09-18 Thread Dilip Kumar
On Thu, Sep 18, 2025 at 9:24 AM Michael Paquier wrote: > > On Wed, Sep 17, 2025 at 09:23:05PM -0400, Melanie Plageman wrote: > > In terms of comments, I think it is best to update the comment above > > XLogNeedsFlush(). Something like : > > > > /* > > - * Test whether XLOG data has been flushed u

Re: [PATCH] Check that index can return in get_actual_variable_range()

2025-09-18 Thread Maxime Schoemans
On 18 Sep 2025, at 14:31, Aleksander Alekseev wrote: > Can you think of any test cases we can add to the code base? The only idea I have would be adding a new index module in src/test/modules that has this particular property and have a test that will hit get_actual_variable_range(). For exampl

Re: Parallel heap vacuum

2025-09-18 Thread Robert Haas
On Wed, Sep 17, 2025 at 7:22 PM Andres Freund wrote: > I continue to find this argument extremely unconvincing. It's very common for > autovacuum to be continuously be busy with the one large table that has a > bunch of indexes. Vacuuming that one table is what prevents the freeze horizon > to mov

Re: REPACK and naming

2025-09-18 Thread Bruce Momjian
On Wed, Sep 17, 2025 at 05:05:38PM -0400, Bruce Momjian wrote: > On Wed, Sep 17, 2025 at 10:59:55AM -0400, Robert Haas wrote: > > I mean, it's PRETTY confusing that VACUUM FULL does something much > > more similar to CLUSTER than it is to VACUUM. We can't ever get out > > from under that confusion

Re: Proposal: Conflict log history table for Logical Replication

2025-09-18 Thread Dilip Kumar
On Thu, Sep 18, 2025 at 2:03 PM Amit Kapila wrote: > > On Sun, Sep 14, 2025 at 12:23 PM Dilip Kumar wrote: > > > > On Sat, Sep 13, 2025 at 6:16 AM Bharath Rupireddy > > wrote: > > > > Thanks for the feedback Bharath > > > > > On Fri, Sep 12, 2025 at 3:13 AM Dilip Kumar wrote: > > > > > > > > I

Re: [PATCH] Check that index can return in get_actual_variable_range()

2025-09-18 Thread Mark Dilger
Testing with the src/test/modules/treeb work in the patch series at [1], modifying treebcanreturn() to always return false and modifying _treeb_first(), _treeb_next(), and _treeb_endpoint() to set scan->xs_itup to NULL rather than to a tuple, without the patch there are a number of test failures wi

Re: Changing shared_buffers without restart

2025-09-18 Thread Andres Freund
Hi, On 2025-09-18 10:25:29 +0530, Ashutosh Bapat wrote: > From d1ed934ccd02fca2c831e582b07a169e17d19f59 Mon Sep 17 00:00:00 2001 > From: Dmitrii Dolgov <9erthali...@gmail.com> > Date: Tue, 17 Jun 2025 15:14:33 +0200 > Subject: [PATCH 02/16] Process config reload in AIO workers I think this is sup

Re: Reduce "Var IS [NOT] NULL" quals during constant folding

2025-09-18 Thread BharatDB
Dear Team, In continuation with the previous mail (CAAh00ETEMEXntw1gxp=xP+4sqrz80tK1R4VEhTpqH9CJpxs-wA) regarding the optimizations in PostgreSQL 18 to simplify query plans by folding away Var IS [NOT] NULL checks on columns declared NOT NULL. I experimented with two approaches, but both hit signi

Re: Report bytes and transactions actually sent downtream

2025-09-18 Thread Ashutosh Bapat
Hi Shveta, Bertrand, Replying to both of your review comments together. On Thu, Sep 18, 2025 at 10:52 AM shveta malik wrote: > > On Wed, Aug 27, 2025 at 7:14 PM Bertrand Drouvot > wrote: > > > > Hi, > > > > On Thu, Jul 24, 2025 at 12:24:26PM +0530, Ashutosh Bapat wrote: > > > Here's the next pa

Re: someone else to do the list of acknowledgments

2025-09-18 Thread Bruce Momjian
On Sun, Aug 17, 2025 at 11:57:50AM +0800, jian he wrote: > hi. > maybe we should start working on this? > > https://www.postgresql.org/developer/roadmap > says 18 will be released in September 2025. Folks, our list of PG 18 "new features and enhancements" and "Acknowledgments" is being added very

Re: _CRT_glob stuff

2025-09-18 Thread Jacob Champion
On Thu, Sep 18, 2025 at 3:03 AM Peter Eisentraut wrote: > Here is some relevant documentation that suggests that this is the > correct approach: > > https://github.com/mingw-w64/mingw-w64/blob/master/mingw-w64-headers/crt/_mingw.h.in#L476 > > This also says that the default is 0 anyway, so it's no

Re: someone else to do the list of acknowledgments

2025-09-18 Thread Robert Haas
On Thu, Sep 18, 2025 at 11:13 AM Bruce Momjian wrote: > I can't think of any good reason we are having to rush to complete this > when we knew and were warned months ago it was needed. Yes, it is > _slightly_ easier to do it only once rather than do it early and keep it > updated, but there isn't

Re: REPACK and naming

2025-09-18 Thread Vik Fearing
On 18/09/2025 16:56, Bruce Momjian wrote: On Wed, Sep 17, 2025 at 05:05:38PM -0400, Bruce Momjian wrote: On Wed, Sep 17, 2025 at 10:59:55AM -0400, Robert Haas wrote: I mean, it's PRETTY confusing that VACUUM FULL does something much more similar to CLUSTER than it is to VACUUM. We can't ever

waiteventset.c XXX

2025-09-18 Thread Robert Haas
Hi, Almost at the very end of waiteventset.c, we have a comment saying should be sure to do a thing that we don't do: * NB: be sure to save and restore errno around it. (That's standard practice * in most signal handlers, of course, but we used to omit it in handlers that * only set a flag.)

Re: pg_stat_statements: faster search by queryid

2025-09-18 Thread Sami Imseih
> > My initial thought is that this patch does not remove the issue of > > loading the entire query text (just to return one or a few entries). > > This patch is not intended to address the issue of loading the file > with query texts. We only try to avoid forming and handling tuples > that we don'

Re: LISTEN/NOTIFY bug: VACUUM sets frozenxid past a xid in async queue

2025-09-18 Thread Matheus Alcantara
On Mon Sep 15, 2025 at 2:40 PM -03, Masahiko Sawada wrote: > While the WAL-based approach discussed on another thread is promising, > I think it would not be acceptable for back branches as it requires > quite a lot of refactoring. Given that this is a long-standing bug in > listen/notify, I think

Re: Updating IPC::Run in CI?

2025-09-18 Thread Jacob Champion
On Thu, Sep 18, 2025 at 11:18 AM Andres Freund wrote: > As you can see we currently don't install packages from outside netbsd's > package repository. We could change that and install IPC::Run via cpan, but > imo it's obviously nicer - and more representative of real world setups - if > we just r

Re: RFC: extensible planner state

2025-09-18 Thread Robert Haas
On Tue, Sep 16, 2025 at 4:12 PM Robert Haas wrote: > On Fri, Sep 5, 2025 at 4:19 PM Robert Haas wrote: > > While mulling this over, I realized that this only works if you don't > > mind propagating information into the final plan regardless without > > knowing whether or not EXPLAIN was actually

Re: Resetting recovery target parameters in pg_createsubscriber

2025-09-18 Thread Alexander Korotkov
Hello, Alyona! On Mon, Sep 8, 2025 at 8:35 AM Alyona Vinter wrote: > > Sorry, wrong patches again. Here are the correct ones. I went though this patches. 1) I've removed the array of parameters. I see it was proposed by Michael upthread. But I think his proposal came from the fact we walk trou

Re: Identifying function-lookup failures due to argument name mismatches

2025-09-18 Thread Tom Lane
Robert Haas writes: > On Mon, Sep 15, 2025 at 4:01 PM Tom Lane wrote: >> The primary error message is not varying, only the DETAIL/HINT, so >> I find this concern pretty far-fetched. Also, I believe that the >> case that the message intends to help with is very common and so >> it will save a lo

Re: GetNamedLWLockTranche crashes on Windows in normal backend

2025-09-18 Thread Nathan Bossart
Committed. -- nathan

Re: Updating IPC::Run in CI?

2025-09-18 Thread Andres Freund
Hi, On 2025-09-18 11:48:15 -0700, Jacob Champion wrote: > On Thu, Sep 18, 2025 at 11:18 AM Andres Freund wrote: > > As you can see we currently don't install packages from outside netbsd's > > package repository. We could change that and install IPC::Run via cpan, but > > imo it's obviously nice

Re: encode/decode support for base64url

2025-09-18 Thread Daniel Gustafsson
> On 17 Sep 2025, at 19:51, Masahiko Sawada wrote: > Thank you for updating the patch! I've done additional tests in my > environment and all test cases passed. One very minor comment is that > we might want to add 'BASE64URL' to: > > /* > * BASE64 > */ I did that, and polished a few comments w

fix obsolete references to postgres.h in comments

2025-09-18 Thread Nathan Bossart
Most of these were missed by commit d952373a98, but I found one that seems to have been missed by commit d08741eab5. -- nathan >From ba87e8b4d334c20edca1526f2d1d71280b39 Mon Sep 17 00:00:00 2001 From: Nathan Bossart Date: Thu, 18 Sep 2025 13:00:51 -0500 Subject: [PATCH v1 1/1] Fix obsolete r

Re: PG 18 relnotes and RC1

2025-09-18 Thread Robert Haas
On Thu, Sep 18, 2025 at 2:19 PM Jonathan S. Katz wrote: > Glad to hear I've been doing my job backwards for years ;) That said, I > am always willing to learn how to improve the process. I don't really care for the flip tone here. I do think there's a problem here, and I do think it's longstandin

Re: Updating IPC::Run in CI?

2025-09-18 Thread Jacob Champion
On Thu, Sep 18, 2025 at 11:49 AM Nazir Bilal Yavuz wrote: > I have not checked it yet but we are on NetBSD 10.0 [1]. I thought > upgrading to 10.1 might help... Apparently it does not, 10.1 too uses > p5-IPC-Run-20231003 [2]. Right. On the Debian side, looks like bookworm is stuck on 20220807.0 -

Re: PG 18 relnotes and RC1

2025-09-18 Thread Robert Haas
On Thu, Sep 18, 2025 at 3:32 PM Nathan Bossart wrote: > I think we ought to set a deadline of, say, beta2 or beta3 and have the RMT > responsible for making sure it happens. Either of those releases would > still give us at least a month or so to address feedback before GA, but > they aren't so e

Introduce XID age based replication slot invalidation

2025-09-18 Thread John H
Hi folks, I'd like to restart the discussion about providing an xid-based slot invalidation mechanism. The previous effort [1] presented an XID and time-based invalidation and the inactive time-based approach was implemented first. The latest XID based patch from Bharath Rupireddy can be found he

Re: [BUG] temporary file usage report with extended protocol and unnamed portals

2025-09-18 Thread Sami Imseih
> Now, if I apply patch v11-0002 that only adds the tests but not > v11-0001, the tests pass. Ok. It looks like my regexp was wrong. v12-0002 fixes this by looking for the correct STATEMENT: after the temp file logging. I also realized that the initial tests we've been working with included: ```

Re: Proposal: Conflict log history table for Logical Replication

2025-09-18 Thread Masahiko Sawada
On Thu, Sep 18, 2025 at 1:33 AM Amit Kapila wrote: > > On Sun, Sep 14, 2025 at 12:23 PM Dilip Kumar wrote: > > > > On Sat, Sep 13, 2025 at 6:16 AM Bharath Rupireddy > > wrote: > > > > Thanks for the feedback Bharath > > > > > On Fri, Sep 12, 2025 at 3:13 AM Dilip Kumar wrote: > > > > > > > > I

Re: Updating IPC::Run in CI?

2025-09-18 Thread Andres Freund
Hi, On 2025-09-18 10:08:49 -0700, Jacob Champion wrote: > Andres pointed out that one of my new OAuth tests has flaked on NetBSD > [1]. The final line of debugging output is missing from the stderr > coming from psql. > > I haven't ruled out a bug in my implementation, but I also remembered > tha

Re: PG 18 relnotes and RC1

2025-09-18 Thread Jonathan S. Katz
On 9/18/25 1:38 PM, Robert Haas wrote: On Thu, Sep 18, 2025 at 12:59 PM Jonathan S. Katz wrote: I like Nathan's version better. I suggest we go with that one. Why? This seems arbitrary without more details. I’ve spent the past several weeks staring at the release notes, talking to users, an

Re: PG 18 relnotes and RC1

2025-09-18 Thread Nathan Bossart
On Thu, Sep 18, 2025 at 01:38:44PM -0400, Robert Haas wrote: > That seems completely backwards to me. We should go with the version > that was submitted weeks ago and upon which people have had the > opportunity to comment unless you can justify each change that you now > want to make at the last m

Re: PG 18 relnotes and RC1

2025-09-18 Thread Jonathan S. Katz
On 9/18/25 2:33 PM, Jonathan S. Katz wrote: On 9/18/25 2:19 PM, Nathan Bossart wrote: Quick analysis of the differences: Common: * AIO * skip scan * pg_upgrade * UUIDv7 * virtual generated columns * OAuth Only v1 (my patch): * OLD/NEW for RETURNIN

Re: Updating IPC::Run in CI?

2025-09-18 Thread Jacob Champion
On Thu, Sep 18, 2025 at 12:16 PM Andres Freund wrote: > I don't think there's a hard and fast rule, but I do think that it's a > reasonably important goal to make sure that the OS/distro actually can build > packages - and as part of that test those packages - reasonably well. So > requiring wildl

Re: PG 18 relnotes and RC1

2025-09-18 Thread Nathan Bossart
On Thu, Sep 18, 2025 at 03:25:08PM -0400, Robert Haas wrote: > As I see it, while our feature freeze isn't perfect -- mostly because > too many things get slipped in at the last minute that aren't really > in great shape -- it's a lot better than the old process where nobody > really knew what the

Re: PG 18 relnotes and RC1

2025-09-18 Thread Jonathan S. Katz
On 9/18/25 3:25 PM, Robert Haas wrote: On Thu, Sep 18, 2025 at 2:19 PM Jonathan S. Katz wrote: Glad to hear I've been doing my job backwards for years ;) That said, I am always willing to learn how to improve the process. I don't really care for the flip tone here. I didn't really care for

  1   2   >