Re: Kerberos test suite

On Tue, Mar 06, 2018 at 10:58:54AM -0500, Peter Eisentraut wrote: > On 3/5/18 16:34, Thomas Munro wrote: > > On Tue, Mar 6, 2018 at 8:45 AM, Peter Eisentraut > > wrote: > >> New patch attached. > > > > Passes here. LGTM. > > committed This fails on my machine, where /etc/hosts has:

Re: Should contrib modules install .h files?

> "Andres" == Andres Freund writes: >> Sure, it works for the simple cases like hstore, but how does it >> handle the case of a pgxs extension that installs more than one >> include file, one of which includes another? Andres> I might be momentarily daft (just was on a conference call

Re: Documentaion fix.

At Wed, 1 Aug 2018 02:47:32 +0900, Michael Paquier wrote in <20180731174732.gd2...@paquier.xyz> > On Tue, Jul 31, 2018 at 10:59:14AM -0400, Alvaro Herrera wrote: > > How about pasting it like this? > > > > alvherre=# select * from pg_replication_slots \gx > > ─[ RECORD 1 ]───┬ >

Re: pg_ugprade test failure on data set with column with default value with type bit/varbit

Thanks. I updated the patch as attached. Double-checked those tests passed. 2018-07-30 9:38 GMT+08:00 Thomas Munro : > On Thu, May 17, 2018 at 8:20 PM, Paul Guo wrote: > > Thanks. I tentatively submitted a patch (See the attachment). > > Hi Paul, > > It looks like you missed a couple of

Re: Should contrib modules install .h files?

On 2018-08-01 04:52:28 +0100, Andrew Gierth wrote: > > "Tom" == Tom Lane writes: > > >> If your extension is relying on pg11+, or you have checked the pg > >> version when constructing the makefile, you can just do: > >> PG_CPPFLAGS += -I$(includedir_server)/extension/hstore > >> and

Re: Should contrib modules install .h files?

> "Tom" == Tom Lane writes: >> If your extension is relying on pg11+, or you have checked the pg >> version when constructing the makefile, you can just do: >> PG_CPPFLAGS += -I$(includedir_server)/extension/hstore >> and #include "hstore.h" will work. Tom> I remain of the opinion that

Re: pg_upgrade from 9.4 to 10.4

On Tue, Jul 31, 2018 at 08:05:06PM -0400, Andrew Dunstan wrote: > On 07/31/2018 07:08 PM, Bruce Momjian wrote: > >Oh, jacana must be a Windows server with spaces in the file name paths. > >Fixed. Thanks again. I really didn't want to backpatch the original > >fix but had to since it could

Re: Should contrib modules install .h files?

Andrew Gierth writes: > "Peter" == Peter Eisentraut writes: > Peter> I'm missing some guidance what an extension using those headers > Peter> is supposed to do. How does it get the right -I options? > If your extension is relying on pg11+, or you have checked the pg > version when

Re: New Defects reported by Coverity Scan for PostgreSQL

Ning Yu writes: > From my point of view it's better to also put some comments for humans to > understand why we are passing l1 and l2 in reverse order. The header comment for lseg_closept_lseg() is pretty far from adequate as well. After studying it for awhile I think I've puzzled out the

Re: [HACKERS] Restricting maximum keep segments by repslots

At Tue, 31 Jul 2018 12:24:13 -0700, Andres Freund wrote in <20180731192413.7lr4qbc4qbyoi...@alap3.anarazel.de> > On 2018-07-31 15:21:27 -0400, Stephen Frost wrote: > > Greetings, > > > > * Andres Freund (and...@anarazel.de) wrote: > > > On 2018-07-31 15:11:52 -0400, Bruce Momjian wrote: > > > >

Re: New Defects reported by Coverity Scan for PostgreSQL

To make coverity happy we might be able to suppress this false alarm by adding a line like below: ``` /* coverity[SWAPPED_ARGUMENTS] */ lseg_closept_lseg(result, l2, l1); ``` >From my point of view it's better to also put some comments for humans to understand why we are passing l1 and l2 in

Re: pg_upgrade from 9.4 to 10.4

On 07/31/2018 07:08 PM, Bruce Momjian wrote: On Tue, Jul 31, 2018 at 06:29:34PM -0400, Tom Lane wrote: Bruce Momjian writes: On Tue, Jul 31, 2018 at 03:26:47PM -0400, Tom Lane wrote: This patch evidently broke build farm member jacana, although only in the 9.3 branch. It's been failing

Re: Should contrib modules install .h files?

> "Peter" == Peter Eisentraut writes: >> A review of contrib/ suggested that cube, hstore, isn, ltree and seg >> were the only modules that had useful headers to install, so do >> those. Peter> I'm missing some guidance what an extension using those headers Peter> is supposed to do.

Re: pg_upgrade from 9.4 to 10.4

On Tue, Jul 31, 2018 at 06:29:34PM -0400, Tom Lane wrote: > Bruce Momjian writes: > > On Tue, Jul 31, 2018 at 03:26:47PM -0400, Tom Lane wrote: > >> This patch evidently broke build farm member jacana, although only > >> in the 9.3 branch. It's been failing with > >> Jul 28 23:22:30 The system

Re: Online enabling of checksums

Hi, On 2018-07-31 18:56:29 -0400, Alvaro Herrera wrote: > In the spirit of supporting incremental development, I think it's quite > sensible to get the current thing done, then see what it takes to get > the next thing done. Each is an improvement on its own merits. And it > doesn't have to be

Re: Online enabling of checksums

On 2018-Jul-31, Tom Lane wrote: > Andres Freund writes: > > On 2018-07-31 23:20:27 +0200, Daniel Gustafsson wrote: > >> Not really arguing for or against, but just to understand the reasoning > >> before > >> starting hacking. Why do we feel that a restart (intended for safety > >> here) in >

Re: Should contrib modules install .h files?

On 31/07/2018 21:19, Andrew Gierth wrote: >> "Andrew" == Andrew Gierth writes: > > Final patch just to let cfbot test the windows code for me. > > A review of contrib/ suggested that cube, hstore, isn, ltree and seg > were the only modules that had useful headers to install, so do those.

Re: Should contrib modules install .h files?

On 31/07/2018 23:46, Andrew Gierth wrote: > not pushing > to 11-beta would mean delaying the issue for another year and forcing > yet another cycle of workarounds. But that applies to every single patch. -- Peter Eisentraut http://www.2ndQuadrant.com/ PostgreSQL Development, 24x7

Re: Should contrib modules install .h files?

On 23/07/2018 18:32, Andrew Gierth wrote: >> "Tom" == Tom Lane writes: > > Tom> As I said before, I think that we should change the existing > Tom> contrib modules to be coded likewise, all using a single -I switch > Tom> that points at SRCDIR/contrib. That'd help give people the right >

Re: pg_upgrade from 9.4 to 10.4

Bruce Momjian writes: > On Tue, Jul 31, 2018 at 03:26:47PM -0400, Tom Lane wrote: >> This patch evidently broke buildfarm member jacana, although only >> in the 9.3 branch. It's been failing with >> Jul 28 23:22:30 The system cannot find the path specified. > Well, that's interesting. I have a

Re: pg_upgrade from 9.4 to 10.4

On Tue, Jul 31, 2018 at 03:26:47PM -0400, Tom Lane wrote: > Bruce Momjian writes: > > Updated patch applied through 9.3: > > > > https://git.postgresql.org/pg/commitdiff/260fe9f2b02b67de1e5ff29faf123e4220586c43 > > This patch evidently broke buildfarm member jacana, although only > in the

Re: Should contrib modules install .h files?

On 2018-07-31 17:53:19 -0400, Tom Lane wrote: > Peter Geoghegan writes: > > On Tue, Jul 31, 2018 at 1:17 PM, Andres Freund wrote: > >> I'm a bit surprised that you decided to push to the 11 branch - the > >> consensus in this thread seem to have gone the other way by my read? > >> Given that

Re: Should contrib modules install .h files?

Peter Geoghegan writes: > On Tue, Jul 31, 2018 at 1:17 PM, Andres Freund wrote: >> I'm a bit surprised that you decided to push to the 11 branch - the >> consensus in this thread seem to have gone the other way by my read? >> Given that that's the rule, and pushing non-fixes is the exception,

Re: Should contrib modules install .h files?

> "Andres" == Andres Freund writes: Andres> I'm a bit surprised that you decided to push to the 11 branch - Andres> the consensus in this thread seem to have gone the other way by Andres> my read? There were also quite a few non-objections or "don't care"s to the idea of pushing it to

doc - improve description of default privileges

I have not found a convenient presentation of the default privileges for different objects, and how to display them (if possible, not always). The information is partly provided within the GRANT description, and not very explicit: eg it is said that owners have all possible perms, but which

commitfest 2018-07

Well, here we are at the end of July. here's the current state of Commitfest 2018-07: *Status summary: *Needs review : 83. Waiting on Author : 31. Ready for Committer

Re: [HACKERS] Cached plans and statement generalization

Hi Yamaji, On 31.07.2018 12:12, Yamaji, Ryo wrote: -Original Message- From: Konstantin Knizhnik [mailto:k.knizh...@postgrespro.ru] Sent: Friday, January 12, 2018 9:53 PM To: Thomas Munro ; Stephen Frost Cc: Michael Paquier ; PostgreSQL mailing lists ; Tsunakawa, Takayuki/綱川 貴之

Re: Online enabling of checksums

Andres Freund writes: > On 2018-07-31 23:20:27 +0200, Daniel Gustafsson wrote: >> Not really arguing for or against, but just to understand the reasoning >> before >> starting hacking. Why do we feel that a restart (intended for safety here) >> in >> this case is a burden on a use-once

Re: Alter index rename concurrently to

Peter Eisentraut writes: > On 27/07/2018 16:16, Robert Haas wrote: >> I also suspect that an appropriate fix might be to ensure that >> AcceptInvalidationMessages() is run at least once at the beginning of >> parse analysis. > Why don't we just do that? Don't we do that already? Certainly it

Re: Online enabling of checksums

Hi, On 2018-07-31 23:20:27 +0200, Daniel Gustafsson wrote: > > On 26 Jul 2018, at 19:35, Andres Freund wrote: > > On July 26, 2018 10:03:39 AM PDT, Robert Haas > > wrote: > > >> Why can't we do better? > > > > I don't think it's that hard to do better. IIRC I

Re: Bizarre behavior in libpq's searching of ~/.pgpass

I wrote: > But now that I look at it, it seems like the code in connectOptions2 > has also Gotten It Wrong. Shouldn't the replacement of "unspecified" > cases by DEFAULT_PGSOCKET_DIR/DefaultHost also happen on an entry-by- > entry basis, so that "host=foo," would behave as though the empty >

Re: Online enabling of checksums

> On 31 Jul 2018, at 21:52, Joshua D. Drake wrote: > > On 07/31/2018 12:45 PM, Bruce Momjian wrote: >>> Thanks for reviewing, I’ve updated the patch with the above mentioned >>> incorrect >>> linkends as well as fixed the comments you made in a previous review. >>> >>> The CF-builder-bot is

Re: Alter index rename concurrently to

On 27/07/2018 16:16, Robert Haas wrote: > With respect to this particular patch, I don't know whether there are > any hazards of the second type. What I'd check, if it were me, is > what structures in the index's relcache entry are going to get rebuilt > when the index name changes. If any of

Re: Online enabling of checksums

On Tue, Jul 31, 2018 at 12:52:40PM -0700, Joshua Drake wrote: > On 07/31/2018 12:45 PM, Bruce Momjian wrote: > > > >>Hi!, > >> > >>Thanks for reviewing, I’ve updated the patch with the above mentioned > >>incorrect > >>linkends as well as fixed the comments you made in a previous review. > >> >

Re: Expression errors with "FOR UPDATE" and postgres_fdw with partition wise join enabled.

On 2018-Jul-31, Etsuro Fujita wrote: > (2018/07/31 4:06), Andres Freund wrote: > > On 2018-07-20 08:38:09 -0400, Robert Haas wrote: > > > I'm going to study this some more now, but I really think this is > > > going in the wrong direction. > > > > We're going to have to get somewhere on this

Re: Should contrib modules install .h files?

On Tue, Jul 31, 2018 at 1:17 PM, Andres Freund wrote: > I'm a bit surprised that you decided to push to the 11 branch - the > consensus in this thread seem to have gone the other way by my read? > Given that that's the rule, and pushing non-fixes is the exception, I'm > not particularly ok with

Re: GiST VACUUM

Hi! Thanks for looking into the patch! > 30 июля 2018 г., в 18:39, Heikki Linnakangas написал(а): > > On 29/07/18 14:47, Andrey Borodin wrote: >> Fixed both problems. PFA v14. > > Thanks, took a really quick look at this. > > The text being added to README is outdated for these latest

Re: Online enabling of checksums

On 07/31/2018 12:45 PM, Bruce Momjian wrote: Hi!, Thanks for reviewing, I’ve updated the patch with the above mentioned incorrect linkends as well as fixed the comments you made in a previous review. The CF-builder-bot is red, but it’s because it’s trying to apply the already committed patch

Re: Online enabling of checksums

On Wed, Jul 25, 2018 at 11:35:31AM +0200, Daniel Gustafsson wrote: > > On 24 Jul 2018, at 11:05, Sergei Kornilov wrote: > > > > The following review has been posted through the commitfest application: > > make installcheck-world: tested, failed > > Implements feature: not tested > > Spec

Re: Usability fail with psql's \dp command

On 31 July 2018 at 15:02, Fabien COELHO wrote: [] > Indeed, all \d* which display perms have the empty/default confusion: > > \dp \ddp \des \dew \l \dn \db \df \dT \dD \dL > > I fixed them all to display the default acl in the patch I just sent. > > I also noticed that although large

Re: pg_upgrade from 9.4 to 10.4

Bruce Momjian writes: > Updated patch applied through 9.3: > > https://git.postgresql.org/pg/commitdiff/260fe9f2b02b67de1e5ff29faf123e4220586c43 This patch evidently broke buildfarm member jacana, although only in the 9.3 branch. It's been failing with Jul 28 23:22:29 Performing

Re: [HACKERS] Restricting maximum keep segments by repslots

On 2018-07-31 15:21:27 -0400, Stephen Frost wrote: > Greetings, > > * Andres Freund (and...@anarazel.de) wrote: > > On 2018-07-31 15:11:52 -0400, Bruce Momjian wrote: > > > On Tue, Jun 26, 2018 at 04:26:59PM +0900, Kyotaro HORIGUCHI wrote: > > > > Hello. This is the reabased version of slot-limit

Re: [HACKERS] Restricting maximum keep segments by repslots

Greetings, * Andres Freund (and...@anarazel.de) wrote: > On 2018-07-31 15:11:52 -0400, Bruce Momjian wrote: > > On Tue, Jun 26, 2018 at 04:26:59PM +0900, Kyotaro HORIGUCHI wrote: > > > Hello. This is the reabased version of slot-limit feature. > > > > > > This patch limits maximum WAL segments

Re: Should contrib modules install .h files?

> "Andrew" == Andrew Gierth writes: Final patch just to let cfbot test the windows code for me. A review of contrib/ suggested that cube, hstore, isn, ltree and seg were the only modules that had useful headers to install, so do those. -- Andrew (irc:RhodiumToad) >From

Re: [HACKERS] Restricting maximum keep segments by repslots

On 2018-07-31 15:11:52 -0400, Bruce Momjian wrote: > On Tue, Jun 26, 2018 at 04:26:59PM +0900, Kyotaro HORIGUCHI wrote: > > Hello. This is the reabased version of slot-limit feature. > > > > This patch limits maximum WAL segments to be kept by replication > > slots. Replication slot is useful to

Re: Doc patch: add RECURSIVE to bookindex

Why referencing only create_view, but not delete, insert, update, select or select_into where RECURSIVE is also used? ISTM that at least the select page should be referenced, I'm less sure of the others because there it appears only in the synopsys. Looking at other occurrences of , it

Re: [HACKERS] Restricting maximum keep segments by repslots

On Tue, Jun 26, 2018 at 04:26:59PM +0900, Kyotaro HORIGUCHI wrote: > Hello. This is the reabased version of slot-limit feature. > > This patch limits maximum WAL segments to be kept by replication > slots. Replication slot is useful to avoid desync with replicas > after temporary disconnection

Re: Usability fail with psql's \dp command

Hello Pavel, I noticed today that \dp does not distinguish empty acl fields (meaning nobody has any privileges) from null acl fields (which mean default privileges, typically not empty). This confusing behavior exists not only for \dp command. Consider schemas and \dn+ command: Indeed,

Re: make installcheck-world in a clean environment

Alexander Lakhin writes: > 31.07.2018 02:42, Tom Lane wrote: >> Alexander's USE_INSTALLED_ASSETS patch attempted to fix that, and I now >> see the point of it, but it still seems pretty hacky and invasive (why >> should an ecpg-only problem be touching stuff outside ecpg)? Also, >> unless I'm

Re: patch to ensure logical decoding errors early

Hi, On 2018-07-31 14:51:12 -0400, Dave Cramer wrote: > This patch does 2 things > > 1) Ensure that when the slot is created > with pg_create_physical_replication_slot if the output plugin does not > exist it will error. *logical, I assume? > diff --git

patch to ensure logical decoding errors early

This patch does 2 things 1) Ensure that when the slot is created with pg_create_physical_replication_slot if the output plugin does not exist it will error. 2) Currently when the decoding context is created and the output plugin does not exist the protocol will respond with CopyDone. This patch

Re: Standby trying "restore_command" before local WAL

Greetings, * Sergei Kornilov (s...@zsrv.org) wrote: > > As mentioned by others, it sounds like we could have an option to try > > contacting the primary before running restore_commnad > Why about primary? > If we have restore_command on slave (or during point in time recovery) - we > force using

Re: Documentaion fix.

On Tue, Jul 31, 2018 at 10:59:14AM -0400, Alvaro Herrera wrote: > How about pasting it like this? > > alvherre=# select * from pg_replication_slots \gx > ─[ RECORD 1 ]───┬ > slot_name │ node_a_slot > plugin │ > slot_type │ physical > datoid

Re: BUG #15182: Canceling authentication due to timeout aka Denial of Service Attack

On Tue, Jul 31, 2018 at 10:34:57AM -0400, Robert Haas wrote: > Just as a general statement, I don't think we should, as part of a > patch for the issue discussed on this thread, make any changes AT ALL > to who has permission to perform which operations. We *certainly* > should not back-patch

Re: New Defects reported by Coverity Scan for PostgreSQL

Hello guys. Coverity complained about this patch as below. What, if anything, should be done about it? One solution is to mark it as a false-positive in Coverity, of course. On 2018-Jul-29, scan-ad...@coverity.com wrote: > ** CID 1438146: API usage errors (SWAPPED_ARGUMENTS) > > >

Re: patch to allow disable of WAL recycling

On Mon, Jul 30, 2018 at 4:43 AM, Peter Eisentraut wrote: > On 19/07/2018 05:59, Kyotaro HORIGUCHI wrote: >> My result is that we cannot disable recycling perfectly just by >> setting min/max_wal_size. > > Maybe the behavior of min_wal_size should be rethought? Elsewhere in > this thread, there

PostgreSQL 11 Beta 3 Release: 2018-08-09

Hi, The Release Management Team is pleased to announce that the release date for PostgreSQL 11 Beta 3 is set to be 2018-08-09, which coincides with the scheduled cumulative release. As always, we appreciate everyone’s diligent effort fixing open items[1] and we hope to get even more closed

Re: Standby trying "restore_command" before local WAL

Hello > As mentioned by others, it sounds like we could have an option to try > contacting the primary before running restore_commnad Why about primary? If we have restore_command on slave (or during point in time recovery) - we force using XLOG_FROM_ARCHIVE, even if XLOG_FROM_PG_WAL source can

Re: Standby trying "restore_command" before local WAL

Greetings, * Emre Hasegeli (e...@hasegeli.com) wrote: > This issue came to our attention after we migrated an application from > an object storage backend, and noticed that restarting a standby node > takes hours or sometimes days. > > We are using shared WAL archive and find it practical to

Re: Usability fail with psql's \dp command

On 28.07.2018 21:41, Tom Lane wrote: I noticed today that \dp does not distinguish empty acl fields (meaning nobody has any privileges) from null acl fields (which mean default privileges, typically not empty). This confusing behavior exists not only for \dp command. Consider schemas and \dn+

Re: [PATCH] Improve geometric types

On 07/31/2018 05:14 PM, Emre Hasegeli wrote: 1) common_entry_cmp is still handling 'delta' as double, although the CommonEntry was modified to use float8. IMHO it should also simply call float8_cmp_internal instead of doing comparisons. I am changing it to define delta as "float8" and to

Re: [PATCH] Improve geometric types

> 1) common_entry_cmp is still handling 'delta' as double, although the > CommonEntry was modified to use float8. IMHO it should also simply call > float8_cmp_internal instead of doing comparisons. I am changing it to define delta as "float8" and to use float8_cmp_internal(). > 2)

Re: Documentaion fix.

On 2018-Jul-31, Kyotaro HORIGUCHI wrote: > But, just fixing it makes the line seemingly a bit too long.. How about pasting it like this? alvherre=# select * from pg_replication_slots \gx ─[ RECORD 1 ]───┬ slot_name │ node_a_slot plugin │ slot_type

Re: Usability fail with psql's \dp command

On Tue, Jul 31, 2018 at 7:24 AM, Robert Haas wrote: > On Sat, Jul 28, 2018 at 4:36 PM, David Fetter wrote: > > Please find attached a patch to fix this. Would this be a > > back-patchable bug? > > In my view, this is not a bug fix, but an improvement, and therefore > should not be

Re: [PATCH] Improve geometric types

Hi Emre, Now that the buildfarm is no longer complaining about 0001 and 0002, I'm working on reviewing and committing 0003. It seems quite straightforward but I do have couple of comment/questions: 1) common_entry_cmp is still handling 'delta' as double, although the CommonEntry was

Re: Bizarre behavior in libpq's searching of ~/.pgpass

Robert Haas writes: > On Fri, Jul 27, 2018 at 11:38 PM, Tom Lane wrote: >> I noticed that there's some strange coding in libpq's choice of >> what hostname to use for searching ~/.pgpass for a password. > Yeah, that's bad code. The intent was that if you set host=a,b you > probably want to use

Re: Usability fail with psql's \dp command

On Sat, Jul 28, 2018 at 4:36 PM, David Fetter wrote: > Please find attached a patch to fix this. Would this be a > back-patchable bug? In my view, this is not a bug fix, but an improvement, and therefore should not be back-patched. -- Robert Haas EnterpriseDB: http://www.enterprisedb.com The

Re: Doc patch: add RECURSIVE to bookindex

Fabien COELHO wrote: > Why referencing only create_view, but not delete, insert, update, select > or select_into where RECURSIVE is also used? > > ISTM that at least the select page should be referenced, I'm less sure of > the others because there it appears only in the synopsys.

Re: Adding a note to protocol.sgml regarding CopyData

Hello Tatsuo-san, Minor suggestions, although I'm not a native English speaker. Well, I did not intend to enhance libpq.sgml but maybe your points is valid (I cannot judge because I am not an native English speaker). Argh, sorry, I did not read the right part:-( The note looks good to

Re: why doesn't pg_create_logical_replication_slot throw an error if the encoder doesn't exist

On 26 July 2018 at 16:49, Andres Freund wrote: > Hi, > > On 2018-07-26 16:40:18 -0400, Dave Cramer wrote: > > Since nothing else can be done we should throw an error early. > > I can't immediately think of a reason not to do that, but I personally > don't care enough to write a patch... > Fair

Standby trying "restore_command" before local WAL

Currently the startup process tries the "restore_command" before the WAL files locally available under pg_wal/ [1]. I believe we should change this behavior. == The Problem == This issue came to our attention after we migrated an application from an object storage backend, and noticed that

Re: Doc patch: add RECURSIVE to bookindex

Hello Daniel, I've noticed that RECURSIVE as a term is not in the index, and thought it should be. PFA a patch to add it with references to WITH queries and CREATE VIEW. Sounds reasonable. Why referencing only create_view, but not delete, insert, update, select or select_into where

Re: Allow auto_explain to log to NOTICE

On 07/17/2018 02:03 PM, Daniel Gustafsson wrote: On 17 Jul 2018, at 19:11, Andrew Dunstan wrote: On 07/17/2018 12:04 PM, Daniel Gustafsson wrote: Since DEBUG is not a defined loglevel, it seems superfluous to include it here. It’s also omitted from the documentation so it should probably

Re: "WIP: Data at rest encryption" patch and, 2 phase commit.

Hi. Applying https://www.postgresql.org/message-id/11678.1532519255%40localhost patch, the problem of pg_create_logical_replication_slot () and the 2PC problem were solved. Thanks. Antonin Houska wrote: > Toshi Harada wrote: > > > Hi. > > > > I applied the patch "WIP: Data at rest

Re: Bizarre behavior in libpq's searching of ~/.pgpass

On Fri, Jul 27, 2018 at 11:38 PM, Tom Lane wrote: > I noticed that there's some strange coding in libpq's choice of > what hostname to use for searching ~/.pgpass for a password. > Historically (pre-v10), it just used the pghost parameter: > > conn->pgpass = PasswordFromFile(conn->pghost,

Re: make installcheck-world in a clean environment

31.07.2018 02:42, Tom Lane wrote: > I wrote: >> The original complaint about ecpg remains; I'm not terribly excited >> about messing with that. > Well, I got curious as to why we were seeing such a weird error, > and eventually traced it to this stuff in ecpg/test/Makefile.regress: > > # Standard

Doc patch: add RECURSIVE to bookindex

Hi, I've noticed that RECURSIVE as a term is not in the index, and thought it should be. PFA a patch to add it with references to WITH queries and CREATE VIEW. Best regards, -- Daniel Vérité PostgreSQL-powered mailer: http://www.manitou-mail.org Twitter: @DanielVerite diff --git

Re: Fw: Windows 10 got stuck with PostgreSQL at starting up. Adding delay lets it avoid.

On Fri, 20 Jul 2018 19:13:21 +0900 Michael Paquier wrote: > On Fri, Jul 20, 2018 at 05:58:13PM +0900, Yugo Nagata wrote: > > He reported this problem to pgsql-general list as below. Also, he created a > > patch > > to add a build-time option for adding 0.5 or 3.0 seconds delay after each > >

Re: [HACKERS] Restricting maximum keep segments by repslots

Hello. At Tue, 24 Jul 2018 16:47:41 +0900, Masahiko Sawada wrote in > On Mon, Jul 23, 2018 at 4:16 PM, Kyotaro HORIGUCHI > wrote: > > Hello. > > > > At Fri, 20 Jul 2018 10:13:58 +0900, Masahiko Sawada > > wrote in > > .. > > Instead, I made the field be shown in flat "bytes" using bigint,

RE: [HACKERS] Cached plans and statement generalization

> -Original Message- > From: Konstantin Knizhnik [mailto:k.knizh...@postgrespro.ru] > Sent: Friday, January 12, 2018 9:53 PM > To: Thomas Munro ; Stephen Frost > > Cc: Michael Paquier ; PostgreSQL mailing > lists ; Tsunakawa, Takayuki/綱川 貴之 > > Subject: Re: [HACKERS] Cached plans and

[Todo item] Add entry creation timestamp column to pg_stat_replication

Hello hackers, I have worked on following todo list item. - Add entry creation timestamp column to pg_stat_replication http://archives.postgresql.org/pgsql-hackers/2011-08/msg00694.php This item looks like simple because necessary data was already exist. So, I wrote a prototype patch.

Re: Adding a note to protocol.sgml regarding CopyData

Hi Fabien, Thank you for the comment. > Hello Tatsuo-san, > > Minor suggestions, although I'm not a native English speaker. > >> In libpq.sgml following is stated: >> >>Before PostgreSQL protocol 3.0, it was >>necessary >>for the application to explicitly send the two

Re: make installcheck-world in a clean environment

Hello Tom, 31.07.2018 01:16, Tom Lane wrote: > Alexander Lakhin writes: >> 14.07.2018 13:57, Peter Eisentraut wrote: >>> On 06.07.18 09:45, Alexander Lakhin wrote: ./configure --enable-tap-tests make install make install -C contrib chown -R postgres:postgres /usr/local/pgsql/

Re: Speeding up INSERTs and UPDATEs to partitioned tables

On 30 July 2018 at 20:26, Amit Langote wrote: > I couldn't find much to complain about in the latest v3, except I noticed > a few instances of the word "setup" where I think what's really meant is > "set up". > > + * must be setup, but any sub-partitioned tables can be setup lazily as > > +