Re: New committers announced at PGCon 2018

2018-06-01 Thread Dave Cramer
dra > > Congratulations to all! > > regards, tom lane > > +7 Congratulations to all! Dave Cramer da...@postgresintl.com www.postgresintl.com

Re: libpq compression

2018-06-05 Thread Dave Cramer
ed at the patch but if we get to the point of negotiating compression please let me know. Thanks, Dave Cramer da...@postgresintl.com www.postgresintl.com

Comment refers to non existent function IncreaseRestartDecodingForSlot

2018-06-29 Thread Dave Cramer
While trying to figure out this code I found https://git.postgresql.org/gitweb/?p=postgresql.git;a=blob;f=src/backend/replication/logical/logical.c;h=61588d626f608006196c769ad9807f1d3ac592e9;hb=HEAD#l913 What function should it be referring to ? Thanks, Dave Cramer

Re: Supporting tls-server-end-point as SCRAM channel binding for OpenSSL 1.0.0 and 1.0.1

2018-06-24 Thread Dave Cramer
at HEAD is cleaner with its simplicity. > > I'm unclear what this has to do with JDBC ? JDBC doesn't use OpenSSL Alvaro ? Dave Cramer da...@postgresintl.com www.postgresintl.com

What does Time.MAX_VALUE actually represent?

2017-12-30 Thread Dave Cramer
We are having a discussion on the jdbc project about dealing with 24:00:00. https://github.com/pgjdbc/pgjdbc/pull/992#issuecomment-354507612 Dave Cramer

Re: patch to ensure logical decoding errors early

2018-08-01 Thread Dave Cramer
On 31 July 2018 at 14:58, Andres Freund wrote: > Hi, > > On 2018-07-31 14:51:12 -0400, Dave Cramer wrote: > > This patch does 2 things > > > > 1) Ensure that when the slot is created > > with pg_create_physical_replication_slot if the output plugin does not >

Re: patch to ensure logical decoding errors early

2018-08-01 Thread Dave Cramer
On 1 August 2018 at 10:13, Petr Jelinek wrote: > Hi, > > On 31/07/18 20:58, Andres Freund wrote> > >> diff --git a/src/backend/replication/logical/logical.c > b/src/backend/replication/logical/logical.c > >> index 3cd4eef..9f883b9 100644 > >> --- a/src/backend/replication/logical/logical.c > >>

why doesn't pg_create_logical_replication_slot throw an error if the encoder doesn't exist

2018-07-26 Thread Dave Cramer
Since nothing else can be done we should throw an error early. Dave Cramer

Re: why doesn't pg_create_logical_replication_slot throw an error if the encoder doesn't exist

2018-07-31 Thread Dave Cramer
On 26 July 2018 at 16:49, Andres Freund wrote: > Hi, > > On 2018-07-26 16:40:18 -0400, Dave Cramer wrote: > > Since nothing else can be done we should throw an error early. > > I can't immediately think of a reason not to do that, but I personally > don't care enough to

patch to ensure logical decoding errors early

2018-07-31 Thread Dave Cramer
will return an error instead and abort the copy connection. Dave Cramer 0002-remove-space.patch Description: Binary data 0001-Ensure-that-pg_create_physical_replication_slot-erro.patch Description: Binary data

Re: Stored procedures and out parameters

2018-08-16 Thread Dave Cramer
On Thu, 16 Aug 2018 at 13:54, Shay Rojansky wrote: > Peter, > > I think this is all coming from Microsoft. The JDBC driver API was >> modeled after the ODBC API, and the ODBC specification also contains the >> {call} escape. Microsoft SQL Server is also the only SQL implementation >> to handle

Re: Fix for REFRESH MATERIALIZED VIEW ownership error message

2018-08-18 Thread Dave Cramer
On Sat, 18 Aug 2018 at 17:30, Jonathan S. Katz wrote: > > On Aug 18, 2018, at 5:26 PM, David G. Johnston > wrote: > > On Saturday, August 18, 2018, Jonathan S. Katz > wrote: >> >> It’s cosmetic, but it’s a cosmetic bug: it incorrectly tells the user >> that they >> must be the owner of the

Re: Fix for REFRESH MATERIALIZED VIEW ownership error message

2018-08-18 Thread Dave Cramer
On Sat, 18 Aug 2018 at 17:48, Tom Lane wrote: > Dave Cramer writes: > > This is a simple fix why push back ? > > What was being pushed back on, I think, was the claim that this needed to > be back-patched. I'd be inclined not to, since (a) the message is not > wrong, on

Re: docs: note ownership requirement for refreshing materialized views

2018-08-17 Thread Dave Cramer
Dave Cramer On Thu, 16 Aug 2018 at 18:27, Jonathan S. Katz < jonathan.k...@excoventures.com> wrote: > > On Aug 16, 2018, at 1:05 AM, Jonathan S. Katz < > jonathan.k...@excoventures.com> wrote: > > > On Aug 15, 2018, at 9:15 PM, Michael Paquier wrote: > >

Re: Fix for REFRESH MATERIALIZED VIEW ownership error message

2018-08-17 Thread Dave Cramer
On Fri, 17 Aug 2018 at 19:35, Alvaro Herrera wrote: > On 2018-Aug-17, Dave Cramer wrote: > > > The only place this is used is in aclcheck_error > > case OBJECT_MATVIEW: > > msg = gettext_noop("permission denied for materialized view %s"); > > break; &g

Re: Fix for REFRESH MATERIALIZED VIEW ownership error message

2018-08-17 Thread Dave Cramer
Dave Cramer da...@postgresintl.com www.postgresintl.com On Fri, 17 Aug 2018 at 18:30, Alvaro Herrera wrote: > On 2018-Aug-17, Jonathan S. Katz wrote: > > > Hi, > > > > I Initially pointed out here[1] that running REFRESH MATERIALIZED VIEW > as a > > no

Re: Stored procedures and out parameters

2018-08-22 Thread Dave Cramer
work it would be a shame not to make it easy to use. I also agree with David that driver writers made the best out of the situation with functions and we are now asking for the server to dual purpose the call command. Is there a technical reason why this is not possible ? Dave Cramer da...@postgresintl.com www.postgresintl.com > >

Reviving the "Stopping logical replication protocol" patch from Vladimir Gordichuk

2018-07-24 Thread Dave Cramer
the patches and attached them for consideration. JDBC tests here https://github.com/pgjdbc/pgjdbc/blob/master/pgjdbc/src/test/java/org/postgresql/replication/LogicalReplicationTest.java all pass Regards, Dave Cramer 0004-Add-test-for-pg_recvlogical-to-stop-replication.patch Description: Binary data

Re: Stored procedures and out parameters

2018-08-30 Thread Dave Cramer
int. Nevertheless, I predict that this is going to be an ongoing > source of pain for a long time to come. > > Undoubtedly.. surely the opportunity to do something about this has not passed as this has not been officially released ? Dave Cramer da...@postgresintl.com www.postgresintl.com

Re: How can we submit code patches that implement our (pending) patents?

2018-07-06 Thread Dave Cramer
e other software under Apache > License. > > Certainly there is history of people using PG code for non-PostgreSQL or at least commercial derivative work. Greenplum for example. Dave Cramer da...@postgresintl.com www.postgresintl.com

pg_recvlogical use of SIGHUP

2018-07-06 Thread Dave Cramer
to be able to change the file name and create a new file based on some form of template ? Am I missing something ? Dave Cramer

Re: pg_recvlogical use of SIGHUP

2018-07-06 Thread Dave Cramer
On 6 July 2018 at 14:11, Andres Freund wrote: > Hi, > > On 2018-07-06 13:49:37 -0400, Dave Cramer wrote: > > There is some undocumented (nothing in the docs) code that allows for > > closing reopening the output file for pg_recvlogical. > > > > Since this do

Re: pg_recvlogical use of SIGHUP

2018-07-06 Thread Dave Cramer
> > > On 6 July 2018 at 14:11, Andres Freund wrote: > >> Hi, >> >> On 2018-07-06 13:49:37 -0400, Dave Cramer wrote: >> > There is some undocumented (nothing in the docs) code that allows for >> > closing reopening the output file for pg_recvlogic

Re: [HACKERS] Client Connection redirection support for PostgreSQL

2018-07-13 Thread Dave Cramer
e proliferation of cloud based implementations I can see this being a useful feature. Regards, Dave Cramer

Re: Proposal: Adding json logging

2018-04-15 Thread Dave Cramer
tools like jq, > reading and querying json on the command line is simple and user friendly, > and using json for logging capture and aggregation is widely supporting and > embraced. > Exactly what are you logging here ??? Why would I need to see a multi-dimensional array in the log ? Dave Cramer da...@postgresintl.com www.postgresintl.com

Re: Built-in connection pooling

2018-04-19 Thread Dave Cramer
On Thu, Apr 19, 2018, 9:24 AM Konstantin Knizhnik, < k.knizh...@postgrespro.ru> wrote: > > > On 19.04.2018 07:46, Tsunakawa, Takayuki wrote: > > From: Konstantin Knizhnik [mailto:k.knizh...@postgrespro.ru] > > Oracle, for example, you can create dedicated and non-dedicated backends. > >> I wonder

v11 transaction semantics inside procedures

2018-09-20 Thread Dave Cramer
transaction. Is there anything else I am missing ? Does DDL get applied after the transaction ends ? I do find this somewhat surprising as Postgres typically requires a BEGIN statement to start a transaction block. Thanks Dave Cramer

Re: Reviving the "Stopping logical replication protocol" patch from Vladimir Gordichuk

2019-01-15 Thread Dave Cramer
Dave Cramer On Sun, 13 Jan 2019 at 23:19, Craig Ringer wrote: > On Mon, 3 Dec 2018 at 19:38, Dave Cramer wrote: > >> Dmitry, >> >> Please see attached rebased patches >> > > I'm fine with patch 0001, though I find this comment a bit hard to follow: > &g

Re: Libpq support to connect to standby server as priority

2019-01-15 Thread Dave Cramer
only" instead, and people > supported that compromise by saying "read only status is more useful than > whether the server is standby or not," I'm afraid. > > The original desire should have been the ability to connect to a primary > or a standby. So, I

Re: Libpq support to connect to standby server as priority

2019-01-17 Thread Dave Cramer
>> 2) If there's no node on which pg_is_in_recovery() returns false, then > >>we need to retry until we find it. To not retry forever, there > >>should be a timeout counter parameter. > >> > >> > > IIRC this is essentially what pgJDBC doe

Re: Reviving the "Stopping logical replication protocol" patch from Vladimir Gordichuk

2019-01-20 Thread Dave Cramer
Dave Cramer On Tue, 15 Jan 2019 at 07:53, Dave Cramer wrote: > > Dave Cramer > > > On Sun, 13 Jan 2019 at 23:19, Craig Ringer wrote: > >> On Mon, 3 Dec 2018 at 19:38, Dave Cramer wrote: >> >>> Dmitry, >>> >>> Please see attached reb

Re: Libpq support to connect to standby server as priority

2019-01-17 Thread Dave Cramer
On Tue, 15 Jan 2019 at 23:21, Tsunakawa, Takayuki < tsunakawa.ta...@jp.fujitsu.com> wrote: > From: Dave Cramer [mailto:p...@fastcrypt.com] > > The original desire should have been the ability to connect to a > > primary or a standby. So, I think we should go back to th

Re: Libpq support to connect to standby server as priority

2019-01-17 Thread Dave Cramer
assume that >other nodes are standbys. done. > > 2) If there's no node on which pg_is_in_recovery() returns false, then >we need to retry until we find it. To not retry forever, there >should be a timeout counter parameter. > > IIRC this is essentially what pgJDBC does. Dave Cramer da...@postgresintl.com www.postgresintl.com > >

Re: Libpq support to connect to standby server as priority

2019-01-17 Thread Dave Cramer
On Thu, 17 Jan 2019 at 05:59, Laurenz Albe wrote: > Tsunakawa, Takayuki wrote: > > From: Tom Lane [mailto:t...@sss.pgh.pa.us] > > > The problem here of course is that whoever invented > target_session_attrs > > > was unconcerned with following that precedent, so what we have is > > >

Re: Libpq support to connect to standby server as priority

2019-01-17 Thread Dave Cramer
On Thu, 17 Jan 2019 at 19:09, Tsunakawa, Takayuki < tsunakawa.ta...@jp.fujitsu.com> wrote: > From: Dave Cramer [mailto:p...@fastcrypt.com] > > >> 2) If there's no node on which pg_is_in_recovery() returns > false, > > then > > >>we ne

Re: Libpq support to connect to standby server as priority

2019-01-17 Thread Dave Cramer
On Thu, 17 Jan 2019 at 19:15, Tatsuo Ishii wrote: > > On Thu, 17 Jan 2019 at 18:03, Tatsuo Ishii wrote: > > > >> > On Wed, 16 Jan 2019 at 01:02, Tatsuo Ishii > wrote: > >> > > >> >> > From: Tatsuo Ishii [mailto:is...@sraoss.co.jp] > >> >> >> But pg_is_in_recovery() returns true even for a

Re: Libpq support to connect to standby server as priority

2019-01-17 Thread Dave Cramer
On Thu, 17 Jan 2019 at 19:38, Tatsuo Ishii wrote: > >> >> >> > From: Tatsuo Ishii [mailto:is...@sraoss.co.jp] > >> >> >> >> But pg_is_in_recovery() returns true even for a promoting > >> standby. So > >> >> >> >> you have to wait and retry to send pg_is_in_recovery() until it > >> >> >> >>

Re: Libpq support to connect to standby server as priority

2019-01-17 Thread Dave Cramer
On Thu, 17 Jan 2019 at 19:56, Tatsuo Ishii wrote: > >> > I'm curious; under what circumstances would the above occur? > >> > >> Former primary goes down and one of standbys is promoting but it is > >> not promoted to new primary yet. > >> > > > > seems like JDBC might have some work to

Re: Reviving the "Stopping logical replication protocol" patch from Vladimir Gordichuk

2018-11-30 Thread Dave Cramer
Why is this being closed? I did not see the first email looking for clarification. The history is the original author dropped off the planet (no idea where he is) I can certainly rebase it. Dave Cramer On Fri, 30 Nov 2018 at 18:00, Dmitry Dolgov <9erthali...@gmail.com> wrote: > >

Re: Reviving the "Stopping logical replication protocol" patch from Vladimir Gordichuk

2018-11-30 Thread Dave Cramer
Dmitry, Thanks, I have done a preliminary check and it seems pretty straightforward. I will clean it up for Monday Thanks for your patience! Dave Cramer On Fri, 30 Nov 2018 at 18:22, Dmitry Dolgov <9erthali...@gmail.com> wrote: > On Sat, Dec 1, 2018 at 12:17 AM Dave Cram

Re: extended query protcol violation?

2018-12-08 Thread Dave Cramer
ill I would say this is buggy > because of the reason Tom said, and I agree with him. > Curious what client is this that is violating the protocol. Dave Cramer da...@postgresintl.com www.postgresintl.com > >

Re: extended query protcol violation?

2018-12-08 Thread Dave Cramer
On Sat, 8 Dec 2018 at 07:50, Tatsuo Ishii wrote: > > Curious what client is this that is violating the protocol. > > I heard it was a Java program. > This is not surprising there are a proliferation of non-blocking implementations, probably approaching 10 different implementati

Re: extended query protcol violation?

2018-12-08 Thread Dave Cramer
code is notorious for not reading warnings, I'd say no That said I'd probably be in favour of a DEBUG mode that did warn. Dave Cramer da...@postgresintl.com www.postgresintl.com

Re: Reviving the "Stopping logical replication protocol" patch from Vladimir Gordichuk

2018-12-03 Thread Dave Cramer
Dmitry, Please see attached rebased patches Dave Cramer On Fri, 30 Nov 2018 at 18:52, Dmitry Dolgov <9erthali...@gmail.com> wrote: > >On Sat, Dec 1, 2018 at 12:49 AM Dave Cramer wrote: > > > > Thanks, I have done a preliminary check and it seems pretty > straightfo

Re: Libpq support to connect to standby server as priority

2018-11-21 Thread Dave Cramer
. > > And to enforce Robert's argument even further almost every pool implementation I am aware of has a keep alive query. So why not use the opportunity to check to see if is a primary or standby at the same time Dave Cramer da...@postgresintl.com www.postgresintl.com > >

Re: Libpq support to connect to standby server as priority

2018-11-20 Thread Dave Cramer
points out as being relevant to this discussion ISTM that this is becoming a half baked "feature" that is being cobbled together instead of being designed. Admittedly biased but I agree with Vladimir that libpq did not implement the above feature using the same name and semantics. This just serves to confuse the users. Just my 2c worth Dave Cramer

ssl tests README and certs

2018-09-14 Thread Dave Cramer
in src/test/ssl the README suggest that the Makefile can be used to recreate the ssl directory, however there are no rules to create *_ca.crt|key. Am I missing something ? Dave Cramer

Re: ssl tests README and certs

2018-09-16 Thread Dave Cramer
On Sun, 16 Sep 2018 at 14:41, Heikki Linnakangas wrote: > On 14/09/18 18:49, Dave Cramer wrote: > > in src/test/ssl the README suggest that the Makefile can be used to > > recreate the ssl directory, however there are no rules to create > > *_ca.crt|key. Am I missing somet

Re: Libpq support to connect to standby server as priority

2019-02-28 Thread Dave Cramer
r to the secondary instance, but instead allow it to process user queries throughout the maintenance." see this for the thread. https://www.postgresql.org/message-id/VI1PR05MB5295AE43EF9525EACC9E57ECBC750%40VI1PR05MB5295.eurprd05.prod.outlook.com Dave Cramer da...@postgresintl.com www.postgresintl.com

Re: Reviving the "Stopping logical replication protocol" patch from Vladimir Gordichuk

2019-02-16 Thread Dave Cramer
Andres, Thanks for looking at this. FYI, I did not originally write this, rather the original author has not replied to requests. JDBC could use this, I assume others could as well. That said I'm certainly open to suggestions on how to do this. Craig, do you have any other ideas? Dave Cramer

Re: change password_encryption default to scram-sha-256?

2019-04-08 Thread Dave Cramer
/SCRAM support. > > On Debian, stretch is on 9.4. buster has 11 packaged, and JDBC is > shipping with SCRAM support. > > Honestly what JDBC driver XYZ distro ships with is a red herring. Any reasonably complex java program is going to use maven and pull it's dependencies. That said from a driver developer, I support pushing this decision off to PG13 Dave Cramer da...@postgresintl.com www.postgresintl.com > >

Re: change password_encryption default to scram-sha-256?

2019-04-08 Thread Dave Cramer
On Mon, 8 Apr 2019 at 16:38, Tom Lane wrote: > Dave Cramer writes: > >> If someone installs a postgres RPM/DEB from postgresql.org, they could > >> also install postgresql-jdbc, right ? > > > I would guess there might be some distro specific java apps th

Re: change password_encryption default to scram-sha-256?

2019-04-08 Thread Dave Cramer
On Mon, 8 Apr 2019 at 16:07, Alvaro Herrera wrote: > On 2019-Apr-08, Dave Cramer wrote: > > > > IIUC the vast majority of clients already support SCRAM auth. So the > > > vast majority of PG users can take advantage of the additional > security. > > > I think

Re: change password_encryption default to scram-sha-256?

2019-04-08 Thread Dave Cramer
as mentioned any reasonably complex Java app is going to ensure it has the correct versions for their app using Maven. Dave Cramer da...@postgresintl.com www.postgresintl.com >

Re: change password_encryption default to scram-sha-256?

2019-04-08 Thread Dave Cramer
d apparently they > already have working patches for SCRAM. > We have more than patches this is already in the driver. What do you mean by "massive-adoption exception" Dave Cramer da...@postgresintl.com www.postgresintl.com > >

This seems like very unfriendly behaviour

2019-05-25 Thread Dave Cramer
ubtruncate -+--+--+---+---+---+- (0 rows) Dave Cramer

Re: This seems like very unfriendly behaviour

2019-05-26 Thread Dave Cramer
On Sun, 26 May 2019 at 01:40, Jaime Casanova wrote: > On Sat, 25 May 2019 at 08:35, Dave Cramer wrote: > > > > How do I get rid of this slot ? > > > > select pg_drop_replication_slot('mysub'); > > ERROR: replication slot "mysub" is active for

Re: Binary support for pgoutput plugin

2019-06-04 Thread Dave Cramer
Dave Cramer On Tue, 4 Jun 2019 at 16:30, Andres Freund wrote: > Hi, > > On 2019-06-04 15:47:04 -0400, Dave Cramer wrote: > > On Mon, 3 Jun 2019 at 20:54, David Fetter wrote: > > > > > On Mon, Jun 03, 2019 at 10:49:54AM -0400, Dave Cramer wrote: > > >

Re: Binary support for pgoutput plugin

2019-06-04 Thread Dave Cramer
Dave Cramer On Mon, 3 Jun 2019 at 20:54, David Fetter wrote: > On Mon, Jun 03, 2019 at 10:49:54AM -0400, Dave Cramer wrote: > > Is there a reason why pgoutput sends data in text format? Seems to > > me that sending data in binary would provide a considerable > > pe

Re: Binary support for pgoutput plugin

2019-06-04 Thread Dave Cramer
On Tue, 4 Jun 2019 at 16:46, Andres Freund wrote: > Hi, > > On 2019-06-04 16:39:32 -0400, Dave Cramer wrote: > > On Tue, 4 Jun 2019 at 16:30, Andres Freund < > andres.fre...@enterprisedb.com> > > wrote: > > > > There's also no reason that I am aware that

Binary support for pgoutput plugin

2019-06-03 Thread Dave Cramer
Is there a reason why pgoutput sends data in text format? Seems to me that sending data in binary would provide a considerable performance improvement. Dave Cramer

Re: Binary support for pgoutput plugin

2019-06-04 Thread Dave Cramer
On Tue, 4 Jun 2019 at 18:08, Andres Freund wrote: > Hi, > > On 2019-06-05 00:05:02 +0200, David Fetter wrote: > > Would it make sense to work toward a binary format that's not > > architecture-specific? I recall from COPY that our binary format is > > not standardized across, for example, big-

Re: Binary support for pgoutput plugin

2019-06-05 Thread Dave Cramer
example at the > write_tuple/read_tuple/decide_datum_transfer in > > https://github.com/2ndQuadrant/pglogical/blob/REL2_x_STABLE/pglogical_proto_native.c > that can help you give some ideas on how to approach this. > Thanks for the tip! Dave Cramer > > >

Re: Binary support for pgoutput plugin

2019-06-05 Thread Dave Cramer
On Wed, 5 Jun 2019 at 07:21, Dave Cramer wrote: > Hi, > > > On Wed, 5 Jun 2019 at 07:18, Petr Jelinek > wrote: > >> Hi, >> >> On 05/06/2019 00:08, Andres Freund wrote: >> > Hi, >> > >> > On 2019-06-05 00:05:02 +0200, David Fetter

Re: [HACKERS] Built-in plugin for logical decoding output

2019-05-29 Thread Dave Cramer
;> Álvaro >> >> >> -- >> >> Alvaro Hernandez >> >> >> --- >> OnGres >> >> I believe there is a valid reason for providing a reasonably feature complete plugin in core. Specifically in instances such as cloud p

Re: Binary support for pgoutput plugin

2019-06-05 Thread Dave Cramer
Hi, On Wed, 5 Jun 2019 at 12:01, Andres Freund wrote: > Hi > > On June 5, 2019 8:51:10 AM PDT, Dave Cramer wrote: > >On Wed, 5 Jun 2019 at 07:21, Dave Cramer wrote: > > > >> Hi, > >> > >> > >> On Wed, 5 Jun 2019 at 07:18, Petr Jelinek

Re: Binary support for pgoutput plugin

2019-06-05 Thread Dave Cramer
Hi, On Wed, 5 Jun 2019 at 18:50, Andres Freund wrote: > Hi, > > On 2019-06-05 18:47:57 -0400, Dave Cramer wrote: > > So one of the things they would like added is to get not null information > > in the schema record. This is so they can mark the field Optional in

Re: Binary support for pgoutput plugin

2019-06-14 Thread Dave Cramer
Dave Cramer On Fri, 14 Jun 2019 at 14:36, Tomas Vondra wrote: > On Wed, Jun 12, 2019 at 10:35:48AM -0400, Dave Cramer wrote: > >On Mon, 10 Jun 2019 at 07:49, Petr Jelinek > >wrote: > > > >> Hi, > >> > >> On 10/06/2019 13:27, Da

Re: Binary support for pgoutput plugin

2019-06-10 Thread Dave Cramer
So back to binary output. >From what I can tell the place to specify binary options would be in the create publication and or in replication slots? The challenge as I see it is that the subscriber would have to be able to decode binary output. Any thoughts on how to handle this? At the moment

Re: Binary support for pgoutput plugin

2019-06-11 Thread Dave Cramer
ata in logicalrep_read_tuple but that would require moving a lot of the logic currently in worker.c to proto.c. This seems minimally invasive. and thanks Petr for the tip to use pglogical for ideas. Thanks, Dave Cramer > > 0001-First-pass-at-working-code-without-subscription-opti.patch Descriptio

Re: Binary support for pgoutput plugin

2019-06-12 Thread Dave Cramer
On Mon, 10 Jun 2019 at 07:49, Petr Jelinek wrote: > Hi, > > On 10/06/2019 13:27, Dave Cramer wrote: > > So back to binary output. > > > > From what I can tell the place to specify binary options would be in the > > create publication and or in replication slot

Re: Binary support for pgoutput plugin

2019-06-17 Thread Dave Cramer
On Fri, 14 Jun 2019 at 15:42, Dave Cramer wrote: > > Dave Cramer > > > On Fri, 14 Jun 2019 at 14:36, Tomas Vondra > wrote: > >> On Wed, Jun 12, 2019 at 10:35:48AM -0400, Dave Cramer wrote: >> >On Mon, 10 Jun 2019 at 07:49, Petr Jelinek > > >> >

Binary support for pgoutput plugin

2019-06-08 Thread Dave Cramer
This should have gone to hackers as well -- Forwarded message - From: Dave Cramer Date: Sat, Jun 8, 2019, 6:41 PM Subject: Re: Binary support for pgoutput plugin To: Tomas Vondra On Sat, Jun 8, 2019, 6:27 PM Tomas Vondra, wrote: > On Fri, Jun 07, 2019 at 06:01:12PM -0

Re: Binary support for pgoutput plugin

2019-06-08 Thread Dave Cramer
On Sat, 8 Jun 2019 at 20:09, Andres Freund wrote: > Hi, > > On 2019-06-08 19:41:34 -0400, Dave Cramer wrote: > > So the reason we are discussing using pgoutput plugin is because it is > part > > of core and guaranteed to be in cloud providers solutions. > >

Re: initdb recommendations

2019-05-24 Thread Dave Cramer
On Fri, 24 May 2019 at 07:48, Joe Conway wrote: > On 5/23/19 10:30 PM, Stephen Frost wrote: > > Greetings, > > > > * Tom Lane (t...@sss.pgh.pa.us) wrote: > >> "Jonathan S. Katz" writes: > >> > For now I have left in the password based method to be scram-sha-256 > as > >> > I am optimistic about

Re: Binary support for pgoutput plugin

2019-07-04 Thread Dave Cramer
On Wed, 5 Jun 2019 at 18:50, Andres Freund wrote: > Hi, > > On 2019-06-05 18:47:57 -0400, Dave Cramer wrote: > > So one of the things they would like added is to get not null information > > in the schema record. This is so they can mark the field Optional in > Java.

Proposal to add GUC_REPORT to lc_monetary, lc_numeric and search_path

2019-07-04 Thread Dave Cramer
these statements fail. This seems like a rather innocuous change as the protocol is not changed, rather the amount of information returned on startup is increased marginally. I've included the authors of the npgsql and the node drivers in the email for their input. Dave Cramer

Re: Fix doc bug in logical replication.

2019-06-27 Thread Dave Cramer
On Thu, 27 Jun 2019 at 14:20, Tomas Vondra wrote: > On Thu, Jun 27, 2019 at 01:46:47PM -0400, Dave Cramer wrote: > >On Thu, 27 Jun 2019 at 12:50, Tomas Vondra > >wrote: > > > >> On Sun, Jun 23, 2019 at 10:26:47PM -0400, Robert Treat wrote: > >> >On Sun

Re: Fix doc bug in logical replication.

2019-06-27 Thread Dave Cramer
On Thu, 27 Jun 2019 at 12:50, Tomas Vondra wrote: > On Sun, Jun 23, 2019 at 10:26:47PM -0400, Robert Treat wrote: > >On Sun, Jun 23, 2019 at 1:25 PM Peter Eisentraut > > wrote: > >> > >> On 2019-04-12 19:52, Robert Treat wrote: > >> > It is clear to me that the docs are wrong, but I don't see

Re: let's make the list of reportable GUCs configurable (was Re: Add %r substitution for psql prompts to show recovery status)

2019-07-11 Thread Dave Cramer
On Thu, 11 Jul 2019 at 15:07, Robert Haas wrote: > On Thu, Jul 11, 2019 at 2:29 PM Dave Cramer wrote: > > So if I understand this correctly if user bob has altered his search > path and there is a security-definer function called owned by him then > > the search pa

Re: let's make the list of reportable GUCs configurable (was Re: Add %r substitution for psql prompts to show recovery status)

2019-07-10 Thread Dave Cramer
On Wed, 10 Jul 2019 at 09:11, Robert Haas wrote: > On Tue, Jul 9, 2019 at 2:32 PM Dave Cramer wrote: > > So did this die from lack of interest? > > > > I have proposed in another thread adding more GUC REPORT variables, but > I see this as a much better way. >

Re: let's make the list of reportable GUCs configurable (was Re: Add %r substitution for psql prompts to show recovery status)

2019-07-11 Thread Dave Cramer
On Thu, 11 Jul 2019 at 10:06, Robert Haas wrote: > On Thu, Jul 11, 2019 at 8:23 AM Dave Cramer wrote: > > See attached for an initial patch. If this is an acceptable way to go I > will add tests and documentation > > And clean up the code? Doesn't look crazy on a quick glan

Re: let's make the list of reportable GUCs configurable (was Re: Add %r substitution for psql prompts to show recovery status)

2019-07-11 Thread Dave Cramer
On Wed, 10 Jul 2019 at 16:34, Tom Lane wrote: > Robert Haas writes: > > On Wed, Jul 10, 2019 at 9:59 AM Dave Cramer wrote: > >> I'm still a bit conflicted about what to do with search_path as I do > believe this is potentially a security issue. > >> It may be

Re: let's make the list of reportable GUCs configurable (was Re: Add %r substitution for psql prompts to show recovery status)

2019-07-11 Thread Dave Cramer
t > > the list to see if a newly-defined variable should be marked GUC_REPORT. > This suggests creating a list in guc.c instead. I'm unclear as to the visibility of variables in there How do I make this list visible only to the session ? Dave Cramer da...@postgresintl.com www.postgresintl.com > >

Re: let's make the list of reportable GUCs configurable (was Re: Add %r substitution for psql prompts to show recovery status)

2019-07-11 Thread Dave Cramer
On Wed, 10 Jul 2019 at 16:22, Robert Haas wrote: > On Wed, Jul 10, 2019 at 9:59 AM Dave Cramer wrote: > > I'm still a bit conflicted about what to do with search_path as I do > believe this is potentially a security issue. > > It may be that we always want to report that and p

Re: Procedure support improvements

2019-08-26 Thread Dave Cramer
On Mon, 26 Aug 2019 at 14:14, Tom Lane wrote: > Laurenz Albe writes: > > Dave Cramer wrote: > > test=> BEGIN; > > BEGIN > > test=> CALL testproc(); > > ERROR: invalid transaction termination > > CONTEXT: PL/pgSQL function testproc()

pg_upgrade issues

2019-09-09 Thread Dave Cramer
? I realize oids are not guaranteed to be unique, but this seems to be quite a coincidence. Dave Cramer

Re: Built-in connection pooler

2019-07-27 Thread Dave Cramer
Responses inline. I just picked up this thread so please bear with me. On Fri, 26 Jul 2019 at 16:24, Tomas Vondra wrote: > Hi Konstantin, > > I've started reviewing this patch and experimenting with it, so let me > share some initial thoughts. > > > 1) not handling session state (yet) > > I

Re: Re: Reviving the "Stopping logical replication protocol" patch from Vladimir Gordichuk

2019-07-08 Thread Dave Cramer
On Mon, 8 Jul 2019 at 06:40, Thomas Munro wrote: > On Thu, Mar 7, 2019 at 8:19 PM David Steele wrote: > > On 2/16/19 10:38 PM, Dave Cramer wrote: > > > Thanks for looking at this. FYI, I did not originally write this, > rather > > > the original author has not r

Re: Proposal to add GUC_REPORT to lc_monetary, lc_numeric and search_path

2019-07-09 Thread Dave Cramer
there was a proposal to make reportable GUC's configurable here https://www.postgresql.org/message-id/ca+tgmobsxsy0kfr_vdqqoxjxqafnesfxf_-darne+qhhqcw...@mail.gmail.com I don't really care which one gets implemented, although I think the latter makes more sense. Dave Cramer On Fri, 5 Jul 2019 at 08:05, Shay

Re: let's make the list of reportable GUCs configurable (was Re: Add %r substitution for psql prompts to show recovery status)

2019-07-09 Thread Dave Cramer
T variables, but I see this as a much better way. I'm willing to code the patch if we can get some buy in here ? Dave Cramer da...@postgresintl.com www.postgresintl.com

Re: Binary support for pgoutput plugin

2019-11-11 Thread Dave Cramer
On Fri, 8 Nov 2019 at 11:20, Dmitry Dolgov <9erthali...@gmail.com> wrote: > > On Tue, Nov 05, 2019 at 07:16:10AM -0500, Dave Cramer wrote: > > > > See attached > > --- a/src/backend/replication/logical/worker.c > +++ b/src/backend/replication/logical/

Re: Binary support for pgoutput plugin

2019-11-11 Thread Dave Cramer
On Mon, 11 Nov 2019 at 12:04, Alvaro Herrera wrote: > On 2019-Nov-11, Dave Cramer wrote: > > > Previously someone mentioned that we need to confirm whether the two > > servers are compatible for binary or not. > > > > Checking to make sure the two servers have th

Re: Binary support for pgoutput plugin

2019-11-11 Thread Dave Cramer
On Mon, 11 Nov 2019 at 12:07, Dave Cramer wrote: > > > On Mon, 11 Nov 2019 at 12:04, Alvaro Herrera > wrote: > >> On 2019-Nov-11, Dave Cramer wrote: >> >> > Previously someone mentioned that we need to confirm whether the two >> > servers are com

Re: Binary support for pgoutput plugin

2019-11-11 Thread Dave Cramer
On Mon, 11 Nov 2019 at 15:17, Alvaro Herrera wrote: > On 2019-Nov-11, Dave Cramer wrote: > > > Following 2 patches address Dmitry's concern and check for compatibility. > > Please resend the whole patchset, so that the patch tester can verify > the series. (Doing

Re: Binary support for pgoutput plugin

2019-10-30 Thread Dave Cramer
On Sun, 27 Oct 2019 at 11:00, Dmitry Dolgov <9erthali...@gmail.com> wrote: > > On Mon, Jun 17, 2019 at 10:29:26AM -0400, Dave Cramer wrote: > > > Which is what I have done. Thanks > > > > > > I've attached both patches for comments. > > > I sti

Re: Binary support for pgoutput plugin

2019-11-05 Thread Dave Cramer
On Sun, 3 Nov 2019 at 21:47, Thomas Munro wrote: > On Thu, Oct 31, 2019 at 3:03 AM Dave Cramer wrote: > > Ok, I've rebased and reverted logicalrep_read_insert > > Hi Dave, > > From the code style police (actually just from cfbot, which is set up > to complain about decla

Re: let's make the list of reportable GUCs configurable (was Re: Add %r substitution for psql prompts to show recovery status)

2019-11-05 Thread Dave Cramer
On Sun, 3 Nov 2019 at 19:40, Thomas Munro wrote: > On Wed, Oct 16, 2019 at 6:49 PM Dave Cramer wrote: > > Here's an updated patch that addresses some of Andres' concerns > specifically does not use strtok. > > Hi Dave, > > I think you need to s/strncasecmp/pg_strncas

client auth docs seem to have devolved

2019-12-17 Thread Dave Cramer
While following an old link to https://www.postgresql.org/docs/10/auth-methods.html I see a list of links to authentication methods. However: When I hit the current version https://www.postgresql.org/docs/current/auth-methods.html There are absolutely no links... Dave Cramer

Re: client auth docs seem to have devolved

2019-12-17 Thread Dave Cramer
On Tue, 17 Dec 2019 at 06:53, Magnus Hagander wrote: > On Tue, Dec 17, 2019 at 12:43 PM Dave Cramer wrote: > >> While following an old link to >> https://www.postgresql.org/docs/10/auth-methods.html >> >> I see a list of links to authentication methods. However

  1   2   3   4   >