Re: pg_basebackup ignores the existing data directory permissions

2019-03-17 Thread Stephen Frost
Greetings, * Robert Haas (robertmh...@gmail.com) wrote: > On Thu, Mar 14, 2019 at 7:34 PM Peter Eisentraut > wrote: > > I think the potential problems of getting this wrong are bigger than the > > issue we are trying to fix. > > I think the question is: how do we know what the user intended? If

Re: Google Summer of Code

2019-03-17 Thread Stephen Frost
Greetings, * Auguste Comte (minasi...@gmail.com) wrote: > Hello Moodle Team, This isn't the Moodle team, I'm guessing you sent this to the wrong place or at least forgot to update your email. > I am a student who is currently take computer science classes at Glendale > Community College, AZ wh

Re: Data-only pg_rewind, take 2

2019-03-17 Thread Stephen Frost
Greetings, * Michael Paquier (mich...@paquier.xyz) wrote: > On Sun, Mar 17, 2019 at 09:00:57PM +0800, Chris Travers wrote: > > I also added test cases and some docs. I don't know if the docs are > > sufficient. Feedback is appreciated. > > To be honest, I don't think that this approach is a goo

Re: Online verification of checksums

2019-03-17 Thread Stephen Frost
Greetings, * Michael Paquier (mich...@paquier.xyz) wrote: > On Mon, Mar 18, 2019 at 01:43:08AM -0400, Stephen Frost wrote: > > To be clear, I agree completely that we don't want to be reporting false > > positives or "this might mean corruption!" to users running th

Re: Online verification of checksums

2019-03-18 Thread Stephen Frost
Greetings, * Michael Banck (michael.ba...@credativ.de) wrote: > Am Montag, den 18.03.2019, 02:38 -0400 schrieb Stephen Frost: > > * Michael Paquier (mich...@paquier.xyz) wrote: > > > On Mon, Mar 18, 2019 at 01:43:08AM -0400, Stephen Frost wrote: > > > > To be cle

Re: Online verification of checksums

2019-03-18 Thread Stephen Frost
Greetings, * Michael Paquier (mich...@paquier.xyz) wrote: > On Mon, Mar 18, 2019 at 02:38:10AM -0400, Stephen Frost wrote: > > Uh, we are, of course, going to have partial reads- we just need to > > handle them appropriately, and that's not hard to do in a way that we

Re: Online verification of checksums

2019-03-18 Thread Stephen Frost
Greetings, On Mon, Mar 18, 2019 at 15:52 Michael Banck wrote: > Hi. > > Am Montag, den 18.03.2019, 03:34 -0400 schrieb Stephen Frost: > > * Michael Banck (michael.ba...@credativ.de) wrote: > > > Am Montag, den 18.03.2019, 02:38 -0400 schrieb Stephen Frost: > &g

Re: Online verification of checksums

2019-03-18 Thread Stephen Frost
Greetings, On Tue, Mar 19, 2019 at 04:15 Michael Banck wrote: > Am Montag, den 18.03.2019, 16:11 +0800 schrieb Stephen Frost: > > On Mon, Mar 18, 2019 at 15:52 Michael Banck > wrote: > > > Am Montag, den 18.03.2019, 03:34 -0400 schrieb Stephen Frost: > > > >

Re: Add exclusive backup deprecation notes to documentation

2019-03-18 Thread Stephen Frost
Greetings, * Peter Eisentraut (peter.eisentr...@2ndquadrant.com) wrote: > On 2019-03-07 10:33, David Steele wrote: > > On 3/1/19 3:14 PM, Laurenz Albe wrote: > >> Magnus Hagander wrote: > >>> Maybe have the first note say "This method is deprecated bceause it has > >>> serious > >>> risks (see be

Re: Add exclusive backup deprecation notes to documentation

2019-03-18 Thread Stephen Frost
Greetings, * Robert Haas (robertmh...@gmail.com) wrote: > On Mon, Mar 18, 2019 at 11:13 PM Stephen Frost wrote: > > I don't view it as up for much debate. > > In other words, you're not willing to listen to what other people > think about this issue. I have lis

Re: Add exclusive backup deprecation notes to documentation

2019-03-18 Thread Stephen Frost
Greetings, * Andres Freund (and...@anarazel.de) wrote: > On 2019-03-18 23:35:07 -0400, Stephen Frost wrote: > > * Robert Haas (robertmh...@gmail.com) wrote: > > > On Mon, Mar 18, 2019 at 11:13 PM Stephen Frost wrote: > > > > I don't view it as up for much

Re: Compressed TOAST Slicing

2019-03-19 Thread Stephen Frost
Greetings, * Paul Ramsey (pram...@cleverelephant.ca) wrote: > > On Mar 18, 2019, at 7:34 AM, Robert Haas wrote: > > +1. I think Paul had it right originally. > > In that spirit, here is a “one pglz_decompress function, new parameter” > version for commit. Alright, I've been working through th

Re: Online verification of checksums

2019-03-19 Thread Stephen Frost
Greetings, On Tue, Mar 19, 2019 at 23:59 Andres Freund wrote: > Hi, > > On 2019-03-19 16:52:08 +0100, Michael Banck wrote: > > Am Dienstag, den 19.03.2019, 11:22 -0400 schrieb Robert Haas: > > > It's torn pages that I am concerned about - the server is writing and > > > we are reading, and we ge

Re: Special role for subscriptions

2019-03-23 Thread Stephen Frost
Greetings, * Petr Jelinek (petr.jeli...@2ndquadrant.com) wrote: > On 23/03/2019 02:38, Michael Paquier wrote: > > On Fri, Mar 22, 2019 at 08:41:06PM +0800, Andrey Borodin wrote: > >> 22 марта 2019 г., в 19:17, Petr Jelinek > >> написал(а): > >>> I still don't like that we are running the subscri

Re: BUG #15708: RLS 'using' running as wrong user when called from a view

2019-03-25 Thread Stephen Frost
Greetings, * Dean Rasheed (dean.a.rash...@gmail.com) wrote: > On Thu, 21 Mar 2019 at 00:39, PG Bug reporting form > wrote: > > > > This fails, seemingly because the RLS on 'bar' is being checked by alice, > > instead of the view owner bob: > > Yes I agree, that appears to be a bug. The subquery

Re: basebackup checksum verification

2019-03-26 Thread Stephen Frost
Greetings, * Andres Freund (and...@anarazel.de) wrote: > As detailed in > https://postgr.es/m/20190319200050.ncuxejradurjakdc%40alap3.anarazel.de > the way the backend's basebackup checksum verification works makes its > error detection capabilities very dubious. I disagree that it's 'very dubiou

Re: basebackup checksum verification

2019-03-26 Thread Stephen Frost
Greetings, * Tomas Vondra (tomas.von...@2ndquadrant.com) wrote: > On Tue, Mar 26, 2019 at 04:49:21PM -0700, Andres Freund wrote: > >On 2019-03-26 19:22:03 -0400, Stephen Frost wrote: > >>* Andres Freund (and...@anarazel.de) wrote: > >>> As detailed in > >&

Re: basebackup checksum verification

2019-03-26 Thread Stephen Frost
Greetings, * Tomas Vondra (tomas.von...@2ndquadrant.com) wrote: > On Tue, Mar 26, 2019 at 08:18:31PM -0400, Stephen Frost wrote: > >* Tomas Vondra (tomas.von...@2ndquadrant.com) wrote: > >>On Tue, Mar 26, 2019 at 04:49:21PM -0700, Andres Freund wrote: > >>>On 2019

Re: basebackup checksum verification

2019-03-26 Thread Stephen Frost
Greetings, * Andres Freund (and...@anarazel.de) wrote: > On 2019-03-26 20:18:31 -0400, Stephen Frost wrote: > > > >>I thought Robert's response was generally good, pointing out that > > > >>we're talking about this being an issue if the corruption happe

Re: basebackup checksum verification

2019-03-26 Thread Stephen Frost
Greetings, * Andres Freund (and...@anarazel.de) wrote: > On 2019-03-26 21:01:27 -0400, Stephen Frost wrote: > > I'm also not convinced that these changes to pg_basebackup will be free > > of issues that may impact users in a negative way, making me concerned > > that w

Re: Online verification of checksums

2019-03-29 Thread Stephen Frost
Greetings, * Magnus Hagander (mag...@hagander.net) wrote: > On Thu, Mar 28, 2019 at 10:19 PM Tomas Vondra > wrote: > > > On Thu, Mar 28, 2019 at 01:11:40PM -0700, Andres Freund wrote: > > >Hi, > > > > > >On 2019-03-28 21:09:22 +0100, Michael Banck wrote: > > >> I agree that the current patch mig

Re: Online verification of checksums

2019-03-29 Thread Stephen Frost
Greetings, * Andres Freund (and...@anarazel.de) wrote: > On 2019-03-29 11:30:15 -0400, Stephen Frost wrote: > > * Magnus Hagander (mag...@hagander.net) wrote: > > > On Thu, Mar 28, 2019 at 10:19 PM Tomas Vondra > > > > > > wrote: > > > > On Thu,

[PATCH v22] GSSAPI encryption support

2019-03-30 Thread Stephen Frost
Greetings, * Robbie Harwood (rharw...@redhat.com) wrote: > Stephen Frost writes: > > > One of the things that I really didn't care for in this patch was the > > use of the string buffers, without any real checks (except for "oh, > > you tried to allocated

Re: Compressed TOAST Slicing

2019-03-30 Thread Stephen Frost
Greetings, * Paul Ramsey (pram...@cleverelephant.ca) wrote: > > On Mar 19, 2019, at 4:47 AM, Stephen Frost wrote: > > * Paul Ramsey (pram...@cleverelephant.ca) wrote: > >>> On Mar 18, 2019, at 7:34 AM, Robert Haas wrote: > >>> +1. I think Paul had it right o

Re: [Proposal] Table-level Transparent Data Encryption (TDE) and Key Management Service (KMS)

2019-07-25 Thread Stephen Frost
Greetings, * Bruce Momjian (br...@momjian.us) wrote: > After talking to Joe Conway, I just want to mention that if we decide > that the LSN is unique among heap and index, or among heap or index, we > will need to make sure future WAL records retain this uniqueness. One thing comes to mind regard

Re: [Proposal] Table-level Transparent Data Encryption (TDE) and Key Management Service (KMS)

2019-07-25 Thread Stephen Frost
Greetings, * Bruce Momjian (br...@momjian.us) wrote: > On Thu, Jul 25, 2019 at 03:41:05PM -0400, Stephen Frost wrote: > > Greetings, > > > > * Bruce Momjian (br...@momjian.us) wrote: > > > After talking to Joe Conway, I just want to mention that if we decide >

Re: [Proposal] Table-level Transparent Data Encryption (TDE) and Key Management Service (KMS)

2019-07-25 Thread Stephen Frost
Greetings, * Bruce Momjian (br...@momjian.us) wrote: > On Thu, Jul 25, 2019 at 03:55:01PM -0400, Stephen Frost wrote: > > * Bruce Momjian (br...@momjian.us) wrote: > > > On Thu, Jul 25, 2019 at 03:41:05PM -0400, Stephen Frost wrote: > > > > * Bruce Mo

Re: [Proposal] Table-level Transparent Data Encryption (TDE) and Key Management Service (KMS)

2019-07-25 Thread Stephen Frost
Greetings, * Bruce Momjian (br...@momjian.us) wrote: > On Thu, Jul 25, 2019 at 05:50:57PM -0400, Stephen Frost wrote: > > > > > pg_upgrade seems immune to must of this, and that is by design. > > > > > However, I am hesitant to change the heap/index page format

Re: [Proposal] Table-level Transparent Data Encryption (TDE) and Key Management Service (KMS)

2019-07-25 Thread Stephen Frost
Greetings, * Bruce Momjian (br...@momjian.us) wrote: > On Thu, Jul 25, 2019 at 07:41:14PM -0400, Stephen Frost wrote: > > > You are right that we can allow it online, but we haven't been > > > discussing these cases since it is easy to do this because we have > > &

Re: pg_upgrade fails with non-standard ACL

2019-07-29 Thread Stephen Frost
Greetings, * Tom Lane (t...@sss.pgh.pa.us) wrote: > Bruce Momjian writes: > > On Thu, Jul 18, 2019 at 06:53:12PM +0300, Anastasia Lubennikova wrote: > >> pg_upgrade from 9.6 fails if old cluster had non-standard ACL > >> on pg_catalog functions that have changed between versions, > >> for example

Re: [PATCH] Stop ALTER SYSTEM from making bad assumptions

2019-08-02 Thread Stephen Frost
Greetings, On Fri, Aug 2, 2019 at 18:27 Tom Lane wrote: > Tomas Vondra writes: > > There seems to be a consensus that this this not a pg_basebackup issue > > (i.e. duplicate values don't make the file invalid), and it should be > > handled in ALTER SYSTEM. > > Yeah. I doubt pg_basebackup is th

Re: [PATCH] Stop ALTER SYSTEM from making bad assumptions

2019-08-02 Thread Stephen Frost
Greetings, On Fri, Aug 2, 2019 at 19:36 Ian Barwick wrote: > On 8/3/19 8:24 AM, Andres Freund wrote: > > Hi, > > > > On 2019-08-03 08:22:29 +0900, Ian Barwick wrote: > >> What I came up with shoehorned a stripped-down version of the backend > >> config parser into fe_utils and provides a functio

Re: [PATCH] Stop ALTER SYSTEM from making bad assumptions

2019-08-02 Thread Stephen Frost
Greetings, On Fri, Aug 2, 2019 at 18:47 Tom Lane wrote: > Stephen Frost writes: > > On Fri, Aug 2, 2019 at 18:27 Tom Lane wrote: > >>> The proposal seems to be to run through the .auto.conf file, remove any > >>> duplicates, and append the new entry

Re: [PATCH] Stop ALTER SYSTEM from making bad assumptions

2019-08-02 Thread Stephen Frost
Greetings, On Fri, Aug 2, 2019 at 20:46 Andres Freund wrote: > Hi, > > On 2019-08-02 20:27:25 -0400, Stephen Frost wrote: > > On Fri, Aug 2, 2019 at 18:47 Tom Lane wrote: > > > Stephen Frost writes: > > > > On Fri, Aug 2, 2019 at 18:27 Tom Lane wrote: &

Re: [PATCH] Stop ALTER SYSTEM from making bad assumptions

2019-08-05 Thread Stephen Frost
Greetings, * Tomas Vondra (tomas.von...@2ndquadrant.com) wrote: > On Fri, Aug 02, 2019 at 06:38:46PM -0400, Stephen Frost wrote: > >On Fri, Aug 2, 2019 at 18:27 Tom Lane wrote: > >>Tomas Vondra writes: > >>> There seems to be a consensus that this this not a

Re: block-level incremental backup

2019-08-05 Thread Stephen Frost
Greetings, * Robert Haas (robertmh...@gmail.com) wrote: > On Fri, Aug 2, 2019 at 9:13 AM vignesh C wrote: > > + rc = system(copycmd); > > I don't think this patch should be calling system() in the first place. +1. Thanks, Stephen signature.asc Description: PGP signature

Re: [PATCH] Stop ALTER SYSTEM from making bad assumptions

2019-08-05 Thread Stephen Frost
Greetings, * Tom Lane (t...@sss.pgh.pa.us) wrote: > Robert Haas writes: > > On Mon, Aug 5, 2019 at 12:25 PM Tom Lane wrote: > >> Perhaps as a future improvement, but it's not happening for v12, > >> at least not unless you accept "use ALTER SYSTEM in a standalone > >> backend" as a usable answer

Re: [PATCH] Stop ALTER SYSTEM from making bad assumptions

2019-08-05 Thread Stephen Frost
Greetings, * Robert Haas (robertmh...@gmail.com) wrote: > On Mon, Aug 5, 2019 at 10:21 AM Stephen Frost wrote: > > Just to be clear, I brought up this exact concern back in *November*: > > > > https://www.postgresql.org/message-id/20181127153405.GX3415%40tamriel.snowma

Re: [PATCH] Stop ALTER SYSTEM from making bad assumptions

2019-08-05 Thread Stephen Frost
Greetings, * Andres Freund (and...@anarazel.de) wrote: > On 2019-08-05 12:43:24 -0400, Tom Lane wrote: > > On the other hand, people have also opined that they want full error > > checking on the inserted values, and that seems out of reach with less > > than a full running system (mumble extensio

Re: [PATCH] Stop ALTER SYSTEM from making bad assumptions

2019-08-05 Thread Stephen Frost
Greetings, On Mon, Aug 5, 2019 at 14:11 Andres Freund wrote: > On 2019-08-05 13:34:39 -0400, Stephen Frost wrote: > > * Andres Freund (and...@anarazel.de) wrote: > > > On 2019-08-05 12:43:24 -0400, Tom Lane wrote: > > > > On the other hand, people have also op

Re: [PATCH] Stop ALTER SYSTEM from making bad assumptions

2019-08-05 Thread Stephen Frost
Greetings, On Mon, Aug 5, 2019 at 14:29 Tom Lane wrote: > Robert Haas writes: > > All we need to do to resolve this issue is have Tom commit his patch. > > I think Stephen is not being unreasonable to suggest that we need some > documentation about what external tools may safely do to pg.auto.c

Re: [PATCH] Stop ALTER SYSTEM from making bad assumptions

2019-08-05 Thread Stephen Frost
Greetings, On Mon, Aug 5, 2019 at 14:38 Robert Haas wrote: > On Mon, Aug 5, 2019 at 2:29 PM Tom Lane wrote: > > Robert Haas writes: > > > All we need to do to resolve this issue is have Tom commit his patch. > > > > I think Stephen is not being unreasonable to suggest that we need some > > doc

Re: [PATCH] Stop ALTER SYSTEM from making bad assumptions

2019-08-05 Thread Stephen Frost
Greetings, On Mon, Aug 5, 2019 at 14:43 Tom Lane wrote: > Robert Haas writes: > > On Mon, Aug 5, 2019 at 2:29 PM Tom Lane wrote: > >> I think Stephen is not being unreasonable to suggest that we need some > >> documentation about what external tools may safely do to pg.auto.conf. > >> So someb

Re: [PATCH] Stop ALTER SYSTEM from making bad assumptions

2019-08-05 Thread Stephen Frost
Greetings, * Tom Lane (t...@sss.pgh.pa.us) wrote: > Robert Haas writes: > > On Mon, Aug 5, 2019 at 2:42 PM Tom Lane wrote: > >> I don't think we need to go on about it at great length, but it seems > >> to me that it'd be reasonable to point out that (a) you'd be well > >> advised not to touch t

Re: [PATCH] Stop ALTER SYSTEM from making bad assumptions

2019-08-05 Thread Stephen Frost
Greetings, * Ian Barwick (ian.barw...@2ndquadrant.com) wrote: > On 8/6/19 9:52 AM, Stephen Frost wrote:> Greetings, > > * Tom Lane (t...@sss.pgh.pa.us) wrote: > >> Robert Haas writes: > >>> On Mon, Aug 5, 2019 at 2:42 PM Tom Lane wrote: > >>>>

Re: More issues with pg_verify_checksums and checksum verification in base backups

2019-08-06 Thread Stephen Frost
Greetings, * Michael Banck (michael.ba...@credativ.de) wrote: > Independently of the whitelist/blacklist question, I believe > pg_checksums should not error out as soon as it encounters a weird looking > file, but either (i) still checksum it or (ii) skip it? Or is that to be > considered a pilot

Re: More issues with pg_verify_checksums and checksum verification in base backups

2019-08-06 Thread Stephen Frost
Greetings, * Andres Freund (and...@anarazel.de) wrote: > On 2019-08-06 10:58:15 -0400, Stephen Frost wrote: > > * Michael Banck (michael.ba...@credativ.de) wrote: > > > Independently of the whitelist/blacklist question, I believe > > > pg_checksums should not error out

Re: More issues with pg_verify_checksums and checksum verification in base backups

2019-08-06 Thread Stephen Frost
Greetings, On Tue, Aug 6, 2019 at 15:45 Magnus Hagander wrote: > On Tue, Aug 6, 2019 at 6:07 PM Stephen Frost wrote: > >> Greetings, >> >> * Andres Freund (and...@anarazel.de) wrote: >> > On 2019-08-06 10:58:15 -0400, Stephen Frost wrote: >> > &g

Re: [PATCH] Stop ALTER SYSTEM from making bad assumptions

2019-08-06 Thread Stephen Frost
Greetings, * Tom Lane (t...@sss.pgh.pa.us) wrote: > Ian Barwick writes: > >>> I dislike the special-casing of ALTER SYSTEM here, where we're basically > >>> saying that only ALTER SYSTEM is allowed to do this cleanup and that if > >>> such cleanup is wanted then ALTER SYSTEM must be run. > > > T

Re: no default hash partition

2019-08-06 Thread Stephen Frost
Greetings, * Tom Lane (t...@sss.pgh.pa.us) wrote: > Alvaro Herrera writes: > > On 2019-Aug-06, Tom Lane wrote: > >> Seems like "it's likely to cause trouble for users" is just going to > >> beg the question "why?". Can we explain the hazard succinctly? > >> Or point to a comment somewhere else t

Re: no default hash partition

2019-08-06 Thread Stephen Frost
Greetings, * Tom Lane (t...@sss.pgh.pa.us) wrote: > Stephen Frost writes: > > * Tom Lane (t...@sss.pgh.pa.us) wrote: > >> Hmm. So given the point about it being hard to predict which hash > >> partitions would receive what values ... under what circumstances >

Re: no default hash partition

2019-08-07 Thread Stephen Frost
Greetings, * Amit Langote (amitlangot...@gmail.com) wrote: > On Wed, Aug 7, 2019 at 1:59 PM Kyotaro Horiguchi > wrote: > > At Tue, 6 Aug 2019 23:26:19 -0400, Robert Haas > > wrote: > > > On Tue, Aug 6, 2019 at 6:58 PM Tom Lane wrote: > > > I think, as Amit says, that having an automatic partit

Re: [Proposal] Table-level Transparent Data Encryption (TDE) and Key Management Service (KMS)

2019-08-08 Thread Stephen Frost
Greetings, * Bruce Momjian (br...@momjian.us) wrote: > On Tue, Jul 9, 2019 at 11:09:01AM -0400, Bruce Momjian wrote: > > On Tue, Jul 9, 2019 at 10:59:12AM -0400, Stephen Frost wrote: > > > * Bruce Momjian (br...@momjian.us) wrote: > > > I agree that all of that isn

Re: [Proposal] Table-level Transparent Data Encryption (TDE) and Key Management Service (KMS)

2019-08-08 Thread Stephen Frost
Greetings, * Tomas Vondra (tomas.von...@2ndquadrant.com) wrote: > On Thu, Aug 08, 2019 at 03:07:59PM -0400, Stephen Frost wrote: > >* Bruce Momjian (br...@momjian.us) wrote: > >>On Tue, Jul 9, 2019 at 11:09:01AM -0400, Bruce Momjian wrote: > >>> On Tue, Jul 9, 201

Re: Add "password_protocol" connection parameter to libpq

2019-08-09 Thread Stephen Frost
Greetings, * Michael Paquier (mich...@paquier.xyz) wrote: > On Thu, Aug 08, 2019 at 11:16:24PM -0700, Jeff Davis wrote: > > On Fri, 2019-08-09 at 12:00 +0900, Michael Paquier wrote: > > > What about auth_protocol then? It seems to me that it could be > > > useful > > > to have the restriction on

Re: Add "password_protocol" connection parameter to libpq

2019-08-09 Thread Stephen Frost
Greetings, * Jeff Davis (pg...@j-davis.com) wrote: > On Sat, 2019-08-10 at 00:17 +0300, Heikki Linnakangas wrote: > > auth_methods = 'MITM, -password, -md5' > > Keep in mind this is client configuration, so something reasonable in > postgresql.conf might not be so reasonable in the form: Yeah, t

Re: Add "password_protocol" connection parameter to libpq

2019-08-12 Thread Stephen Frost
Greetings, * Peter Eisentraut (peter.eisentr...@2ndquadrant.com) wrote: > On 2019-08-12 18:02, Jeff Davis wrote: > > https://postgr.es/m/daf0017a1a5c2caabf88a4e00f66b4fcbdfeccad.camel%40j-davis.com > > > > The weakness of proposal #1 is that it's not very "future-proof" and we > > would likely ne

Re: Add "password_protocol" connection parameter to libpq

2019-08-12 Thread Stephen Frost
Greetings, * Tom Lane (t...@sss.pgh.pa.us) wrote: > Stephen Frost writes: > > I'm not really thrilled with approach #2 because it means the user > > will have to know which of the PG authentication methods involve, eg, > > sending the password in the clear to the s

Re: pg_upgrade fails with non-standard ACL

2019-08-13 Thread Stephen Frost
Greetings, * Bruce Momjian (br...@momjian.us) wrote: > On Tue, Aug 13, 2019 at 07:04:42PM +0300, Anastasia Lubennikova wrote: > > Maybe, as a compromise, we can reset grants to default for all changed > > functions > > and also generate a script that will allow a user to preserve privileges of > >

Re: [PATCH] Stop ALTER SYSTEM from making bad assumptions

2019-08-14 Thread Stephen Frost
Greetings, * Tom Lane (t...@sss.pgh.pa.us) wrote: > Stephen Frost writes: > > * Tom Lane (t...@sss.pgh.pa.us) wrote: > >> Perhaps we could put some of these details into the Notes section of the > >> ALTER SYSTEM ref page. But I wonder how much of this is needed at

Re: [Proposal] Table-level Transparent Data Encryption (TDE) and Key Management Service (KMS)

2019-08-15 Thread Stephen Frost
Greetings, * Bruce Momjian (br...@momjian.us) wrote: > On Thu, Aug 15, 2019 at 11:24:46AM +0200, Antonin Houska wrote: > > > I think there are several directions we can go after all-cluster > > > encryption, > > > > I think I misunderstood. What you summarize in > > > > https://wiki.postgresql.o

Re: [Proposal] Table-level Transparent Data Encryption (TDE) and Key Management Service (KMS)

2019-08-15 Thread Stephen Frost
Greetings, * Bruce Momjian (br...@momjian.us) wrote: > On Thu, Aug 15, 2019 at 06:10:24PM +0900, Masahiko Sawada wrote: > > On Thu, Aug 15, 2019 at 10:19 AM Bruce Momjian wrote: > > > > > > On Wed, Aug 14, 2019 at 04:36:35PM +0200, Antonin Houska wrote: > > > > I can work on it right away but don

Re: Add "password_protocol" connection parameter to libpq

2019-08-15 Thread Stephen Frost
Greetings, * Jeff Davis (pg...@j-davis.com) wrote: > On Wed, 2019-08-14 at 11:38 +0900, Michael Paquier wrote: > > What I got in mind was a comma-separated list of authorized protocols > > which can be specified as a connection parameter, which extends to > > all > > the types of AUTH_REQ requests

Re: [Proposal] Table-level Transparent Data Encryption (TDE) and Key Management Service (KMS)

2019-08-17 Thread Stephen Frost
Greetings, * Ibrar Ahmed (ibrar.ah...@gmail.com) wrote: > On Sat, Aug 17, 2019 at 3:04 AM Bruce Momjian wrote: > > +1 for voice call, bruce we usually have a weekly TDE call. I will include > you in > that call. Currently, in that group are > moon_insung...@lab.ntt.co.jp, > sawada.m...@gmail.co

Re: [Proposal] Table-level Transparent Data Encryption (TDE) and Key Management Service (KMS)

2019-08-17 Thread Stephen Frost
Greetings, * Bruce Momjian (br...@momjian.us) wrote: > On Sat, Aug 17, 2019 at 08:16:06AM +0200, Antonin Houska wrote: > > Bruce Momjian wrote: > > > > > On Thu, Aug 15, 2019 at 09:01:05PM -0400, Stephen Frost wrote: > > > > * Bruce Momjian (br...@momjian.u

Re: [Proposal] Table-level Transparent Data Encryption (TDE) and Key Management Service (KMS)

2019-08-17 Thread Stephen Frost
Greetings, * Bruce Momjian (br...@momjian.us) wrote: > I will state whet I have already told some people privately, that for > this feature, we have many people understanding 40% of the problem, but > thinking they understand 90%. I do agree we should plan for our > eventual full feature set, but

Re: [Proposal] Table-level Transparent Data Encryption (TDE) and Key Management Service (KMS)

2019-08-17 Thread Stephen Frost
Greetings, On Sat, Aug 17, 2019 at 18:30 Ahsan Hadi wrote: > The current calendar entry for TDE weekly call will not work for EST > timezone. I will change the invite so we can accommodate people from > multiple time zones. > I appreciate the thought but at least for my part, I already have reg

Re: pg_upgrade fails with non-standard ACL

2019-08-20 Thread Stephen Frost
Greetings, * Anastasia Lubennikova (a.lubennik...@postgrespro.ru) wrote: > 14.08.2019 3:28, Stephen Frost wrote: > >* Bruce Momjian (br...@momjian.us) wrote: > >>As much as it would be nice if the release notes covered all that, and > >>we updated pg_upgrade to somehow

Re: [PATCH] Stop ALTER SYSTEM from making bad assumptions

2019-08-21 Thread Stephen Frost
Greetings, * Tom Lane (t...@sss.pgh.pa.us) wrote: > + > + External tools may also > + modify postgresql.auto.conf. It is not > + recommended to do this while the server is running, since a > + concurrent ALTER SYSTEM command could overwrite > + such changes. Such tools mi

Re: [Proposal] Table-level Transparent Data Encryption (TDE) and Key Management Service (KMS)

2019-08-23 Thread Stephen Frost
Greetings, * Bruce Momjian (br...@momjian.us) wrote: > On Sat, Aug 17, 2019 at 01:52:17PM -0400, Stephen Frost wrote: > > Being PostgreSQL, I would expect us to shoot for as much flexibility as > > we possible, similar to what we've done for our ACL system where we > >

Re: [Proposal] Table-level Transparent Data Encryption (TDE) and Key Management Service (KMS)

2019-08-23 Thread Stephen Frost
Greetings, * Bruce Momjian (br...@momjian.us) wrote: > On Fri, Aug 23, 2019 at 07:45:22AM -0400, Stephen Frost wrote: > > Having listed out the feature set of each of the other major databases > > when it comes to TDE is exactly how we objectively look at what is being > >

Re: WIP/PoC for parallel backup

2019-08-23 Thread Stephen Frost
Greetings, * Asif Rehman (asifr.reh...@gmail.com) wrote: > On Fri, Aug 23, 2019 at 3:18 PM Asim R P wrote: > > Interesting proposal. Bulk of the work in a backup is transferring files > > from source data directory to destination. Your patch is breaking this > > task down in multiple sets of fi

Re: WIP/PoC for parallel backup

2019-08-23 Thread Stephen Frost
Greetings, * Ahsan Hadi (ahsan.h...@gmail.com) wrote: > On Fri, 23 Aug 2019 at 10:26 PM, Stephen Frost wrote: > > I would expect you to quickly want to support compression on the server > > side, before the data is sent across the network, and possibly > > encryption, an

Re: [Proposal] Table-level Transparent Data Encryption (TDE) and Key Management Service (KMS)

2019-08-23 Thread Stephen Frost
Greetings, * Bruce Momjian (br...@momjian.us) wrote: > On Fri, Aug 23, 2019 at 10:35:17AM -0400, Stephen Frost wrote: > > Following on from that- when other databases don't have something that > > we're thinking about implementing, maybe we should be contemplating if >

Re: add a MAC check for TRUNCATE

2019-09-03 Thread Stephen Frost
Greetings, * Kohei KaiGai (kai...@heterodb.com) wrote: > 2019年7月25日(木) 3:52 Yuli Khodorkovskiy : > > Since all DAC checks should have corresponding MAC, this patch adds a > > hook to allow extensions to implement a MAC check on TRUNCATE. I have > > also implemented this access check in the sepgsql

Re: SIGQUIT on archiver child processes maybe not such a hot idea?

2019-09-03 Thread Stephen Frost
Greetings, * Michael Paquier (mich...@paquier.xyz) wrote: > On Mon, Sep 02, 2019 at 12:27:09AM +, Tsunakawa, Takayuki wrote: > > From: Tom Lane [mailto:t...@sss.pgh.pa.us] > >> After investigation, the mechanism that's causing that is that the > >> src/test/recovery/t/010_logical_decoding_time

Re: SIGQUIT on archiver child processes maybe not such a hot idea?

2019-09-03 Thread Stephen Frost
Greetings, * David Steele (da...@pgmasters.net) wrote: > On 9/3/19 12:04 PM, Tom Lane wrote: > > Kyotaro Horiguchi writes: > >> But now we know that sending it to grand-children is wrong in a > >> sense that that leads to left-alone unwanted core files. But the > >> behavior is already knwon at t

Re: Proposal: roll pg_stat_statements into core

2019-09-03 Thread Stephen Frost
Greetings, * David Fetter (da...@fetter.org) wrote: > I'd like to $Subject, on by default, with a switch to turn it off for > those really at the outer edges of performance. Some reasons include: Sure, half of contrib should really be in core (amcheck, file_fdw, postgres_fdw, maybe dblink, pagein

Re: Add default role 'pg_access_server_files'

2018-01-02 Thread Stephen Frost
Magnus, * Magnus Hagander (mag...@hagander.net) wrote: > On Sun, Dec 31, 2017 at 8:19 PM, Stephen Frost wrote: > > This patch adds a new default role called 'pg_access_server_files' which > > allows an administrator to GRANT to a non-superuser role the ability to >

Re: Add default role 'pg_access_server_files'

2018-01-02 Thread Stephen Frost
Magnus, * Magnus Hagander (mag...@hagander.net) wrote: > On Tue, Jan 2, 2018 at 1:08 PM, Stephen Frost wrote: > > * Magnus Hagander (mag...@hagander.net) wrote: > > > On Sun, Dec 31, 2017 at 8:19 PM, Stephen Frost > > wrote: > > > > This

Re: TODO list (was Re: Contributing with code)

2018-01-02 Thread Stephen Frost
Robert, * Robert Haas (robertmh...@gmail.com) wrote: > On Sun, Dec 31, 2017 at 1:51 PM, Stephen Frost wrote: > > The todo entry even talks about why it's difficult to do and what the > > expected way to go about doing it is (that is, connect to each database > &g

Re: TODO list (was Re: Contributing with code)

2018-01-02 Thread Stephen Frost
Greetings, * Patrick Krecker (pkrec...@gmail.com) wrote: > As a person looking to become a postgres contributor, perhaps I can > offer some perspective on this. I think there is value in providing > *some* starting point for new contributors in the form of concrete > problems to solve. The value I

Re: Contributing with code

2018-01-02 Thread Stephen Frost
Noah, all, * Noah Misch (n...@leadboat.com) wrote: > On Tue, Jan 02, 2018 at 05:52:37PM -0500, Peter Eisentraut wrote: > > On 12/31/17 22:43, Craig Ringer wrote: > > > I'd rather rename it the "stuck, hard and abandoned projects list" ;)  > > > > That might actually be useful. > > +1. When I do

Re: CFM for January commitfest?

2018-01-02 Thread Stephen Frost
Tom, all, * Tom Lane (t...@sss.pgh.pa.us) wrote: > Now that the January fest has nominally started, we need somebody > to act as CF manager. Any volunteers? > > (If someone already did volunteer and I missed it, my apologies.) With the list migrations more-or-less behind us, I'll volunteer to r

Re: CFM for January commitfest?

2018-01-02 Thread Stephen Frost
Greetings, On the PG mailing lists, we'd prefer if you didn't top-post but instead respond in-line (as I'll do below). * Gerdan Rezende dos Santos (ger...@gmail.com) wrote: > I have interest in help with this. That's great! I took your email to mean that you're interested in helping out, but no

Re: CFM for January commitfest?

2018-01-03 Thread Stephen Frost
All, * Stephen Frost (sfr...@snowman.net) wrote: > * Tom Lane (t...@sss.pgh.pa.us) wrote: > > Now that the January fest has nominally started, we need somebody > > to act as CF manager. Any volunteers? > > > > (If someone already did volunteer and I missed it, my apo

Re: CFM for January commitfest?

2018-01-03 Thread Stephen Frost
Greetings Gerdan, * Gerdan Rezende dos Santos (ger...@gmail.com) wrote: > On Wed, 3 Jan 2018 at 00:53 Stephen Frost wrote: > > On the PG mailing lists, we'd prefer if you didn't top-post but instead > > respond in-line (as I'll do below). > > > > * G

Re: CFM for January commitfest?

2018-01-03 Thread Stephen Frost
Ryan, * Ryan Murphy (ryanfmur...@gmail.com) wrote: > > > Yes, I have interest to help. I do not have the experience of how to do > > the > > > whole, but I believe that if I help you (you as CFM) in the future I can > > > assume this activity when necessary. > > Hi Stephen. Thanks for being the

January CommitFest is underway!

2018-01-03 Thread Stephen Frost
Greetings! The January commitfest (the second-to-last of the PG11 release cycle, which likely means lots of big patches landing, since big patches aren't allowed to be first seen in the last commitfest before feature freeze... ;) has officially begun and we have a lot of work ahead of us. To the

Re: January CommitFest is underway!

2018-01-03 Thread Stephen Frost
Michael, * Michael Paquier (michael.paqu...@gmail.com) wrote: > On Wed, Jan 03, 2018 at 06:38:53PM -0500, Stephen Frost wrote: > > The January commitfest (the second-to-last of the PG11 release cycle, > > which likely means lots of big patches landing, since big patches > >

Re: GSoC 2018

2018-01-04 Thread Stephen Frost
Greetings -hackers, * Stephen Frost (sfr...@snowman.net) wrote: > The deadline for Mentoring organizations to apply is: January 23. We currently only have four (4) projects for 2018 listed on our projects page here: https://wiki.postgresql.org/index.php?title=GSoC_2018 Last year we had quit

Re: GSoC 2018

2018-01-04 Thread Stephen Frost
Alexander, * Alexander Korotkov (a.korot...@postgrespro.ru) wrote: > On Thu, Jan 4, 2018 at 11:36 PM, Stephen Frost wrote: > > * Stephen Frost (sfr...@snowman.net) wrote: > > > The deadline for Mentoring organizations to apply is: January 23. > > > > We currently o

Re: [HACKERS] WAL logging problem in 9.4.3?

2018-01-04 Thread Stephen Frost
Greetings, * Kyotaro HORIGUCHI (horiguchi.kyot...@lab.ntt.co.jp) wrote: > At Tue, 28 Nov 2017 10:36:39 +0900, Michael Paquier > wrote in > > > On Thu, Sep 14, 2017 at 3:34 PM, Kyotaro HORIGUCHI > > wrote: > > > At Wed, 13 Sep 2017 17:42:39 +0900 (Tokyo Standard Time), Kyotaro > > > HORIGUCHI

Re: BUGFIX: standby disconnect can corrupt serialized reorder buffers

2018-01-04 Thread Stephen Frost
Greetings all, * Masahiko Sawada (sawada.m...@gmail.com) wrote: > On Tue, Dec 26, 2017 at 10:03 PM, Petr Jelinek > wrote: > > On 26/12/17 11:13, Masahiko Sawada wrote: > >> On Tue, Dec 26, 2017 at 12:49 AM, Petr Jelinek > >> wrote: > >> > > It's not a problem on crash restart because S

Re: [HACKERS] VACUUM and ANALYZE disagreeing on what reltuples means

2018-01-04 Thread Stephen Frost
Tomas, * Michael Paquier (michael.paqu...@gmail.com) wrote: > On Sun, Nov 19, 2017 at 6:40 AM, Tomas Vondra > wrote: > > Thanks for looking into this. I agree your patch is more consistent and > > generally cleaner. > > This is classified as a bug fix, and is marked as waiting on author. I > am

Re: Add default role 'pg_access_server_files'

2018-01-06 Thread Stephen Frost
Greetings Ryan! * Ryan Murphy (ryanfmur...@gmail.com) wrote: > Stephen, so far I've read thru your patch and familiarized myself with some > of the auth functionality in pg_authid.h and src/backend/utils/adt/acl.c > > The only question I have so far about your patch is the last several hunks of

Re: PATCH: pgbench - option to build using ppoll() for larger connection counts

2018-01-06 Thread Stephen Frost
Doug, * Rady, Doug (radyd...@amazon.com) wrote: > This patch enables building pgbench to use ppoll() instead of select() > to allow for more than (FD_SETSIZE - 10) connections. As implemented, > when using ppoll(), the only connection limitation is system resources. Looks like this patch had som

Re: General purpose hashing func in pgbench

2018-01-06 Thread Stephen Frost
Greetings Ildar, * Fabien COELHO (coe...@cri.ensmp.fr) wrote: > >>I noticed from the source of all human knowledege (aka Wikipedia:-) > >>that there seems to be a murmur3 successor. Have you considered it? > >>One good reason to skip it would be that the implementation is long > >>and complex. I'm

Re: [HACKERS] GUC for cleanup indexes threshold.

2018-01-06 Thread Stephen Frost
Greetings, (pruned the CC list) * Michael Paquier (michael.paqu...@gmail.com) wrote: > On Thu, Nov 30, 2017 at 12:06 AM, Masahiko Sawada > wrote: > > On Wed, Nov 29, 2017 at 11:05 PM, Simon Riggs wrote: > >> Unless there is disagreement on the above, it seems we should apply > >> Yura's patch

Re: [HACKERS] [PATCH] Vacuum: Update FSM more frequently

2018-01-06 Thread Stephen Frost
Greetings Claudio, * Michael Paquier (michael.paqu...@gmail.com) wrote: > On Mon, Nov 27, 2017 at 2:39 PM, Jing Wang wrote: > > A few general comments. > > > > + FreeSpaceMapVacuum(onerel, 64); > > > > Just want to know why '64' is used here? It's better to give a description. > > > > +else

<    1   2   3   4   5   6   7   8   9   10   >