On Fri, Jul 16, 2021 at 10:51 PM vignesh C wrote:
>
> On Sat, Jul 3, 2021 at 11:23 AM Dilip Kumar wrote:
> >
> > On Fri, Jul 2, 2021 at 12:03 PM Dilip Kumar wrote:
> > >
> > > Yeah, this looks like a bug. I will look at the patch.
> > >
> >
On Sat, Aug 28, 2021 at 3:19 PM Amit Kapila wrote:
>
> On Fri, Aug 27, 2021 at 6:09 PM vignesh C wrote:
> >
> > On Fri, Aug 27, 2021 at 4:57 PM Amit Kapila wrote:
> > >
> > > On Fri, Aug 27, 2021 at 11:43 AM vignesh C wrote:
> > > >
> >
On Tue, Aug 31, 2021 at 7:40 AM houzj.f...@fujitsu.com
wrote:
>
> From Tuesday, August 31, 2021 1:10 AM vignesh C wrote:
> > Hi,
> >
> > Relation invalidation was missing in case of create publication and drop
> > publication of "FOR ALL TABLES" pu
On Mon, Aug 30, 2021 at 2:14 PM Greg Nancarrow wrote:
>
> On Fri, Aug 27, 2021 at 4:13 PM vignesh C wrote:
> >
> > I have implemented this in the 0003 patch, I have kept it separate to
> > reduce the testing effort and also it will be easier if someone
> > disagrees
On Mon, Aug 30, 2021 at 12:12 PM Amit Kapila
wrote:
>
>
> Okay, I got it but let's add few comments in the code related to it.
> Also, I noticed that the code in InvalidatePublicationRels() already
> exists in AlterPublicationOptions(). You can try to refactor the
> existing code as a separate
On Tue, Aug 10, 2021 at 1:40 PM Greg Nancarrow wrote:
>
> On Fri, Aug 6, 2021 at 6:32 PM vignesh C wrote:
> >
> > Thanks for the comments, the attached v19 patch has the fixes for the
comments.
> >
>
> Some more review comments, this time for the v19 patch:
>
&
On Mon, Aug 9, 2021 at 9:50 PM Mark Dilger
wrote:
>
>
>
> > On Aug 6, 2021, at 1:32 AM, vignesh C wrote:
> >
> > the attached v19 patch
>
> With v19 applied, a schema owner can publish the contents of a table
regardless of ownership or permissions on that table:
On Thu, Aug 12, 2021 at 5:54 PM Masahiko Sawada
wrote:
>
> On Fri, Aug 6, 2021 at 5:33 PM vignesh C wrote:
> >
> > Thanks for the comments, the attached v19 patch has the fixes for the
comments.
>
> Thank you for updating the patch!
>
> Here
On Mon, Aug 9, 2021 at 10:23 AM Amit Kapila wrote:
>
> On Sun, Aug 8, 2021 at 2:52 PM vignesh C wrote:
> >
> > On Fri, Aug 6, 2021 at 4:39 PM Amit Kapila
wrote:
> > >
> > > On Fri, Aug 6, 2021 at 2:02 PM vignesh C wrote:
> > > >
> >
On Fri, Aug 6, 2021 at 4:02 PM Amit Kapila wrote:
>
> On Fri, Aug 6, 2021 at 2:16 PM vignesh C wrote:
> >
> > On Thu, Aug 5, 2021 at 3:54 PM Amit Kapila
wrote:
> > >
> > >
> > > Few more comments:
> > > ===
> > >
On Wed, Sep 1, 2021 at 11:14 AM tanghy.f...@fujitsu.com
wrote:
>
> > On Monday, August 30, 2021 11:28 PM vignesh C wrote:
> >
> > I have fixed these comments as part of v23 patch attached at [1].
> > [1] - https://www.postgresql.org/message-
> > id/CALDaN
On Wed, Sep 1, 2021 at 6:58 AM houzj.f...@fujitsu.com
wrote:
>
> Here are some other comments for v23-000x patches.
>
> 1)
>
> @@ -6225,6 +6342,9 @@ describePublications(const char *pattern)
> boolhas_pubtruncate;
> boolhas_pubviaroot;
>
> +
On Sat, Aug 28, 2021 at 3:19 PM Amit Kapila wrote:
>
> Don't you think some users might want to know all the schema names for
> a publication? I am not completely sure on this point but I think it
> is good to have information for users. It might be also useful to have
> pg_publication_objects
On Wed, Sep 15, 2021 at 5:20 PM Alvaro Herrera wrote:
>
> On 2021-Sep-15, Amit Kapila wrote:
>
> > On Mon, Sep 6, 2021 at 11:21 PM Alvaro Herrera
> > wrote:
> > >
> > > I pushed the clerical part of this -- namely the addition of
> > > PublicationTable node and PublicationRelInfo struct.
> >
>
On Mon, Sep 13, 2021 at 7:06 PM tanghy.f...@fujitsu.com
wrote:
>
> On Sunday, September 12, 2021 11:13 PM vignesh C wrote:
> >
> > Thanks for the changes, the suggested changes make the parsing code
> > simpler. I have merged the changes to the main patch. Attached v27
&
On Tue, Sep 14, 2021 at 6:31 AM houzj.f...@fujitsu.com
wrote:
>
> From Sun, Sept 12, 2021 11:13 PM vignesh C wrote:
> > On Fri, Sep 10, 2021 at 11:21 AM Hou Zhijie wrote:
> > > Attach the without-flag version and add comments about the pubobj_name.
> >
> > Than
On Tue, Sep 7, 2021 at 11:38 AM houzj.f...@fujitsu.com
wrote:
>
> From Tues, Sep 7, 2021 12:02 PM Amit Kapila wrote:
> > On Mon, Sep 6, 2021 at 1:49 PM houzj.f...@fujitsu.com
> > wrote:
> > >
> > > I can reproduce this bug.
> > >
> > > I think the reason is it didn't invalidate all the leaf
On Thu, Sep 16, 2021 at 8:45 AM Amit Kapila wrote:
>
> On Wed, Sep 15, 2021 at 6:06 PM Alvaro Herrera
> wrote:
> >
> > On 2021-Sep-15, vignesh C wrote:
> > > The patch
> > > Generic_object_type_parser_002_table_schema_publication.patch has the
> > &
On Tue, Sep 7, 2021 at 5:10 PM Amit Kapila wrote:
>
> On Tue, Sep 7, 2021 at 12:45 PM vignesh C wrote:
> >
> > On Fri, Sep 3, 2021 at 4:49 PM Amit Kapila wrote:
> > >
> >
> > > 5.
> > > If I modify the search path to remove public schema then
On Fri, Sep 3, 2021 at 4:49 PM Amit Kapila wrote:
>
> On Thu, Sep 2, 2021 at 5:12 PM Amit Kapila wrote:
> >
> > On Thu, Sep 2, 2021 at 11:58 AM vignesh C wrote:
> > >
> >
> > Below are few comments on v23. If you have already addressed anything
> >
On Fri, Sep 3, 2021 at 4:06 PM Amit Kapila wrote:
>
> On Wed, Sep 1, 2021 at 12:05 PM Amit Kapila wrote:
> >
> > On Wed, Sep 1, 2021 at 8:52 AM Greg Nancarrow wrote:
> > >
> >
> > > I'd expect a lot of users to naturally think that "ALTER PUBLICATION
> > > pub1 DROP ALL TABLES IN SCHEMA sc1;"
On Fri, Sep 3, 2021 at 3:12 PM Amit Kapila wrote:
>
> On Mon, Aug 30, 2021 at 8:56 PM vignesh C wrote:
> >
> > On Mon, Aug 30, 2021 at 9:10 AM houzj.f...@fujitsu.com
> > wrote:
> > >
> >
> > > 5)
> > > +
On Mon, Sep 6, 2021 at 6:56 AM houzj.f...@fujitsu.com
wrote:
>
> From Thur, Sep 2, 2021 7:42 PM Amit Kapila wrote:
> > On Thu, Sep 2, 2021 at 11:58 AM vignesh C wrote:
> > >
> >
> > Below are few comments on v23. If you have already addressed anything in
>
On Mon, Sep 6, 2021 at 6:56 AM houzj.f...@fujitsu.com
wrote:
>
> From Thur, Sep 2, 2021 2:33 PM vignesh C wrote:
> > On Wed, Sep 1, 2021 at 6:58 AM houzj.f...@fujitsu.com
> > wrote:
> > >
> > > Here are some other co
On Thu, Sep 16, 2021 at 7:20 PM Alvaro Herrera wrote:
>
> On 2021-Sep-16, vignesh C wrote:
>
> > diff --git a/src/backend/parser/gram.y b/src/backend/parser/gram.y
> > index e3068a374e..c50bb570ea 100644
> > --- a/src/backend/parser/gram.y
> > +++ b/src/backend/p
On Thu, Sep 16, 2021 at 9:54 AM Amit Kapila wrote:
>
> On Wed, Sep 15, 2021 at 12:30 PM Amit Kapila wrote:
> >
> > On Tue, Sep 14, 2021 at 2:08 PM vignesh C wrote:
> > >
> > > I have handled this in the patch attached.
> >
On Thu, Sep 16, 2021 at 8:59 AM houzj.f...@fujitsu.com
wrote:
>
> On Tuesday, September 14, 2021 4:39 PM vignesh C wrote:
> >
> > I have handled this in the patch attached.
>
> Thanks for updating the patch.
> Here are some comments.
>
> 1)
> +st
On Thu, Sep 16, 2021 at 11:24 AM Amit Kapila wrote:
>
> On Wed, Sep 15, 2021 at 4:45 PM Greg Nancarrow wrote:
> >
> > On Tue, Sep 14, 2021 at 6:38 PM vignesh C wrote:
> > >
> > > I have handled this in the patch attached.
> > >
> >
> &g
On Wed, May 12, 2021 at 2:27 AM Robert Haas wrote:
>
> On Thu, May 6, 2021 at 3:31 PM Tom Lane wrote:
> > Andres Freund writes:
> > > On 2021-05-06 14:56:09 -0400, Tom Lane wrote:
> > >> If we think it's worth having a predefined role for, OK. However,
> > >> I don't like the future I see us
On Fri, Jul 2, 2021 at 12:11 PM Haotian Wu wrote:
>
> Hi,
>
> I agree that —drop-cascade does not make sense for pg_dumpall, so I removed
> them.
>
> > are we expecting more things to appear after the semi-colon?
>
> No, I was just trying to “reuse” original statement as much as possible.
>
On Tue, Jul 13, 2021 at 4:25 PM Dean Rasheed wrote:
>
> On Mon, 12 Jul 2021 at 17:39, vignesh C wrote:
> >
> > Thanks for your comments, I have made the changes for the same in the
> > V10 patch attached.
> > Thoughts?
> >
>
> I'm still not happy about
On Wed, Oct 28, 2020 at 6:14 AM Justin Pryzby wrote:
>
> Forking this thread, since the existing CFs have been closed.
> https://www.postgresql.org/message-id/flat/20200914143102.GX18552%40telsasoft.com#58b1056488451f8594b0f0ba40996afd
>
> On Mon, Sep 14, 2020 at 09:31:03AM -0500, Justin Pryzby
On Wed, Apr 7, 2021 at 5:23 PM Michael Banck wrote:
>
> Hi,
>
> Am Dienstag, den 06.04.2021, 15:37 +0200 schrieb Michael Banck:
> > Am Montag, den 05.04.2021, 14:33 -0400 schrieb Stephen Frost:
> > > Should drop the 'DEFAULT_' to match the others since the rename to
> > > 'predefined' roles went
On Thu, Mar 4, 2021 at 9:51 AM Andy Fan wrote:
>
>
>>
>> I have implemented a new one, which only handles 1 level of partitioned
>> table, and
>> only 1 partition key. and only handle the eq operators like partkey = $1 /
>> partkey in ($1, $2)
>> / parkey = $1 or partkey = $2; The patch works
On Sat, Jun 26, 2021 at 2:52 AM Bruce Momjian wrote:
>
> On Wed, May 26, 2021 at 05:02:01PM -0400, Bruce Momjian wrote:
> > For these reasons, if we decide to go in the direction of using a
> > non-LSN nonce, I no longer plan to continue working on this feature. I
> > would rather work on things
On Mon, Apr 19, 2021 at 5:18 PM David Rowley wrote:
>
> On Wed, 3 Mar 2021 at 22:37, David Rowley wrote:
> > I've attached a rebased patch.
>
> I've rebased this again.
>
> I also moved away from using hash tables for storing references and
> libraries. I was having some problems getting psql
On Wed, Mar 10, 2021 at 1:49 PM yuzuko wrote:
>
> Hello,
>
> I thought about this suggestion again.
>
> Amit's patch suggested in the thread [1] can eliminate SPI plans from
> INSERT/UPDATE triggers, so our memory pressure issue would be solved.
> But as far as I can see that thread, Amit's patch
On Wed, Mar 31, 2021 at 7:28 PM Denis Hirn wrote:
>
> Sorry, I didn't append the patch properly.
The patch does not apply on Head anymore, could you rebase and post a
patch. I'm changing the status to "Waiting for Author".
Regards,
Vignesh
On Tue, Mar 30, 2021 at 2:14 AM Mark Rofail wrote:
>
> Hey Alvaro
>
>> Yes, we should do that.
>
> I have attached v12 with more tests in “ src/test/regress/sql/gin.sql”
>
> Changelog:
> - v12 (compatible with current master 2021/03/29, commit
> 6d7a6feac48b1970c4cd127ee65d4c487acbb5e9)
> *
On Thu, Apr 8, 2021 at 11:40 PM Simon Riggs wrote:
>
> On Thu, 8 Apr 2021 at 18:15, Alvaro Herrera wrote:
> >
> > On 2021-Apr-08, Simon Riggs wrote:
> >
> > > On Thu, 8 Apr 2021 at 16:58, David Steele wrote:
> >
> > > > It's not clear to me which patch is which, so perhaps move one CF entry
> >
On Thu, Jul 8, 2021 at 12:25 PM osumi.takami...@fujitsu.com
wrote:
>
> Hello, hackers
>
>
> When the current HEAD fails during logical decoding, the failure
> increments txns count in pg_stat_replication_slots - [1] and adds
> the transaction size to the sum of bytes in the same repeatedly
> on
On Wed, Jun 30, 2021 at 11:10 PM Antonin Houska wrote:
>
> Antonin Houska wrote:
>
> > tsunakawa.ta...@fujitsu.com wrote:
> >
> > > I'm crawling like a snail to read the patch set. Below are my first set
> > > of review comments, which are all minor.
> >
> > Thanks.
>
> I've added the patch
On Thu, Jul 15, 2021 at 1:40 PM Dean Rasheed wrote:
>
> On Tue, 13 Jul 2021 at 15:30, vignesh C wrote:
> >
> > On Tue, Jul 13, 2021 at 4:25 PM Dean Rasheed
> > wrote:
> > >
> > > As it stands, the improvements from (3) seem quite worthwhile. Also,
On Sat, Jun 12, 2021 at 3:11 PM Fabien COELHO wrote:
>
>
> Hello Peter,
>
> >> My overly naive trust in non regression test to catch any issues has been
> >> largely proven wrong. Three key features do not have a single tests. Sigh.
> >>
> >> I'll have some time to look at it over next week-end,
On Tue, Jun 22, 2021 at 2:37 AM Heikki Linnakangas wrote:
>
> On 17/06/2021 02:00, Andres Freund wrote:
> > On 2021-06-16 16:30:45 +0300, Heikki Linnakangas wrote:
> >> That's a fairly clean split. StartupXLOG() stays in xlog.c, but much of
> >> the
> >> code from it has been moved to new
On Wed, Jul 14, 2021 at 6:31 PM Daniil Zakhlystov
wrote:
>
> **sorry for the noise, but I need to re-send the message because one of the
> recipients is blocked on the pgsql-hackers for some reason**
>
> Hi!
>
> Done, the patch should apply to the current master now.
>
> Actually, I have an
On Mon, May 17, 2021 at 10:08 AM Yugo NAGATA wrote:
>
> On Fri, 7 May 2021 14:14:16 +0900
> Yugo NAGATA wrote:
>
> > On Mon, 26 Apr 2021 16:03:48 +0900
> > Yugo NAGATA wrote:
> >
> > > On Mon, 26 Apr 2021 15:46:21 +0900
> > > Yugo NAGATA wrote:
> > >
> > > > On Tue, 20 Apr 2021 09:51:34 +0900
On Thu, May 27, 2021 at 12:21 PM Andrey V. Lepikhov
wrote:
>
> On 5/8/21 2:00 AM, Hywel Carver wrote:
> > On Fri, May 7, 2021 at 8:23 AM Andrey Lepikhov
> > mailto:a.lepik...@postgrespro.ru>> wrote:
> > Here I didn't work on 'unnecessary IS NOT NULL filter'.
> >
> > I've tested the new patch,
On Mon, May 10, 2021 at 6:03 PM Bharath Rupireddy
wrote:
>
> Hi,
>
> While working on [1], I got to know that there is a new GUC
> debug_invalidate_system_caches_always that has been introduced in v14.
> It can be used to switch off cache invalidation in
> CLOBBER_CACHE_ALWAYS builds which makes
On Tue, Jul 6, 2021 at 8:09 PM vignesh C wrote:
>
> On Wed, Jun 30, 2021 at 8:23 PM vignesh C wrote:
> >
> > On Sun, Jun 6, 2021 at 11:55 AM vignesh C wrote:
> > >
> > > On Fri, May 7, 2021 at 6:44 PM vignesh C wrote:
> > > >
> > >
On Sun, Jul 4, 2021 at 9:58 AM Thomas Munro wrote:
>
> On Fri, Jul 2, 2021 at 2:32 PM John Naylor
> wrote:
> > I suspect if we experiment on two extremes of type "heaviness" (accessing
> > and comparing trivial or not), such as uint32 and tuplesort, we'll have a
> > pretty good idea what the
On Mon, Jun 28, 2021 at 3:46 PM Arne Roland wrote:
>
> Hi!
>
>
> From: Zhihong Yu
> Sent: Saturday, June 26, 2021 20:32
> Subject: Re: Rename of triggers for partitioned tables
>
> > Hi, Arne:
> > It seems the patch no longer applies cleanly on master branch.
> > Do you mind updating the patch ?
On Mon, Jun 28, 2021 at 3:30 PM Peter Eisentraut
wrote:
>
> There are certain parts of code that laboriously initialize every field
> of a struct to (some spelling of) zero, even though the whole struct was
> just zeroed (by makeNode() or memset()) a few lines earlier. Besides
> being redundant,
On Wed, Jun 23, 2021 at 7:55 PM Tomas Vondra
wrote:
>
> On 6/23/21 4:14 PM, Tomas Vondra wrote:
> > A rebased patch, addressing a minor bitrot due to 4daa140a2f5.
> >
>
> Meh, forgot to attach the patch as usual, of course ...
The patch does not apply on Head anymore, could you rebase and post a
On Mon, Aug 2, 2021 at 9:10 PM Tom Lane wrote:
>
> Peter Smith writes:
> > I agree. The specified value looks better when it comes first, as you did
> > it.
>
> Actually, it looks to me like we don't have to resolve the question of
> which should come first, because I don't see any cases where
On Mon, Aug 2, 2021 at 3:31 PM tanghy.f...@fujitsu.com
wrote:
>
> Hi Hackers
>
> When review and test another patch at [1], I found some comments in existing
> test code of " src/test/regress/sql/publication.sql " is a little bit
> confused.
> Attached a patch to fix them, please take a check.
On Mon, Aug 2, 2021 at 1:13 PM Masahiko Sawada wrote:
>
> On Mon, Aug 2, 2021 at 2:52 PM osumi.takami...@fujitsu.com
> wrote:
> >
> > On Thursday, July 29, 2021 10:50 AM Masahiko Sawada
> > wrote:
> > > On Thu, Jul 8, 2021 at 3:55 PM osumi.takami...@fujitsu.com
> > > wrote:
> > > > When the
On Tue, Aug 3, 2021 at 12:32 PM Amit Kapila wrote:
>
> On Tue, Aug 3, 2021 at 6:17 AM Peter Smith wrote:
> >
> > Please find attached the latest patch set v102*
> >
>
> I have made minor modifications in the comments and docs, please see
> attached. Can you please check whether the names of
On Tue, Aug 3, 2021 at 12:20 PM Masahiko Sawada wrote:
>
> On Mon, Aug 2, 2021 at 12:21 PM Amit Kapila wrote:
> >
> > On Mon, Aug 2, 2021 at 7:45 AM Masahiko Sawada
> > wrote:
> > >
> > > On Fri, Jul 30, 2021 at 12:52 PM Amit Kapila
> > > wrote:
> > > >
> > > > On Thu, Jul 29, 2021 at 11:18
On Tue, Aug 3, 2021 at 8:36 AM tanghy.f...@fujitsu.com
wrote:
>
> On Monday, August 2, 2021 11:56 PM vignesh C wrote:
> >
> > Few minor suggestions:
> > 1) Should we change below to "fail - tables can't be added, dropped or
> > set to "FOR ALL TABLES
On Fri, Aug 6, 2021 at 2:00 PM Masahiko Sawada wrote:
>
> On Wed, Aug 4, 2021 at 12:08 AM vignesh C wrote:
> >
> > On Tue, Aug 3, 2021 at 12:00 PM tanghy.f...@fujitsu.com
> > wrote:
> > >
> > > On Monday, August 2, 2021 11:40 PM vignesh C wrote:
> &g
On Wed, Aug 4, 2021 at 8:08 PM tanghy.f...@fujitsu.com <
tanghy.f...@fujitsu.com> wrote:
>
> On Tuesday, August 3, 2021 11:08 PM vignesh C wrote:
> >
> > Thanks for reporting this, this is fixed in the v18 patch attached.
>
> Thanks for fixing it.
>
> Few sugge
On Thu, Aug 5, 2021 at 3:54 PM Amit Kapila wrote:
>
> On Wed, Aug 4, 2021 at 4:10 PM Amit Kapila
wrote:
> >
> > On Tue, Aug 3, 2021 at 8:38 PM vignesh C wrote:
> > >
> > > Thanks for reporting this, this is fixed in the v18 patch attached.
> > >
&
On Fri, Aug 6, 2021 at 3:33 PM tanghy.f...@fujitsu.com
wrote:
>
> Hi
>
> I saw some inaccurate comments for AlterPublicationStmt structure when
> reviewing patches related to publication[1].
>
> The variable tables are used for 'ALTER PUBLICATION ... ADD/DROP/SET TABLE',
> but the comments only
On Fri, Aug 6, 2021 at 4:39 PM Amit Kapila wrote:
>
> On Fri, Aug 6, 2021 at 2:02 PM vignesh C wrote:
> >
> > On Wed, Aug 4, 2021 at 4:10 PM Amit Kapila wrote:
> > >
> > > On Tue, Aug 3, 2021 at 8:38 PM vignesh C wrote:
> >
> > > 6.
> >
On Mon, Aug 9, 2021 at 9:50 PM Mark Dilger wrote:
>
>
>
> > On Aug 6, 2021, at 1:32 AM, vignesh C wrote:
> >
> > the attached v19 patch
>
> With v19 applied, a schema owner can publish the contents of a table
> regardless of ownership or permissions o
On Fri, Jul 30, 2021 at 9:32 AM Peter Smith wrote:
>
> Please find attached the latest patch set v100*
>
> v99-0002 --> v100-0001
>
> Differences:
>
> * Rebased to HEAD @ today (needed because some recent commits [1][2] broke
> v99)
>
The patch applies neatly, tests passes and documentation
On Sat, Jul 31, 2021 at 11:12 AM Ajin Cherian wrote:
>
> On Sat, Jul 31, 2021 at 2:39 PM Amit Kapila wrote:
>
> > Here, the test is expecting 2 prepared transactions corresponding to
> > two subscriptions but it waits for just one subscription via
> > appname_copy. It should wait for the second
On Sat, Jul 31, 2021 at 2:30 AM Tom Lane wrote:
>
> vignesh C writes:
> [ v6-0001-Included-the-actual-datatype-used-in-logical-repl.patch ]
>
> I see what you want to do here, but the way you did it seems quite
> detrimental to the readability of the field description
On Sun, Aug 1, 2021 at 4:11 PM Peter Smith wrote:
>
> On Sat, Jul 31, 2021 at 7:00 AM Tom Lane wrote:
> >
> > vignesh C writes:
> > [ v6-0001-Included-the-actual-datatype-used-in-logical-repl.patch ]
> >
> > I see what you want to do here, but the way yo
On Fri, Aug 6, 2021 at 4:02 PM Amit Kapila wrote:
>
> On Fri, Aug 6, 2021 at 2:16 PM vignesh C wrote:
> >
> > On Thu, Aug 5, 2021 at 3:54 PM Amit Kapila wrote:
> > >
> > >
> > > Few more comments:
> > > ===
> > >
On Mon, Sep 20, 2021 at 4:20 PM vignesh C wrote:
>
> On Mon, Sep 20, 2021 at 3:57 PM Amit Kapila wrote:
> >
> > On Fri, Sep 17, 2021 at 5:40 PM vignesh C wrote:
> > >
> > > On Thu, Sep 16, 2021 at 9:54 AM Amit Kapila
> > > wrote:
> > &g
On Tue, Sep 21, 2021 at 9:03 AM Greg Nancarrow wrote:
>
> On Fri, Sep 17, 2021 at 10:09 PM vignesh C wrote:
> >
> > Attached v29 patch has the fixes for the same.
> >
>
> Some minor comments on the v29-0002 patch:
>
> (1)
> In get_object_address_
On Mon, Sep 20, 2021 at 3:57 PM Amit Kapila wrote:
>
> On Fri, Sep 17, 2021 at 5:40 PM vignesh C wrote:
> >
> > On Thu, Sep 16, 2021 at 9:54 AM Amit Kapila wrote:
> > >
> > > I think there is one more similar locking problem.
> > > AlterPublicati
On Fri, Sep 24, 2021 at 6:55 PM Alvaro Herrera wrote:
>
> On 2021-Sep-23, Amit Kapila wrote:
>
> > Alvaro, do you have any thoughts on these proposed grammar changes?
>
> Yeah, I think pubobj_name remains a problem in that you don't know its
> return type -- could be a String or a RangeVar, and
On Fri, Sep 24, 2021 at 8:40 AM Amit Kapila wrote:
>
> On Fri, Sep 24, 2021 at 12:45 AM Tomas Vondra
> wrote:
> >
> > Hi,
> >
> > I wanted to do a review of this patch, but I'm a bit confused about
> > which patch(es) to review. There's the v5 patch, and then these two
> > patches - which seem
On Wed, Sep 22, 2021 at 11:27 AM tanghy.f...@fujitsu.com
wrote:
>
> On Wednesday, September 22, 2021 11:22 AM Masahiko Sawada
> wrote:
> >
> > ---
> > + if (!IsA(node, String))
> > + ereport(ERROR,
> > +
On Wed, Sep 22, 2021 at 11:31 AM Amit Kapila wrote:
>
> On Tue, Sep 21, 2021 at 11:39 PM vignesh C wrote:
> >
> > On Tue, Sep 21, 2021 at 9:03 AM Greg Nancarrow wrote:
> > >
> > > On Fri, Sep 17, 2021 at 10:09 PM vignesh C wrote:
> > > >
>
On Tue, Sep 21, 2021 at 6:05 PM Greg Nancarrow wrote:
>
> On Tue, Sep 21, 2021 at 4:12 PM vignesh C wrote:
> >
> > > (1)
> > > In get_object_address_publication_schema(), the error message:
> > >
> > > + errmsg("publication tables of sch
On Wed, Sep 22, 2021 at 8:52 AM Masahiko Sawada wrote:
>
> On Wed, Sep 22, 2021 at 3:02 AM vignesh C wrote:
> >
> >
> > Attached v30 patch has the fixes for the same.
> >
>
> Thank you for updating the patches.
>
>
On Thu, Oct 7, 2021 at 9:30 PM Tom Lane wrote:
>
> "David G. Johnston" writes:
> > On Thursday, October 7, 2021, vignesh C wrote:
> >> Should tables be allowed to create in "information_schema" schema, if
> >> yes should the tables/publicati
On Mon, Oct 11, 2021 at 1:21 PM Greg Nancarrow wrote:
>
> On Mon, Oct 11, 2021 at 5:39 PM vignesh C wrote:
> >
> > These comments are fixed in the v38 patch attached.
> >
>
> Thanks for the updates.
> I noticed that these patches don't apply on the latest sourc
On Thu, Oct 21, 2021 at 3:29 PM Greg Nancarrow wrote:
>
> On Thu, Oct 21, 2021 at 3:25 AM vignesh C wrote:
> >
> > Attached v44 patch as the fixes for the same.
> >
>
> In the v44-0001 patch, I have some doubts about the condition guarding
> the following
On Tue, Oct 19, 2021 at 11:23 AM tanghy.f...@fujitsu.com
wrote:
>
> On Tuesday, October 19, 2021 12:57 PM Amit Kapila
> wrote:
> >
> > On Tue, Oct 19, 2021 at 9:15 AM tanghy.f...@fujitsu.com
> > wrote:
> > >
> > > On Monday, October 18, 2021 8:23 PM
On Mon, Oct 11, 2021 at 7:46 AM tanghy.f...@fujitsu.com
wrote:
>
> > On Friday, October 8, 2021 7:05 PM Amit Kapila
> > wrote:
> >
> > v37-0003-Tests-for-FOR-ALL-TABLES-IN-SCHEMA-publication
> > 3.
> > --- a/src/bin/pg_dump/t/002_pg_dump.pl
> > +++ b/src/bin/pg_dump/t/002_pg_dump.pl
> > ..
> >
On Fri, Oct 8, 2021 at 4:34 PM Amit Kapila wrote:
>
> On Thu, Oct 7, 2021 at 5:19 PM Amit Kapila wrote:
> >
> > On Wed, Oct 6, 2021 at 11:12 AM vignesh C wrote:
> > >
> > > Attached v37 patch has the changes for the same.
> > >
> >
> > F
On Mon, Sep 27, 2021 at 4:41 PM Amit Kapila wrote:
>
> On Sat, Sep 25, 2021 at 1:15 PM vignesh C wrote:
> >
> > On Fri, Sep 24, 2021 at 6:55 PM Alvaro Herrera
> > wrote:
> > >
> > > On 2021-Sep-23, Amit Kapila wrote:
> > >
> > >
On Tue, Sep 28, 2021 at 4:35 PM tanghy.f...@fujitsu.com
wrote:
>
> On Monday, September 27, 2021 1:32 PM, vignesh C wrote:
>
> >Attached v33 patch has the preprocess_pubobj_list review comment fix
> >suggested by Alvaro at [1]. The
> >v33-0006-Alternate-grammar-for
On Mon, Sep 27, 2021 at 4:51 PM Greg Nancarrow wrote:
>
> On Mon, Sep 27, 2021 at 2:32 PM vignesh C wrote:
> >
> > Attached v33 patch has the preprocess_pubobj_list review comment fix
> > suggested by Alvaro at [1].
>
> In the v33-0003 patch, there's a couple
On Mon, Sep 27, 2021 at 2:46 PM Greg Nancarrow wrote:
>
> On Mon, Sep 27, 2021 at 2:32 PM vignesh C wrote:
> >
> > Attached v33 patch has the preprocess_pubobj_list review comment fix
> > suggested by Alvaro at [1].
>
> A minor point I noticed in the v33
On Wed, Sep 29, 2021 at 10:46 AM Amit Kapila wrote:
>
> On Tue, Sep 28, 2021 at 8:15 PM vignesh C wrote:
> >
> > On Mon, Sep 27, 2021 at 12:15 PM houzj.f...@fujitsu.com
> > wrote:
> >
> > Attached v34 patch has the changes for the same.
> >
>
On Wed, Sep 29, 2021 at 11:49 AM Greg Nancarrow wrote:
>
> On Wed, Sep 29, 2021 at 3:16 PM Amit Kapila wrote:
> >
> > 4.
> > + /*
> > + * Check if setting the relation to a different schema will result in the
> > + * publication having schema and same schema's table in the publication.
> > + */
On Wed, Sep 29, 2021 at 9:07 AM houzj.f...@fujitsu.com
wrote:
>
> On Tues, Sep 28, 2021 10:46 PM vignesh C wrote:
> > Attached v34 patch has the changes for the same.
>
> Thanks for updating the patch.
> Here are a few comments.
>
> 1)
> + *
Hi,
I was able to create a table in "information_schema" schema, but
pg_dump does not dumps the table that was created in
"information_schema" schema:
create table information_schema.t1(c1 int);
The similar problem exists in case of create publication, we are able
to create publications for
On Tue, Sep 21, 2021 at 9:03 AM Greg Nancarrow wrote:
>
> On Fri, Sep 17, 2021 at 10:09 PM vignesh C wrote:
> >
> > Attached v29 patch has the fixes for the same.
> >
>
> Some minor comments on the v29-0002 patch:
>
> (1)
> In get_object_address_
On Tue, Oct 5, 2021 at 4:41 PM Amit Kapila wrote:
>
> On Tue, Oct 5, 2021 at 11:10 AM Greg Nancarrow wrote:
> >
> > On Tue, Oct 5, 2021 at 3:11 PM Amit Kapila wrote:
> > >
> > > > Code has been added to prevent a table being set (via ALTER TABLE) to
> > > > UNLOGGED if it is part of a
On Tue, Oct 5, 2021 at 6:57 AM Greg Nancarrow wrote:
>
> On Mon, Oct 4, 2021 at 4:55 AM vignesh C wrote:
> >
> > Attached v36 patch has the changes for the same.
> >
>
> I have some comments on the v36-0001 patch:
>
> src/backend/commands/publicationcm
On Thu, Sep 23, 2021 at 12:32 PM houzj.f...@fujitsu.com
wrote:
>
> On Thur, Sep 23, 2021 11:06 AM Greg Nancarrow wrote:
> > On Wed, Sep 22, 2021 at 9:33 PM houzj.f...@fujitsu.com
> > wrote:
> > >
> > > >
> > > > How do you suggest changing it?
> > >
> > > Personally, I think we'd better move
On Thu, Sep 23, 2021 at 12:22 PM houzj.f...@fujitsu.com
wrote:
>
> From Thurs, Sep 23, 2021 12:09 PM Amit Kapila wrote:
> > On Wed, Sep 22, 2021 at 5:03 PM Hou Zhijie wrote:
> > >
> > > Personally, I think we'd better move the code about changing publication's
> > > tablelist into
gnesh
From fd58e547c22723856a2f18c306b17ab6e59cddb1 Mon Sep 17 00:00:00 2001
From: Vignesh C
Date: Mon, 30 Aug 2021 22:29:07 +0530
Subject: [PATCH v1] Added missing invalidations for all tables publication.
Relation invalidation was missing in case of create publication and drop
publication of "FOR ALL TABL
501 - 600 of 1488 matches
Mail list logo
