Thanks all! I'll try creating the replication slot manually.
Ok great. Thanks Michael and Stephen for the explanations.
Just circling back on this.
I did have a question that came up about the behavior of the server as it is
without the patch. I logged into psql with my superuser "postgres":
postgres=# select pg_read_file('/Users/postgres/temp');
ERROR: absolute path not allowed
I had not tried this
The following review has been posted through the commitfest application:
make installcheck-world: tested, passed
Implements feature: tested, passed
Spec compliant: not tested
Documentation:tested, passed
I ran make installcheck-world and all tests passed except one
(Duplicated to make sure it's in the commitfest Thread, didn't seem to get in
there when I replied to the email)
Oops! I made a mistake, which clearly showed up in my last email: I forgot to
psql back in as "tester".
Now I get the right behavior:
$ psql postgres tester
postgres=>
Oops! I made a mistake, which clearly showed up in my last email: I forgot
to psql back in as "tester".
Now I get the right behavior:
$ psql postgres tester
psql (9.4.5, server 11devel)
Type "help" for help.
postgres=> select pg_read_file('/Users/postgres/temp');
ERROR: absolute path not
Hi Stephen,
I have another question then based on what you said earlier today, and some
testing I did using your patch.
TLDR: I created a role "tester" and was (as expected) not able to perform
pg_read_file() on files outside the data directory.
But then I granted EXECUTE on that function for
Stephen, so far I've read thru your patch and familiarized myself with some of
the auth functionality in pg_authid.h and src/backend/utils/adt/acl.c
The only question I have so far about your patch is the last several hunks of
the diff, which remove superuser checks without adding anything
Thanks for this contribution!
I think it's a hard but important problem to upgrade these xids.
Unfortunately, I've confirmed that this patch 0001-64bit-guc-relopt-3.patch
doesn't apply correctly on my computer.
Here's what I did:
I did a "git pull" to the current HEAD, which is
Since the Patch Tester (http://commitfest.cputube.org/) says this Patch will
not apply correctly, I am tempted to change the status to Waiting on Author.
However, I'm new to the CommitFest process, so I'm leaving the status as-is for
now and asking Stephen Frost whether he agrees.
I haven't
> BTW, for those who aren't already aware of it, I'd like to point out
> this very handy resource:
>
> http://commitfest.cputube.org
>
>
Wow, that makes it way easier to see what's going on! Thanks Tom.
> Now that the January fest has nominally started, we need somebody
> to act as CF manager. Any volunteers?
>
>
What are the responsibilities? How many hours per week are typically given
for this role?
Best,
Ryan
>
> There isn't going to be that much appetite for this just so that people
> can use PostgreSQL without reading our documentation: or the output of
> typing "help" at the psql prompt that says "type \q to quit".
>
>
Agree with this. The whole reason people here are reluctant to add "quit"
in
I am +1 on doing this too, unless we can imagine it clashing with any SQL
queries or breaking scripts (which I can't).
Helping people migrate to postgres w minimal frustration is important
enough imho to be worth breaking this \ rule unless we can forsee real
actual compatibility problems. We
14 matches
Mail list logo
