On Wed, Aug 28, 2019 at 11:27:15AM -0700, Peter Geoghegan wrote:
> Movead is correct -- the NULL handling within
> ApplySortAbbrevFullComparator() cannot actually be used currently. I
> wouldn't change anything about the code, though, since it's useful to
> defensively handle NULLs.
No objections
On Wed, Aug 28, 2019 at 9:43 PM Peter Eisentraut <
peter.eisentr...@2ndquadrant.com> wrote:
> On 2019-08-22 11:46, movead...@highgo.ca wrote:
> > *1. src/include/utils/float.h:140*
> >
> > Analyze:
> > This is an error report line when converting a big float8 value
> > which a float4 can not
On 2019-08-29 00:43, peter.eisentr...@2ndquadrant.com wrote:
> Make spaces and capitalization match surrounding code.
>That's fine, but I suggest that if you really want to make an impact in
>test coverage, look to increase function coverage rather than line
>coverage. Or look for files that
On Tue, Aug 27, 2019 at 8:30 PM Michael Paquier wrote:
> Please note that I have not looked in details where we could put that,
> but perhaps Robert and Peter G who worked on 4ea51cd to add support
> for abbreviated keys have some ideas, so I am adding them in CC for
> input.
Movead is correct
On 2019-08-22 11:46, movead...@highgo.ca wrote:
> *1. src/include/utils/float.h:140*
>
> Analyze:
> This is an error report line when converting a big float8 value
> which a float4 can not storage to float4.
>
> Test case:
> Add a test case as below in file float4.sql:
> select
On Wed, 28 Aug 2019 11:30:23 +0800 mich...@paquier.xyz wrote
>- numeric is not a test suite designed for sorting, and hijacking it
>to do so it not a good approach.
Absolutely agreement. We can wait for repling from
Robert and Peter G.
>- it would be good to get coverage for the two extra code
On Tue, Aug 27, 2019 at 03:57:20PM +0800, movead...@highgo.ca wrote:
> I think your way is much better, so I change the patch and it is
> 'regression_20190827.patch' now.
Thanks for the new patch, I have committed the part for float4.
> There are code lines related to NULL values in
>
On Tue, 27 Aug 2019 14:07:48 +0800 mich...@paquier.xyz wrote:
> There is a section in float4.sql which deals with overflow and
> underflow, so wouldn't it be better to move the tests there? You
> could just trigger the failures with that:
> =# insert into float4_tbl values ('-10e-70'::float8);
On Mon, Aug 26, 2019 at 05:10:59PM +0800, movead...@highgo.ca wrote:
> Thanks for your remind, I have modified the patch and now it is
> 'regression_20190826.patch' in attachment, and I have done a successful
> test on Cygwin.
There is a section in float4.sql which deals with overflow and
On Mon, 26 Aug 2019 12:48:40 +0800 mich...@paquier.xyz wrote
>Your patch has forgotten to update the alternate output in
>float4-misrounded-input.out.
Thanks for your remind, I have modified the patch and now it is
'regression_20190826.patch' in attachment, and I have done a successful
test on
On Sat, Aug 24, 2019 at 11:23:32PM +0800, movead...@highgo.ca wrote:
> Thanks and I just do it, it is
> https://commitfest.postgresql.org/24/2258/
Your patch has forgotten to update the alternate output in
float4-misrounded-input.out.
--
Michael
signature.asc
Description: PGP signature
>Hi Movead,
>Please add that to commitfest.
Thanks and I just do it, it is
https://commitfest.postgresql.org/24/2258/
--
Movead Li
On Thu, Aug 22, 2019 at 2:46 PM movead...@highgo.ca
wrote:
> Hello hackers,
>
> One of the area that didn't get much attention in the community
> recently is analysing and increasing the code coverage of
> PostgreSQL regession test suite. I have started working on the
> code coverage by running
The subject of the email may be bit misleading however this is really good
exercise to analyse the current code of Postgres regression suite using
GCOV and then adding test cases incrementally to increase the test
coverage.
On Thu, 22 Aug 2019 at 2:46 PM, movead...@highgo.ca
wrote:
> Hello
Hello hackers,
One of the area that didn't get much attention in the community
recently is analysing and increasing the code coverage of
PostgreSQL regession test suite. I have started working on the
code coverage by running the GCOV code coverage analysis tool in
order to analyse the current
15 matches
Mail list logo
