On 2018/08/28 22:36, Michael Paquier wrote:
On Mon, Aug 27, 2018 at 07:03:18PM +0900, Michael Paquier wrote:
Thanks, I have looked at the patch set.
I have been through the set once again, and pushed both things. Thanks
a lot Yamada-san.
Thank you very much for your time to review and
On Mon, Aug 27, 2018 at 07:03:18PM +0900, Michael Paquier wrote:
> Thanks, I have looked at the patch set.
I have been through the set once again, and pushed both things. Thanks
a lot Yamada-san.
--
Michael
signature.asc
Description: PGP signature
On Fri, Aug 24, 2018 at 01:32:47PM +0900, Tatsuro Yamada wrote:
> I revised the patch and created new tap tests.
Thanks, I have looked at the patch set. And here are some notes about
issues found while reviewing. For oid2name:
- Documentation had some typos, --tablename was used instead of
On 2018/08/21 12:57, Tatsuro Yamada wrote:
> On 2018/08/21 12:40, Michael Paquier wrote:
>> On Tue, Aug 21, 2018 at 12:26:15PM +0900, Tatsuro Yamada wrote:
>>> BTW, can I add the patch to the Commitfest September?
>>
>> You should.
>
> Thanks, I'll do that.
> I'll send 2 patches in this week,
On 2018/08/21 12:57, Tatsuro Yamada wrote:
On 2018/08/21 12:40, Michael Paquier wrote:
On Tue, Aug 21, 2018 at 12:26:15PM +0900, Tatsuro Yamada wrote:
BTW, can I add the patch to the Commitfest September?
You should.
Thanks, I'll do that.
I'll send 2 patches in this week, probably.
I
On 2018/08/21 12:40, Michael Paquier wrote:
On Tue, Aug 21, 2018 at 12:26:15PM +0900, Tatsuro Yamada wrote:
BTW, can I add the patch to the Commitfest September?
You should.
Thanks, I'll do that.
The patch includes improvements and bug fix as you know, So, I can divide the
patch into 2
On Tue, Aug 21, 2018 at 12:26:15PM +0900, Tatsuro Yamada wrote:
> BTW, can I add the patch to the Commitfest September?
You should.
> The patch includes improvements and bug fix as you know, So, I can divide the
> patch into 2 patches for that.
I am not really seeing any bug fix, but if you
On 2018/08/20 17:38, Michael Paquier wrote:
On Mon, Aug 20, 2018 at 03:51:07PM +0900, Tatsuro Yamada wrote:
On 2018/08/20 13:54, Michael Paquier wrote:
Therefore, "-P" is a manual bag. I investigated more using git log command and
understood followings:
1. -P option was removed on 4192f2d85
On Mon, Aug 20, 2018 at 03:51:07PM +0900, Tatsuro Yamada wrote:
> On 2018/08/20 13:54, Michael Paquier wrote:
> Therefore, "-P" is a manual bag. I investigated more using git log command and
> understood followings:
>
> 1. -P option was removed on 4192f2d85
> 2. -P option revived in only the
On 2018/08/20 13:54, Michael Paquier wrote:
On Mon, Aug 20, 2018 at 12:30:29PM +0900, Tatsuro Yamada wrote:
vacuumlo:
Document
- Add long options
- Add environment section
Let's keep things simple by not adding long options where it is not
especially obvious, so I would
On Mon, Aug 20, 2018 at 12:30:29PM +0900, Tatsuro Yamada wrote:
> vacuumlo:
>Document
> - Add long options
> - Add environment section
Let's keep things simple by not adding long options where it is not
especially obvious, so I would suggest to keep the patch simple and just
add
On August 18, 2018 10:52:33 AM GMT+09:00, Tom Lane wrote:
I think it probably needs to stay documented, but we could mark it as
deprecated ...
Okay, no issues with doing so.
I revised the patch like following:
vacuumlo:
Document
- Add long options
- Add environment section
On August 18, 2018 10:52:33 AM GMT+09:00, Tom Lane wrote:
> I think it probably needs to stay documented, but we could mark it as
> deprecated ...
Okay, no issues with doing so.
--
Michael
Michael Paquier writes:
> On August 17, 2018 10:53:48 PM GMT+09:00, Tom Lane wrote:
>> Well, we can't remove the -H option, for that reason. But I think
>> we could get away with repurposing -h to also mean "--host", rather
>> than "--help" as it is now. Seems unlikely that any scripts are
>>
On August 17, 2018 10:53:48 PM GMT+09:00, Tom Lane wrote:
> Well, we can't remove the -H option, for that reason. But I think
> we could get away with repurposing -h to also mean "--host", rather
> than "--help" as it is now. Seems unlikely that any scripts are
> depending on it to mean
Alvaro Herrera writes:
> On 2018-Aug-17, Tatsuro Yamada wrote:
>> only oid2name
>> - Replace -H with -h
> I think this one is a bad idea, as it'll break scripts.
Well, we can't remove the -H option, for that reason. But I think
we could get away with repurposing -h to also mean "--host",
On 2018-Aug-17, Tatsuro Yamada wrote:
> only oid2name
> - Replace -H with -h
I think this one is a bad idea, as it'll break scripts.
--
Álvaro Herrerahttps://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services
On 2018/08/17 12:42, Tatsuro Yamada wrote:
On 2018/08/17 11:47, Michael Paquier wrote:
On Thu, Aug 16, 2018 at 08:57:57PM +0900, Michael Paquier wrote:
I agree on both points. Any objections if I apply what's proposed here
on HEAD?
I have been looking at this patch. And while consistency
On 2018/08/17 11:47, Michael Paquier wrote:
On Thu, Aug 16, 2018 at 08:57:57PM +0900, Michael Paquier wrote:
I agree on both points. Any objections if I apply what's proposed here
on HEAD?
I have been looking at this patch. And while consistency is nice, I
think that if we are cleaning up
On 2018/08/17 12:31, Michael Paquier wrote:
On Fri, Aug 17, 2018 at 12:19:42PM +0900, Tatsuro Yamada wrote:
But if you think it needs back-patch, please let me know, I can create it.
This would not be back-patched.
I see.
Thanks,
Tatsuro Yamada
On Fri, Aug 17, 2018 at 12:19:42PM +0900, Tatsuro Yamada wrote:
> But if you think it needs back-patch, please let me know, I can create it.
This would not be back-patched.
--
Michael
signature.asc
Description: PGP signature
Hi Laurenz and Michael,
On 2018/08/16 20:57, Michael Paquier wrote:
On Thu, Aug 16, 2018 at 12:40:42PM +0200, Laurenz Albe wrote:
I don't think it is super important, but +1 for consistency.
Thanks! :)
I agree on both points. Any objections if I apply what's proposed here
on HEAD?
I
On Thu, Aug 16, 2018 at 08:57:57PM +0900, Michael Paquier wrote:
> I agree on both points. Any objections if I apply what's proposed here
> on HEAD?
I have been looking at this patch. And while consistency is nice, I
think that if we are cleaning up this stuff we could do a bit more to
be more
On Thu, Aug 16, 2018 at 12:40:42PM +0200, Laurenz Albe wrote:
> I don't think it is super important, but +1 for consistency.
I agree on both points. Any objections if I apply what's proposed here
on HEAD?
--
Michael
signature.asc
Description: PGP signature
Tatsuro Yamada wrote:
> Almost all client applications and extensions will show "Options" and
> "Connection options" sections when running with help option (--help).
> However, "oid2name" was different, there is only the Options section.
>
> For consistency, attached patch divides the Options
Hi,
Almost all client applications and extensions will show "Options" and
"Connection options" sections when running with help option (--help).
However, "oid2name" was different, there is only the Options section.
For example,
$ vacuumlo --help
vacuumlo removes unreferenced large objects
26 matches
Mail list logo
