Re: Missing test of SPI copy functionality

2019-11-08 Thread Michael Paquier
On Thu, Nov 07, 2019 at 06:25:54AM -0800, Mark Dilger wrote: > Thanks for reviewing! After a closer lookup, I have noticed that you missed a second code path which is able to trigger the COPY failures as you use EXECUTE with COPY in PL/pgSQL. So I have added some tests for that, and committed

Re: Missing test of SPI copy functionality

2019-11-07 Thread Mark Dilger
On 11/6/19 6:27 PM, Michael Paquier wrote: On Wed, Nov 06, 2019 at 04:16:14PM -0800, Mark Dilger wrote: While working on cleaning up the SPI interface, I found that one of the SPI error codes, SPI_ERROR_COPY, is never encountered in any test case when running `make check-world`. This case

Re: Missing test of SPI copy functionality

2019-11-06 Thread Michael Paquier
On Wed, Nov 06, 2019 at 04:16:14PM -0800, Mark Dilger wrote: > While working on cleaning up the SPI interface, I found that one of the SPI > error codes, SPI_ERROR_COPY, is never encountered in any test case when > running `make check-world`. This case is certainly reachable by a user, as > is

Missing test of SPI copy functionality

2019-11-06 Thread Mark Dilger
Hackers, While working on cleaning up the SPI interface, I found that one of the SPI error codes, SPI_ERROR_COPY, is never encountered in any test case when running `make check-world`. This case is certainly reachable by a user, as is shown in the attached patch. Is this tested from some