Re: Typo in xact.c

2022-09-18 Thread John Naylor
On Fri, Sep 16, 2022 at 10:51 AM John Naylor wrote: > > On Fri, Sep 16, 2022 at 10:11 AM Kyotaro Horiguchi > wrote: > > > > The patch seems to me covering all occurances of PG_PROC as PGPROC. > > +1 since this hinders grep-ability. Pushed this. > > I found several uses of PG_PROC as

Re: Typo in xact.c

2022-09-15 Thread Japin Li
On Fri, 16 Sep 2022 at 11:11, Kyotaro Horiguchi wrote: > At Thu, 15 Sep 2022 22:38:01 +0800, Japin Li wrote in >> >> Hi hacker, >> >> Recently, I find there might be a typo in xact.c comments. The comments >> say "PG_PROC", however, it actually

Re: Typo in xact.c

2022-09-15 Thread Japin Li
On Fri, 16 Sep 2022 at 11:51, John Naylor wrote: > On Fri, Sep 16, 2022 at 10:11 AM Kyotaro Horiguchi > wrote: >> >> At Thu, 15 Sep 2022 22:38:01 +0800, Japin Li wrote in >> > >> > Hi hacker, >> > >> > Recently, I find there might be a ty

Re: Typo in xact.c

2022-09-15 Thread John Naylor
On Fri, Sep 16, 2022 at 10:11 AM Kyotaro Horiguchi wrote: > > At Thu, 15 Sep 2022 22:38:01 +0800, Japin Li wrote in > > > > Hi hacker, > > > > Recently, I find there might be a typo in xact.c comments. The comments > > say "PG_PROC", however, i

Re: Typo in xact.c

2022-09-15 Thread Kyotaro Horiguchi
At Thu, 15 Sep 2022 22:38:01 +0800, Japin Li wrote in > > Hi hacker, > > Recently, I find there might be a typo in xact.c comments. The comments > say "PG_PROC", however, it actually means "PGPROC" structure. Since we > have pg_proc catalog, and use PG

Typo in xact.c

2022-09-15 Thread Japin Li
Hi hacker, Recently, I find there might be a typo in xact.c comments. The comments say "PG_PROC", however, it actually means "PGPROC" structure. Since we have pg_proc catalog, and use PG_PROC to reference the catalog [1], so, we should use PGPROC to reference the structure

Re: Fix a typo in xact.c

2017-11-28 Thread Masahiko Sawada
On Tue, Nov 28, 2017 at 10:22 PM, Robert Haas wrote: > On Mon, Nov 27, 2017 at 8:29 PM, Masahiko Sawada > wrote: >> Attached patch for $subject. >> >> s/recoreds/record/ > > Committed. > Thank you! Regards, -- Masahiko Sawada NIPPON TELEGRAPH AND

Re: Fix a typo in xact.c

2017-11-28 Thread Robert Haas
On Mon, Nov 27, 2017 at 8:29 PM, Masahiko Sawada wrote: > Attached patch for $subject. > > s/recoreds/record/ Committed. -- Robert Haas EnterpriseDB: http://www.enterprisedb.com The Enterprise PostgreSQL Company

Fix a typo in xact.c

2017-11-27 Thread Masahiko Sawada
Hi, Attached patch for $subject. s/recoreds/record/ Regards, -- Masahiko Sawada NIPPON TELEGRAPH AND TELEPHONE CORPORATION NTT Open Source Software Center fix_typo_in_xact_c.patch Description: Binary data