Re: documentation fixes for partition pruning, round two

2018-06-01 Thread Alvaro Herrera
On 2018-May-23, Justin Pryzby wrote: > There's two other, wider changes to consider: > > - should "5.10.4. Partition Pruning" be moved after "5.10.2. Declarative >Partitioning", rather than after "5.10.3. Implementation Using > Inheritance" ? I considered that when reorganizing this

Re: documentation fixes for partition pruning, round two

2018-06-01 Thread Alvaro Herrera
Pushed. I made a couple of minor changes, in particular I added the word "one" to this sentence, which was already under discussion: On 2018-May-24, Justin Pryzby wrote: > On Thu, May 24, 2018 at 11:30:40AM +0900, Amit Langote wrote: > > +possible to show the difference between a plan

Re: documentation fixes for partition pruning, round two

2018-05-23 Thread Justin Pryzby
On Thu, May 24, 2018 at 11:30:40AM +0900, Amit Langote wrote: > Hi Justin. > > Thanks for writing the patch. I have a couple of comments. Thanks for your review, find attached updated patch. > +possible to show the difference between a plan whose partitions have been > +pruned and one

Re: documentation fixes for partition pruning, round two

2018-05-23 Thread Amit Langote
Hi Justin. Thanks for writing the patch. I have a couple of comments. On 2018/05/24 8:31, Justin Pryzby wrote: > On Thu, May 24, 2018 at 10:46:38AM +1200, David Rowley wrote: >> On 24 May 2018 at 09:35, Justin Pryzby wrote: >>> On Fri, May 18, 2018 at 08:56:53PM -0500,

Re: documentation fixes for partition pruning, round two

2018-05-23 Thread Justin Pryzby
On Thu, May 24, 2018 at 10:46:38AM +1200, David Rowley wrote: > On 24 May 2018 at 09:35, Justin Pryzby wrote: > > On Fri, May 18, 2018 at 08:56:53PM -0500, Justin Pryzby wrote: > >> I reread this and have some more comments. > >>

Re: documentation fixes for partition pruning, round two

2018-05-23 Thread David Rowley
On 24 May 2018 at 09:35, Justin Pryzby wrote: > On Fri, May 18, 2018 at 08:56:53PM -0500, Justin Pryzby wrote: >> I reread this and have some more comments. >> https://www.postgresql.org/docs/devel/static/ddl-partitioning.html > >> Let me know if it's useful to provide a

documentation fixes for partition pruning, round two

2018-05-23 Thread Justin Pryzby
On Fri, May 18, 2018 at 08:56:53PM -0500, Justin Pryzby wrote: > I reread this and have some more comments. > https://www.postgresql.org/docs/devel/static/ddl-partitioning.html > Let me know if it's useful to provide a patch. I propose this. There's two other, wider changes to consider: -