On Thu, Feb 28, 2019 at 9:59 AM John Naylor wrote:
>
> On Thu, Feb 28, 2019 at 10:25 AM Amit Kapila wrote:
> >
> > Here's an updated patch based on comments by you. I will proceed with
> > this unless you have any more comments.
>
> Looks good to me. I would just adjust the grammar in the
On Thu, Feb 28, 2019 at 10:25 AM Amit Kapila wrote:
>
> Here's an updated patch based on comments by you. I will proceed with
> this unless you have any more comments.
Looks good to me. I would just adjust the grammar in the comment, from
"This prevents us to use the map", to "This prevents us
On Thu, Feb 28, 2019 at 8:10 AM Amit Kapila wrote:
>
> On Thu, Feb 28, 2019 at 7:45 AM John Naylor
> wrote:
> >
> > On Thu, Feb 28, 2019 at 7:24 AM Amit Kapila wrote:
> > > > The flaw in my thinking was treating extension too similarly too
> > > > finding an existing block. With your patch
On Thu, Feb 28, 2019 at 7:45 AM John Naylor wrote:
>
> On Thu, Feb 28, 2019 at 7:24 AM Amit Kapila wrote:
> > > The flaw in my thinking was treating extension too similarly too
> > > finding an existing block. With your patch clearing the local map in
> > > the correct place, it seems the call
On Thu, Feb 28, 2019 at 7:24 AM Amit Kapila wrote:
> > The flaw in my thinking was treating extension too similarly too
> > finding an existing block. With your patch clearing the local map in
> > the correct place, it seems the call at hio.c:682 is now superfluous?
>
> What if get some valid
On Wed, Feb 27, 2019 at 11:07 AM John Naylor
wrote:
>
> On Wed, Feb 27, 2019 at 5:06 AM Amit Kapila wrote:
> > I have tried this test many times (more than 1000 times) by varying
> > thread count, but couldn't reproduce it. My colleague, Kuntal has
> > tried a similar test overnight, but the
On Wed, Feb 27, 2019 at 5:06 AM Amit Kapila wrote:
> I have tried this test many times (more than 1000 times) by varying
> thread count, but couldn't reproduce it. My colleague, Kuntal has
> tried a similar test overnight, but the issue didn't reproduce which
> is not surprising to me seeing the
On Tue, Feb 26, 2019 at 10:28 AM Amit Kapila wrote:
> John, others, can you review my findings and patch?
I can confirm your findings with your debugging steps. Nice work!
--
John Naylorhttps://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training &
On Tue, Feb 26, 2019 at 2:58 PM Amit Kapila wrote:
>
> On Mon, Feb 25, 2019 at 10:32 PM Tom Lane wrote:
> >
>
> To fix this symptom, we can ensure that once we didn't get any block
> from local map, we must clear it. See the attached patch. I will try
> to evaluate this code path to see if
On Mon, Feb 25, 2019 at 10:32 PM Tom Lane wrote:
>
> Amit Kapila writes:
> > Avoid creation of the free space map for small heap relations, take 2.
>
> I think this patch still has some issues. Note the following two
> recent buildfarm failures:
>
>
On Tue, Feb 26, 2019 at 8:38 AM John Naylor wrote:
>
> On Tue, Feb 26, 2019 at 8:59 AM Amit Kapila wrote:
> > I will look into it today and respond back with my findings. John,
> > see if you also get time to investigate this.
>
> Will do, but it will likely be tomorrow
>
No problem, thanks!
On Mon, Feb 25, 2019 at 11:14 PM Tom Lane wrote:
>
> I wrote:
> > Amit Kapila writes:
> >> Avoid creation of the free space map for small heap relations, take 2.
>
> > I think this patch still has some issues.
>
> Just out of curiosity ... how can it possibly be even a little bit sane
> that
On Tue, Feb 26, 2019 at 8:59 AM Amit Kapila wrote:
> I will look into it today and respond back with my findings. John,
> see if you also get time to investigate this.
Will do, but it will likely be tomorrow
--
John Naylorhttps://www.2ndQuadrant.com/
PostgreSQL Development,
On Mon, Feb 25, 2019 at 10:32 PM Tom Lane wrote:
>
> Amit Kapila writes:
> > Avoid creation of the free space map for small heap relations, take 2.
>
> I think this patch still has some issues.
>
I will look into it today and respond back with my findings. John,
see if you also get time to
I wrote:
> Amit Kapila writes:
>> Avoid creation of the free space map for small heap relations, take 2.
> I think this patch still has some issues.
Just out of curiosity ... how can it possibly be even a little bit sane
that fsm_local_map is a single static data structure, without even any
Amit Kapila writes:
> Avoid creation of the free space map for small heap relations, take 2.
I think this patch still has some issues. Note the following two
recent buildfarm failures:
https://buildfarm.postgresql.org/cgi-bin/show_log.pl?nm=petalura=2019-02-20%2004%3A20%3A01
16 matches
Mail list logo
