Re: spelling of enable_partition_wise_join

On Mon, Feb 19, 2018 at 9:08 AM, Ashutosh Bapat wrote: > > Thanks. There are functions like try_partition_wise_join(), > generate_partition_wise_join_paths() which use partition_wise > spelling. Should we update those as well? I see that the commit already did

Re: spelling of enable_partition_wise_join

On 2/14/18 03:28, Ashutosh Bapat wrote: > On Wed, Feb 14, 2018 at 2:15 AM, Alvaro Herrera <alvhe...@alvh.no-ip.org> > wrote: >> Peter Eisentraut wrote: >>> I wonder how others feel about this, but the spelling of >>> enable_partition_wise_join feels fun

Re: spelling of enable_partition_wise_join

On Wed, Feb 14, 2018 at 2:15 AM, Alvaro Herrera <alvhe...@alvh.no-ip.org> wrote: > Peter Eisentraut wrote: >> I wonder how others feel about this, but the spelling of >> enable_partition_wise_join feels funny to me every time I look at it. I >> would write it enable

Re: spelling of enable_partition_wise_join

On 14/02/18 09:27, Peter Eisentraut wrote: I wonder how others feel about this, but the spelling of enable_partition_wise_join feels funny to me every time I look at it. I would write it enable_partitionwise_join. Thoughts? As 'wise' is a suffix, not a word in this situation - so

Re: spelling of enable_partition_wise_join

Peter Eisentraut wrote: > I wonder how others feel about this, but the spelling of > enable_partition_wise_join feels funny to me every time I look at it. I > would write it enable_partitionwise_join. +1 See also: https://postgr.es/m/20171005134847.shzldz2ublrb3ny2@alvherre.pgsql -

spelling of enable_partition_wise_join

I wonder how others feel about this, but the spelling of enable_partition_wise_join feels funny to me every time I look at it. I would write it enable_partitionwise_join. Thoughts? -- Peter Eisentraut http://www.2ndQuadrant.com/ PostgreSQL Development, 24x7 Support, Remote DBA