Re: tuplesort Generation memory contexts don't play nicely with index builds

2022-07-07 Thread Joe Conway
On 7/6/22 23:15, Tom Lane wrote: David Rowley writes: On Thu, 7 Jul 2022 at 13:41, John Naylor wrote: Hmm, the commit appeared on git.postgresql.org, but apparently not in my email nor the list archives. Strange. I'd suspect a temporary hiccup in whatever code pushes the commits onto the

Re: tuplesort Generation memory contexts don't play nicely with index builds

2022-07-06 Thread Tom Lane
David Rowley writes: > On Thu, 7 Jul 2022 at 13:41, John Naylor wrote: >> Hmm, the commit appeared on git.postgresql.org, but apparently not in >> my email nor the list archives. > Strange. I'd suspect a temporary hiccup in whatever code pushes the > commits onto the mailing list, but I see

Re: tuplesort Generation memory contexts don't play nicely with index builds

2022-07-06 Thread David Rowley
On Thu, 7 Jul 2022 at 13:41, John Naylor wrote: > > On Thu, Jul 7, 2022 at 3:16 AM David Rowley wrote: > > > > Pushed. > > Hmm, the commit appeared on git.postgresql.org, but apparently not in > my email nor the list archives. Strange. I'd suspect a temporary hiccup in whatever code pushes the

Re: tuplesort Generation memory contexts don't play nicely with index builds

2022-07-06 Thread John Naylor
On Thu, Jul 7, 2022 at 3:16 AM David Rowley wrote: > > Pushed. Hmm, the commit appeared on git.postgresql.org, but apparently not in my email nor the list archives. -- John Naylor EDB: http://www.enterprisedb.com

Re: tuplesort Generation memory contexts don't play nicely with index builds

2022-07-06 Thread Robert Haas
On Tue, Jul 5, 2022 at 9:34 PM David Rowley wrote: > I voiced my dislike for the patch I came up with to fix this issue to > Andres. He suggested that I just add a version of index_form_tuple > that can be given a MemoryContext pointer to allocate the returned > tuple into. > > I like that idea

Re: tuplesort Generation memory contexts don't play nicely with index builds

2022-07-06 Thread David Rowley
On Wed, 6 Jul 2022 at 13:34, David Rowley wrote: > If there are no objections, I plan to push this in the next 24 hours. Pushed. David

Re: tuplesort Generation memory contexts don't play nicely with index builds

2022-07-05 Thread David Rowley
On Wed, 29 Jun 2022 at 12:59, David Rowley wrote: > I noticed while doing some memory context related work that since we > now use generation.c memory contexts for tuplesorts (40af10b57) that > tuplesort_putindextuplevalues() causes memory "leaks" in the > generation context due to

Re: tuplesort Generation memory contexts don't play nicely with index builds

2022-06-29 Thread David Rowley
On Wed, 29 Jun 2022 at 12:59, David Rowley wrote: > I noticed while doing some memory context related work that since we > now use generation.c memory contexts for tuplesorts (40af10b57) that > tuplesort_putindextuplevalues() causes memory "leaks" in the > generation context due to

tuplesort Generation memory contexts don't play nicely with index builds

2022-06-28 Thread David Rowley
Hackers, I noticed while doing some memory context related work that since we now use generation.c memory contexts for tuplesorts (40af10b57) that tuplesort_putindextuplevalues() causes memory "leaks" in the generation context due to index_form_tuple() being called while we're switched into the