Re: [HACKERS] get_whatever_oid, part 1: object types with unqualifed names

2010-07-02 Thread KaiGai Kohei
Robert, I checked the v2 patch, but I could not find anything to comment except for its patch format. The -v2 patch still uses unified format, instead of context format. I believe it is just a careless miss. Please fix it later, if necessary. When I submit a patch, I makes it as follows :D git

Re: [HACKERS] server authentication over Unix-domain sockets

2010-07-02 Thread KaiGai Kohei
(2010/07/01 11:30), Peter Eisentraut wrote: On tis, 2010-06-22 at 09:37 +0900, KaiGai Kohei wrote: As you described at the source code comments as follows, it is not portable except for Linux due to the getsockopt() API. + // TODO: currently Linux-only code, needs to be made +

Re: [HACKERS] server authentication over Unix-domain sockets

2010-07-02 Thread Magnus Hagander
On Fri, Jul 2, 2010 at 8:35 AM, KaiGai Kohei kai...@ak.jp.nec.com wrote: (2010/07/01 11:30), Peter Eisentraut wrote: I have a question. The pqGetpwuid() is enclosed by #ifndef WIN32 ... #endif, although this patch encloses the section to obtain user id of the peer by #ifdef HAVE_UNIX_SOCKETS

Re: [HACKERS] bitmap indexes - performance

2010-07-02 Thread Mark Kirkwood
On 02/07/10 13:31, Bruce Momjian wrote: Leonardo F wrote: I'm trying to find more docs that explain the improvements of bitmap indexes in other products... but most of what I've found talks about bitmapAND/OR which is something that is very cool, but that postgres already does even with

[HACKERS] hello

2010-07-02 Thread uwcssa
hello: I have Order china Product Apple iPad Wi-Fi 32GB I have received the product! this website:Toradeo.com I believe you will find what you want there and have an good experience on shopping from them. Regards! -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make

[HACKERS] gincostestimate

2010-07-02 Thread Teodor Sigaev
Patch implements much more accuracy estimation of cost for GIN index scan than generic cost estimation function. Basic idea is described on PGCon-2010: http://www.sai.msu.su/~megera/postgres/talks/pgcon-2010-1.pdf, pages 48-54. After discussion on PGCon, the storage of additional statistic

Re: [HACKERS] Issue: Deprecation of the XML2 module 'xml_is_well_formed' function

2010-07-02 Thread Mike Fowler
Quoting Robert Haas robertmh...@gmail.com: I think the point if IS DOCUMENT is to distinguish a document: foosome stuffbar/baz//foo from a document fragment: bar/baz/ A document is allowed only one toplevel tag. It'd be nice, I think, to have a function that tells you whether something is

Re: [HACKERS] [COMMITTERS] pgsql: Allow copydir() to be interrupted.

2010-07-02 Thread Tom Lane
Robert Haas robertmh...@gmail.com writes: This appears to have broken MinGW and Cygwin builds on the buildfarm. Well, that's not awesome. IM-ing with Magnus now.  I'm wondering if this is a link-ordering problem of some kind. Possibly an #ifndef FRONTEND will fix it.

Re: [HACKERS] [COMMITTERS] pgsql: Allow copydir() to be interrupted.

2010-07-02 Thread Robert Haas
On Fri, Jul 2, 2010 at 10:18 AM, Tom Lane t...@sss.pgh.pa.us wrote: Robert Haas robertmh...@gmail.com writes: This appears to have broken MinGW and Cygwin builds on the buildfarm. Well, that's not awesome. IM-ing with Magnus now.  I'm wondering if this is a link-ordering problem of some kind.

Re: [HACKERS] Adding regexp_match() function

2010-07-02 Thread Jim Nasby
This seems like it'd be useful. Anyone else have thoughts on it? On May 31, 2010, at 4:09 AM, Daniele Varrazzo wrote: Hello, I'd like to contribute a regexp_match() function as discussed in bug #5469 [1] The aim is to overcome the limitation outlined in the thread above

Re: [HACKERS] [COMMITTERS] pgsql: Allow copydir() to be interrupted.

2010-07-02 Thread Robert Haas
On Fri, Jul 2, 2010 at 10:21 AM, Robert Haas robertmh...@gmail.com wrote: On Fri, Jul 2, 2010 at 10:18 AM, Tom Lane t...@sss.pgh.pa.us wrote: Robert Haas robertmh...@gmail.com writes: This appears to have broken MinGW and Cygwin builds on the buildfarm. Well, that's not awesome. IM-ing with

Re: [HACKERS] Adding regexp_match() function

2010-07-02 Thread Robert Haas
On Wed, Jun 30, 2010 at 4:25 AM, Jim Nasby j...@nasby.net wrote: This seems like it'd be useful. Anyone else have thoughts on it? +1. -- Robert Haas EnterpriseDB: http://www.enterprisedb.com The Enterprise Postgres Company -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)

Re: [HACKERS] get_whatever_oid, part 1: object types with unqualifed names

2010-07-02 Thread Robert Haas
2010/7/2 KaiGai Kohei kai...@ak.jp.nec.com: The transitions from object name to its oid are widely used in the routines of the backend, so I also think this reworks will enough worthwhile to keep the code clean. So, I marked it as ready for committer. Thanks. Are you planning to review the

Re: [HACKERS] server authentication over Unix-domain sockets

2010-07-02 Thread Peter Eisentraut
On fre, 2010-07-02 at 09:16 +0100, Magnus Hagander wrote: On Fri, Jul 2, 2010 at 8:35 AM, KaiGai Kohei kai...@ak.jp.nec.com wrote: (2010/07/01 11:30), Peter Eisentraut wrote: I have a question. The pqGetpwuid() is enclosed by #ifndef WIN32 ... #endif, although this patch encloses the

Re: [HACKERS] hstore == and deprecate =

2010-07-02 Thread David E. Wheeler
On Jun 28, 2010, at 12:10 PM, Tom Lane wrote: While I would personally prefer to have an operator for the slicing opeeration, I'm not willing to spend time arguing about it. So, +1 to implement the subset operation as the function slice(), and defer having an operator until later. Yeah, I

Re: [HACKERS] [COMMITTERS] pgsql: Allow copydir() to be interrupted.

2010-07-02 Thread Robert Haas
On Fri, Jul 2, 2010 at 11:07 AM, Robert Haas robertmh...@gmail.com wrote: On Fri, Jul 2, 2010 at 10:21 AM, Robert Haas robertmh...@gmail.com wrote: On Fri, Jul 2, 2010 at 10:18 AM, Tom Lane t...@sss.pgh.pa.us wrote: Robert Haas robertmh...@gmail.com writes: This appears to have broken MinGW

Re: [HACKERS] server authentication over Unix-domain sockets

2010-07-02 Thread Andrew Dunstan
Peter Eisentraut wrote: Is there any possibilities that both WIN32 and HAVE_UNIX_SOCKETS are set concurrently? If possible, the libpq may try to call undefined function, then build will be failed. Win32 never has HAVE_UNIX_SOCKET. Cygwin might though, I recall some old discussion

Re: [HACKERS] hstore == and deprecate =

2010-07-02 Thread Robert Haas
On Fri, Jul 2, 2010 at 12:36 PM, David E. Wheeler da...@kineticode.com wrote: On Jun 28, 2010, at 12:10 PM, Tom Lane wrote: While I would personally prefer to have an operator for the slicing opeeration, I'm not willing to spend time arguing about it.  So, +1 to implement the subset operation

Re: [HACKERS] hstore == and deprecate =

2010-07-02 Thread David E. Wheeler
On Jul 2, 2010, at 10:07 AM, Robert Haas wrote: Yeah, I think the consensus is to avoid picking an operator name at all. slice() is OK by me. Will this be done for Beta 3? You forgot to attach the patch. :-) Attached. Only thing that gave me pause is the presence of the undocumented

Re: [HACKERS] Keepalive for max_standby_delay

2010-07-02 Thread Tom Lane
[ Apologies for the very slow turnaround on this --- I got hit with another batch of non-postgres security issues this week. ] Attached is a draft patch for revising the max_standby_delay behavior into something I think is a bit saner. There is some unfinished business: * I haven't touched the

Re: [HACKERS] [COMMITTERS] pgsql: Allow copydir() to be interrupted.

2010-07-02 Thread Robert Haas
On Fri, Jul 2, 2010 at 12:38 PM, Robert Haas robertmh...@gmail.com wrote: On Fri, Jul 2, 2010 at 11:07 AM, Robert Haas robertmh...@gmail.com wrote: On Fri, Jul 2, 2010 at 10:21 AM, Robert Haas robertmh...@gmail.com wrote: On Fri, Jul 2, 2010 at 10:18 AM, Tom Lane t...@sss.pgh.pa.us wrote:

Re: [HACKERS] Keepalive for max_standby_delay

2010-07-02 Thread Robert Haas
On Fri, Jul 2, 2010 at 4:11 PM, Tom Lane t...@sss.pgh.pa.us wrote: [ Apologies for the very slow turnaround on this --- I got hit with another batch of non-postgres security issues this week. ] Attached is a draft patch for revising the max_standby_delay behavior into something I think is a

Re: [HACKERS] Keepalive for max_standby_delay

2010-07-02 Thread Tom Lane
Robert Haas robertmh...@gmail.com writes: I haven't been able to wrap my head around why the delay should be LESS in the archive case than in the streaming case. Can you attempt to hit me with the clue-by-four? In the archive case, you're presumably trying to catch up, and so it makes sense

Re: [HACKERS] hstore == and deprecate =

2010-07-02 Thread Robert Haas
On Fri, Jul 2, 2010 at 2:39 PM, David E. Wheeler da...@kineticode.com wrote: On Jul 2, 2010, at 10:07 AM, Robert Haas wrote: Yeah, I think the consensus is to avoid picking an operator name at all. slice() is OK by me. Will this be done for Beta 3? You forgot to attach the patch.  :-)

Re: [HACKERS] Keepalive for max_standby_delay

2010-07-02 Thread Robert Haas
On Fri, Jul 2, 2010 at 4:36 PM, Tom Lane t...@sss.pgh.pa.us wrote: Robert Haas robertmh...@gmail.com writes: I haven't been able to wrap my head around why the delay should be LESS in the archive case than in the streaming case.  Can you attempt to hit me with the clue-by-four? In the

Re: [HACKERS] hstore == and deprecate =

2010-07-02 Thread David E. Wheeler
On Jul 2, 2010, at 1:38 PM, Robert Haas wrote: Thanks, committed - with the exception that I reverted your change to the title of section F.13.2, which I believe was in error (and possibly accidental). No, I removed that because that table has only operators, no functions. See

Re: [HACKERS] hstore == and deprecate =

2010-07-02 Thread Robert Haas
On Fri, Jul 2, 2010 at 4:43 PM, David E. Wheeler da...@kineticode.com wrote: On Jul 2, 2010, at 1:38 PM, Robert Haas wrote: Thanks, committed - with the exception that I reverted your change to the title of section F.13.2, which I believe was in error (and possibly accidental). No, I

Re: [HACKERS] hstore == and deprecate =

2010-07-02 Thread David E. Wheeler
On Jul 2, 2010, at 1:45 PM, Robert Haas wrote: No, I removed that because that table has only operators, no functions. Seehttp://developer.postgresql.org/docs/postgres/hstore.html. The section contains two tables. Table F-5 is called hstore operators, and table F-6 is called hstore

Re: [HACKERS] Keepalive for max_standby_delay

2010-07-02 Thread Tom Lane
Robert Haas robertmh...@gmail.com writes: On Fri, Jul 2, 2010 at 4:36 PM, Tom Lane t...@sss.pgh.pa.us wrote: In the archive case, you're presumably trying to catch up, and so it makes sense to kill queries faster so you can catch up. On the flip side, the timeout for the WAL segment is for

Re: [HACKERS] Keepalive for max_standby_delay

2010-07-02 Thread Robert Haas
On Fri, Jul 2, 2010 at 4:52 PM, Tom Lane t...@sss.pgh.pa.us wrote: Robert Haas robertmh...@gmail.com writes: On Fri, Jul 2, 2010 at 4:36 PM, Tom Lane t...@sss.pgh.pa.us wrote: In the archive case, you're presumably trying to catch up, and so it makes sense to kill queries faster so you can

Re: [HACKERS] hstore == and deprecate =

2010-07-02 Thread Tom Lane
David E. Wheeler da...@kineticode.com writes: You forgot to attach the patch. :-) Attached. Okay, I'm confused. This patch removed an operator named %, which AFAIK was not controversial. The problematic operator is = no? regards, tom lane -- Sent via pgsql-hackers

Re: [HACKERS] hstore == and deprecate =

2010-07-02 Thread Robert Haas
On Fri, Jul 2, 2010 at 5:00 PM, Tom Lane t...@sss.pgh.pa.us wrote: David E. Wheeler da...@kineticode.com writes: You forgot to attach the patch.  :-) Attached. Okay, I'm confused.  This patch removed an operator named %, which AFAIK was not controversial.  The problematic operator is = no?

Re: [HACKERS] hstore == and deprecate =

2010-07-02 Thread Tom Lane
Robert Haas robertmh...@gmail.com writes: On Fri, Jul 2, 2010 at 5:00 PM, Tom Lane t...@sss.pgh.pa.us wrote: Okay, I'm confused.  This patch removed an operator named %, which AFAIK was not controversial.  The problematic operator is = no? It used to be = Nevermind, I *am* confused.

Re: [HACKERS] hstore == and deprecate =

2010-07-02 Thread Robert Haas
On Fri, Jul 2, 2010 at 5:03 PM, Tom Lane t...@sss.pgh.pa.us wrote: Robert Haas robertmh...@gmail.com writes: On Fri, Jul 2, 2010 at 5:00 PM, Tom Lane t...@sss.pgh.pa.us wrote: Okay, I'm confused.  This patch removed an operator named %, which AFAIK was not controversial.  The problematic

Re: [HACKERS] keepalives on MacOS X

2010-07-02 Thread Robert Haas
On Tue, Jun 29, 2010 at 10:53 PM, Fujii Masao masao.fu...@gmail.com wrote: On Tue, Jun 29, 2010 at 11:28 PM, Robert Haas robertmh...@gmail.com wrote: On Tue, Jun 29, 2010 at 12:42 AM, Tom Lane t...@sss.pgh.pa.us wrote: Yeah, a bit of rooting around in the Darwin sources shows that this value

Re: [HACKERS] warning message in standby

2010-07-02 Thread Robert Haas
On Tue, Jun 29, 2010 at 10:58 AM, Kevin Grittner kevin.gritt...@wicourts.gov wrote: Robert Haas robertmh...@gmail.com wrote: If someone is sloppy about how they copy the WAL files around, they could temporarily have a truncated file. Can you explain the scenario you're concerned about in

Re: [HACKERS] _bt_parent_deletion_safe() isn't safe

2010-07-02 Thread Bruce Momjian
Tom Lane wrote: I wrote: I realized this while thinking about Jeff Amiel's report here: http://archives.postgresql.org/pgsql-general/2010-06/msg00351.php I can't prove that this is what's causing his crashes, but it could produce the symptom he's reporting. Actually, no it can't: the

Re: [HACKERS] [COMMITTERS] pgsql: Allow copydir() to be interrupted.

2010-07-02 Thread Andrew Dunstan
Robert Haas wrote: I suspect that moving copydir.c into the backend will fix this, but I don't have an appropriate build environment to test. Can someone please test the attached patch? Andrew confirms that this works on mingw, so I'm going to go ahead and check it in and see what

[HACKERS] dynamically allocating chunks from shared memory

2010-07-02 Thread Markus Wanner
Hi, for quite some time, I've been under the impression, that there's still one disadvantage left from using processes instead of threads: we can only use statically sized chunks of shared memory. Every component that wants to use shared memory needs to pre-allocate whatever it thinks is

Re: [HACKERS] [COMMITTERS] pgsql: Allow copydir() to be interrupted.

2010-07-02 Thread Robert Haas
On Fri, Jul 2, 2010 at 7:30 PM, Andrew Dunstan and...@dunslane.net wrote: MSVC was looking for it and not finding it. I have committed a fix that I hope will fix the MSVC builds, by removing it from the list of files in libpgport. You'll need to do the same thing in 8.4... -- Robert Haas

Re: [HACKERS] [COMMITTERS] pgsql: Allow copydir() to be interrupted.

2010-07-02 Thread Andrew Dunstan
Robert Haas wrote: On Fri, Jul 2, 2010 at 7:30 PM, Andrew Dunstan and...@dunslane.net wrote: MSVC was looking for it and not finding it. I have committed a fix that I hope will fix the MSVC builds, by removing it from the list of files in libpgport. You'll need to do the same thing

Re: [HACKERS] bitmap indexes - performance

2010-07-02 Thread Mark Kirkwood
On 02/07/10 20:30, Mark Kirkwood wrote: I recall that for (some/most? of) those low cardinality cases, (on disk) bitmap indexes would perform better too. I think the size saving alone is a huge win for serious data warehousing situations. On the other hand problems I recall are possibly

Re: [HACKERS] _bt_parent_deletion_safe() isn't safe

2010-07-02 Thread Tom Lane
Bruce Momjian br...@momjian.us writes: Tom Lane wrote: A search of the archives produces no evidence that anyone has ever reported the failed to delete rightmost child error from the field. So while I still think this is a bug that needs to be fixed, it may be lower priority than I thought

Re: [HACKERS] Issue: Deprecation of the XML2 module 'xml_is_well_formed' function

2010-07-02 Thread Peter Eisentraut
On fre, 2010-07-02 at 14:07 +0100, Mike Fowler wrote: So if IS CONTENT were to be implemented, to determine that you have something that is malformed But that's not what IS CONTENT does. Content still needs to be well-formed. -- Sent via pgsql-hackers mailing list